Hi, On Tue, Jun 24, 2014 at 3:24 AM, Masahiro Yamada <yamad...@jp.panasonic.com> wrote: > OK. It seems better to check. > > I added some patches which include whitespace errors > and ran Patman. > > It looks like nothing changes with/without -a option. > > > $ tools/patman/patman -a -c 3 > 1 warnings for 0002-arm-commit-2.patch: > Line 21/0 has space before tab > > 1 warnings for 0003-arm-commit-3.patch: > Found possible blank line(s) at end of file 'None' > > Cleaned 3 patches > 1 errors, 0 warnings, 0 checks for 0001-arm-commit-1.patch: > error: common/cmd_mmc.c,22: trailing whitespace > > 1 errors, 2 warnings, 0 checks for 0002-arm-commit-2.patch: > error: common/cmd_mmc.c,26: code indent should use tabs where possible > warning: common/cmd_mmc.c,26: please, no space before tabs > warning: common/cmd_mmc.c,26: please, no spaces at the start of a line > > checkpatch.pl found 2 error(s), 2 warning(s), 0 checks(s) > > > $ tools/patman/patman -c 3 > 1 warnings for 0002-arm-commit-2.patch: > Line 21/0 has space before tab > > 1 warnings for 0003-arm-commit-3.patch: > Found possible blank line(s) at end of file 'None' > > Cleaned 3 patches > 1 errors, 0 warnings, 0 checks for 0001-arm-commit-1.patch: > error: common/cmd_mmc.c,22: trailing whitespace > > 1 errors, 2 warnings, 0 checks for 0002-arm-commit-2.patch: > error: common/cmd_mmc.c,26: code indent should use tabs where possible > warning: common/cmd_mmc.c,26: please, no space before tabs > warning: common/cmd_mmc.c,26: please, no spaces at the start of a line > > checkpatch.pl found 2 error(s), 2 warning(s), 0 checks(s)
It sure looks like checkpatch now catches things so it never gets to "git am". Making "-a" off by default seems reasonable to me. -Doug _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
