Mike, On Mon, Feb 13, 2012 at 11:00 PM, Mike Frysinger <vap...@gentoo.org> wrote:
> i don't know the exynos5 pinmux specifics, but speaking in general, you > shouldn't go configuring pins directly if the user hasn't asked for them. > config multi would be useful because then the pinmux logic would be in a > uart- > specific init func and we wouldn't need ifdefs. when the user says "use > uart# > as my i/o device", we know we should configure the pinmuxes for that. > > the uart1 above looks like a good example ... the pins can be UART1 or I2C. > we shouldn't go blasting them all to UART1 ... > > Doug can speak to the exact pinrouting setup that the smdk5250 board has > ... > In the case of the smdk5250, all of the above pinmuxes are safe to always configure as UART. ...and since this pinmux is in a board-specific file (as opposed to generic exynos code), I think it's OK to remove the ifdefs. Eventually this still will change with device tree work, but until then I think the v2 patch is a reasonable way to do things and does allow all the serial ports to work. Thanks! -Doug
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
