Re: [PATCH 3/3] rockchip: Fix binman error

2025-02-09 Thread FUKAUMI Naoki
Hi, On 2/9/25 23:27, Simon Glass wrote: Hi Quentin, On Thu, 6 Feb 2025 at 09:54, Quentin Schulz wrote: Hi Simon, On 2/6/25 1:46 PM, Simon Glass wrote: Hi Quentin, On Wed, 5 Feb 2025 at 06:00, Quentin Schulz wrote: Hi Naoki, On 1/29/25 2:25 PM, FUKAUMI Naoki wrote: After adding the be

Re: [PATCH 1/4] board: phytec: common: k3: Introduce Configs to Sign Images

2025-02-09 Thread Daniel Schultz
On 07.02.25 18:07, Andrew Davis wrote: On 2/7/25 12:51 AM, Daniel Schultz wrote: Private keys to sign bootloader images shouldn't be commit or part of this repository. Add config entries to use keys located outside of U-Boot to sign images. The custMpk.pem was always a placeholder, we fill

[PATCH 2/2] arch: arm: dts: k3-am642-phycore-som-binman: Add custMpk to all images

2025-02-09 Thread Daniel Schultz
There are some device-tree overlays and firmwares with missing entries for the keyfile. Add them to sign all images in the U-Boot FIT image. Signed-off-by: Daniel Schultz --- arch/arm/dts/k3-am642-phycore-som-binman.dtsi | 49 --- 1 file changed, 41 insertions(+), 8 deletions(-)

[PATCH 1/2] arch: arm: dts: k3-am625-phycore-som-binman: Add custMpk to all images

2025-02-09 Thread Daniel Schultz
There are some device-tree overlays and firmwares with missing entries for the keyfile. Add them to sign all images in the U-Boot FIT image. Signed-off-by: Daniel Schultz --- arch/arm/dts/k3-am625-phycore-som-binman.dtsi | 49 --- 1 file changed, 41 insertions(+), 8 deletions(-)

[PATCH v3 7/7] ARM: dts: at91: Align pinctrl node with Linux Devicetree

2025-02-09 Thread Manikandan Muralidharan
The GPIO banks are added as sub nodes or child nodes under the pinctrl node (as per Linux ABI) and the reg property which points to an array of controllers physical base address is removed to align with the Linux devicetree. Signed-off-by: Charan Pedumuru Signed-off-by: Manikandan Muralidharan -

[PATCH v3 3/7] ARM: dts: at91: sam9x60: Move pinmux node to board DTS

2025-02-09 Thread Manikandan Muralidharan
Move pinmux nodes defined under the pinctrl node from sam9x60 SoC DT to its board specific DTS files. Signed-off-by: Manikandan Muralidharan --- arch/arm/dts/at91-sam9x60_curiosity.dts | 71 + arch/arm/dts/sam9x60.dtsi | 63 -- arch/arm/d

[PATCH v3 2/7] ARM: dts: at91: sam9x60: Define pinctrl node with its label

2025-02-09 Thread Manikandan Muralidharan
From: Balamanikandan Gunasundar Define the pinctrl nodes with its label to align with the Linux DT. Without this change the pinmux nodes are grouped under an additional 'pinctrl' child node which is not identified by the pinctrl driver when the GPIO banks are made as child nodes of pinctrl node.

[PATCH v3 1/7] ARM: dts: at91: sam9x60: Add AIC node

2025-02-09 Thread Manikandan Muralidharan
Add Advanced Interrupt Controller node and define it as interrupt parent in sam9x60 SoC DT. Signed-off-by: Manikandan Muralidharan --- arch/arm/dts/sam9x60.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/sam9x60.dtsi b/arch/arm/dts/sam9x60.dtsi index 3b684fc63d5..4

[PATCH v3 0/7] Align pio3 pinctrl node with Linux

2025-02-09 Thread Manikandan Muralidharan
The series adds support in the pinctrl driver and additional changes in the at91 DT to align the pio3 based pinctrl nodes in the u-boot DT with that of Linux Changes in v3: - 5/7 - Add comment block to describe at91_pinctrl_bind() Changes in v2: - 1/7 - Align the properties of AIC node with that

[PATCH v3 6/7] pinctrl: at91: Add support to align with Linux Devicetree

2025-02-09 Thread Manikandan Muralidharan
U-Boot pinctrl driver expects a reg property explicitly unlike linux. To align the DT of U-boot with the Linux, reg property is also arrvied from child GPIO bank nodes when configured under the pinctrl node. Signed-off-by: Manikandan Muralidharan --- drivers/pinctrl/pinctrl-at91.c | 25 +

[PATCH v3 5/7] pinctrl: at91: Bind GPIO driver to the pinctrl DT node

2025-02-09 Thread Manikandan Muralidharan
In Linux DT,the pinctrl node acts as parent nodes with all other gpio banks as child nodes and a single driver in Linux handles both pinctrl settings and gpio requests.Current U-Boot DT maintains both pinctrl and gpio nodes as separate nodes and offers two different class of U-Boot drivers: UCLASS_

[PATCH v3 4/7] ARM: dts: at91: sam9x60: Add missing pinctrl node properties

2025-02-09 Thread Manikandan Muralidharan
Add the missing properties for the pinctrl node and for its corresponding GPIO bank nodes to align with the Linux DT. Signed-off-by: Manikandan Muralidharan --- arch/arm/dts/sam9x60.dtsi | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/sa

Please pull u-boot-samsung master

2025-02-09 Thread Minkyu Kang
Dear Tom, The following changes since commit 97c125e6bb441a8062bdd28e82f17b1da1224416: Gitlab: Add results.xml to the list of artifacts as well. (2025-02-04 11:57:36 -0600) are available in the Git repository at: g...@source.denx.de:u-boot/custodians/u-boot-samsung.git master for you to fe

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

2025-02-09 Thread Kumar, Udit
Hi Tom On 2/9/2025 10:50 PM, Tom Rini wrote: On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote: Previously saved environment introduce discrepancies and may lead to incompatibilities without default settings. This series removes the saved environment functionality on am57xx evms so

[PATCH v3] board: starfive: Update the maintainer file for VisionFive 2 board

2025-02-09 Thread Hal Feng
Update the maintainer file and mark jh7110 / visionfive2 related files with N: patterns. Signed-off-by: Hal Feng --- Changes since v2: - Mark visionfive2 related files with N: pattern. Changes since v1: - Mark jh7110 related files with N: pattern. History: v2: https://lore.kernel.org/all/20250

[PATCH v3] board: nuvoton: use an event to replace last_stage_init()

2025-02-09 Thread Michael Chang
Add a new event which handles this function refer to commit ("91caa3bb89b1 event: Use an event to replace last_stage_init()") Signed-off-by: Michael Chang Reviewed-by: Tom Rini --- board/nuvoton/arbel_evb/arbel_evb.c | 7 ++- board/nuvoton/common/uart.c | 7 --- board/nuvoton/co

[PATCH] ARM: dts: stm32: Add support for environment in eMMC on STM32MP13xx DHCOR SoM

2025-02-09 Thread Marek Vasut
Enable support for environment in eMMC on STM32MP13xx DHCOR SoM, in addition to existing support for environment in SPI NOR. The environment size is the same, except in case the environment is placed in eMMC, it is stored at the end of eMMC BOOT partitions in the last 32 sectors of each eMMC HW BOO

[PATCH] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties

2025-02-09 Thread Marek Vasut
Introduce a new function mmc_env_hwpart_redund() which replaces IS_ENABLED(ENV_MMC_HWPART_REDUND) and internally does almost the same check as the macro which assigned ENV_MMC_HWPART_REDUND did, and call it in place of IS_ENABLED(ENV_MMC_HWPART_REDUND). The difference compared to IS_ENABLED(ENV_MM

[PATCH 2/2] net: dwc_eth_qos_rockchip: Fix disable of RX/TX delay for RK3588

2025-02-09 Thread Jonas Karlman
When rgmii-rxid/txid/id phy-mode is used the MAC should not add RX and/or TX delay. Currently RX/TX delay is configured as enabled using zero as delay value for the rgmii-rxid/txid/id modes. Change to disable RX and/or TX delay and using zero as delay value. Signed-off-by: Jonas Karlman --- dri

[PATCH 1/2] net: dwc_eth_qos_rockchip: Fix disable of RX/TX delay for RK356x

2025-02-09 Thread Jonas Karlman
When rgmii-rxid/txid/id phy-mode is used the MAC should not add RX and/or TX delay. Currently RX/TX delay is configured as enabled using zero as delay value for the rgmii-rxid/txid/id modes. Change to disable RX and/or TX delay and using zero as delay value. Signed-off-by: Jonas Karlman --- dri

[PATCH 0/2] net: dwc_eth_qos_rockchip: Fix disable of delay for RK356x and RK3588

2025-02-09 Thread Jonas Karlman
When rgmii-rxid/txid/id phy-mode is used the MAC should not add RX and/or TX delay. Currently RX/TX delay is configured as enabled using zero as delay value for the rgmii-rxid/txid/id modes. This series change to disable RX and/or TX delay and using zero as delay value for RK356x and RK3588. Jona

Re: [PATCH 4/4] configs: starfive: default to jh7110-starfive-visionfive-2-v1.3b

2025-02-09 Thread E Shattow
Postscript of my reply below, with context from off-list discussion xypron (Heinrich) and Shadow AI6FS (E Shattow)... On 2/9/25 13:55, E Shattow wrote: > Hi Heinrich, I re-send my reply w/ CC's as you ask off-list :) > > On 2/9/25 12:52, Heinrich Schuchardt wrote: >> E Shattow schrieb am So., 9.

Re: [PATCH 05/29] rockchip: Allow RAM init to happen in SPL on rk3399

2025-02-09 Thread Jonas Karlman
Hi Simon, On 2025-02-09 21:14, Simon Glass wrote: > Hi Jonas, > > On Sun, 9 Feb 2025 at 09:30, Jonas Karlman wrote: >> >> Hi Simon, >> >> On 2025-02-09 16:36, Simon Glass wrote: >>> Hi Jonas, >>> >>> On Sun, 9 Feb 2025 at 08:17, Jonas Karlman wrote: Hi Simon, On 2025-02-09 1

Re: [PATCH 4/4] configs: starfive: default to jh7110-starfive-visionfive-2-v1.3b

2025-02-09 Thread E Shattow
Hi Heinrich, I re-send my reply w/ CC's as you ask off-list :) On 2/9/25 12:52, Heinrich Schuchardt wrote: > E Shattow schrieb am So., 9. Feb. 2025, 21:43: > >> >> On 2/9/25 07:23, Heinrich Schuchardt wrote: >>> We use starfive_visionfive2_defconfig to generate a FIT image supporting >>> all JH7

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Simon Glass
Hi Tom, On Sun, 9 Feb 2025 at 09:39, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: > > [snip] > > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the > > way you want to go, I'd be happy to do a precursor series to deal with > > the fallout. > >

Re: [PATCH 06/12] rockchip: rk3399-gru: Include binman generated FIT in u-boot.rom image

2025-02-09 Thread Jonas Karlman
On 2025-02-09 21:14, Simon Glass wrote: > Hi Tom, > > On Sun, 9 Feb 2025 at 09:49, Tom Rini wrote: >> >> On Sun, Feb 09, 2025 at 07:27:37AM -0700, Simon Glass wrote: >>> Hi Jonas, >>> >>> On Fri, 20 Dec 2024 at 09:50, Jonas Karlman wrote: Hi Quentin and Simon, On 2024-12-13 1

[PATCH v2 02/35] spl: Add an SPL_HAVE_INIT_STACK option

2025-02-09 Thread Simon Glass
At present there is a hex value SPL_STACK which both determines whether SPL has its own initial stack and the hex value of that stack. Split off the former into SPL_HAVE_INIT_STACK with SPL_STACK depending on that and only providing the latter. Signed-off-by: Simon Glass --- Changes in v2: - Ad

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Heinrich Schuchardt
Am 9. Februar 2025 21:15:53 MEZ schrieb Simon Glass : >Hi Tom, > >On Sun, 9 Feb 2025 at 09:39, Tom Rini wrote: >> >> On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: >> >> [snip] >> > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the >> > way you want to go, I'd be ha

[PATCH v2 30/35] rockchip: Set the skip-at-start property correctly

2025-02-09 Thread Simon Glass
The rockchip image is written to the media at block 64, which is a 32K offset, so set the skip-at-start property to 0x8000 Update CONFIG_SPL_PAD_TO to point to the offset in the image, since Binman is dealing with the 'missing' 32K now. Signed-off-by: Simon Glass --- Changes in v2: - Move this

[PATCH v2 00/35] VBE serial part H: Implement VBE on Rockchip RK3399

2025-02-09 Thread Simon Glass
This series completes the work to enable VBE on a suitable board. Most of it is rockchip-specific patches to support the VPL phase, i.e. the one which decides which boot patch to take (A, B or recovery). A good chunk of this series is adding an image for VBE, by creating a new Binman image. Future

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Thu, Feb 06, 2025 at 08:47:47AM -0700, Simon Glass wrote: [snip] > Perhaps make EFI_LOADER select CPU, or depend on CPU? If that's the > way you want to go, I'd be happy to do a precursor series to deal with > the fallout. I'm not sure what EFI_LOADER has to do with the generic security featur

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:30:43AM -0700, Simon Glass wrote: > Hi Ilias, > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > wrote: > > > > Hi Heinrich, > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > > > For armv8 we are a

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Tom Rini
On Sun, Feb 09, 2025 at 07:35:31AM -0700, Simon Glass wrote: > Hi Ilias, > > On Thu, 6 Feb 2025 at 09:21, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > > > wro

[PATCH v2 26/35] rockchip: Allow SPL to set up SDRAM

2025-02-09 Thread Simon Glass
The current logic assumes that if TPL exists then it must be setting up the SDRAM. This is not true with VBE, so allow this to be controlled by whether CONFIG_TPL_RAM is enabled, or not. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-rockchip/tpl.c | 10 ++ 1 file c

[PATCH 2/2] u_boot_pylib: Clean up pylint warnings in gitutil.py

2025-02-09 Thread Simon Glass
Reduce the number of warnings in this file. Signed-off-by: Simon Glass --- tools/buildman/func_test.py | 4 +- tools/u_boot_pylib/gitutil.py | 240 ++ 2 files changed, 128 insertions(+), 116 deletions(-) diff --git a/tools/buildman/func_test.py b/tools/build

[PATCH 1/2] u_boot_pylib: Move gitutil into the library

2025-02-09 Thread Simon Glass
Move this file into U-Boot's Python library, so that it is no-longer part of patman. This makes a start on: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/35 Signed-off-by: Simon Glass --- tools/buildman/builder.py | 2 +- tools/buildman/builderthread.py

[PATCH v2 27/35] rockchip: Add a generic-ddr3 rk3399 board

2025-02-09 Thread Simon Glass
This build-target is used to build an image which can run on multiple rk3399 boards, using VBE to boot. To use it, the TPL binary for a particular board must be placed into the first part of the image. The rest of the image (i.e. VPL, SPL and U-Boot) are largely generic and can work on any support

[PATCH v2 22/35] rockchip: Update rk3399 bootph-tags for VPL

2025-02-09 Thread Simon Glass
When VPL is in use, memory init happens in SPL, so there is no need to include the DMC device before that. Adjust the tags to save space. Signed-off-by: Simon Glass --- Changes in v2: - Only enable MMC when VPM is in use. arch/arm/dts/rk3399-u-boot.dtsi | 11 ++- 1 file changed, 10 ins

[PATCH v2 33/35] RFC: Revert "bloblist: Load the bloblist from the previous loader"

2025-02-09 Thread Simon Glass
The logic of this has become too confusing. The primary issue with the patch is that U-Boot needs to set up a bloblist in the first phase where BLOBLIST is enabled. Subsequent phases can then use that bloblist. But the first phase of U-Boot cannot assume that one exists. Reverting this commit se

[PATCH v2 28/35] rockchip: Add documentation for VBE

2025-02-09 Thread Simon Glass
Now that VBE is running at a basic level on rk3399, add mention of it in the documentation. Signed-off-by: Simon Glass --- (no changes since v1) doc/board/rockchip/rockchip.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockch

[PATCH v2 34/35] rockchip: Relocate bloblist at the end of the SPL phase

2025-02-09 Thread Simon Glass
Where the bloblist is located in internal memory and TF-A's BL31 blob removes access to this memory, the best option seems to be to relocate the bloblist just before running TF-A. Do this at the end of SPL. Signed-off-by: Simon Glass Suggested-by: Raymond Mao --- Changes in v2: - Move this log

[PATCH v2 35/35] bloblist: Allow using a different bloblist address

2025-02-09 Thread Simon Glass
Where the bloblist is located in internal memory and TF-A's BL31 blob removes access to this memory, the best option seems to be to relocate the bloblist just before running TF-A. We can do the relocation in board-specific code, but need an option to pick up the correct address within U-Boot prope

[PATCH v2 32/35] rockchip: Update binman image for new skip-at-start setup

2025-02-09 Thread Simon Glass
Now that the skip-at-start feature is properly used in Binman, drop the various workarounds in the image. Signed-off-by: Simon Glass --- Changes in v2: - Split out the fixes for skip-at-start into a new patch arch/arm/dts/rockchip-vpl-u-boot.dtsi | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH v2 31/35] vbe: Add a bootmeth driver for abrec

2025-02-09 Thread Simon Glass
Add a VBE-ABrec bootmeth so that the VBE state can be accessed. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch with a bootmeth driver for abrec boot/vbe_abrec.c | 99 1 file changed, 99 insertions(+) diff --git a/boot/vbe_abrec.c

[PATCH v2 29/35] gitlab: Add an VBE board to the sjg lab

2025-02-09 Thread Simon Glass
Add a rockchip rk3399 board which runs Verified Boot for Embedded. Signed-off-by: Simon Glass --- (no changes since v1) .gitlab-ci.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8c49d5b0a79..a9daa7bb84e 100644 --- a/.gitlab-ci.yml +++ b/.git

[PATCH v2 24/35] rockchip: Add symbols for spl_reloc

2025-02-09 Thread Simon Glass
Add various symbols so that this feature works as intended. This allows xPL to copy the relocating-jump code up to the top of memory, then use it to decompress and start the next phase. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-rockchip/u-boot-tpl-v8.lds | 13 +

[PATCH v2 25/35] rockchip: rk3399: Adjust initial TPL-stack to match SPL

2025-02-09 Thread Simon Glass
There doesn't seem to be a good reason to use a different value for TPL than SPL. Change the TPL value, since it allows a 256-byte bloblist to be safely located above the stack in all phases. Note that for most boards, SDRAM init happens in TPL so the SPL stack ends up in DRAM, at address CONFIG_S

[PATCH v2 23/35] rockchip: Provide a VPL phase on rk3399

2025-02-09 Thread Simon Glass
Add support for this new phase, which runs after TPL. It determines the state of the machine, then selects which SPL image to use. SDRAM init is then done in SPL, so that it is updatable. Signed-off-by: Simon Glass --- Changes in v2: - Rewrite help for VPL_ROCKCHIP_COMMON_BOARD - Skip spl-boot-o

[PATCH v2 21/35] rockchip: Add TPL alternatives

2025-02-09 Thread Simon Glass
The TPL image must be built for each board we need to support. It is the only part of the image which is board-specific. This helps to save space and reduce the size of TPL, so that it can fit within the internal 192K IRAM of the RK3399 SoC. As with other phases, the TPL devicetree is run through

[PATCH v2 20/35] rockchip: Add a VPL image

2025-02-09 Thread Simon Glass
The VPL image is immutable and has a single VPL binary plus a devicetree for each board we need to support. The devicetree is run through fdtgrep to remove unwanted nodes and properties and reduce its size. Changes in v2: - Move VPL things into a separate file Signed-off-by: Simon Glass --- (n

[PATCH v2 19/35] rockchip: Add a template for SPL

2025-02-09 Thread Simon Glass
The SPL phase has a single SPL binary plus a devicetree for each board we need to support. The devicetree is run through fdtgrep to remove unwanted nodes and properties and reduce its size. While it would be nicer to just have a single FIT holding both the SPL and U-Boot images, there may not be

[PATCH v2 18/35] rockchip: Include a compatible string in each configuration

2025-02-09 Thread Simon Glass
Provide a compatible string so that U-Boot can decide which configuration to use. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi in

[PATCH v2 17/35] rockchip: Add SPL into the main FIT

2025-02-09 Thread Simon Glass
VBE may want to load the SPL image from the same FIT as contains U-Boot, if there is enough memory, so add it. Changes in v2: - Move VPL things into a separate file Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-vpl-u-boot.dtsi | 29 +++ 1 f

[PATCH v2 16/35] rockchip: Provide a bootstd configuration

2025-02-09 Thread Simon Glass
Add bootstd information for VBE. Put it in a separate file to avoid cluttering the main one. Signed-off-by: Simon Glass --- Changes in v2: - Move VPL things into a separate file arch/arm/dts/rockchip-u-boot.dtsi | 4 arch/arm/dts/rockchip-vpl-u-boot.dtsi | 31

[PATCH v2 15/35] rockchip: dts: Specify the phase in the image

2025-02-09 Thread Simon Glass
Add 'u-boot' as the phase for the images intended for use with U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi in

[PATCH v2 14/35] rockchip: dts: Use the new binman template for the SPI image too

2025-02-09 Thread Simon Glass
At present simple-bin-spi relies on the u-boot.itb file created by the simple-bin image. Use the template to avoid this, since Binman may change to process images in parallel in the future. Drop the filename to prevent another image being created which uses the u-boot.itb file. Signed-off-by: Sim

[PATCH v2 13/35] rockchip: dts: Un-indent the FIT template

2025-02-09 Thread Simon Glass
Fix the indentation on the template. This is done in a separate patch so that it is easier to review. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 178 +++--- 1 file changed, 89 insertions(+), 89 deletions(-) diff --git a/arc

[PATCH v2 11/35] rockchip: dts: Add an fdtmap

2025-02-09 Thread Simon Glass
Add an fdtmap so it is possible to look at the image with 'binman ls'. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi index 2b0

[PATCH v2 12/35] rockchip: dts: Create a template for the FIT

2025-02-09 Thread Simon Glass
Move the FIT description into a template so that it can (later) be used in multiple places in the image. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 57 ++- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/

[PATCH v2 09/35] rockchip: dts: Correct the OS for U-Boot

2025-02-09 Thread Simon Glass
The U-Boot section is currently getting an invalid OS. Use the correct value to fix this. Signed-off-by: Simon Glass Reviewed-by: Jonas Karlman --- Changes in v2: - Put this patch before 'Factor out arch and compression' arch/arm/dts/rockchip-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+)

[PATCH v2 10/35] rockchip: dts: Factor out arch and compression

2025-02-09 Thread Simon Glass
Declare these at the top of the file to avoid needing #ifdefs in every usage. Add a few comments to help with the remaining #ifdefs Signed-off-by: Simon Glass Reviewed-by: Jonas Karlman --- (no changes since v1) arch/arm/dts/rockchip-u-boot.dtsi | 44 +++ 1 file c

[PATCH v2 08/35] rockchip: Allow RAM init to happen in SPL on rk3399

2025-02-09 Thread Simon Glass
TPL runs before VPL. The earliest updatable phase with VBE is SPL. We want to be able to update the RAM-init code in the field. So when VPL is being used, init the RAM later, in SPL. Signed-off-by: Simon Glass --- (no changes since v1) drivers/ram/rockchip/sdram_rk3399.c | 6 -- 1 file ch

[PATCH v2 07/35] vbe: Show the margin when using SPL_RELOC

2025-02-09 Thread Simon Glass
Collect information about the memory-margin in each phase which uses this feature. Update the 'vbe state' command to show it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/vbe.c | 8 ++-- common/spl/spl_reloc.c | 12 include/vbe.h | 3 +++ 3

[PATCH v2 05/35] spl: Adjust xPL symbols

2025-02-09 Thread Simon Glass
Update for the new xPL naming, which was missed in a previous patch which purported to do this. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) common/spl/spl_reloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl_reloc.c b/common

[PATCH v2 06/35] spl: Allow VBE to handle xPL size

2025-02-09 Thread Simon Glass
When VBE is in use, the size of each phase is obtained by reading it from a FIT. Avoid using binman symbols unless necessary, i.e. in TPL. Signed-off-by: Simon Glass --- (no changes since v1) common/spl/spl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/spl/spl.c b/common/spl/s

[PATCH v2 04/35] arm: Support a separate stack for VPL

2025-02-09 Thread Simon Glass
VPL has the same needs as TPL in situations where the stack is at the top of SRAM. Add an option for this and implement it for arm Signed-off-by: Simon Glass --- Changes in v2: - Reply on existing CONFIG_VAL() to select the VPL stack - Correct reference to TPL when VPL was intended common/spl/

[PATCH v2 03/35] spl: Use CONFIG_VAL() to obtain the SPL stack

2025-02-09 Thread Simon Glass
Now that we have the same option for SPL and VPL, simplify the logic for determining the initial stack. Signed-off-by: Simon Glass Suggested-by: Tom Rini --- Changes in v2: - Add new patch to use CONFIG_VAL() to obtain the SPL stack arch/arm/cpu/armv7/lowlevel_init.S | 4 ++-- arch/arm/cpu/ar

[PATCH v2 01/35] tpl: Rename TPL_NEEDS_SEPARATE_STACK to TPL_HAVE_INIT_STACK

2025-02-09 Thread Simon Glass
The most common word for features that make a platform work is to use 'HAVE_xxx'. Rename this option to match. Update the help to use the word 'phase' rather than 'stage', since that is the current terminology. Also clarify that, absent this setting, the stack pointer generally comes from the valu

Re: [PATCH v2 25/29] efi: Generate the app as a shared library

2025-02-09 Thread Simon Glass
Hi Tom, On Sun, 9 Feb 2025 at 11:14, Tom Rini wrote: > > On Sat, Feb 08, 2025 at 10:11:45AM -0700, Simon Glass wrote: > > > The app should be built as a shared library, with position-independent > > code and the -shared flags. Update the Makefile to handle this. > > > > Signed-off-by: Simon Glass

Re: [PATCH 4/4] configs: starfive: default to jh7110-starfive-visionfive-2-v1.3b

2025-02-09 Thread E Shattow
On 2/9/25 07:23, Heinrich Schuchardt wrote: > We use starfive_visionfive2_defconfig to generate a FIT image supporting > all JH7110 boards in U-Boot. Make jh7110-starfive-visionfive-2-v1.3b the > default configuration that is used if no other configuration fits. > > Signed-off-by: Heinrich Schuc

[PATCH 1/3] u-boot: drivers: marvell: rtc: adding rtc driver

2025-02-09 Thread Josua Mayer
From: Alex Leibovich Adding missing marvell-rtc driver and configuration, in order to support "date" command. Signed-off-by: Alex Leibovich Reviewed-on: https://sj1git1.cavium.com/c/IP/SW/boot/u-boot/+/6322 Reviewed-by: Kostya Porotchkin Tested-by: Kostya Porotchkin Signed-off-by: Josua Mayer

[PATCH 0/3] arm: mvebu: add solidrun cn913x based boards

2025-02-09 Thread Josua Mayer
changed, 1065 insertions(+), 1 deletion(-) --- base-commit: ac3dcb0c2710c4917d93d6d2eb34dbfb00516bc2 change-id: 20250209-cn9130-board-09c8db7c077a Best regards, -- Josua Mayer

[PATCH 3/3] board: solidrun: add cn9130 based boards

2025-02-09 Thread Josua Mayer
Add a new solidrun board "octeontx2_cn913x" for all boards designed with Marvell CN9130 SoC: - CN9130 Clearfog Base - CN9130 Clearfog Pro - CN9131 SolidWAN - CN9132 Clearfog The boards can share a lot of common code differing only in device-tree. This initial support is limited to: - GPIO - RTC

[PATCH 2/3] mvebu: armada-8k: set fdtfile env from DEFAULT_FDT_FILE

2025-02-09 Thread Josua Mayer
Developers find themselves with two options for defining the default device-tree for a platform: 1. CONFIG_DEFAULT_DEVICE_TREE deciding which DT the u-boot build will use for itself. 2. CONFIG_DEFAULT_FDT_FILE deciding what should be the name of the actual device-tree file, when booting an O

Re: [PATCH 05/29] rockchip: Allow RAM init to happen in SPL on rk3399

2025-02-09 Thread Simon Glass
Hi Jonas, On Sun, 9 Feb 2025 at 09:30, Jonas Karlman wrote: > > Hi Simon, > > On 2025-02-09 16:36, Simon Glass wrote: > > Hi Jonas, > > > > On Sun, 9 Feb 2025 at 08:17, Jonas Karlman wrote: > >> > >> Hi Simon, > >> > >> On 2025-02-09 15:26, Simon Glass wrote: > >>> Hi Jonas, > >>> > >>> On Wed,

Re: [PATCH 1/2] boot: continue in fit_find_config_node()

2025-02-09 Thread Simon Glass
Hi Heinrich, On Sun, 9 Feb 2025 at 10:33, Heinrich Schuchardt wrote: > > On 09.02.25 17:24, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 9 Feb 2025 at 09:10, Heinrich Schuchardt > > wrote: > >> > >> On 09.02.25 17:02, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Sun, 9 Feb 2025 at

Re: [PATCH 06/12] rockchip: rk3399-gru: Include binman generated FIT in u-boot.rom image

2025-02-09 Thread Simon Glass
Hi Tom, On Sun, 9 Feb 2025 at 09:49, Tom Rini wrote: > > On Sun, Feb 09, 2025 at 07:27:37AM -0700, Simon Glass wrote: > > Hi Jonas, > > > > On Fri, 20 Dec 2024 at 09:50, Jonas Karlman wrote: > > > > > > Hi Quentin and Simon, > > > > > > On 2024-12-13 15:30, Quentin Schulz wrote: > > > > Hi Jonas

Re: [PATCH 07/32] scripts: Update build-efi to support arm64

2025-02-09 Thread Heinrich Schuchardt
Am 3. Februar 2025 18:42:00 MEZ schrieb Simon Glass : >Provide a -A flag to select ARM instead of x86. For now, only the app >is supported and only for 64-bit ARM. > >Signed-off-by: Simon Glass >--- > > scripts/build-efi.py | 49 +++- > 1 file changed, 35 ins

Re: [PATCH 01/32] Convert build-efi script to Python

2025-02-09 Thread Heinrich Schuchardt
Am 3. Februar 2025 18:41:54 MEZ schrieb Simon Glass : >Before this gets any longer, convert it to Python so it is easier to >maintain. > >Signed-off-by: Simon Glass >--- > > MAINTAINERS| 2 +- > doc/develop/uefi/u-boot_on_efi.rst | 4 +- > scripts/build-efi.py

Re: [PATCH 0/3] rockchip: rk3399-gru: Fix missing TPL and SPL banner on debug UART

2025-02-09 Thread Jonas Karlman
Hi, On 2025-02-09 17:58, Tom Rini wrote: > On Sun, Feb 09, 2025 at 07:28:38AM -0700, Simon Glass wrote: >> Hi Jonas, >> >> On Sat, 8 Feb 2025 at 15:49, Jonas Karlman wrote: >>> >>> The PP1500 and PP3000 power rails must be on very early for the U-Boot >>> TPL and SPL banner to be shown on debug U

Re: [PATCH v3 19/29] efi: arm: Drop exception-level code when running as EFI app

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 07:01:18PM -0700, Simon Glass wrote: > The switch_to_non_secure_mode() function cannot be used since EFI is in > charge of managing exception-levels. > > Build just the exceptions.S file. > > Modify the existing SPL rule to cater to the EFI app too. > > Signed-off-by: Si

Re: [PATCH v2 25/29] efi: Generate the app as a shared library

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 10:11:45AM -0700, Simon Glass wrote: > The app should be built as a shared library, with position-independent > code and the -shared flags. Update the Makefile to handle this. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > Makefile | 4 > 1 fil

Re: [PATCH v3 09/29] efi: x86: Rework VENDOR_EFI option to permit other archs

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 07:01:08PM -0700, Simon Glass wrote: > At present only x86 supports the EFI app and (apart from Qualcomm) the > payload. In preparation for supporting 64-bit ARM more generally, rename > the existing ARCH_EFI option to ARCH_EFI_X86, using that to define a > generic ARCH_EFI

Re: [PATCH v3 08/29] treewide: Rename VENDOR_EFI to ARCH_EFI

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 07:01:07PM -0700, Simon Glass wrote: > The 'vendor' concept comes from arch/x86. Rather than letting this > spread around the tree, rename it to ARCH_EFI. > > While EFI is not quite an architecture in the strict sense, it is > similar to sandbox in that it sits somewhat ab

Re: [PATCH v3 02/29] video: Move vesa_setup_video_priv() into its own file

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 07:01:01PM -0700, Simon Glass wrote: > This helper is used by the EFI driver and we would like to use that on > ARM. Move the helper function into its own file, separate from PCI ROMs, > which are an x86 thing. > > Add a forward declaration for struct udevice so that the h

Re: [PATCH v2 01/29] Makefile: Avoid using TEXT_BASE if not present

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 10:11:21AM -0700, Simon Glass wrote: > This value is only available if CONFIG_HAVE_TEXT_BASE is enabled. Add > conditions to avoid introducing errors in link scripts when it is not. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Depend on CONFIG_EFI_APP inste

Re: [PATCH 2/5] rockchip: Improve ARMv7 support for ROCKCHIP_COMMON_STACK_ADDR

2025-02-09 Thread Jonas Karlman
Hi Alex, On 2025-02-05 20:02, Alex Bee wrote: > Hi Jonas, > >> Hi Alex, >> >> On 2025-01-27 19:59, Alex Bee wrote: >>> Hi Jonas, >>> >>> thanks for working on this.  Please see one comment below. >>> >>> Am 27.01.25 um 00:48 schrieb Jonas Karlman: A few Rockchip ARMv7 SoCs use 0x6000 as

Re: [PATCH 01/32] Convert build-efi script to Python

2025-02-09 Thread Tom Rini
On Fri, Feb 07, 2025 at 06:28:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 10:10, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 06:05:36AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:07, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 1/2] boot: continue in fit_find_config_node()

2025-02-09 Thread Heinrich Schuchardt
On 09.02.25 17:24, Simon Glass wrote: Hi Heinrich, On Sun, 9 Feb 2025 at 09:10, Heinrich Schuchardt wrote: On 09.02.25 17:02, Simon Glass wrote: Hi Heinrich, On Sun, 9 Feb 2025 at 08:53, Heinrich Schuchardt wrote: On 09.02.25 15:29, Simon Glass wrote: Hi Heinrich, On Sun, 9 Feb 2025 at

Re: [PATCH 0/2] Remove "saveenv" functionality from am57xx evms

2025-02-09 Thread Tom Rini
On Sat, Feb 08, 2025 at 10:09:36AM +0530, Anurag Dutta wrote: > Previously saved environment introduce discrepancies and may lead to > incompatibilities without default settings. This series removes the saved > environment functionality on am57xx evms so that the default configuration > is always

Re: [PATCH 1/2] boot: continue in fit_find_config_node()

2025-02-09 Thread Heinrich Schuchardt
On 09.02.25 17:02, Simon Glass wrote: Hi Heinrich, On Sun, 9 Feb 2025 at 08:53, Heinrich Schuchardt wrote: On 09.02.25 15:29, Simon Glass wrote: Hi Heinrich, On Sun, 9 Feb 2025 at 04:52, Heinrich Schuchardt wrote: If a single configuration node lacks a description, this does not rule out

Re: [PATCH 0/3] rockchip: rk3399-gru: Fix missing TPL and SPL banner on debug UART

2025-02-09 Thread Tom Rini
On Sun, Feb 09, 2025 at 07:28:38AM -0700, Simon Glass wrote: > Hi Jonas, > > On Sat, 8 Feb 2025 at 15:49, Jonas Karlman wrote: > > > > The PP1500 and PP3000 power rails must be on very early for the U-Boot > > TPL and SPL banner to be shown on debug UART for bob and kevin. > > > > This series res

Re: [PATCH 06/12] rockchip: rk3399-gru: Include binman generated FIT in u-boot.rom image

2025-02-09 Thread Tom Rini
On Sun, Feb 09, 2025 at 07:27:37AM -0700, Simon Glass wrote: > Hi Jonas, > > On Fri, 20 Dec 2024 at 09:50, Jonas Karlman wrote: > > > > Hi Quentin and Simon, > > > > On 2024-12-13 15:30, Quentin Schulz wrote: > > > Hi Jonas, > > > > > > On 12/13/24 12:57 AM, Jonas Karlman wrote: > > >> The u-boot

[PATCH v2 4/6] test/py: Drop assigning ubman to cons

2025-02-09 Thread Simon Glass
Now that we have a shorter name, we don't need this sort of thing. Just use ubman instead. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to drop assigning ubman to cons test/py/tests/test_android/test_abootimg.py | 43 +++--- test/py/tests/test_efi_fit.py | 81 +

[PATCH v2 0/6] test: A few quality-of-life improvements

2025-02-09 Thread Simon Glass
This little series includes a few patches to make it easier to work with the Python tests, by shortening identifiers and renaming the 'console' fixture to reflect its role as the top-level fixture. It also adds a command to fix testing on samus_tpl This series is based on the previous 'test' seri

[PATCH] tools: Fix potential null-deref with result of strtok_r

2025-02-09 Thread Maks Mishin
Return value of a function 'strtok_r' is dereferenced at kwbimage.c:1655 without checking for NULL, but it is usually checked for this function. Signed-off-by: Maks Mishin --- tools/kwbimage.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index d1

Re: [PATCH v2 00/29] arm: Support building as an EFI app

2025-02-09 Thread Simon Glass
Hi Tom, On Sat, 8 Feb 2025 at 18:59, Simon Glass wrote: > > Hi Tom, > > On Sat, 8 Feb 2025 at 18:43, Simon Glass wrote: > > > > Hi Tom, > > > > On Sat, 8 Feb 2025 at 17:03, Tom Rini wrote: > > > > > > On Sat, Feb 08, 2025 at 03:40:07PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > O

[PATCH] tools: Fix handle leak in mmap_fdt function

2025-02-09 Thread Maks Mishin
The handle 'ptr' is created at fit_common.c:91 by calling function 'mmap' and lost at fit_common.c:127: Added call of free for `ptr` if ptr != MAP_FAILED. Trigger was found by the Svace static analyzer. Signed-off-by: Maks Mishin --- tools/fit_common.c | 1 + 1 file changed, 1 insertion(+) d

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-09 Thread Simon Glass
Hi Ilias, On Thu, 6 Feb 2025 at 09:21, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > > > Hi Ilias, > > > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > > wrote: > > > > > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > > > > > Hi Ili

Re: [PATCH 00/29] VBE serial part H: Implement VBE on Rockchip RK3399

2025-02-09 Thread Simon Glass
Hi Jonas, On Wed, 5 Feb 2025 at 02:51, Jonas Karlman wrote: > > Hi Simon, > > It does not look like this is based on the master branch and cannot be > applied for review/testing. Please rebase on top of the master branch. > > Some quick feedback: > - Some of these could/should be a standalone pat

  1   2   >