On 2/9/25 07:23, Heinrich Schuchardt wrote:
> We use starfive_visionfive2_defconfig to generate a FIT image supporting
> all JH7110 boards in U-Boot. Make jh7110-starfive-visionfive-2-v1.3b the
> default configuration that is used if no other configuration fits.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
> ---
>  configs/starfive_visionfive2_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/starfive_visionfive2_defconfig 
> b/configs/starfive_visionfive2_defconfig
> index c3f2142ae1b..ed077886436 100644
> --- a/configs/starfive_visionfive2_defconfig
> +++ b/configs/starfive_visionfive2_defconfig
> @@ -78,7 +78,7 @@ CONFIG_CMD_WDT=y
>  CONFIG_CMD_TFTPPUT=y
>  CONFIG_CMD_BOOTSTAGE=y
>  CONFIG_OF_BOARD=y
> -CONFIG_OF_LIST="starfive/jh7110-milkv-mars starfive/jh7110-pine64-star64 
> starfive/jh7110-starfive-visionfive-2-v1.2a 
> starfive/jh7110-starfive-visionfive-2-v1.3b"
> +CONFIG_OF_LIST="starfive/jh7110-starfive-visionfive-2-v1.3b 
> starfive/jh7110-milkv-mars starfive/jh7110-pine64-star64 
> starfive/jh7110-starfive-visionfive-2-v1.2a"
>  CONFIG_MULTI_DTB_FIT=y
>  CONFIG_ENV_OVERWRITE=y
>  CONFIG_ENV_IS_IN_SPI_FLASH=y

Please keep CONFIG_OF_LIST sorted. Fall-through case should instead be a
failure to boot, or at least a warning to the user that something
unexpected is happening and inform that an assumption of a generic set
of parameters or arbitrary board Fdt is being substituted. Implicit
fall-through selection that un-orders the list is NAK. -E

Reply via email to