Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Joakim Tjernlund
> > Hi Marek, > > On Mon, Apr 2, 2012 at 1:36 PM, Marek Vasut wrote: > > Dear Mike Frysinger, > > > >> On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: > >> > b) The code calling malloc(0) is making a perfectly legitimate assumption > >> > > >> >    based on how glibc handles malloc(0) > >> > >

Re: [U-Boot] [PATCH V2 12/24] SPEAr: Enable usb device high speed support

2012-04-01 Thread Amit Virdi
Dear Marek, On 3/31/2012 11:58 PM, Marek Vasut wrote: Dear Amit Virdi, From: Vipin KUMAR Cc me with usb related stuff please. Ok, I'll take care in future. Does USBTTY work for you? Tom complained about it. Yes it works and we haven't found any issue till date. Infact, Vipin has dev

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Joakim Tjernlund
Graeme Russ wrote on 2012/04/02 05:05:51: > > Hi Marek, > > On Mon, Apr 2, 2012 at 12:51 PM, Marek Vasut wrote: > > Dear Graeme Russ, > > > >> Hi Marek, > > >> Bottom line is, we could do either and we would be 100% compliant with the > >> C standard > >> > >> The question is, what would be more

Re: [U-Boot] [PATCH v2] lsxl: add support for lschlv2 and lsxhl

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: Michael Walle [mailto:mich...@walle.cc] > Sent: 30 March 2012 19:27 > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Wolfgang Denk > Subject: Re: [PATCH v2] lsxl: add support for lschlv2 and lsxhl > > > Hi Prafulla, > > [ I'm CCing Wolfgang on this, be

Re: [U-Boot] [PATCH v2 05/18] net: Move debug trace to point of action

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass > --- > Changes for v2: >   - Split from "Refactor bootp packet length computations" > >  net/bootp.c |    2 +- >  1 fi

Re: [U-Boot] [PATCH v2 04/18] net: Refactor bootp packet length computations

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Eliminate pointer subtraction that recovers values computed earlier > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass ___

Re: [U-Boot] [PATCH v2 03/18] net: Refactor packet length computations

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/li

Re: [U-Boot] [PATCH v2 02/18] net: Refactor NetSendUDPPacket to share more code

2012-04-01 Thread Simon Glass
Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Share more of the code that is common between ARP vs not. > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger It seems ok to my eye. Acked-by: Simon Glass Regards, Simon _

Re: [U-Boot] [PATCH v2 01/18] net: Refactor IP, UPD, and ICMP header writing functions

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > ICMP (ping) was reimplementing IP header code... it now shares code. > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass Seems like the call to NetCksum() could be tid

Re: [U-Boot] [PATCH][resubmit] eb_cpux9k2: add USB host support to board

2012-04-01 Thread esw
Am 2012-04-01 18:14, schrieb Marek Vasut: > Dear Jens Scharsig, > >> * add USB host support to eb_cpux9k2 board > > Did you test this too? Of course, I've test this with/against current RC1. > > CCing Albert, Albert do you want me to push this through staging or you'll > pick > this? > >> S

Re: [U-Boot] [PATCH v2 10/10] net: cosmetic: netconsole.c checkpatch compliance

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Requires: > --ignore CONSIDER_KSTRTO > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@list

Re: [U-Boot] [PATCH v2 09/10] net: cosmetic: tftp.* checkpatch compliance

2012-04-01 Thread Simon Glass
Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass > --- > Changes for v2: >   - Split into smaller patches > >  include/net.h |    4 >  net/tftp.c    |   3

Re: [U-Boot] [PATCH v2 08/10] net: cosmetic: sntp.* checkpatch compliance

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass but see suggestion below (not checkpatch issue though) > --- > Changes for v2: >   - Split into smaller patches > >  n

Re: [U-Boot] [PATCH v2 07/10] net: cosmetic: rarp.* checkpatch compliance

2012-04-01 Thread Simon Glass
On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Acked-by: Simon Glass > --- > Changes for v2: >   - Split into smaller patches > >  net/rarp.c |   28 ++-- >  net/rar

Re: [U-Boot] [PATCH v2 06/10] net: cosmetic: nfs.* checkpatch compliance

2012-04-01 Thread Simon Glass
Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger Looks good. Acked-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://li

Re: [U-Boot] [PATCH v2 03/10] net: cosmetic: net.c checkpatch compliance

2012-04-01 Thread Simon Glass
Hi Joe, On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger wrote: > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Simon Glass > Cc: Mike Frysinger > --- > Changes for v2: >   - Split into smaller patches > >  net/bootp.c |  340 > ++-

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 23:34:28 Marek Vasut wrote: > Dear Mike Frysinger, > > On Sunday 01 April 2012 21:44:39 Marek Vasut wrote: > > > Dear Mike Frysinger, > > > > On Sunday 01 April 2012 17:00:56 Marek Vasut wrote: > > > > > Dear Mike Frysinger, > > > > > > On Sunday 01 April 2012 09:22:59 Stefa

Re: [U-Boot] [PATCH 3/5] net: add eth_setenv_enetaddr_by_index()

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: Michael Walle [mailto:mich...@walle.cc] > Sent: 31 March 2012 18:09 > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Wolfgang Denk; Michael Walle > Subject: [PATCH 3/5] net: add eth_setenv_enetaddr_by_index() > > Signed-off-by: Michael Walle > --- > in

Re: [U-Boot] [PATCH 2/5] net: add helper to generate random mac address

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: Michael Walle [mailto:mich...@walle.cc] > Sent: 31 March 2012 18:09 > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Wolfgang Denk; Michael Walle > Subject: [PATCH 2/5] net: add helper to generate random mac address > > Add new function eth_random_enetaddr

Re: [U-Boot] [PATCH 0/5 v3] Kirkwood: add lschlv2 and lsxhl board support

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: Michael Walle [mailto:mich...@walle.cc] > Sent: 31 March 2012 18:09 > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Wolfgang Denk; Michael Walle > Subject: [PATCH 0/5 v3] Kirkwood: add lschlv2 and lsxhl board support > > This patchset add support for the

Re: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de [mailto:u-boot- > boun...@lists.denx.de] On Behalf Of David Purdy > Sent: 02 April 2012 02:54 > To: u-boot@lists.denx.de > Subject: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board: > > Problem w/ SATA/IDE on Kirkwood 88F6

Re: [U-Boot] Marvell/Kirkwood: 6192 vs. 6281 - does U-Boot correctly distinguish between the two?

2012-04-01 Thread Prafulla Wadaskar
From: David Purdy [mailto:david.c.pu...@gmail.com] Sent: 02 April 2012 03:47 To: u-boot@lists.denx.de; Prafulla Wadaskar; albert.u.b...@aribaud.net Subject: Marvell/Kirkwood: 6192 vs. 6281 - does U-Boot correctly distinguish between the two? I've found either a

Re: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-01 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de [mailto:u-boot- > boun...@lists.denx.de] On Behalf Of David Purdy > Sent: 02 April 2012 07:31 > To: u-boot@lists.denx.de > Subject: Re: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board: > > On Sun, Apr 1, 2012 at 4:24 PM,

Re: [U-Boot] [PATCH v2 4/4] ARM: EXYNOS: support EXYNOS display driver

2012-04-01 Thread Minkyu Kang
On 2 April 2012 11:22, Donghwa Lee wrote: > This patch is for EXYNOS Display driver. > > > Signed-off-by: Donghwa Lee > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- >  arch/arm/include/asm/arch-exynos/fb.h |  446 > + >  drivers/video/Makefile    

Re: [U-Boot] [PATCH v2 3/4] ARM: EXYNOS: add exynos lcd clock interface

2012-04-01 Thread Minkyu Kang
On 2 April 2012 11:22, Donghwa Lee wrote: > To get lcd clock in EXYNOS display driver, added get_lcd_clk() interface. > > Signed-off-by: Donghwa Lee > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- >  arch/arm/cpu/armv7/exynos/clock.c |   72 >

Re: [U-Boot] [PATCH v2 1/4] ARM: EXYNOS: definition of system registers

2012-04-01 Thread Minkyu Kang
On 2 April 2012 11:22, Donghwa Lee wrote: > This is definition of system registers for EXYNOS SoC. > > Signed-off-by: Donghwa Lee > Signed-off-by: Kyungmin Park > --- >  arch/arm/cpu/armv7/exynos/Makefile        |    2 +- >  arch/arm/cpu/armv7/exynos/system.c        |   44 ++

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 2:23 PM, Marek Vasut wrote: > Dear Graeme Russ, > >> Hi Marek, >> >> On Mon, Apr 2, 2012 at 1:36 PM, Marek Vasut wrote: >> > Dear Mike Frysinger, >> > >> >> On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: >> >> > b) The code calling malloc(0) is making a perf

Re: [U-Boot] [PATCH] m28evk: Use GENERATED_GBL_DATA_SIZE

2012-04-01 Thread Marek Vasut
Dear Fabio Estevam, I think this patch is wrong ... did I ack this one? > Use GENERATED_GBL_DATA_SIZE for calculating CONFIG_SYS_INIT_SP_OFFSET. > > Signed-off-by: Fabio Estevam > --- > include/configs/m28evk.h |9 - > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --gi

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi Marek, > > On Mon, Apr 2, 2012 at 1:36 PM, Marek Vasut wrote: > > Dear Mike Frysinger, > > > >> On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: > >> > b) The code calling malloc(0) is making a perfectly legitimate > >> > assumption > >> > > >> >based on how glibc

[U-Boot] [PATCH] i.MX28: Fix initial stack pointer position

2012-04-01 Thread Marek Vasut
The patch: m28evk: Use GENERATED_GBL_DATA_SIZE commit 1084606c972ea5f1d89f69bdbd978b867d0ee521 introduced usage of GENERATED_GBL_DATA_SIZE and calculation of initial stack pointer position defived from that. Due to a small typo, the SP position moved to 0x21f80, which is past the SRAM area. T

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 1:36 PM, Marek Vasut wrote: > Dear Mike Frysinger, > >> On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: >> > b) The code calling malloc(0) is making a perfectly legitimate assumption >> > >> >    based on how glibc handles malloc(0) >> >> not really.  POSIX sa

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 01 April 2012 18:40:05 Graeme Russ wrote: > > if ((long)bytes == 0) { > > > > DEBUG("Warning: malloc of zero block size\n"); > > bytes = 1; > > > > } else if ((long)bytes < 0) { > > > >

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: > > b) The code calling malloc(0) is making a perfectly legitimate assumption > > > >based on how glibc handles malloc(0) > > not really. POSIX says malloc(0) is implementation defined (so it may > return a unique ad

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 01 April 2012 21:44:39 Marek Vasut wrote: > > Dear Mike Frysinger, > > > > > On Sunday 01 April 2012 17:00:56 Marek Vasut wrote: > > > > Dear Mike Frysinger, > > > > > > > > > On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > > > > > > If the range passed t

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Mike, On Mon, Apr 2, 2012 at 1:12 PM, Mike Frysinger wrote: > On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: >> b) The code calling malloc(0) is making a perfectly legitimate assumption >>    based on how glibc handles malloc(0) > > not really.  POSIX says malloc(0) is implementation defi

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 20:25:44 Graeme Russ wrote: > b) The code calling malloc(0) is making a perfectly legitimate assumption >based on how glibc handles malloc(0) not really. POSIX says malloc(0) is implementation defined (so it may return a unique address, or it may return NULL). no use

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 18:40:05 Graeme Russ wrote: > if ((long)bytes == 0) { > DEBUG("Warning: malloc of zero block size\n"); > bytes = 1; > } else if ((long)bytes < 0) { > DEBUG("Error: malloc of negative block size\n"); >

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 21:44:39 Marek Vasut wrote: > Dear Mike Frysinger, > > On Sunday 01 April 2012 17:00:56 Marek Vasut wrote: > > > Dear Mike Frysinger, > > > > On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > > > > > If the range passed to flush_cache is not multiple > > > > > of ARCH_

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 12:51 PM, Marek Vasut wrote: > Dear Graeme Russ, > >> Hi Marek, >> Bottom line is, we could do either and we would be 100% compliant with the >> C standard >> >> The question is, what would be more onerous. Since the majority of U-Boot >> developers will be more

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi Marek, > > On Mon, Apr 2, 2012 at 11:04 AM, Marek Vasut wrote: > > Dear Graeme Russ, > > > >> Hi Marek, > >> > >> On Mon, Apr 2, 2012 at 10:13 AM, Marek Vasut wrote: > >> > Dear Graeme Russ, > >> > > >> >> Hi Marek, > >> >> > >> >> On Mon, Apr 2, 2012 at 9:45 AM, Mare

Re: [U-Boot] Pull request: u-boot-nios/master

2012-04-01 Thread Thomas Chou
Dear Wolfgang, On 04/02/2012 10:40 AM, Thomas Chou wrote: Dear Wolfgang, On 03/31/2012 05:58 AM, Wolfgang Denk wrote: Just one note: After you have pulled these patches, we should also apply two other patches of the series from from Stefan Kristiansson: http://patchwork.ozlabs.org/patch/1236

Re: [U-Boot] Pull request: u-boot-nios/master

2012-04-01 Thread Thomas Chou
Dear Wolfgang, On 03/31/2012 05:58 AM, Wolfgang Denk wrote: Just one note: After you have pulled these patches, we should also apply two other patches of the series from from Stefan Kristiansson: http://patchwork.ozlabs.org/patch/123622/ 1/3 http://patchwork.ozlabs.org/patch/123623/

[U-Boot] [PATCH v2 4/4] ARM: EXYNOS: support EXYNOS display driver

2012-04-01 Thread Donghwa Lee
This patch is for EXYNOS Display driver. Signed-off-by: Donghwa Lee Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/include/asm/arch-exynos/fb.h | 446 + drivers/video/Makefile|1 + drivers/video/exynos_fb.c |

[U-Boot] [PATCH v2 3/4] ARM: EXYNOS: add exynos lcd clock interface

2012-04-01 Thread Donghwa Lee
To get lcd clock in EXYNOS display driver, added get_lcd_clk() interface. Signed-off-by: Donghwa Lee Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- arch/arm/cpu/armv7/exynos/clock.c | 72 + 1 files changed, 72 insertions(+), 0 deletions(-) diff

[U-Boot] [PATCH v2 2/4] ARM: EXYNOS: add data structure for EXYNOS display driver

2012-04-01 Thread Donghwa Lee
add vidinfo data structure for EXYNOS display driver Signed-off-by: Donghwa Lee Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- include/lcd.h | 62 + 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/include/lcd.h

[U-Boot] [PATCH v2 1/4] ARM: EXYNOS: definition of system registers

2012-04-01 Thread Donghwa Lee
This is definition of system registers for EXYNOS SoC. Signed-off-by: Donghwa Lee Signed-off-by: Kyungmin Park --- arch/arm/cpu/armv7/exynos/Makefile|2 +- arch/arm/cpu/armv7/exynos/system.c| 44 + arch/arm/include/asm/arch-exynos/cpu.h|2 +

[U-Boot] [PATCH v2 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

2012-04-01 Thread Donghwa Lee
This patch is for display driver of EXYNOS SoC. [1/4]: ARM: EXYNOS: definition of system registers - to contorl FIMD of LBLK0 bypass selection, add missed definitions of system register [2/4]: ARM: EXYNOS: add data structure for EXYNOS display driver - It is needed to s

Re: [U-Boot] [RESEND PATCH] ARM: Exynos4: ADC: Universal_C210: Enable LDO4 power line for ADC measurement

2012-04-01 Thread Minkyu Kang
Dear Lukasz Majewski, On 27 March 2012 16:53, Lukasz Majewski wrote: > This patch enables LDO4 power line for preparing proper voltages to be > measured by ADC converter. > This measurement is used for determination of target board HW revision. > > Test HW: > Universal_C210 (Exynos4210) rev. 0.0

Re: [U-Boot] [PATCH v2] EXYNOS: Rename exynos5_tzpc structure to exynos_tzpc

2012-04-01 Thread Minkyu Kang
Dear Chander Kashyap, On 15 March 2012 12:34, Chander Kashyap wrote: > TZPC IP is common across Exynos based SoC'c. Renaming exynos5_tzpc > in arch/arm/include/asm/arch-exynos/tzpc.h to exynos_tzpc will allow generic > usase of tzpc. > > Also modify board/samsung/smdk5250/tzpc_init.c to use exyno

Re: [U-Boot] [PATCH] TRATS: modify the trats's configuration

2012-04-01 Thread Minkyu Kang
Jaehoon, On 28 March 2012 15:05, Jaehoon Chung wrote: > Trats is supported 1GiB memory size. > (Each bank size is 512MB.) > And INITRD is unnecessary. So removed them. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > --- >  include/configs/trats.h |    5 ++--- >  1 files change

Re: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-01 Thread David Purdy
On Sun, Apr 1, 2012 at 4:24 PM, David Purdy wrote: > Problem w/ SATA/IDE on Kirkwood 88F6281 board: > > To clarify, this is actually a _6192_ board. I double-checked, there are no 6192 boards in include/configs/ . The contents in arch/arm/arch-kirkwood/ certainly suggest that the 6192 is su

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 01 April 2012 17:00:56 Marek Vasut wrote: > > Dear Mike Frysinger, > > > > > On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > > > > If the range passed to flush_cache is not multiple > > > > of ARCH_DMA_MINALIGN, a warning due to mislaignment > > > > is pri

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 11:04 AM, Marek Vasut wrote: > Dear Graeme Russ, > >> Hi Marek, >> >> On Mon, Apr 2, 2012 at 10:13 AM, Marek Vasut wrote: >> > Dear Graeme Russ, >> > >> >> Hi Marek, >> >> >> >> On Mon, Apr 2, 2012 at 9:45 AM, Marek Vasut wrote: >> >> > Dear Graeme Russ, >> >> >

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 17:00:56 Marek Vasut wrote: > Dear Mike Frysinger, > > On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > > > If the range passed to flush_cache is not multiple > > > of ARCH_DMA_MINALIGN, a warning due to mislaignment > > > is printed. > > > Detected with fec_mxc, mx35

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi Marek, > > On Mon, Apr 2, 2012 at 10:13 AM, Marek Vasut wrote: > > Dear Graeme Russ, > > > >> Hi Marek, > >> > >> On Mon, Apr 2, 2012 at 9:45 AM, Marek Vasut wrote: > >> > Dear Graeme Russ, > >> > >> Because you just set it off - Right now, that code is assuming malloc

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 10:13 AM, Marek Vasut wrote: > Dear Graeme Russ, > >> Hi Marek, >> >> On Mon, Apr 2, 2012 at 9:45 AM, Marek Vasut wrote: >> > Dear Graeme Russ, >> > >> Because you just set it off - Right now, that code is assuming malloc(0) >> will return a valid pointer and th

Re: [U-Boot] [PATCH 05/14] CMD: Drop CONFIG_CMD_DFL, it's not used

2012-04-01 Thread Nobuhiro Iwamatsu
Acked-by: Nobuhiro Iwamatsu 2012/4/1 Marek Vasut : > $ git grep CMD_DFL > board/atc/ti113x.c:#define CMD_DFLT (PCI_COMMAND_IO|PCI_COMMAND_MEMORY| \ > board/atc/ti113x.c:     pci_writew (s, PCI_COMMAND, CMD_DFLT); > board/cpc45/pd67290.c:#define CMD_DFLT (PCI_COMMAND_IO|PCI_COMMAND_MEMORY| \ > boa

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi Marek, > > On Mon, Apr 2, 2012 at 9:45 AM, Marek Vasut wrote: > > Dear Graeme Russ, > > > >> Hi All > >> > >> Here we go again ;) > > > > Yay (polishing my flamethrower)! > > > >> On Mon, Apr 2, 2012 at 12:21 AM, Marek Vasut wrote: > >> > Dear Joakim Tjernlund, > >> >

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi Marek, On Mon, Apr 2, 2012 at 9:45 AM, Marek Vasut wrote: > Dear Graeme Russ, > >> Hi All >> >> Here we go again ;) > > Yay (polishing my flamethrower)! > >> On Mon, Apr 2, 2012 at 12:21 AM, Marek Vasut wrote: >> > Dear Joakim Tjernlund, >> > >> >> Marek Vasut wrote on 2012/04/01 16:01:56: >

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi All > > Here we go again ;) Yay (polishing my flamethrower)! > On Mon, Apr 2, 2012 at 12:21 AM, Marek Vasut wrote: > > Dear Joakim Tjernlund, > > > >> Marek Vasut wrote on 2012/04/01 16:01:56: > >> > Dear Joakim Tjernlund, > >> > > >> > > > Dear Mike Frysinger, > >> >

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Graeme Russ
Hi All Here we go again ;) On Mon, Apr 2, 2012 at 12:21 AM, Marek Vasut wrote: > Dear Joakim Tjernlund, > >> Marek Vasut wrote on 2012/04/01 16:01:56: >> > Dear Joakim Tjernlund, >> > >> > > > Dear Mike Frysinger, >> > > > >> > > > > On Thursday, October 21, 2010 17:10:31 Graeme Russ wrote: >>

[U-Boot] Marvell/Kirkwood: 6192 vs. 6281 - does U-Boot correctly distinguish between the two?

2012-04-01 Thread David Purdy
I've found either a bug, a "feature" or a misunderstanding of my own. I've researched it before posting as much as I could, but since there are __no__ 6192 Kirkwoods in mainline (AFAICS), there isn't much to compare to... _Marvell's_ U-Boot running on a Pogoplug V4, with its 6192_A1 ... shows t

[U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-01 Thread David Purdy
Problem w/ SATA/IDE on Kirkwood 88F6281 board: I've got U-Boot 2011.12 working well on a 8192 Kirkwood board, _except_ for a nagging SATA problem. Currently, it loads and executes U-Boot fine, it boots fine from a USB drive, but I'm unable to get the SATA port to function correctly. Any insight f

Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-01 Thread Marek Vasut
Dear Gachet Daniel, > Hi Stefano and Marek, > > -Original Message- > From: stefano babic [mailto:sba...@denx.de] > Sent: dimanche 1 avril 2012 12:33 > To: Gachet Daniel > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO > TX25 modules >

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Marek Vasut
Dear Mike Frysinger, > On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > > If the range passed to flush_cache is not multiple > > of ARCH_DMA_MINALIGN, a warning due to mislaignment > > is printed. > > Detected with fec_mxc, mx35 boards: > > > > CACHE: Misaligned operation at range [808

Re: [U-Boot] [PATCH 2/5] net: add helper to generate random mac address

2012-04-01 Thread Michael Walle
Hi Mike, Am Sonntag 01 April 2012, 21:34:26 schrieb Mike Frysinger: > On Saturday 31 March 2012 08:38:33 Michael Walle wrote: > > --- a/include/net.h > > +++ b/include/net.h > > > > in emergency cases, where you need a working network connection to seti > > "seti" -> "set" > > > + *Eg. you

Re: [U-Boot] [PATCH v3 3/4] sandbox: Use the new run_command()

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 03:30:57 Simon Glass wrote: > Now that run_command() handles both parsers, clean up sandbox to use it. > This fixes a build error. Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___

Re: [U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 03:30:58 Simon Glass wrote: > --- /dev/null > +++ b/test/Makefile > > +include $(TOPDIR)/config.mk > + > +LIB = $(obj)libtest.o > + > +COBJS-$(CONFIG_SANDBOX) += command_ut.o > + > +COBJS:= $(sort $(COBJS-y)) that sort actually needed ? > +SRCS := $(COBJS:.o=.c)

Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 03:30:55 Simon Glass wrote: > --- a/common/cmd_pxe.c > +++ b/common/cmd_pxe.c > > + return run_command_list(localcmd, strlen(localcmd), 0); should be -1 instead of strlen() > +int run_command_list(const char *cmd, int len, int flag) > +{ > + int need_buff = 1; >

Re: [U-Boot] [PATCH 2/5] net: add helper to generate random mac address

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 08:38:33 Michael Walle wrote: > --- a/include/net.h > +++ b/include/net.h > > in emergency cases, where you need a working network connection to seti "seti" -> "set" > + *Eg. you wan't a rescue boot and don't have a serial port to access "wan't" -> "want" > +void

Re: [U-Boot] [STATUS] v2012.04-rc1 is out

2012-04-01 Thread Mike Frysinger
On Friday 30 March 2012 19:40:49 Wolfgang Denk wrote: > Please help testing, so we can fix the remaining issues before the > release, which I decided to shift to April 21, 2012. we need Marek's recent patch as quite a number of boards are broken w/out: http://patchwork.ozlabs.org/patch/149

Re: [U-Boot] [PATCH] LMB: Fix undefined lmb_reserve() on non-lmb platforms

2012-04-01 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Mike Frysinger
On Sunday 01 April 2012 09:22:59 Stefano Babic wrote: > If the range passed to flush_cache is not multiple > of ARCH_DMA_MINALIGN, a warning due to mislaignment > is printed. > Detected with fec_mxc, mx35 boards: > > CACHE: Misaligned operation at range [8080, 8083c310] warning on flushing is

Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-01 Thread Gachet Daniel
Hi Stefano and Marek, -Original Message- From: stefano babic [mailto:sba...@denx.de] Sent: dimanche 1 avril 2012 12:33 To: Gachet Daniel Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules >Am 31/03/2012 09:31, schrieb Gachet D

Re: [U-Boot] [PATCH] mx6qsabrelite: Fix the serial console port

2012-04-01 Thread Stefano Babic
On 01/04/2012 18:27, Marek Vasut wrote: > Dear Stefano Babic, > >> On 28/03/2012 21:45, Fabio Estevam wrote: >>> On mx6qsabrelite the console is ttymxc1. >>> >>> Signed-off-by: Fabio Estevam >>> --- >> >> Applied to u-boot-imx after fixing the checkpatch warning: > > Stefano, do you run this che

Re: [U-Boot] [PATCH] mx6qsabrelite: Fix the serial console port

2012-04-01 Thread Marek Vasut
Dear Stefano Babic, > On 28/03/2012 21:45, Fabio Estevam wrote: > > On mx6qsabrelite the console is ttymxc1. > > > > Signed-off-by: Fabio Estevam > > --- > > Applied to u-boot-imx after fixing the checkpatch warning: Stefano, do you run this checkpatch stuff by hand on every file or do you hav

Re: [U-Boot] [PATCH][resubmit] eb_cpux9k2: add USB host support to board

2012-04-01 Thread Marek Vasut
Dear Jens Scharsig, > * add USB host support to eb_cpux9k2 board Did you test this too? CCing Albert, Albert do you want me to push this through staging or you'll pick this? > Signed-off-by: Jens Scharsig > --- > include/configs/eb_cpux9k2.h | 14 ++ > 1 files changed, 14 inser

[U-Boot] [PATCH][resubmit] eb_cpux9k2: add USB host support to board

2012-04-01 Thread Jens Scharsig
* add USB host support to eb_cpux9k2 board Signed-off-by: Jens Scharsig --- include/configs/eb_cpux9k2.h | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h index 9046cf0..eb05e2a 100644 --- a/include/

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Marek Vasut
Dear Stefano Babic, > On 01/04/2012 15:46, Marek Vasut wrote: > > Dear Stefano Babic, > > Hi Marek, > > >> If the range passed to flush_cache is not multiple > >> of ARCH_DMA_MINALIGN, a warning due to mislaignment > >> is printed. > >> Detected with fec_mxc, mx35 boards: > >> > >> CACHE: Misal

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Stefano Babic
On 01/04/2012 15:46, Marek Vasut wrote: > Dear Stefano Babic, Hi Marek, > >> If the range passed to flush_cache is not multiple >> of ARCH_DMA_MINALIGN, a warning due to mislaignment >> is printed. >> Detected with fec_mxc, mx35 boards: >> >> CACHE: Misaligned operation at range [8080, 8083c

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Joakim Tjernlund, > Marek Vasut wrote on 2012/04/01 16:01:56: > > Dear Joakim Tjernlund, > > > > > > Dear Mike Frysinger, > > > > > > > > > On Thursday, October 21, 2010 17:10:31 Graeme Russ wrote: > > > > > > On 22/10/10 06:51, Mike Frysinger wrote: > > > > > > > have u-boot return an err

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Joakim Tjernlund
Marek Vasut wrote on 2012/04/01 16:01:56: > > Dear Joakim Tjernlund, > > > > Dear Mike Frysinger, > > > > > > > On Thursday, October 21, 2010 17:10:31 Graeme Russ wrote: > > > > > On 22/10/10 06:51, Mike Frysinger wrote: > > > > > > have u-boot return an error. > > > > > > > > > > Is NULL what you

Re: [U-Boot] [PATCH] LMB: Fix undefined lmb_reserve() on non-lmb platforms

2012-04-01 Thread Marek Vasut
Dear Marek Vasut, > Signed-off-by: Marek Vasut > Cc: Wolfgang Denk > Cc: Mike Frysinger > Cc: Stephen Warren > Cc: Tom Warren > Cc: Graeme Russ > --- > common/cmd_bootm.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c >

Re: [U-Boot] [PATCH V6] BOOT: Add "bootz" command to boot Linux zImage on ARM

2012-04-01 Thread Marek Vasut
Dear Graeme Russ, > Hi Marek, > > On 04/01/2012 05:27 AM, Marek Vasut wrote: > > Dear Mike Frysinger, > > > >> On Thursday 15 March 2012 03:52:45 Marek Vasut wrote: > >>> --- a/common/cmd_bootm.c > >>> +++ b/common/cmd_bootm.c > >>> > >>> -static void bootm_start_lmb(void) > >>> -{ > >>> > >>>

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Marek Vasut
Dear Joakim Tjernlund, > > Dear Mike Frysinger, > > > > > On Thursday, October 21, 2010 17:10:31 Graeme Russ wrote: > > > > On 22/10/10 06:51, Mike Frysinger wrote: > > > > > have u-boot return an error. > > > > > > > > Is NULL what you consider to be an error > > > > > > yes > > > > > > > Bes

[U-Boot] [PATCH] LMB: Fix undefined lmb_reserve() on non-lmb platforms

2012-04-01 Thread Marek Vasut
Signed-off-by: Marek Vasut Cc: Wolfgang Denk Cc: Mike Frysinger Cc: Stephen Warren Cc: Tom Warren Cc: Graeme Russ --- common/cmd_bootm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c index 9ad2535..5685232 100644 --- a/common

Re: [U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Marek Vasut
Dear Stefano Babic, > If the range passed to flush_cache is not multiple > of ARCH_DMA_MINALIGN, a warning due to mislaignment > is printed. > Detected with fec_mxc, mx35 boards: > > CACHE: Misaligned operation at range [8080, 8083c310] > > Signed-off-by: Stefano Babic > CC: Marek Vasut >

Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-01 Thread Marek Vasut
Dear Gachet Daniel, > Dear Marek, > > >Dear Gachet Daniel, > > > >> This short patch correct corrupted data while reading NAND flash > >> modules on the KARO TX25 module. > >> > >> The current version of the mxc_nand driver uses the symmetric mode to > >> access the NAND flash, but the devices p

Re: [U-Boot] [STATUS] v2012.04-rc1 is out

2012-04-01 Thread Marek Vasut
Dear Jens Scharsig, > Dear Marek, > > >> > The eb_cpux9k2 board (maintained by myself) works basically with > >> > 2012.04-rc1. But for full functionality, please apply patch: > >> > > >> > http://patchwork.ozlabs.org/patch/104279/ > > > > Next time Cc me with USB related stuff please. Btw. it'

Re: [U-Boot] [PATCH] mx6qsabrelite: Add boot switch setting information into the README

2012-04-01 Thread Stefano Babic
On 29/03/2012 14:22, Fabio Estevam wrote: > Add boot switch setting information into the README > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx (fix), thanks. Best regards, Stefano Babic -- = DENX Software Engine

Re: [U-Boot] [PATCH] mx6qsabrelite: Fix the serial console port

2012-04-01 Thread Stefano Babic
On 28/03/2012 21:45, Fabio Estevam wrote: > On mx6qsabrelite the console is ttymxc1. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx after fixing the checkpatch warning: WARNING: please, no spaces at the start of a line #30: FILE: include/configs/mx6qsabrelite.h:119: + "conso

Re: [U-Boot] [PATCH V2 2/3] i.MX6: implement enable_caches()

2012-04-01 Thread Stefano Babic
On 19/03/2012 16:39, Stefano Babic wrote: > On 13/03/2012 02:11, Eric Nelson wrote: >> On 03/04/2012 02:47 PM, Eric Nelson wrote: >>> disabled by default until drivers are fixed >>> >>> Signed-off-by: Eric Nelson >>> Acked-by: Marek Vasut >>> --- >>> arch/arm/cpu/armv7/mx6/soc.c|8 +++

Re: [U-Boot] [PATCH V2 1/3] i.MX6: define CACHELINE_SIZE

2012-04-01 Thread Stefano Babic
On 13/03/2012 02:08, Eric Nelson wrote: > On 03/04/2012 02:47 PM, Eric Nelson wrote: >> Signed-off-by: Eric Nelson >> Acked-by: Marek Vasut >> >> --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Softwar

[U-Boot] [PATCH 3/4] mx35: flea3: fix when cache functions are linked

2012-04-01 Thread Stefano Babic
Signed-off-by: Stefano Babic --- include/configs/flea3.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/flea3.h b/include/configs/flea3.h index 649e272..f046a58 100644 --- a/include/configs/flea3.h +++ b/include/configs/flea3.h @@ -34,6 +34,7 @@ #define

[U-Boot] [PATCH 4/4] mx35: mx35pdk: fix when cache functions are linked

2012-04-01 Thread Stefano Babic
Signed-off-by: Stefano Babic --- include/configs/mx35pdk.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h index 0c62b9f..1e03639 100644 --- a/include/configs/mx35pdk.h +++ b/include/configs/mx35pdk.h @@ -38,6 +38,7 @

[U-Boot] [PATCH 2/4] net: round up before calling flush_cache

2012-04-01 Thread Stefano Babic
If the range passed to flush_cache is not multiple of ARCH_DMA_MINALIGN, a warning due to mislaignment is printed. Detected with fec_mxc, mx35 boards: CACHE: Misaligned operation at range [8080, 8083c310] Signed-off-by: Stefano Babic CC: Marek Vasut CC: Joe Hershberger Cc: Wolfgang Denk -

[U-Boot] [PATCH 1/4] ARM1136: add cache flush and invalidate operations

2012-04-01 Thread Stefano Babic
From: Anatolij Gustschin Since commit 5c1ad3e6f8ae578bbe30e09652f1531e9bc22031 (net: fec_mxc: allow use with cache enabled) the FEC_MXC driver uses flush_dcache_range() and invalidate_dcache_range() functions. This driver is also configured for ARM1136 based 'flea3' and 'mx35pdk' boards which cur

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-01 Thread Joakim Tjernlund
> > Dear Mike Frysinger, > > > On Thursday, October 21, 2010 17:10:31 Graeme Russ wrote: > > > On 22/10/10 06:51, Mike Frysinger wrote: > > > > have u-boot return an error. > > > > > > Is NULL what you consider to be an error > > > > yes > > > > > Besides, is not free(NULL) valid (does nothing) as

Re: [U-Boot] [STATUS] v2012.04-rc1 is out

2012-04-01 Thread Graeme Russ
Hi Wolfgang, On 03/31/2012 10:40 AM, Wolfgang Denk wrote: > Hi everybody, > > after long struggeling we finally have a -rc1. > > Please help testing, so we can fix the remaining issues before the > release, which I decided to shift to April 21, 2012. I just sent a pull request for an outstandin

[U-Boot] Pull request: u-boot-x86/master

2012-04-01 Thread Graeme Russ
Hi Wolfgang, The following changes since commit c008b6f6dd6b8965e9a7654ffbce75bb9ff7a3b5: Prepare v2012.04-rc1 (2012-03-31 00:13:05 +0200) are available in the git repository at: git://git.denx.de/u-boot-x86.git master Simon Glass (1): x86: Remove dead code in eNET board/eNET/eNET.c

  1   2   >