Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-16 Thread Gonglei (Arei)
XEN) stdvga.c:596:d1 >>> vga mmio count_2=8415000 ... ... //Omit some similar (XEN) stdvga.c:596:d1 >>> vga mmio count_2=1257 (XEN) stdvga.c:596:d1 >>> vga mmio count_2=12575000 (XEN) stdvga.c:596:d1 >>> vga mmio count_2=1258 (XEN) stdvga.c:596:d1

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-17 Thread Gonglei (Arei)
guest screen updating is fast with upstream qemu. And I test the latest vgabios-0.7a come from http://www.nongnu.org/vgabios/#DOWNLOAD but the problem of blank screen remain. Best Regards! -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Friday, August 16, 2013 5

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 10:26 PM > To: Paolo Bonzini > Cc: Gonglei (Arei); qemu-devel@nongnu.org; Huangweidong (C); > kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_re

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Wednesday, September 17, 2014 12:16 AM > To: Gerd Hoffmann > Cc: Gonglei (Arei); Huangweidong (C); qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report > > Gerd Hof

Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 11:12 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; kw...@redhat.com; Huangweidong (C); > lcapitul...@redhat.com; stefa...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] hmp:

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 16, 2014 10:37 PM > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > Il 16/09/2014 16:32, Markus Armbruster ha scritto: > > Paolo Bonzini writes: > > > >> Il 16/09/2014 11:16, Markus Ar

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-17 Thread Gonglei (Arei)
> > >> > > >> Doesn't this leak prop_list when local_err && prop_list? > > >> > > > No, it will not happen this situation. > > > > > >> Returning both a value in need of destruction and an error object is at > > >> least highly unusual, and probably plain wrong. > > >> > > >> Should qmp_device_list

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-17 Thread Gonglei (Arei)
> but switching all usb over to realize is a bigger project indeed. > Hi, Gerd I want to do this job which converting USB devices from init to realize. So all the implementations can use error_setg instead of error_report for reporting error. Include those devices as below: name "usb-host", bu

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, September 18, 2014 3:38 PM > Subject: Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and > missing error message > > writes: > > > From: Gonglei > > > > When scsi_bus_legacy_add_drive() return NULL, meanwhile

Re: [Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-18 Thread Gonglei (Arei)
> >> > --- > >> > hw/usb/dev-storage.c | 11 ++- > >> > 1 file changed, 6 insertions(+), 5 deletions(-) > >> > > >> > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > >> > index 5c51ac0..cabd053 100644 > >> > --- a/hw/usb/dev-storage.c > >> > +++ b/hw/usb/dev-storage.c > >> > @@

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:08 PM > Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > @@ -460,7 +460,7 @@ static void usb_serial_event(void *opaqu

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:09 PM > Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > static void usb_msd_password_cb(void *opaque, int err) > >

Re: [Qemu-devel] [PATCH 14/19] dev-hid: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 6:16 PM > Subject: Re: [PATCH 14/19] dev-hid: convert init to realize > > Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > In this way, all the implementations now use > > err

Re: [Qemu-devel] [PATCH v2] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, September 18, 2014 7:09 PM > Subject: Re: [Qemu-devel] [PATCH v2] pci-hotplug-old: avoid lossing error > message > > writes: > > > From: Gonglei > > > > When scsi_bus_legacy_add_drive() produce error, > > we will loss error

Re: [Qemu-devel] [PATCH] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, September 18, 2014 8:22 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); arm...@redhat.com; m...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] pci-hotplug-

Re: [Qemu-devel] [PATCH v3] pci-hotplug-old: avoid lossing error message

2014-09-18 Thread Gonglei (Arei)
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, September 18, 2014 9:01 PM > Subject: Re: [PATCH v3] pci-hotplug-old: avoid lossing error message > > On 09/18/2014 06:58 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > s/lossing/losing/ in the subject (still) > > > > > W

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 8:59 PM > Subject: Re: [PATCH v2 12/19] dev-serial: convert init to realize > > Il 18/09/2014 14:47, arei.gong...@huawei.com ha scritto: > > if (s->cs->be_open && !dev->attached) { > > -usb_device_

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, September 18, 2014 9:31 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Huangpeng > (Peter); Luonengjun > Subject: Re: [PATCH v2 12/19] dev-seria

Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to realize

2014-09-18 Thread Gonglei (Arei)
> >>> Can we use qerror_report_err still in realize function? > >>> Just report this error but not propagate to the caller. Thanks! > >> > >> No, I think propagating the error is fine. In fact I suggested checking > >> for the error more aggressively, so that it can better propagate to the > >> ca

Re: [Qemu-devel] [question] virtio-net-device and multi-queue option

2014-09-18 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [question] virtio-net-device and multi-queue option > > Hi, > > > I am currently doing some benchmarks using virtio-net-device using > virtio-mmio (non PCI) with qemu_system_arm with KVM. Purpose is to > compare with device passthrough performance. > > I heard about the

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 19, 2014 2:42 AM > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > Il 18/09/2014 19:15, Markus Armbruster ha scritto: > > > > Thanks for doing this work. If you can

Re: [Qemu-devel] [question] virtio-net-device and multi-queue option

2014-09-18 Thread Gonglei (Arei)
> From: Eric Auger [mailto:eric.au...@linaro.org] > Sent: Friday, September 19, 2014 10:23 AM > To: Gonglei (Arei); qemu list; Michael S. Tsirkin > Subject: Re: [Qemu-devel] [question] virtio-net-device and multi-queue option > > On 09/19/2014 03:42 AM, Gonglei (Arei) wrote: &

Re: [Qemu-devel] [PATCH v2 15/19] dev-wacom: convert init to realize

2014-09-18 Thread Gonglei (Arei)
Hi, > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:02 PM > Subject: Re: [PATCH v2 15/19] dev-wacom: convert init to realize > > > > static const VMStateDescription vmstate_usb_wacom = { > > @@ -357,7 +356,7 @@ static void usb_wacom_class_init(ObjectClass *

Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize

2014-09-18 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 19, 2014 2:06 PM > To: Gonglei (Arei) > Subject: Re: [PATCH v2 00/19] usb: convert device init to realize > > On Do, 2014-09-18 at 20:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei >

Re: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and listen() failure

2014-09-19 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] qemu-socket: Polish errors for connect() and > listen() failure > > connect() doesn't "connect to socket", it connects a socket to an > address and, if it's of type SOCK_STREAM, initiates a connection. > Scratch "to". > > listen() does "set socket to listening mode

Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time

2014-09-19 Thread Gonglei (Arei)
> Il 19/09/2014 09:25, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > This patch series based on > > [PATCH v3 00/19] usb: convert device init to realize > > > > As Paolo's comments: > > > > usb port speed check could be extracted to a separate > > function usb_check_attach, that i

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-19 Thread Gonglei (Arei)
. What's your opinion? Thanks a lot! Does this patch series can be merged firstly? Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, September 09, 2014 2:35 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com;

Re: [Qemu-devel] [PATCH] qom: suppress conscan warning of returning null point

2014-09-19 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] qom: suppress conscan warning of returning null > point > > Conscan complains about g_malloc0() and malloc() return null. > > Error: NULL_RETURNS (CWE-476): > qemu-kvm/qom/object.c:239: returned_null: Function "g_malloc0(gsize)" > returns null. > qemu-kvm/qom

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names > > It is easy to typo a blkdebug configuration and waste a lot of time > figuring out why no rules are matching. > > Push the Error** down into add_rule() so we can report an error when the > event name is invalid. >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
Hi, Paolo > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, September 17, 2014 10:32 AM > To: 'Paolo Bonzini'; Markus Armbruster > Cc: Huangweidong (C); aligu...@amazon.com; Michael S. Tsirkin; > ag...@suse.de; qemu-devel@nongnu.org; stefa...@re

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 22, 2014 4:34 PM > Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > At present, people have no way

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 5:15 PM > To: Michael S. Tsirkin; Gonglei (Arei) > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng > (Peter); qemu-devel@nongnu.org; s

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-22 Thread Gonglei (Arei)
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, September 22, 2014 6:28 PM > Subject: Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event > names > > On Sat, Sep 20, 2014 at 09:32:35AM +0000, Gonglei (Arei) wrote: > > > @@ -3

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 6:04 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: Huangweidong (C); aligu...@amazon.com; qemu-devel@nongnu.org; > ag...@suse.de; stefa...@redhat.com

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, September 22, 2014 8:07 PM > To: Gonglei (Arei); Michael S. Tsirkin > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng >

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > Bonzini > > Sent: Monday, September 22, 2014 8:07 PM > > To: Gonglei (Arei); Michael S. Tsirkin > > Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng > > (

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 22/09/2014 15:13, Gonglei (Arei) ha scritto: > > (I don't add alias-sepecific filed into ObjectProperty > > struct, just add a bool property. ) > > > > diff --git a/include/qom/obj

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 22/09/2014 15:36, Gonglei (Arei) ha scritto: > >> If the field is called "opaque", it's opaque. > > > > Sorry? > > The field is called "opaque" because no one,

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-22 Thread Gonglei (Arei)
Hi, > This doesn't change the fact that ObjectProperty is a generic struct, > and adding alias-specific fields there is wrong. > >>> > >>> OK, Maybe I should find other ways to attach this purpose and > >>> avoid layering violation. Thanks! > >> > >> Unfortunately I cannot think of any.

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-22 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security > > On 09/22/2014 09:25 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > The PATCH 2 is splited from another patch series, which has been > > s/splited/split/ > > 'split' is one of those stupid English word

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-23 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 23, 2014 5:06 PM > To: Gonglei (Arei) > Cc: Paolo Bonzini; Michael S. Tsirkin; ag...@suse.de; Huangweidong (C); > stefa...@redhat.com; Huangpeng (Peter); qem

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > Il 23/09/2014 05:09, Gonglei (Arei) ha scritto: > > Hi, > > > >>>>>> This doesn't change the fact that ObjectProperty is a generic struct, > >>>>>> and addi

Re: [Qemu-devel] [PATCH v3 00/19] usb: convert device init to realize

2014-09-23 Thread Gonglei (Arei)
Hi, Gred Would you like to pick up this patch series? Thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Friday, September 19, 2014 2:48 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; > p

Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at realize time

2014-09-23 Thread Gonglei (Arei)
And this one :) Thanks! Best regards, -Gonglei > -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 19, 2014 4:08 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luo

Re: [Qemu-devel] [PATCH v3 00/19] usb: convert device init to realize

2014-09-23 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, September 23, 2014 7:02 PM > Subject: Re: [PATCH v3 00/19] usb: convert device init to realize > > On Di, 2014-09-23 at 10:58 +, Gonglei (Arei) wrote: > > Hi, Gred > > > > Would you like to

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-23 Thread Gonglei (Arei)
> > > > The PATCH 2 is splited from another patch series, which has been > > reviewed by Paolo. PATCH 1 can avoid possible leaking memory. > > > > Gonglei (2): > > qom: add error handler for object_property_print() > > qom: add error handler for object alias property > > > > qom/object.c | 21

Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security

2014-09-23 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 23, 2014 9:23 PM > Subject: Re: [PATCH 0/2] qom: add error handler for security > > Il 23/09/2014 15:21, Gonglei (Arei) ha scritto: > > Thanks, Paolo. I merged those two patches in my next patch s

Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for object_property_print()

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 1/2] qom: add error handler for > object_property_print() > > Hi, > > Am 23.09.2014 um 05:25 schrieb arei.gong...@huawei.com: > > From: Gonglei > > > > Avoid the caller of object_property_print() leaking string > > argument's memory, such as qdev_print_props()

Re: [Qemu-devel] [PATCH 4/7] qom: add description field in ObjectProperty struct

2014-09-23 Thread Gonglei (Arei)
> Subject: [PATCH 4/7] qom: add description field in ObjectProperty struct > > From: Gonglei > > The descriptions can serve as documentation in the code, > and they can be used to provide better help. > > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Markus Armbruster > Signed-off-by: Gon

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-23 Thread Gonglei (Arei)
> Subject: Re: [PATCH 5/7] qdev: set the object property's description to the > qdev > property's. > > Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > When we call qdev_alias_all_properties() adding alias properties to > > the source object all qdev properties

Re: [Qemu-devel] [PATCH 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-23 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 24, 2014 1:04 AM > Subject: Re: [PATCH 0/7] add description field in ObjectProperty and > PropertyInfo struct > > Il 23/09/2014 15:08, arei.gong...@huawei.com ha scritto: > > From: Gong

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-24 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 24, 2014 2:54 PM > Subject: Re: [PATCH 5/7] qdev: set the object property's description to the > qdev > property's. > > Il 24/09/2014 02:42,

Re: [Qemu-devel] [PATCH 5/7] qdev: set the object property's description to the qdev property's.

2014-09-24 Thread Gonglei (Arei)
Hi, > > > > Il 24/09/2014 02:42, Gonglei (Arei) ha scritto: > > > OK. > > > > > > This way I have to add a description string parametet to > > > object_property_add_alias function. Will do in the next version. :) > > > > No, just take it

Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 1/4] os-posix/win32: convert fprintf/perror > to > error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > os-posix.c | 34 ++ > > os-win32.c | 3 ++-

Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 3/4] osdep: convert fprintf to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/osdep.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --gi

Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report

2014-09-25 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert > fprintf/perror > to error_report > > On 09/25/2014 03:46 AM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > util/oslib-posix.c | 8 > > util/oslib-win32.c | 2 +- > > 2 fi

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-25 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > v2: rebase > > Signed-off-by: Jan Vesely > --- > hw/usb/dev-hid.c | 38 ++ > 1 file changed, 18 insertions(+), 20 deletions(-) > > diff --git a/hw/usb/dev-hid.c

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-26 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 26, 2014 2:53 PM > To: Gonglei (Arei) > Cc: Jan Vesely; QEMU > Subject: Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to > usb-hid initfn > > Hi, > > > > -stati

Re: [Qemu-devel] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Subject: Re: [PATCH 0/3] os-posix: improve the error message printing > > Il 26/09/2014 10:14, arei.gong...@huawei.com ha scritto: > > From: Gonglei > > > > The patches mainly improve the error message printing. > > And adjust coding style of o

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-26 Thread Gonglei (Arei)
Hi, > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with string or pointer properties since we > > must be careful about leaking or double-freeing them. > > > > Use the QOM alias property to forward property

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-27 Thread Gonglei (Arei)
> > > virtio-net: use aliases instead of duplicate qdev properties > > > virtio: fix virtio-net child refcount in transports > > > virtio/vhost scsi: use aliases instead of duplicate qdev properties > > > virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in > > > transports >

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-28 Thread Gonglei (Arei)
Hi, Michael Would you like to pick up this patch, which had been reviewed by Markus and Eric? Thanks. :) Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 18, 2014 9:06 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com;

Re: [Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] ssh: Don't crash if either host or path is not > specified. > > $ ./qemu-img create -f qcow2 overlay \ > -b 'json: { "file.driver":"ssh", > "file.host":"localhost", > "file.host_key_check":"no" }' > qemu-img: qobject/qdict.c:193:

Re: [Qemu-devel] [PATCH v2] ssh: Don't crash if either host or path is not specified.

2014-09-29 Thread Gonglei (Arei)
> -Original Message- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Monday, September 29, 2014 4:06 PM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) > Subject: [PATCH v2] ssh: Don't crash if either host or path is not specified. > > $ ./qem

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-29 Thread Gonglei (Arei)
Hi, Michael Would you give me some response? I have pinged this patch series the third time. :( Thanks a lot! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 01, 2014 9:29 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.co

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, September 29, 2014 6:53 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > On Sat, 27 Sep 2014 10:37:23 +0000 > "Gonglei (Arei)" wrote: > > > > &

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, September 29, 2014 7:33 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > On Fri, 26 Sep 2014 16:45:38 +0800 > wrote: > > > Gonglei (9): > > virtio-net: use aliases instead of duplicat

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Monday, September 29, 2014 8:32 PM > Subject: Re: [PATCH RESEND 0/9] virtio: fix virtio child recount in transports > > Il 29/09/2014 12:53, Cornelia Huck ha scritto: > > void virtio_instance_init_common(Object *proxydev, > >

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> > > > > > > > Hm... > > > > > > > > void virtio_instance_init_common(Object *proxydev, > > > > DeviceState *vdev, > > > > size_t vdevsize, > > > > const char *vdevname) > > > > { > > > > object_

Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v3 0/7] add description field in > ObjectProperty and PropertyInfo struct > > Hi, > > Am 27.09.2014 um 07:13 schrieb arei.gong...@huawei.com: > > Gonglei (7): > > qom: add error handler for object_property_print() > > qom: add error handler for object alias

Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

2014-09-29 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v3 4/7] qom: add description field in ObjectProperty > struct > > Il 27/09/2014 07:13, arei.gong...@huawei.com ha scritto: > > +void object_property_set_description(Object *obj, const char *name, > > + const char *description, Error >

Re: [Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties

2014-09-29 Thread Gonglei (Arei)
> > On 09/26/2014 11:14 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Add a new "description" field to DevicePropertyInfo. > > The descriptions can serve as documentation in the code, > > and they can be used to provide better help. For example: > > > > $./qemu-system-x86_64 -devic

Re: [Qemu-devel] [PATCH v3 2/3] pcie: add check for ari capability of pcie devices

2014-09-29 Thread Gonglei (Arei)
> > > > In QEMU, ARI Forwarding is enabled defualt at emulation of PCIe > > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > > If the bit is Set when a non-ARI Device is present, the non-ARI > > Device can respond to Configuration Space accesses under what it > > interprets as

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-30 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v3 0/3] add check for PCIe root ports and downstream > ports > > On Mon, Sep 01, 2014 at 09:29:16PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Root ports and downstream ports of switches are the hot > > pluggable ports in a PCI Express hierarchy. >

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v4] pci-hotplug-old: avoid losing error message > > Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto: > > we will lose the error message. Using error_report > > to report it. > > > > Cc: Markus Armbruster > > Signed-off-by: Gonglei > > Reviewed-by: Markus Armbru

Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 00/12] virtio: fix virtio child recount in transports > > On Tue, 30 Sep 2014 14:10:26 +0800 > wrote: > > > From: Gonglei > > > > virtio-$device-{pci, s390, ccw} all duplicate the > > qdev properties of their virtio child. This approach does > > not work well with strin

Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error > message > > Il 30/09/2014 10:12, Markus Armbruster ha scritto: > > error_report() is just fine here. qerror_report() is never necessary in > > HMP-only code. It makes a difference only in QMP context, and even > > there

Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend > initialization > > Il 30/09/2014 11:04, Cornelia Huck ha scritto: > > On Tue, 30 Sep 2014 14:10:38 +0800 > > wrote: > > > >> From: Gonglei > >> > >> For better code sharing, add a wrapper help funciton > > > > typo: s/fun

Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-30 Thread Gonglei (Arei)
> Subject: Re: [PATCH v2 12/12] virtio: add a wrapper for virtio-backend > initialization > > Il 30/09/2014 11:04, Cornelia Huck ha scritto: > >> > For better code sharing, add a wrapper help funciton > > typo: s/funciton/function/ > > > >> > for various virtio devices. > > s/for various virtio de

Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of pcie devices

2014-10-07 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v4 2/3] pcie: add check for ari capability of > pcie devices > > On Fri, 2014-10-03 at 13:22 +0200, Knut Omang wrote: > > On Wed, 2014-10-01 at 17:08 +0300, Marcel Apfelbaum wrote: > > > On Wed, 2014-10-01 at 07:26 +0200, Knut Omang wrote: > > > > On Tue, 2014-09

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-15 Thread Gonglei (Arei)
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Tuesday, April 16, 2013 1:44 AM > To: Gonglei (Arei) > Cc: linux-...@vger.kernel.org; Yanqiangjun; Hanweidong; Luonengjun; > kra...@redhat.com; hdego...@redhat.com; qemu-devel@nongnu

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-17 Thread Gonglei (Arei)
> > After our repeated verification and debug, we found that windows > > virtual machine USB disk format will send a 64Kbits's URB packet > > which was divided into four QTD (Size: 19968,16384,16384,12800): > > That's okay. > > > The first QTD offset is 32, split into five URB > > 4064/4096/4096

Re: [Qemu-devel] USB2.0 disk format failure in windows guest

2013-04-17 Thread Gonglei (Arei)
> > > Fixing this will require qemu to copy the beginning and ending parts of > > these non-aligned qTDs into separate bounce buffers so that the URB > > length can be divisible by 512. > > Worth trying: http://www.kraxel.org/cgit/qemu/log/?h=usb.80 > > It puts the qemu usb passthrough code ups

Re: [Qemu-devel] [PATCH v2 3/6] json-parser: Fix two coverity defects

2014-06-09 Thread Gonglei (Arei)
> -Original Message- > From: Luiz Capitulino [mailto:lcapitul...@redhat.com] > Sent: Tuesday, June 10, 2014 4:16 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; av1...@comtv.ru; kra...@redhat.com; > ler...@redhat.com; qiaonuo...@cn.fujitsu.com; afaer...@suse.de; &

Re: [Qemu-devel] [PATCH v2 2/6] vga: Fix divide-by-zero in vga_update_text

2014-06-10 Thread Gonglei (Arei)
Hi, Gerd What's your opinion about this patch? Thanks, Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, May 28, 2014 9:22 PM > To: qemu-devel@nongnu.org > Cc: av1...@comtv.ru; kra...@redhat.com; lcapitul...@redhat.com;

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

2014-06-10 Thread Gonglei (Arei)
> -Original Message- > From: Amit Shah [mailto:amit.s...@redhat.com] > Sent: Tuesday, June 10, 2014 3:20 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; yamah...@private.email.ne.jp; Huangweidong > (C); quint...@redhat.com; m...@tls.msk.ru; owass...@redhat.com; &g

Re: [Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-11 Thread Gonglei (Arei)
Hi, Gerd, do you plan to apply and pull the patch serials? Thanks! I have finished some qtest cases for usb host adapters hotpug/unplug. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, June 04, 2014 4:32 PM > To: qemu-devel@nongnu.o

Re: [Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-12 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 12, 2014 7:33 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Luonengjun; Huangweidong (C); Huangpeng > (Peter) > Subject: Re: [PATCH v3 00/10] usb: usb host adapter hot

Re: [Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text

2014-06-12 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 12, 2014 6:44 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; lcapitul...@redhat.com; > av1...@comtv.ru; stefa...@redhat.com; Luonengjun; Huangweidong

Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out()

2014-06-12 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 12, 2014 6:32 PM > To: Peter Maydell > Cc: Gonglei (Arei); QEMU Developers; Huangweidong (C); Luonengjun; Luiz > Capitulino; Vassili Karpov; Stefan Hajnoczi; Paolo Bonzini &g

Re: [Qemu-devel] [PATCH] audio: Fix using freed pointer in wav_fini_out

2014-06-13 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, June 13, 2014 4:18 PM > To: Gerd Hoffmann > Cc: Markus Armbruster; Gonglei (Arei); qemu-devel@nongnu.org; > Huangweidong (C); Luonengjun; stefa...@redhat.com > Subject: Re

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Amos Kong [mailto:ak...@redhat.com] > Sent: Thursday, June 19, 2014 11:58 AM > To: Stefan Hajnoczi > Cc: qemu-devel@nongnu.org; Gonglei (Arei); afaer...@suse.de; > pbonz...@redhat.com; kw...@redhat.com > Subject: Re: [PATCH v5 4/4] v

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 19, 2014 6:05 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun >

Re: [Qemu-devel] [PATCH 1/5] tests: add OHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Q

Re: [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:38 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Q

Re: [Qemu-devel] [PATCH 2/5] tests: add UHCI qtest

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:41 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Q

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 9:07 PM > To: Gerd Hoffmann > Cc: Gonglei (Arei); qemu-devel@nongnu.org; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun > Su

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
> -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 9:33 PM > To: Gonglei (Arei) > Cc: Gerd Hoffmann; qemu-devel@nongnu.org; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun > Su

Re: [Qemu-devel] [PATCH 0/5] tests: add usb host adapter qtest cases

2014-06-19 Thread Gonglei (Arei)
Good morning, Gerd & Andreas > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 19, 2014 9:47 PM > To: Andreas Färber > Cc: Gonglei (Arei); qemu-devel@nongnu.org; stefa...@redhat.com; > ebl...@redhat.com; ak...@redha

Re: [Qemu-devel] [PATCH] usb: initialize libusb_device to avoid crash

2014-06-20 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Jincheng Miao > Sent: Friday, June 20, 2014 2:13 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Jincheng Miao >

  1   2   3   4   5   6   7   8   9   10   >