> -----Original Message----- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:38 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 3/5] tests: add xHCI qtest > > Am 17.06.2014 10:04, schrieb arei.gong...@huawei.com: > > From: Gonglei <arei.gong...@huawei.com> > > > > add xhci controller hotplug/unplug qtest > > > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > --- > > tests/Makefile | 3 +++ > > tests/usb-hcd-xhci-test.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 45 insertions(+) > > create mode 100644 tests/usb-hcd-xhci-test.c > > > > diff --git a/tests/Makefile b/tests/Makefile > > index 54b8af2..f13d229 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -155,6 +155,8 @@ check-qtest-i386-y += > tests/usb-hcd-ohci-test$(EXESUF) > > gcov-files-i386-y += hw/usb/hcd-ohci.c > > check-qtest-i386-y += tests/usb-hcd-uhci-test$(EXESUF) > > gcov-files-i386-y += hw/usb/hcd-uhci.c > > +check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF) > > +gcov-files-i386-y += hw/usb/hcd-xhci.c > > check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF) > > gcov-files-i386-y += hw/usb/hcd-ehci.c > > gcov-files-i386-y += hw/usb/hcd-uhci.c > > @@ -327,6 +329,7 @@ tests/intel-hda-test$(EXESUF): tests/intel-hda-test.o > > tests/ioh3420-test$(EXESUF): tests/ioh3420-test.o > > tests/usb-hcd-ohci-test$(EXESUF): tests/usb-hcd-ohci-test.o > > tests/usb-hcd-uhci-test$(EXESUF): tests/usb-hcd-uhci-test.o > > +tests/usb-hcd-xhci-test$(EXESUF): tests/usb-hcd-xhci-test.o > > tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-test.o > $(libqos-pc-obj-y) > > tests/qemu-iotests/socket_scm_helper$(EXESUF): > tests/qemu-iotests/socket_scm_helper.o > > tests/test-qemu-opts$(EXESUF): tests/test-qemu-opts.o libqemuutil.a > libqemustub.a > > Nitpick: Maybe order xhci after ehci in both cases? Then we have 1.x / > 2.0 / 3.0 ordering. > Hah... agree.
> Same comments wrt QMP and -device testing apply. > OK. Thanks. > Cheers, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg Best regards, -Gonglei
