> -----Original Message----- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 19, 2014 6:05 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; stefa...@redhat.com; > ebl...@redhat.com; ak...@redhat.com; Huangweidong (C); Luonengjun > Subject: Re: [PATCH 0/5] tests: add usb host adapter qtest cases > > Hi, > > > Gonglei (5): > > tests: add OHCI qtest > > tests: add UHCI qtest > > tests: add xHCI qtest > > usb-hcd-ehci-test: change ehci qtest more expansively > > usb-hcd-ehci-test: add ehci hotplug/unplug qtest > > I'd prefer to leave the usb-hcd-ehci-test alone. Maybe rename to > "usb-hcd-ehci-companion-test" to make room for a new usb-hcd-ehci-test > for the standalone ehic test. > OK, good idea!
> I also suggest to hot-plug some usb device into the host adapter. Some > hid device is probably easiest. Then unplug host-adapter without > unplugging the usb device beforehand. > OK. I will do those in the next version, thanks for your review! > Also "make check" fails for me: > > GTESTER tests/test-vmstate > GTESTER tests/test-qemu-opts > GTESTER check-qtest-x86_64 > blkdebug: Suspended request 'A' > blkdebug: Resuming request 'A' > main-loop: WARNING: I/O thread spun for 1000 iterations > acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-GQ9SHX.dsl, > aml:/tmp/aml-GI9SHX], Expected [asl:/tmp/asl-FY4SHX.dsl, > aml:tests/acpi-test-data/pc/DSDT]. > acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-F4ITHX.dsl, > aml:/tmp/aml-6M9SHX], Expected [asl:/tmp/asl-H9LSHX.dsl, > aml:tests/acpi-test-data/pc/SSDT]. > main-loop: WARNING: I/O thread spun for 1000 iterations > acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-7NI2HX.dsl, > aml:/tmp/aml-4UG2HX], Expected [asl:/tmp/asl-LE71HX.dsl, > aml:tests/acpi-test-data/q35/DSDT]. > acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-40M2HX.dsl, > aml:/tmp/aml-YZG2HX], Expected [asl:/tmp/asl-LJL4HX.dsl, > aml:tests/acpi-test-data/q35/SSDT]. > [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. > Task offloads will be emulated. > ** > ERROR:/home/kraxel/projects/qemu/tests/libqtest.c:668:qmp_exec_hmp_cm > d: > assertion failed: (response_return) > GTester: last random seed: R02S88e3bbe1d1db1bc8f97f72f791c3610a > ** > ERROR:/home/kraxel/projects/qemu/tests/libqtest.c:668:qmp_exec_hmp_cm > d: > assertion failed: (response_return) > GTester: last random seed: R02S3e505ce96a4bf0db48dbe98e31037359 > ** > ERROR:/home/kraxel/projects/qemu/tests/libqtest.c:668:qmp_exec_hmp_cm > d: > assertion failed: (response_return) > GTester: last random seed: R02S09d78c5751122dc043d2c9e0896b9efa > ** > ERROR:/home/kraxel/projects/qemu/tests/libqtest.c:668:qmp_exec_hmp_cm > d: > assertion failed: (response_return) > GTester: last random seed: R02S61a33eb223796b0573353669f80c6431 > make: *** [check-qtest-x86_64] Error 1 > test failure > > cheers, > Gerd > Gerd, I haven't encounter this issue. Would you use "make check V=1" for more details, thanks. Best regards, -Gonglei