> -----Original Message----- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Thursday, June 19, 2014 8:41 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun; kra...@redhat.com; > stefa...@redhat.com; ak...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 2/5] tests: add UHCI qtest > > Am 17.06.2014 10:04, schrieb arei.gong...@huawei.com: > > From: Gonglei <arei.gong...@huawei.com> > > > > add uhci controller hotplug/unplug qtest > > > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > > --- > > tests/Makefile | 3 +++ > > tests/usb-hcd-uhci-test.c | 42 > ++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 45 insertions(+) > > create mode 100644 tests/usb-hcd-uhci-test.c > > > > diff --git a/tests/Makefile b/tests/Makefile > > index b1fbfb6..54b8af2 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -153,6 +153,8 @@ check-qtest-i386-y += tests/ioh3420-test$(EXESUF) > > gcov-files-i386-y += hw/pci-bridge/ioh3420.c > > check-qtest-i386-y += tests/usb-hcd-ohci-test$(EXESUF) > > gcov-files-i386-y += hw/usb/hcd-ohci.c > > +check-qtest-i386-y += tests/usb-hcd-uhci-test$(EXESUF) > > +gcov-files-i386-y += hw/usb/hcd-uhci.c > > check-qtest-i386-y += tests/usb-hcd-ehci-test$(EXESUF) > > gcov-files-i386-y += hw/usb/hcd-ehci.c > > > gcov-files-i386-y += hw/usb/hcd-uhci.c > > You can drop this duplicate line then. > OK, got it.
> Again, QMP and -device testing would be nice. > OK. > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg Best regards, -Gonglei
