> -----Original Message----- > From: Richard W.M. Jones [mailto:rjo...@redhat.com] > Sent: Monday, September 29, 2014 4:06 PM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) > Subject: [PATCH v2] ssh: Don't crash if either host or path is not specified. > > $ ./qemu-img create -f qcow2 overlay \ > -b 'json: { "file.driver":"ssh", > "file.host":"localhost", > "file.host_key_check":"no" }' > qemu-img: qobject/qdict.c:193: qdict_get_obj: Assertion `obj != ((void *)0)' > failed. > Aborted > > A similar crash also happens if the file.host field is omitted. > > https://bugzilla.redhat.com/show_bug.cgi?id=1147343 > > Bug found and reported by Jun Li. > > Signed-off-by: Richard W.M. Jones <rjo...@redhat.com> > --- > block/ssh.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Cc'ing Stefan and Kevin.
You can add the change log between v1 and v2. Anyway, looks good to me, so Reviewed-by: Gonglei <arei.gong...@huawei.com> Best regards, -Gonglei
