Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

2021-06-29 Thread Philippe Mathieu-Daudé
On 6/29/21 4:52 AM, Akihiko Odaki wrote: > Tested-by: Akihiko Odaki Thanks! Does this apply to this single patch or the whole series (since this patch depends on patch #1)? > 2021年6月29日(火) 1:09 Philippe Mathieu-Daudé : >> >> Avoid accessing QCryptoTLSCreds internals by using >> the qcrypto_tls_c

Re: [PATCH v7 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

2021-06-29 Thread Emanuele Giuseppe Esposito
On 28/06/2021 23:00, Eric Blake wrote: On Mon, Jun 28, 2021 at 02:31:48PM +0200, Emanuele Giuseppe Esposito wrote: Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 inserti

Re: [PATCH v7 00/16] qemu_iotests: improve debugging options

2021-06-29 Thread Emanuele Giuseppe Esposito
On 28/06/2021 18:48, John Snow wrote: On Mon, Jun 28, 2021 at 8:32 AM Emanuele Giuseppe Esposito mailto:eespo...@redhat.com>> wrote: This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests. It also allows to redirect QEMU binarie

Re: [PATCH] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-29 Thread Philippe Mathieu-Daudé
On 6/29/21 7:56 AM, Dov Murik wrote: > On 29/06/2021 1:03, Tom Lendacky wrote: >> On 6/22/21 7:58 AM, Dov Murik wrote: >>> +cc: Tom Lendacky >>> >>> On 22/06/2021 15:47, Philippe Mathieu-Daudé wrote: On 6/22/21 2:44 PM, Dov Murik wrote: > Suggested-by: Philippe Mathieu-Daudé > Signed-

[PATCH] scsi: fix bug scsi resp sense is 0 when expand disk

2021-06-29 Thread Jie Wang
A large number of I/Os are delivered during disk capacity expansion. Many I/Os are extracted from the Vring ring, and each one registers reqops_unit_attention when new scsi req. If the first registered req takes the ua, the ua is cleared and other registered req is return 0 sense. Let's add req_ha

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-29 Thread Vladimir Sementsov-Ogievskiy
28.06.2021 20:42, Eric Blake wrote: On Wed, Jun 23, 2021 at 06:04:19PM +0200, Kevin Wolf wrote: This is fine, but it means that this flag will present in all ranges, instead of only in unallocated ranges (what this patch is doing). An argument for always having the flag would be that it's prob

Re: [PATCH] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-29 Thread Dov Murik
On 29/06/2021 8:56, Dov Murik wrote: > > > On 29/06/2021 1:03, Tom Lendacky wrote: >> On 6/22/21 7:58 AM, Dov Murik wrote: >>> +cc: Tom Lendacky >>> >>> On 22/06/2021 15:47, Philippe Mathieu-Daudé wrote: On 6/22/21 2:44 PM, Dov Murik wrote: > Suggested-by: Philippe Mathieu-Daudé

Re: [PATCH 01/20] target/loongarch: Add README

2021-06-29 Thread Song Gao
Hi, Philippe, On 06/29/2021 02:40 AM, Philippe Mathieu-Daudé wrote: > On 6/28/21 2:04 PM, Song Gao wrote: >> This patch give an introduction to the LoongArch target. >> >> Signed-off-by: Song Gao >> --- >> MAINTAINERS | 5 + >> target/loongarch/README | 16 >> 2

Re: [PATCH 03/20] target/loongarch: Add core definition

2021-06-29 Thread Song Gao
Hi, Philippe, On 06/29/2021 02:44 AM, Philippe Mathieu-Daudé wrote: > On 6/28/21 2:04 PM, Song Gao wrote: >> This patch add target state header,target definitions >> and initialization routines. >> >> Signed-off-by: Song Gao >> --- >> target/loongarch/cpu-param.h | 21 ++ >> target/loongarch/cp

Re: [PATCH v3] Add basic power management to raspi.

2021-06-29 Thread Philippe Mathieu-Daudé
On 6/28/21 7:38 PM, Peter Maydell wrote: > On Sat, 26 Jun 2021 at 11:16, Philippe Mathieu-Daudé wrote: >> >> Hi Nolan, Peter, >> >> On 6/25/21 11:02 PM, Nolan Leake wrote: >>> diff --git hw/arm/bcm2835_peripherals.c hw/arm/bcm2835_peripherals.c >> >> Odd, usually the diff line comes with a/ b/ pre

Re: [PULL v2 00/28] Misc (including block file-posix) for 2021-06-23

2021-06-29 Thread Peter Maydell
On Fri, 25 Jun 2021 at 15:20, Paolo Bonzini wrote: > > The following changes since commit ecba223da6215d6f6ce2d343b70b2e9a19bfb90b: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210624' into staging (2021-06-24 > 15:00:34 +0100) > > are available in the Git reposi

Re: [PATCH 06/20] target/loongarch: Add main translation routines

2021-06-29 Thread Song Gao
Hi, Philippe, On 06/29/2021 02:46 AM, Philippe Mathieu-Daudé wrote: > On 6/28/21 2:04 PM, Song Gao wrote: >> This patch add main translation routines and >> basic functions for translation. >> >> Signed-off-by: Song Gao >> --- >> target/loongarch/helper.h| 10 + >> target/loongarch/op_helpe

Re: [PULL 0/4] Hexagon (target/hexagon) bug fixes

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:08, Taylor Simpson wrote: > > The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 > 09:54:42 +0100) > > are available in the git repo

Re: [PATCH v2] misc: Fix "havn't" typo

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 06:15, Philippe Mathieu-Daudé wrote: > > Fix "havn't (make)" -> "haven't (made)" typo. > > Reviewed-by: Luis Pires > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] hw/mips/jazz: Map the UART devices unconditionally

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 06:37, Philippe Mathieu-Daudé wrote: > > When using the Magnum ARC firmware we can see accesses to the > UART1 beeing rejected, because the device is not mapped: "being" > > $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW > Invalid access at add

Re: [PATCH 0/2] monitor: Shutdown fixes

2021-06-29 Thread Vladimir Sementsov-Ogievskiy
12.02.2021 20:20, Kevin Wolf wrote: This fixes the bug(s) that Markus reported here: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07719.html Kevin Wolf (2): monitor: Fix assertion failure on shutdown monitor/qmp: Stop processing requests when shutdown is requested monitor/mo

Re: [PATCH v3 4/9] target/nios2: Add DisasContextBase to DisasContext

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:14, Richard Henderson wrote: > > Migrate the is_jmp, tb and singlestep_enabled fields from > DisasContext into the base. Use pc_first instead of tb->pc. > Increment pc_next prior to decode, leaving the address of > the current insn in dc->pc. > > Signed-off-by: Richard H

Re: iothread_instance_finalize -> aio_ctx_finalize crash

2021-06-29 Thread Vladimir Sementsov-Ogievskiy
24.06.2021 15:59, Vladimir Sementsov-Ogievskiy wrote: Hi! Could someone help me with the following please? We have a crash in v5.2.0-based downstream branch. I don't have a realiable reproduce, neither can find significant differencies with upstream code in touched functions. #0  0x7fc2a

Re: [PATCH v3 5/9] target/nios2: Convert to TranslatorOps

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:14, Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 6/9] target/nios2: Remove assignment to env in handle_instruction

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:12, Richard Henderson wrote: > > Direct assignments to env during translation do not work. > > As it happens, the only way we can get here is if env->pc > is already set to dc->pc. We will trap on the first insn > we execute anywhere on the page. > > Signed-off-by: Richa

Re: [PATCH v3 7/9] target/nios2: Clean up goto in handle_instruction

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:12, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/nios2/translate.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/target/nios2/translate.c b/target/nios2/translate.c > index 6fd4330b31..9e71267b42 100644

Re: [PATCH v2 1/1] migration: Unregister yank if migration setup fails

2021-06-29 Thread Dr. David Alan Gilbert
* Leonardo Bras (leob...@redhat.com) wrote: > Currently, if a qemu instance is started with "-incoming defer" and > an incorect parameter is passed to "migrate_incoming", it will print the > expected error and reply with "duplicate yank instance" for any upcoming > "migrate_incoming" command. > >

Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:13, Richard Henderson wrote: > > Move handle_instruction into nios2_tr_translate_insn > as the only caller. > > Signed-off-by: Richard Henderson > --- > target/nios2/translate.c | 66 +++- > 1 file changed, 31 insertions(+), 35 deleti

Re: [PATCH v3 9/9] target/nios2: Use pc_next for pc + 4

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 23:08, Richard Henderson wrote: > > We have pre-computed the next instruction address into > dc->base.pc_next, so we might as well use it. > > Suggested-by: Peter Maydell > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[question] Shall we flush ITS tables into guest RAM when shutdown the VM?

2021-06-29 Thread Kunkun Jiang
Hi all, Accroding to the patch cddafd8f353d2d251b1a5c6c948a577a85838582, our original intention is to flush the ITS tables into guest RAM at the point RUN_STATE_FINISH_MIGRATE, but sometimes the VM gets stopped before migration launch so let's simply flush the tables each time the VM gets stopp

Re: [PATCH 0/1] target/arm: Check NaN mode before silencing NaN

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 16:05, Richard Henderson wrote: > > On 6/28/21 7:54 AM, Peter Maydell wrote: > > Richard, Alex: what is the assertion trying to achieve ? It doesn't > > seem entirely obvious to me that because we're in default-NaN mode > > (which is a property of the *output* of FPU insns)

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 09:27, wrote: > > Signed-off-by: Nick Hudson > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index a66c1f0b9e..7267af7924 100644 > --- a/target/arm/helper.c > +++ b/target/arm/

Re: [PATCH v4 3/3] fuzz: make object-name matching case-insensitive

2021-06-29 Thread Darren Kenny
Hi Alex, On Monday, 2021-06-28 at 01:23:49 -04, Alexander Bulekov wrote: > We have some configs for devices such as the AC97 and ES1370 that were > not matching memory-regions correctly, because the configs provided > lowercase names. To resolve these problems and prevent them from > occurring aga

Re: [PATCH v4 3/3] fuzz: make object-name matching case-insensitive

2021-06-29 Thread Darren Kenny
On Monday, 2021-06-28 at 21:11:51 -04, Alexander Bulekov wrote: > On 210628 0123, Alexander Bulekov wrote: >> We have some configs for devices such as the AC97 and ES1370 that were >> not matching memory-regions correctly, because the configs provided >> lowercase names. To resolve these problems a

Re: [PATCH v2] ui/cocoa: Use NSWindow's ability to resize

2021-06-29 Thread BALATON Zoltan
On Tue, 29 Jun 2021, Akihiko Odaki wrote: 2021年6月29日(火) 6:19 BALATON Zoltan : On Mon, 28 Jun 2021, Akihiko Odaki wrote: 2021年6月28日(月) 17:57 BALATON Zoltan : On Mon, 28 Jun 2021, Akihiko Odaki wrote: This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanb

Re: [PULL 0/5] target/alpha patch queue

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 15:35, Richard Henderson wrote: > > The following changes since commit 687f9f7834e30330fd952f1fe096518509ff8ff7: > > Merge remote-tracking branch 'remotes/philmd/tags/mips-20210625' into > staging (2021-06-28 09:44:42 +0100) > > are available in the Git repository at: > >

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

2021-06-29 Thread BALATON Zoltan
On Tue, 29 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/24/21 10:43 PM, BALATON Zoltan wrote: On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: Test the PMON firmware. As the firmware is not redistributable, it has to be downloaded manually first. Then it can be used by providing its path via

Re: [PATCH 01/20] target/loongarch: Add README

2021-06-29 Thread Alex Bennée
Song Gao writes: > This patch give an introduction to the LoongArch target. > > Signed-off-by: Song Gao > --- > MAINTAINERS | 5 + > target/loongarch/README | 16 > 2 files changed, 21 insertions(+) > create mode 100644 target/loongarch/README > > diff --git

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

2021-06-29 Thread Philippe Mathieu-Daudé
On 6/29/21 12:47 PM, BALATON Zoltan wrote: > On Tue, 29 Jun 2021, Philippe Mathieu-Daudé wrote: >> On 6/24/21 10:43 PM, BALATON Zoltan wrote: >>> On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: Test the PMON firmware. As the firmware is not redistributable, it has to be downloaded manu

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 11:41, Nick Hudson wrote: > > > > > On 29 Jun 2021, at 10:49, Peter Maydell wrote: > > > > On Tue, 29 Jun 2021 at 09:27, wrote: > >> > >> Signed-off-by: Nick Hudson > >> --- > >> target/arm/helper.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff

Re: [PATCH 01/20] target/loongarch: Add README

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 13:04, Song Gao wrote: > > This patch give an introduction to the LoongArch target. > > Signed-off-by: Song Gao > --- > +There are several code directories > + > +1 qemu/target/loongarch > +This is the instruction emulation directory > +2 qemu/linux-user/lo

Re: [PATCH 5/5] tests/acceptance: Test PMON on the Fuloong 2E machine

2021-06-29 Thread BALATON Zoltan
On Tue, 29 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/29/21 12:47 PM, BALATON Zoltan wrote: On Tue, 29 Jun 2021, Philippe Mathieu-Daudé wrote: On 6/24/21 10:43 PM, BALATON Zoltan wrote: On Thu, 24 Jun 2021, Philippe Mathieu-Daudé wrote: Test the PMON firmware. As the firmware is not redistr

Re: [PULL 0/4] Hexagon (target/hexagon) bug fixes

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:08, Taylor Simpson wrote: > > The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 > 09:54:42 +0100) > > are available in the git repo

Re: [PATCH v1 QEMU CXL modifications for openspdm 0/1] Testing PCIe DOE in QEMU CXL/PCIe Device using openspdm

2021-06-29 Thread Jonathan Cameron
On Fri, 25 Jun 2021 20:02:03 -0400 Chris Browy wrote: > This patch series provides an implementation of the the Data Object Exchange > (DOE) for Component Measurement and Authentication (CMA) of the Security > Protocol and Data Model (SPDM). > > This patch is based on > [1] [PATCH v1 openspdm

Re: [PATCH 06/20] target/loongarch: Add main translation routines

2021-06-29 Thread Alex Bennée
Song Gao writes: > Hi, Philippe, > > On 06/29/2021 02:46 AM, Philippe Mathieu-Daudé wrote: >> On 6/28/21 2:04 PM, Song Gao wrote: >>> This patch add main translation routines and >>> basic functions for translation. >>> >>> Signed-off-by: Song Gao >>> --- >>> target/loongarch/helper.h| 1

Re: [PATCH 1/3] hw/char: renesas_sci: Refactor for merge all SCI variant..

2021-06-29 Thread Peter Maydell
On Wed, 16 Jun 2021 at 10:22, Yoshinori Sato wrote: > > In order to handle unified all of the SCI, SCIa and SCIF in one part, > to separate the transmission and reception portion and a register portion. > > RenesasSCIBase - common registers operation and event handling. > RenesasSCIA - SCIa specif

Re: [PATCH 2/3] hw/char: renesas_sci Add SCI and SCIF support.

2021-06-29 Thread Peter Maydell
On Wed, 16 Jun 2021 at 10:20, Yoshinori Sato wrote: > > This peripheral using SH7750. > > Signed-off-by: Yoshinori Sato > --- > include/hw/char/renesas_sci.h | 43 ++- > hw/char/renesas_sci.c | 489 ++ > 2 files changed, 531 insertions(+), 1 deletion(-)

Re: [Virtio-fs] [PATCH v7 1/7] virtiofsd: Fix fuse setxattr() API change issue

2021-06-29 Thread Greg Kurz
On Mon, 28 Jun 2021 15:46:40 +0100 "Dr. David Alan Gilbert" wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > With kernel header updates fuse_setxattr_in struct has grown in size. > > But this new struct size only takes affect if user has opted in > > for fuse feature FUSE_SETXATTR_EXT otherw

Re: [PULL 12/23] qemu-config: add error propagation to qemu_config_parse

2021-06-29 Thread Peter Maydell
On Sat, 6 Mar 2021 at 10:59, Paolo Bonzini wrote: > > This enables some simplification of vl.c via error_fatal, and improves > error messages. Before: > > $ ./qemu-system-x86_64 -readconfig . > qemu-system-x86_64: error reading file > qemu-system-x86_64: -readconfig .: read config .: Invali

Re: [PULL 12/13] vl: plumb keyval-based options into -readconfig

2021-06-29 Thread Peter Maydell
On Fri, 4 Jun 2021 at 16:23, Paolo Bonzini wrote: > > Let -readconfig support parsing command line options into QDict or > QemuOpts. This will be used to add back support for objects in > -readconfig. > > Cc: Markus Armbruster > Cc: qemu-sta...@nongnu.org > Reviewed-by: Kevin Wolf > Signed-off-

[PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread hnick
Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a66c1f0b9e..7267af7924 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6330,7 +6330,7 @@ static const ARMCPRegInfo

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Nick Hudson
> On 29 Jun 2021, at 10:49, Peter Maydell wrote: > > On Tue, 29 Jun 2021 at 09:27, wrote: >> >> Signed-off-by: Nick Hudson >> --- >> target/arm/helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/arm/helper.c b/target/arm/helper.c >> index a66c1f0b9e.

[PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Nick Hudson
Signed-off-by: Nick Hudson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a66c1f0b9e..7267af7924 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6330,7 +6330,7 @@ static const ARMCPRegInfo

Re: [Virtio-fs] [PATCH v7 2/7] virtiofsd: Fix xattr operations overwriting errno

2021-06-29 Thread Greg Kurz
On Mon, 28 Jun 2021 16:31:27 +0100 "Dr. David Alan Gilbert" wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > getxattr/setxattr/removexattr/listxattr operations handle regualar > > and non-regular files differently. For the case of non-regular files > > we do fchdir(/proc/self/fd) and the xat

Re: [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-29 Thread Hyman
在 2021/6/29 7:05, Peter Xu 写道: On Mon, Jun 28, 2021 at 12:27:46AM +0800, huang...@chinatelecom.cn wrote: +static void dirtyrate_global_dirty_log_stop(void) +{ +qemu_mutex_lock_iothread(); One thing I missed: maybe we want to sync dirty before stop, so the value will be more accurate. P

Re: [Virtio-fs] [PATCH v7 2/7] virtiofsd: Fix xattr operations overwriting errno

2021-06-29 Thread Vivek Goyal
On Tue, Jun 29, 2021 at 03:03:43PM +0200, Greg Kurz wrote: > On Mon, 28 Jun 2021 16:31:27 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > getxattr/setxattr/removexattr/listxattr operations handle regualar > > > and non-regular files differently. For th

Re: [PATCH 3/3] hw/sh4: sh7750 using renesas_sci.

2021-06-29 Thread Peter Maydell
On Wed, 16 Jun 2021 at 10:14, Yoshinori Sato wrote: > > Signed-off-by: Yoshinori Sato > --- > include/hw/sh4/sh.h | 8 > hw/sh4/sh7750.c | 41 + > hw/sh4/Kconfig | 2 +- > 3 files changed, 42 insertions(+), 9 deletions(-) > > diff --git

[PATCH] ui/gtk: Fix relative mouse with multiple monitors

2021-06-29 Thread Dennis Wölfing
To handle relative mouse input the event handler needs to move the mouse away from the screen edges. Failing to do so results in the mouse getting stuck at invisible walls. However the current implementation for this is broken on hosts with multiple monitors. With multiple monitors the mouse can b

Re: [PATCH] hw/i386/pc: Document pc_system_ovmf_table_find

2021-06-29 Thread Tom Lendacky
On 6/29/21 2:11 AM, Philippe Mathieu-Daudé wrote: > On 6/29/21 7:56 AM, Dov Murik wrote: >> On 29/06/2021 1:03, Tom Lendacky wrote: >>> On 6/22/21 7:58 AM, Dov Murik wrote: >> >> (a) add a 'static bool ovmf_table_parsed' which will be set to true at >> the beginning of pc_system_parse_ovmf_flash()

Re: [PATCH v6 3/7] qemu-nbd: Use qcrypto_tls_creds_check_endpoint()

2021-06-29 Thread Akihiko Odaki
I tested only with qemu-nbd. Other files were compiled successfully but I have not tested them. On Tue, Jun 29, 2021 at 4:01 PM Philippe Mathieu-Daudé wrote: > > On 6/29/21 4:52 AM, Akihiko Odaki wrote: > > Tested-by: Akihiko Odaki > > Thanks! Does this apply to this single patch or the > whole

Re: [PATCH v2 01/23] linux-user: Add infrastructure for a signal trampoline page

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:32, Richard Henderson wrote: > > Allocate a page to hold the signal trampoline(s). > Invoke a guest-specific hook to fill in the contents > of the page before marking it read-execute again. > > Reviewed-by: Max Filippov > Signed-off-by: Richard Henderson > --- > linux-

Re: [PATCH v2 02/23] linux-user/aarch64: Implement setup_sigtramp

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:33, Richard Henderson wrote: > > Create and record the rt signal trampoline. > Use it when the guest does not use SA_RESTORER. > > Cc: qemu-...@nongnu.org > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > linux-user/aarch64/target_signal.

Re: VMs hanging with rcu stall problems

2021-06-29 Thread Richard Purdie
On Thu, 2021-06-03 at 11:02 +0100, Richard Purdie wrote: > We're seeing intermittent rcu stalls in qemu system mode emulation which is  > causing CI issues for us (Yocto Project). We're struggling to understand > the cause and have tried several things to mitigate without much success.  > The stall

[PATCH] trace: add hardware interrupt calls tracing

2021-06-29 Thread Arkadiy
From: NDNF Adds hardware interrupt call tracing. This is necessary to debugging Qemu and virtual devices. It was decided to use function names. This allow us tracing IRQ without global code changes. There was an attempt to use device names, but appeared the problem: it wasn't always possible to f

[PATCH v3] ui/cocoa: Use NSWindow's ability to resize

2021-06-29 Thread Akihiko Odaki
This change brings two new features: - The window will be resizable if "Zoom To Fit" is eanbled - The window can be made full screen by clicking full screen button provided by the platform. (The left-top green button.) Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 546 +

[PATCH v11 2/6] memory: make global_dirty_tracking a bitmask

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) since dirty ring has been introduced, there are two methods to track dirty pages of vm. it seems that "logging" has a hint on the method, so rename the global_dirty_log to global_dirty_tracking would make description more accurate. dirty rate measurement may start or stop d

[PATCH v11 3/6] migration/dirtyrate: introduce struct and adjust DirtyRateStat

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) introduce "DirtyRateMeasureMode" to specify what method should be used to calculate dirty rate, introduce "DirtyRateVcpu" to store dirty rate fore each vcpu. use union to store stat data of specific mode Signed-off-by: Hyman Huang(黄勇) Message-Id: <661c98c40f40e163aa58334

[PATCH v11 5/6] migration/dirtyrate: move init step of calculation to main thread

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) since main thread may "query dirty rate" at any time, it's better to move init step into main thead so that synchronization overhead between "main" and "get_dirtyrate" can be reduced. Signed-off-by: Hyman Huang(黄勇) Message-Id: <109f8077518ed2f13068e3bfb10e625e964780f1.162

[PATCH v11 1/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) dirty_pages is used to calculate dirtyrate via dirty ring, when enabled, kvm-reaper will increase the dirty pages after gfns being dirtied. kvm_dirty_ring_enabled shows if kvm-reaper is working. dirtyrate thread could use it to check if measurement can base on dirty ring fe

[PATCH v11 0/6] support dirtyrate at the granualrity of vcpu

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) v11 - rebase on master - call memory_global_dirty_log_sync before stopping dirty log when we calculate dirtyrate. this can make dirtyrate result more accurate, since kvm-reaper may be sleeping when there are dirty pages but not very much, this may lead to miss some pa

[PATCH v11 4/6] migration/dirtyrate: adjust order of registering thread

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) registering get_dirtyrate thread in advance so that both page-sampling and dirty-ring mode can be covered. Signed-off-by: Hyman Huang(黄勇) Message-Id: Reviewed-by: Peter Xu --- migration/dirtyrate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v11 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-06-29 Thread huangy81
From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. introduce mode option in qmp calc_dirty_rate to specify what method should be used when calculating dirtyrate, either page-sampling or dirty-ring should be passed. introduce "dirty_ring:-r" option in hmp calc_dirty

Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support

2021-06-29 Thread Peter Maydell
On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: > > Add files to linux-user/loongarch64 > Add file to default-configs > Add loongarch to target/meson.build > > Signed-off-by: Song Gao > --- > MAINTAINERS| 1 + > default-configs/targets/loongarch64-linux-us

Re: [PATCH v2 03/23] linux-user/arm: Split out v2_frame

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:32, Richard Henderson wrote: > > Split out a helper function to test for a v2 signal frame. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > linux-user/arm/signal.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --gi

Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction

2021-06-29 Thread Richard Henderson
On 6/29/21 2:27 AM, Peter Maydell wrote: On Mon, 28 Jun 2021 at 23:13, Richard Henderson wrote: Move handle_instruction into nios2_tr_translate_insn as the only caller. Signed-off-by: Richard Henderson --- target/nios2/translate.c | 66 +++- 1 file chan

Re: [PATCH v2 04/23] linux-user/arm: Force v2 frames for fdpic

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:32, Richard Henderson wrote: > > The value of get_os_release may be controlled by a command > line option. Since fdpic was added in v4.14, and v2 frame > were added in v2.6.12, this makes no change under normal conditions. > > Cc: qemu-...@nongnu.org > Signed-off-by: Ric

Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 14:53, Richard Henderson wrote: > > On 6/29/21 2:27 AM, Peter Maydell wrote: > > On Mon, 28 Jun 2021 at 23:13, Richard Henderson > > wrote: > >> > >> Move handle_instruction into nios2_tr_translate_insn > >> as the only caller. > >> > >> Signed-off-by: Richard Henderson >

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Richard Henderson
On 6/29/21 1:15 AM, Nick Hudson wrote: { .name = "MDCCSR_EL0", .state = ARM_CP_STATE_BOTH, - .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 1, .opc2 = 0, + .cp = 14, .opc0 = 2, .opc1 = 3, .crn = 0, .crm = 1, .opc2 = 0, Reviewed-by: Richard Henderson r~

Re: [PATCH] nvdimm: release the correct device list

2021-06-29 Thread Igor Mammedov
On Thu, 24 Jun 2021 19:04:15 +0800 Li Zhijian wrote: > Signed-off-by: Li Zhijian Reviewed-by: Igor Mammedov > --- > hw/acpi/nvdimm.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c > index e3d5fe19392..ff317263e85 100

Re: [PATCH] target/i386: Fix cpuid level for AMD

2021-06-29 Thread Dr. David Alan Gilbert
* zhenwei pi (pizhen...@bytedance.com) wrote: > A AMD server typically has cpuid level 0x10(test on Rome/Milan), it > should not be changed to 0x1f in multi-dies case. > > Fixes: a94e1428991 (target/i386: Add CPUID.1F generation support > for multi-dies PCMachine) > Signed-off-by: zhenwei pi (Co

Re: [PATCH v3 1/3] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

2021-06-29 Thread Eric Auger
Hi Wainer, On 6/28/21 5:06 PM, Wainer dos Santos Moschetta wrote: > Hi Eric, > > On 6/21/21 5:08 AM, Eric Auger wrote: >> When running LinuxTests we may need to run the guest with >> custom params. It is practical to store the pxeboot URL >> and the default kernel params so that the >> tests just

Re: [PATCH v3 2/3] avocado_qemu: Add SMMUv3 tests

2021-06-29 Thread Eric Auger
On 6/28/21 8:27 PM, Wainer dos Santos Moschetta wrote: > Hi, > > On 6/21/21 5:08 AM, Eric Auger wrote: >> Add new tests checking the good behavior of the SMMUv3 protecting >> 2 virtio pci devices (block and net). We check the guest boots and >> we are able to install a package. Different guest c

Re: [PATCH v2 05/23] linux-user/arm: Implement setup_sigtramp

2021-06-29 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:33, Richard Henderson wrote: > > ARM is more complicated than the others, in that we also > have trampolines for using SA_RESTORER with FDPIC, and > we need to create trampolines for both ARM and Thumb modes. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson

Re: [PATCH] target/arm: Correct the encoding of MDCCSR_EL0

2021-06-29 Thread Peter Maydell
On Tue, 29 Jun 2021 at 14:03, Nick Hudson wrote: > > Signed-off-by: Nick Hudson > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index a66c1f0b9e..7267af7924 100644 > --- a/target/arm/helper.c > +++ b

[RFC v6 00/13] s390x cleanup

2021-06-29 Thread Cho, Yu-Chen
this is the next version of a cleanup series for s390x. v5 -> v6: * target/s390x: start moving TCG-only code to tcg/ - keep the old pattern in MAINTAINERS (Cornelia) * target/s390x: make helper.c sysemu-only - fixed typo v4 -> v5: * "target/s390x: start moving TCG-only code to tcg/" - add

[RFC v6 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c

2021-06-29 Thread Cho, Yu-Chen
we stop short of renaming the actual qom object though, so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 2 +- hw/s390x/{tod-qem

[RFC v6 01/13] target/s390x: meson: add target_user_arch

2021-06-29 Thread Cho, Yu-Chen
the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- ta

[PATCH 3/4] hw/misc: Add Infineon DPS310 sensor model

2021-06-29 Thread Cédric Le Goater
From: Joel Stanley This contains some hardcoded register values that were obtained from the hardware after reading the temperature. It does enough to test the Linux kernel driver. The FIFO mode, IRQs and operation modes other than the default as used by Linux are not modelled. Signed-off-by: Jo

[RFC v6 09/13] target/s390x: make helper.c sysemu-only

2021-06-29 Thread Cho, Yu-Chen
Now that we have moved cpu-dump functionality out of helper.c, we can make the module sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/helper.c| 9 + target/s390x/meson.build | 2 +- 2 files changed, 2 insertions(+), 9

[RFC v6 05/13] target/s390x: remove tcg-stub.c

2021-06-29 Thread Cho, Yu-Chen
now that we protect all calls to the tcg-specific functions with if (tcg_enabled()), we do not need the TCG stub anymore. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- target/s390x/meson.build | 2 +- target/s390x/tcg

[RFC v6 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build

2021-06-29 Thread Cho, Yu-Chen
this will allow in later patches to remove unneeded stubs in target/s390x. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/s3

[RFC v6 11/13] target/s390x: remove kvm-stub.c

2021-06-29 Thread Cho, Yu-Chen
all function calls are protected by kvm_enabled(), so we do not need the stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS | 1 - target/s390x/kvm-stub.c | 121 --- target/s390x/meson.build | 2 +- 3 files cha

[RFC v6 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

2021-06-29 Thread Cho, Yu-Chen
this will allow to remove the kvm stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/diag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index c17a2498a7..8405f69df0 100644 --- a/target/s390x/diag

Re: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-29 Thread Alessandro Di Federico via
On Thu, 24 Jun 2021 03:55:35 + Taylor Simpson wrote: > > + | rvalue '[' rvalue ']' > > + { > > + @1.last_column = @4.last_column; > > + if ($3.type == IMMEDIATE) { > > + $$ = gen_tmp(c, &@1, $1.bit_width); > > + OUT(c, &@1,

[RFC v6 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing

2021-06-29 Thread Cho, Yu-Chen
replace general "else" with specific checks for each possible accelerator. Handle qtest as a NOP, and error out for an unknown accelerator used in combination with tod. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw

[RFC v6 12/13] target/s390x: move kvm files into kvm/

2021-06-29 Thread Cho, Yu-Chen
move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS| 3 +-- hw/intc/s390_flic_kvm.c| 2 +- hw/s390x/s390

[RFC v6 06/13] target/s390x: start moving TCG-only code to tcg/

2021-06-29 Thread Cho, Yu-Chen
move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. After the reshuffling, update MAINT

Re: [PATCH v5 14/14] gitlab-ci: do not use qemu-project Docker registry

2021-06-29 Thread Alessandro Di Federico via
On Sat, 19 Jun 2021 11:37:13 +0200 Alessandro Di Federico wrote: > From: Alessandro Di Federico > > This commit is necessary in order to use container built by the > current run of the CI. If we don't do this, we use official > containers which are not affected by the additional dependencies >

[PATCH 0/4] Aspeed: I2C extensions

2021-06-29 Thread Cédric Le Goater
Hello, Here is a small series of patches I have been collecting from Joel. It populates the Aspeed machines with more I2C devices and adds a minimal model for the DPS310 sensor model. The AST2600 SoC revision is updated to A3 and the A1 is dropped as it didn't seem useful to keep multiple revisio

[RFC v6 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c

2021-06-29 Thread Cho, Yu-Chen
move sysemu-only code out to cpu-sysemu.c Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/cpu-sysemu.c | 309 ++ target/s390x/cpu.c| 285 ++- target/s390x/meson.build | 1 + target/s390x/t

Re: [Virtio-fs] [PATCH v7 2/7] virtiofsd: Fix xattr operations overwriting errno

2021-06-29 Thread Greg Kurz
On Tue, 29 Jun 2021 09:22:36 -0400 Vivek Goyal wrote: > On Tue, Jun 29, 2021 at 03:03:43PM +0200, Greg Kurz wrote: > > On Mon, 28 Jun 2021 16:31:27 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > > getxattr/setxattr/removexattr/listxattr operat

Re: [PATCH v2 03/23] linux-user/arm: Split out v2_frame

2021-06-29 Thread Richard Henderson
On 6/29/21 6:53 AM, Peter Maydell wrote: On Fri, 18 Jun 2021 at 20:32, Richard Henderson wrote: Split out a helper function to test for a v2 signal frame. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- linux-user/arm/signal.c | 13 + 1 file changed, 9 insertions(

[RFC v6 08/13] target/s390x: split cpu-dump from helper.c

2021-06-29 Thread Cho, Yu-Chen
Splitting this functionality also allows us to make helper.c sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/cpu-dump.c | 176 +++ target/s390x/helper.c| 151 --

[PATCH v4 4/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-06-29 Thread Eric Auger
From: Wainer dos Santos Moschetta As the KNOWN_DISTROS grows, more loosely methods will be created in the avocado_qemu/__init__.py file. Let's refactor the code so that KNOWN_DISTROS and related methods are packaged in a class Signed-off-by: Wainer dos Santos Moschetta Signed-off-by: Eric Auge

[PATCH v4 0/4] avocado-qemu: New SMMUv3 and intel IOMMU tests

2021-06-29 Thread Eric Auger
This series adds ARM SMMU and Intel IOMMU functional tests using Fedora cloud-init images. ARM SMMU tests feature guests with and without RIL (range invalidation support) using respectively fedora 33 and 31. For each, we test the protection of virtio-net-pci and virtio-block-pci devices. Also str

  1   2   3   4   >