On Mon, 28 Jun 2021 at 23:12, Richard Henderson <richard.hender...@linaro.org> wrote: > > Direct assignments to env during translation do not work. > > As it happens, the only way we can get here is if env->pc > is already set to dc->pc. We will trap on the first insn > we execute anywhere on the page. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/nios2/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/nios2/translate.c b/target/nios2/translate.c > index 66f4c25b06..6fd4330b31 100644 > --- a/target/nios2/translate.c > +++ b/target/nios2/translate.c > @@ -740,14 +740,15 @@ static void handle_instruction(DisasContext *dc, > CPUNios2State *env) > uint32_t code; > uint8_t op; > const Nios2Instruction *instr; > + > #if defined(CONFIG_USER_ONLY) > /* FIXME: Is this needed ? */ > if (dc->pc >= 0x1000 && dc->pc < 0x2000) { > - env->regs[R_PC] = dc->pc; > t_gen_helper_raise_exception(dc, 0xaa); > return; > } > #endif > +
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM