On 6/29/21 2:27 AM, Peter Maydell wrote:
On Mon, 28 Jun 2021 at 23:13, Richard Henderson
<richard.hender...@linaro.org> wrote:

Move handle_instruction into nios2_tr_translate_insn
as the only caller.

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  target/nios2/translate.c | 66 +++++++++++++++++++---------------------
  1 file changed, 31 insertions(+), 35 deletions(-)

Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

Side note: I think we could replace all the handling of dc->zero
by having load_gpr() return a tcg_constant_i32(0) for R_ZERO,
which then never needs freeing. (We never try to write back
to what we get from load_gpr().)

Quite right.  There are several targets that could benefit from that 
simplification.


r~


Reply via email to