On Tue, 29 Jun 2021 at 06:37, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>
> When using the Magnum ARC firmware we can see accesses to the
> UART1 beeing rejected, because the device is not mapped:

"being"

>
>   $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007001, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007002, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007003, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
>
> Since both UARTs are present (soldered on the board) regardless there

"regardless of whether there are"

> are character devices connected, map them unconditionally.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

(This code pre-dated commit 12051d82f004 which made it safe to pass NULL
in as a chardev to serial devices.)

thanks
-- PMM

Reply via email to