Re: [Qemu-devel] [PATCH v3 02/13] tests: acpi: rename acpi_parse_rsdp_table() into acpi_fetch_rsdp_table()

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:38AM +0200, Igor Mammedov wrote: >so name would reflect what the function does > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang >--- > tests/acpi-utils.h | 2 +- > tests/acpi-utils.c | 2 +- > tests/bios-tables-t

Re: [Qemu-devel] [PATCH v3 01/13] tests: acpi: make RSDT test routine handle XSDT

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:37AM +0200, Igor Mammedov wrote: >If RSDP revision is more than 0 fetch table pointed by XSDT >and fallback to legacy RSDT table otherwise. > >While at it drop unused acpi_get_xsdt_address(). Would it be proper to split this into another patch? > >Signed-off-by: Igor

Re: [Qemu-devel] [PATCH v3 03/13] tests: acpi: make pointer to RSDP 64bit

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:39AM +0200, Igor Mammedov wrote: >In case of UEFI, RSDP doesn't have to be located in lowmem, >it could be placed at any address. Make sure that test won't >break if it is placed above the first 4Gb of address space. > >PS: >While at it cleanup some local variables as

Re: [Qemu-devel] [PATCH 0/3] Export machine type deprecation info through QMP

2019-04-25 Thread Thomas Huth
On 24/04/2019 20.10, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 09:56:53AM +0200, Thomas Huth wrote: >> On 23/04/2019 23.22, Eduardo Habkost wrote: >>> This series adds machine type deprecation information to the >>> output of the `query-machines` QMP command. With this, libvirt >>> and mana

Re: [Qemu-devel] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines

2019-04-25 Thread Thomas Huth
On 24/04/2019 14.50, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2019 at 02:37:02PM +0200, Thomas Huth wrote: >> On 24/04/2019 13.25, Daniel P. Berrangé wrote: >>> On Wed, Apr 24, 2019 at 12:37:43PM +0200, Thomas Huth wrote: Tests in this group are supposed to run in every possible QEMU

Re: [Qemu-devel] [PATCH v3 04/13] tests: acpi: fetch X_DSDT if pointer to DSDT is 0

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:40AM +0200, Igor Mammedov wrote: >that way it would be possible to test a DSDT pointed by >64bit X_DSDT field in FADT. > >PS: >it will allow to enable testing arm/virt board, which sets >only newer X_DSDT field. > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe M

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-25 Thread Thomas Huth
On 24/04/2019 17.23, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote: >> On 4/24/19 5:37 AM, Thomas Huth wrote: >>> bash is installed in a different directory on non-Linux systems like >>> FreeBSD. Do not hard-code /bin/bash here so that the tests can run >>>

Re: [Qemu-devel] [PATCH v3 05/13] tests: acpi: skip FACS table if board uses hw reduced ACPI profile

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:41AM +0200, Igor Mammedov wrote: >If FADT has HW_REDUCED_ACPI flag set, do not attempt to fetch >FACS as it's not provided by the board. > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wei Yang >--- > tests/bios-tables-test.c | 10

Re: [Qemu-devel] [PATCH v3 01/13] tests: acpi: make RSDT test routine handle XSDT

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 15:22:56 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:37AM +0200, Igor Mammedov wrote: > >If RSDP revision is more than 0 fetch table pointed by XSDT > >and fallback to legacy RSDT table otherwise. > > > >While at it drop unused acpi_get_xsdt_address(). > > Would i

Re: [Qemu-devel] [PATCH v3 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:44AM +0200, Igor Mammedov wrote: >For testcase to use UEFI firmware, one needs to provide and specify >firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } ^

Re: [Qemu-devel] [PATCH v3 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:43AM +0200, Igor Mammedov wrote: >introduce UEFI specific counterpart to acpi_find_rsdp_address() >that will help to find RSDP address when [OA]VMF is used as >firmware. It requires guest firmware or other guest app to place >1Mb aligned UefiTestSupport structure (defi

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Gerd Hoffmann
On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > Thomas Huth 于2019年4月24日周三 上午12:29写道: > > > Is this endianess-safe? Or do you need to byteswap reboot_timeout if the > > host and guest endianess does not match? > > Good question! > > IIUC, the qemu fw_cfg store the 'file' entry data j

Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: >Make initial list contain aarch64 and x86_64 targets. so i386 is taken out? > >Signed-off-by: Igor Mammedov >Reviewed-by: Philippe Mathieu-Daudé >--- >v2: > * fix up error message (Philippe Mathieu-Daudé ) >--- > tests/data/acpi/re

Re: [Qemu-devel] [PATCH v3 13/13] tests: acpi: print error unable to dump ACPI table during rebuild

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 07:34:49AM +0200, Igor Mammedov wrote: >Instead of just asserting print the error that lead to assert first. >While at it move assert into rebuild branch, which removes reduntant >check done in case of !rebuild branch is taken (the later is taken >care of by g_assert_no_erro

Re: [Qemu-devel] [PATCH v3 01/13] tests: acpi: make RSDT test routine handle XSDT

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 10:07:51AM +0200, Igor Mammedov wrote: >On Thu, 25 Apr 2019 15:22:56 +0800 >Wei Yang wrote: > >> On Thu, Apr 25, 2019 at 07:34:37AM +0200, Igor Mammedov wrote: >> >If RSDP revision is more than 0 fetch table pointed by XSDT >> >and fallback to legacy RSDT table otherwise. >

Re: [Qemu-devel] [PATCH v14 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-25 Thread Stefan Hajnoczi
On Wed, Apr 24, 2019 at 09:01:05AM +0800, Wei Yang wrote: > On Tue, Apr 23, 2019 at 10:25:18AM +0100, Stefan Hajnoczi wrote: > [...] > >> +#ifdef CONFIG_LINUX > >> +#include > >> +#else /* !CONFIG_LINUX */ > >> +#define MAP_SYNC 0x0 > >> +#define MAP_SHARED_VALIDATE 0x0 > >> +#endi

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Li Qiang
Gerd Hoffmann 于2019年4月25日周四 下午4:15写道: > On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > > Thomas Huth 于2019年4月24日周三 上午12:29写道: > > > > > Is this endianess-safe? Or do you need to byteswap reboot_timeout if > the > > > host and guest endianess does not match? > > > > Good question! >

Re: [Qemu-devel] [Qemu-block] question: Does qemu-pr-helper have its own log files?

2019-04-25 Thread Stefan Hajnoczi
On Tue, Apr 23, 2019 at 10:42:17AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 23, 2019 at 11:12:40AM +0800, Jie Wang wrote: > >  Does qemu-pr-helper have its own log files? > > When QEMU launches it, i think it just inherits stdout/err from > QEMU itself, so errors appear mixed into QEMU's std

Re: [Qemu-devel] [Qemu-block] question: Does qemu-pr-helper have its own log files?

2019-04-25 Thread Stefan Hajnoczi
On Wed, Apr 24, 2019 at 02:37:36AM +, Zhangbo (Oscar) wrote: > >From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > >Sent: Tuesday, April 23, 2019 9:57 PM > >On Tue, Apr 23, 2019 at 11:12:40AM +0800, Jie Wang wrote: > >>  Does qemu-pr-helper have its own log files? > > > >No, it does not. qemu

Re: [Qemu-devel] [PATCH v2 0/3] vhost-scsi: Support migration

2019-04-25 Thread Stefan Hajnoczi
On Wed, Apr 24, 2019 at 07:38:57PM +0300, Liran Alon wrote: > > > > On 18 Apr 2019, at 12:41, Stefan Hajnoczi wrote: > > > > On Tue, Apr 16, 2019 at 03:59:09PM +0300, Liran Alon wrote: > >> Hi, > >> > >> This patch series aims to add supprot to migrate a VM with a vhost-scsi > >> device. > >>

Re: [Qemu-devel] [PATCH v2 0/5] fw_cfg_test refactor and add two test cases

2019-04-25 Thread Thomas Huth
On 24/04/2019 16.06, Li Qiang wrote: > In the disscuss of adding reboot timeout test case: > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03304.html > > Philippe suggested we should uses the only related option for one > specific test. However currently we uses one QTestState for all t

Re: [Qemu-devel] [PATCH v2 2/2] build-sys: move slirp as git submodule project

2019-04-25 Thread Stefan Hajnoczi
On Wed, Apr 24, 2019 at 01:14:57PM +0100, Peter Maydell wrote: > On Wed, 24 Apr 2019 at 12:13, Marc-André Lureau > wrote: > > > > The slirp project is now hosted on freedesktop at: > > https://gitlab.freedesktop.org/slirp. > > > > The libslirp source was extracted from qemu/slirp filtered through

Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 10:29 AM, Li Qiang wrote: > > > Gerd Hoffmann mailto:kra...@redhat.com>> 于2019年4月 > 25日周四 下午4:15写道: > > On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote: > > Thomas Huth mailto:th...@redhat.com>> 于2019年4 > 月24日周三 上午12:29写道: > > > > > Is this endianess-safe?

Re: [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again

2019-04-25 Thread Thomas Huth
On 25/04/2019 07.57, Thomas Huth wrote: > On 24/04/2019 22.42, Wainer dos Santos Moschetta wrote: >> Hi Thomas, >> >> >> On 04/24/2019 07:37 AM, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do n

Re: [Qemu-devel] [PATCH v7 1/2] qemu-io: Use error_[gs]et_progname()

2019-04-25 Thread Thomas Huth
On 31/01/2019 17.46, Christophe Fergeau wrote: > qemu-io reimplements itself what > error_get_progname()/error_set_progname() already does. > This commit switches it to use this API from qemu-error.h > > Signed-off-by: Christophe Fergeau > Reviewed-by: Eric Blake > Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 03/13] tests: acpi: make pointer to RSDP 64bit

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 15:31:42 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:39AM +0200, Igor Mammedov wrote: > >In case of UEFI, RSDP doesn't have to be located in lowmem, > >it could be placed at any address. Make sure that test won't > >break if it is placed above the first 4Gb of addres

[Qemu-devel] [PATCH 2/2] tests/uefi-boot-images: report the SMBIOS entry point structures

2019-04-25 Thread Laszlo Ersek
Rebuild the "bios-tables-test" UEFI boot images with the SMBIOS entry point reporting that has been added in the previous patch. Cc: "Philippe Mathieu-Daudé" Cc: Igor Mammedov Launchpad: https://bugs.launchpad.net/qemu/+bug/1821884 Signed-off-by: Laszlo Ersek --- tests/data/uefi-boot-images/bi

[Qemu-devel] [PATCH 1/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-04-25 Thread Laszlo Ersek
On UEFI systems, the SMBIOS entry point (a.k.a. anchor) structures are found similarly to the ACPI RSD PTR table(s): by scanning the ConfigurationTable array in the EFI system table for well-known GUIDs. Locate the SMBIOS 2.1 (32-bit) and 3.0 (64-bit) anchors in the BiosTablesTest UEFI application

[Qemu-devel] [Bug 1821884] Re: Extend uefi-test-tools to report SMBIOS location

2019-04-25 Thread Laszlo Ersek (Red Hat)
Posted [PATCH 0/2] tests/uefi-test-tools: report the SMBIOS entry point structures 20190425104326.12835-1-lersek@redhat.com">http://mid.mail-archive.com/20190425104326.12835-1-lersek@redhat.com ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification bec

[Qemu-devel] [PATCH 0/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-04-25 Thread Laszlo Ersek
Repo: https://github.com/lersek/qemu.git Branch:smbios_lp_1821884 Launchpad: https://bugs.launchpad.net/qemu/+bug/1821884 In [Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used at http://mid.mail-archive.com/1553605799-168605-10-git-

Re: [Qemu-devel] [PATCH v3 07/13] tests: acpi: add acpi_find_rsdp_address_uefi() helper

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 16:00:46 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:43AM +0200, Igor Mammedov wrote: > >introduce UEFI specific counterpart to acpi_find_rsdp_address() > >that will help to find RSDP address when [OA]VMF is used as > >firmware. It requires guest firmware or other gu

Re: [Qemu-devel] [PATCH v3 08/13] tests: acpi: add a way to start tests with UEFI firmware

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 16:08:42 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:44AM +0200, Igor Mammedov wrote: > >For testcase to use UEFI firmware, one needs to provide and specify > >firmwarei and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } >

Re: [Qemu-devel] [PATCH v3 13/13] tests: acpi: print error unable to dump ACPI table during rebuild

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 7:34 AM, Igor Mammedov wrote: > Instead of just asserting print the error that lead to assert first. > While at it move assert into rebuild branch, which removes reduntant "redundant" > check done in case of !rebuild branch is taken (the later is taken > care of by g_assert_no_error).

Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 16:20:50 +0800 Wei Yang wrote: > On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: > >Make initial list contain aarch64 and x86_64 targets. > > so i386 is taken out? > > > > >Signed-off-by: Igor Mammedov > >Reviewed-by: Philippe Mathieu-Daudé > >--- > >v2: >

Re: [Qemu-devel] [PATCH 1/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 12:43 PM, Laszlo Ersek wrote: > On UEFI systems, the SMBIOS entry point (a.k.a. anchor) structures are > found similarly to the ACPI RSD PTR table(s): by scanning the > ConfigurationTable array in the EFI system table for well-known GUIDs. > > Locate the SMBIOS 2.1 (32-bit) and 3.0 (64-

[Qemu-devel] [Bug 1826393] [NEW] QEMU 3.1.0 stuck waiting for 800ms (5 times slower) in pre-bios phase

2019-04-25 Thread Waldemar Kozaczuk
Public bug reported: Yesterday I have upgraded my laptop from Ubuntu 18.10 to 19.04 and that way got newer QEMU 3.1.0 along vs QEMU 2.12.0 before. I have noticed that everytime I start QEMU to run OSv, QEMU seems to hand noticably longer (~1 second) before showing SeaBIOS output. I have tried all

Re: [Qemu-devel] [PATCH v3 12/13] tests: acpi: refactor rebuild-expected-aml.sh to dump ACPI tables for a specified list of targets

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 13:32:50 +0200 Igor Mammedov wrote: > On Thu, 25 Apr 2019 16:20:50 +0800 > Wei Yang wrote: > > > On Thu, Apr 25, 2019 at 07:34:48AM +0200, Igor Mammedov wrote: > > >Make initial list contain aarch64 and x86_64 targets. > > > > so i386 is taken out? we use the same bl

Re: [Qemu-devel] [PATCH v3 0/2] s390x/kvm: Properly detect page size of initial memory

2019-04-25 Thread Cornelia Huck
On Wed, 17 Apr 2019 13:31:41 +0200 David Hildenbrand wrote: > While the detection on s390x of the maximum ram pagesize works by pure luck, > we should try to do better. Especially, once "-mem-path" is replaced > by memory backends, the current approach will break. > > Configure the maximum page

[Qemu-devel] [PATCH v2 0/3] Leon3 patches

2019-04-25 Thread KONRAD Frederic
Hi all, Those are some little fixes for the leon3 machine: * The first part initializes the uart and the timer when no bios are provided. * The second part adds AHB and APB plug and play devices to allow to boot linux. * The third part adds myself to the MAINTAINERS for this board.

[Qemu-devel] [PATCH v2 3/3] MAINTAINERS: add myself for leon3

2019-04-25 Thread KONRAD Frederic
Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 23db6f8..6f7d237 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1151,6 +1151,7 @@ F: include/hw/tim

[Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-04-25 Thread KONRAD Frederic
This adds a little bootloader to the leon3_machine when a ram image is given through the kernel parameter and no bios are provided: * The UART transmiter is enabled. * The TIMER is initialized. Reviewed-by: Fabien Chouteau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: KONRAD Frederic -

[Qemu-devel] [PATCH v2 2/3] leon3: introduce the plug and play mecanism

2019-04-25 Thread KONRAD Frederic
This adds the AHB and APB plug and play devices. They are scanned during the linux boot to discover the various peripheral. Reviewed-by: Fabien Chouteau Signed-off-by: KONRAD Frederic --- hw/misc/Makefile.objs | 2 + hw/misc/grlib_ahb_apb_pnp.c | 269

Re: [Qemu-devel] [PULL SUBSYSTEM s390-ccw-bios 00/17] vfio-ccw dasd ipl support

2019-04-25 Thread Cornelia Huck
On Fri, 12 Apr 2019 14:25:06 +0200 Thomas Huth wrote: > This pull request is not for master. > > Hi Cornelia, > > the following changes since commit 532cc6da74ec25b5ba6893b5757c977d54582949: > > Update version for v4.0.0-rc3 release (2019-04-10 15:38:59 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH v3 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Igor, On 4/25/19 7:34 AM, Igor Mammedov wrote: > once FW provides a pointer to SMBIOS entry point like it does for > RSDP it should be possible to enable this one the same way. > > Signed-off-by: Igor Mammedov > Reviewed-by: Laszlo Ersek > --- > v3: > - add ref to a uefi-test-tools feature

Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 7:34 AM, Igor Mammedov wrote: > adds simple arm/virt test case that starts guest with > bios-tables-test.aarch64.iso.qcow2 boot image which > initializes UefiTestSupport* structure in RAM once > guest is booted. > > * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper >

Re: [Qemu-devel] [PATCH v3 10/13] tests: add expected ACPI tables for arm/virt board

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 7:34 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Tested-by: Philippe Mathieu-Daudé > --- > this patch is ahead fo "tests: acpi: add simple arm/virt testcase" > to keep 'make check' working during bisection and not to pollute > code with binary blobs which are not reviewa

Re: [Qemu-devel] [PATCH 0/2] tests/uefi-test-tools: report the SMBIOS entry point structures

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 12:43 PM, Laszlo Ersek wrote: > Repo: https://github.com/lersek/qemu.git > Branch:smbios_lp_1821884 > Launchpad: https://bugs.launchpad.net/qemu/+bug/1821884 > > In > > [Qemu-devel] [PATCH for 4.1 v2 09/13] > tests: acpi: ignore SMBIOS tests when UEFI firmware is used > >

Re: [Qemu-devel] [PATCH v2 1/3] leon3: add a little bootloader

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/25/19 2:18 PM, KONRAD Frederic wrote: > This adds a little bootloader to the leon3_machine when a ram image is > given through the kernel parameter and no bios are provided: > * The UART transmiter is enabled. > * The TIMER is initialized. > > Reviewed-by: Fabien Chouteau > Reviewed-by:

[Qemu-devel] [Bug 1826401] [NEW] qemu-system-aarch64 has a high cpu usage on windows

2019-04-25 Thread Adrian Luca
Public bug reported: Running qemu-system-aarch64 leads to a high CPU consumption on windows 10. Tested with qemu: 4.0.0-rc4 & 3.1.0 & 2.11.0 Command: qemu_start_command = [ qemu-system-aarch64, "-pidfile", target_path + "/qemu" + str(instance) + ".pid", "-machine"

[Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors

2019-04-25 Thread Stefan Hajnoczi
qemu.org hosts git repository mirrors of all submodules. Update .gitmodules to use the mirrors and not the upstream repositories. Mirroring upstream repositories ensures that QEMU continues to build even when upstream repositories are deleted or temporarily offline. Signed-off-by: Stefan Hajnocz

Re: [Qemu-devel] [PATCH] virtio: clarify VirtioPCIDeviceTypeInfo usage

2019-04-25 Thread Stefan Hajnoczi
On Wed, Apr 24, 2019 at 01:44:47PM -0300, Eduardo Habkost wrote: > On Wed, Apr 24, 2019 at 04:24:01PM +0100, Stefan Hajnoczi wrote: > > How to use .base_name, .generic_name, .transitional_name, and > > .non_transitional_name can be confusing. > > > > Existing devices have .generic_name but its beh

[Qemu-devel] [PATCH v2] virtio: clarify VirtioPCIDeviceTypeInfo usage

2019-04-25 Thread Stefan Hajnoczi
How to use .base_name, .generic_name, .transitional_name, and .non_transitional_name can be confusing. Existing devices have .generic_name but its behavior is somewhat magic. Devices added to new versions of the VIRTIO specification should forego transitional mode completely and always operate in

Re: [Qemu-devel] [PATCH] gitmodules: use qemu.org git mirrors

2019-04-25 Thread Philippe Mathieu-Daudé
Hi Stefan, On 4/25/19 2:56 PM, Stefan Hajnoczi wrote: > qemu.org hosts git repository mirrors of all submodules. Update > .gitmodules to use the mirrors and not the upstream repositories. > > Mirroring upstream repositories ensures that QEMU continues to build > even when upstream repositories a

Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 02/29] hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device

2019-04-25 Thread Philippe Mathieu-Daudé
On 4/20/19 12:31 PM, Philippe Mathieu-Daudé wrote: > On 4/18/19 8:00 PM, Thomas Huth wrote: >> Some of our machines (like the ARM cubieboard) use CONFIG_AHCI for an AHCI >> sysbus device, but do not use CONFIG_PCI since they do not feature a PCI >> bus. With CONFIG_AHCI but without CONFIG_PCI, curr

[Qemu-devel] [PULL 01/19] s390 vfio-ccw: Add bootindex property and IPLB data

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signe

[Qemu-devel] [PULL 07/19] s390-bios: ptr2u32 and u32toptr

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth Message-Id: <1554388475-18329-8-git-

[Qemu-devel] [PULL 00/19] first batch of s390x patches for 4.1

2019-04-25 Thread Cornelia Huck
The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' into staging (2019-04-24 13:19:41 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-2019042

[Qemu-devel] [PULL 05/19] s390-bios: Decouple channel i/o logic from virtio

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Message-Id: <155438

[Qemu-devel] [PULL 03/19] s390-bios: decouple common boot logic from virtio

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Re

[Qemu-devel] [PULL 02/19] s390-bios: decouple cio setup from virtio

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Reviewed-by: Farhan Ali

[Qemu-devel] [PULL 13/19] s390-bios: Use control unit type to determine boot method

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" The boot method is different depending on which device type we are booting from. Let's examine the control unit type to determine if we're a virtio device. We'll eventually add a case to check for a real dasd device here as well. Since we have to call enable_subchannel() i

[Qemu-devel] [PULL 08/19] s390-bios: Support for running format-0/1 channel programs

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Introduce a library function for executing format-0 and format-1 channel programs and waiting for their completion before continuing execution. Add cu_type() to channel io library. This will be used to query control unit type which is used to determine if we are booting a

[Qemu-devel] [PULL 04/19] s390-bios: Clean up cio.h

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Acked-by: Cornelia Huck Reviewed-by: Thomas Huth Message-Id: <1554388475-18329-5-git-send-email

[Qemu-devel] [PULL 06/19] s390-bios: Map low core memory

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth Message-Id: <1554388475-18329-7-

[Qemu-devel] [PULL 09/19] s390-bios: cio error handling

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: cio device error ssid : 0x

[Qemu-devel] [PULL 16/19] s390-bios: Use control unit type to find bootable devices

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" When the user does not specify which device to boot from then we end up guessing. Instead of simply grabbing the first available device let's be a little bit smarter and only choose devices that might be bootable like disk, and not console devices. Signed-off-by: Jason J.

[Qemu-devel] [PULL 10/19] s390-bios: Extend find_dev() for non-virtio devices

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Corn

[Qemu-devel] [PULL 15/19] s390-bios: Support booting from real dasd device

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Message-Id: <1554388475-18329-16-git-send-email-jjhe...@linux.ibm.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + docs/devel

[Qemu-devel] [PULL 12/19] s390-bios: Refactor virtio to run channel programs via cio

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Acked-by: Thomas Huth Message-Id: <1554388475-18329-13-git-send-email-jjhe...@linux.ibm.com> Sig

[Qemu-devel] [PATCH v6 03/21] gdbstub: Implement thread_alive (T pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fdad1ac466..29ca6be3df 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1499,6 +1499,30 @@ static void handle_detach(GdbCm

[Qemu-devel] [PULL 11/19] s390-bios: Factor finding boot device out of virtio code path

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" Make a new routine find_boot_device to locate the boot device for all cases, not just virtio. The error message for the case where no boot device has been specified and a suitable boot device cannot be auto detected was specific to virtio devices. We update this message to

[Qemu-devel] [PULL 18/19] s390x/kvm: Configure page size after memory has actually been initialized

2019-04-25 Thread Cornelia Huck
From: David Hildenbrand Right now we configure the pagesize quite early, when initializing KVM. This is long before system memory is actually allocated via memory_region_allocate_system_memory(), and therefore memory backends marked as mapped. Instead, let's configure the maximum page size after

[Qemu-devel] [PATCH v6 09/21] gdbstub: Implement set register (P pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 80f2a92da6..49db09ef52 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1635,6 +1635,27 @@ static void handle_remove_bp(GdbCmdC

[Qemu-devel] [PATCH v6 00/21] gdbstub: Refactor command packets handler

2019-04-25 Thread Jon Doron
This patch series refactors the old gdbstub command packets handler with a new infrastructure which should ease extending and adding new and missing gdb command packets. version 4-6 changes: - mostly feedback from Richard Henderson version 3 changes - Split the single patch to many individual pat

[Qemu-devel] [PULL 19/19] exec: Introduce qemu_maxrampagesize() and rename qemu_getrampagesize()

2019-04-25 Thread Cornelia Huck
From: David Hildenbrand Rename qemu_getrampagesize() to qemu_minrampagesize(). While at it, properly rename find_max_supported_pagesize() to find_min_backend_pagesize(). s390x is actually interested into the maximum ram pagesize, so introduce and use qemu_maxrampagesize(). Add a TODO, indicatin

[Qemu-devel] [PATCH v6 20/21] gdbstub: Implement target halted (? pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 779da2aa77..8838241209 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2248,13 +2248,30 @@ static void handle_gen_set(GdbCmdCont

[Qemu-devel] [PULL 14/19] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-04-25 Thread Cornelia Huck
From: "Jason J. Herne" The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Acked-by: Thomas Huth Message-Id: <1554388475-18329-15-git-send-email-jjhe...@

[Qemu-devel] [PATCH v6 02/21] gdbstub: Implement deatch (D pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-otff-by: Jon Doron --- gdbstub.c | 89 +++ 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3308279fa8..fdad1ac466 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1420,10 +1420,6 @@ static inline int

[Qemu-devel] [PATCH v6 01/21] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 200 ++ 1 file changed, 200 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..3308279fa8 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,206 @@ out: return res; } +typede

[Qemu-devel] [PATCH v6 21/21] gdbstub: Clear unused variables in gdb_handle_packet

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8838241209..32aeefbbe6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2268,17 +2268,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *us

[Qemu-devel] [PULL 17/19] pc-bios/s390: Update firmware images

2019-04-25 Thread Cornelia Huck
From: Thomas Huth s390-ccw.img contains support for booting from vfio-ccw dasd passthrough devices now, and s390-netboot.img is updated since there were changes to the code that is shared between s390-ccw.img and s390-netboot.img. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 3

[Qemu-devel] [PATCH v6 04/21] gdbstub: Implement continue (c pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 29ca6be3df..a38f9d4ef9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1523,6 +1523,16 @@ static void handle_thread_alive(GdbCmdContext *gdb

[Qemu-devel] [PATCH v6 10/21] gdbstub: Implement get register (p pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 50 ++ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 49db09ef52..c439b8e796 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1656,6 +1656,36 @@ static void handle_set_r

Re: [Qemu-devel] [RISU PATCH 3/5] risu_reginfo_i386: implement arch-specific reginfo interface

2019-04-25 Thread Alex Bennée
Jan Bobek writes: > CPU-specific code in risu_reginfo_* is expected to define and export > the following symbols: > > - arch_long_opts, arch_extra_help, process_arch_opt > - reginfo_size > - reginfo_init > - reginfo_is_eq > - reginfo_dump, reginfo_dump_mismatch > > Make risu_reginfo_i386.c impl

[Qemu-devel] [Bug 1825452] Re: Pulse audio backend doesn't work in v4.0.0-rc4 release

2019-04-25 Thread Ivan Volosyuk
It looks like this code relies on the systemd specifics and doesn't work with OpenRC used in Gentoo by default. Still not fixed in 4.0.0 release. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1825452

[Qemu-devel] [PATCH v6 05/21] gdbstub: Implement continue with signal (C pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index a38f9d4ef9..8e922a2df4 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1533,6 +1533,21 @@ static void handle_continue(GdbCmdContext *gd

Re: [Qemu-devel] [PATCH v3 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-04-25 Thread Igor Mammedov
On Thu, 25 Apr 2019 14:37:35 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 4/25/19 7:34 AM, Igor Mammedov wrote: > > once FW provides a pointer to SMBIOS entry point like it does for > > RSDP it should be possible to enable this one the same way. > > > > Signed-off-by: Igor Mammedov >

[Qemu-devel] [PATCH v6 07/21] gdbstub: Implement insert breakpoint (Z pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 33 + 1 file changed, 33 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 83757def9b..8e0446d305 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1589,6 +1589,29 @@ static void handle_set_thread(GdbCmdContext *gdb_ctx, voi

[Qemu-devel] [PATCH v6 06/21] gdbstub: Implement set_thread (H pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 79 ++- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8e922a2df4..83757def9b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1548,6 +1548,47 @@ static void handle_

[Qemu-devel] [PATCH v2] security.rst: add Security Guide to developer docs

2019-04-25 Thread Stefan Hajnoczi
At KVM Forum 2018 I gave a presentation on security in QEMU: https://www.youtube.com/watch?v=YAdRf_hwxU8 (video) https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides) This patch adds a security guide to the developer docs. This document covers things that developers should know about

[Qemu-devel] [PATCH v6 08/21] gdbstub: Implement remove breakpoint (z pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 49 - 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8e0446d305..80f2a92da6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1612,6 +1612,29 @@ static void handle_insert

[Qemu-devel] [PATCH v6 13/21] gdbstub: Implement write all registers (G pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 5b60c1369c..acf0e75908 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1735,6 +1735,29 @@ static void handle_read_mem(GdbCm

[Qemu-devel] [PATCH v6 11/21] gdbstub: Implement write memory (M pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c439b8e796..4522c93fa2 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1686,6 +1686,31 @@ static void handle_get_

[Qemu-devel] [PATCH v6 14/21] gdbstub: Implement read all registers (g pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index acf0e75908..3a7ef5eea6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1758,6 +1758,21 @@ static void handle_write_all_regs(GdbCmdCont

[Qemu-devel] [PATCH v6 12/21] gdbstub: Implement read memory (m pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 48 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 4522c93fa2..5b60c1369c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1711,6 +1711,30 @@ static void handle_write_m

[Qemu-devel] [PATCH v6 15/21] gdbstub: Implement file io (F pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 62 +++ 1 file changed, 40 insertions(+), 22 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 3a7ef5eea6..18949120be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1773,6 +1773,39 @@ static void handle_

[Qemu-devel] [PATCH v6 16/21] gdbstub: Implement step (s pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 18949120be..809503c20a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1806,6 +1806,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx,

Re: [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386

2019-04-25 Thread Alex Bennée
Jan Bobek writes: > Hi all, > > Thanks, > -Jan Bobek > > P.S. This is my first time using git send-email, so please bear with > me if something goes wrong and/or let me know how I can improve > my future submissions. Thank you! Looks good to me. Excellent first patch series ;-) I a

[Qemu-devel] [PATCH v6 17/21] gdbstub: Implement v commands with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 170 +++--- 1 file changed, 110 insertions(+), 60 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 809503c20a..7bc00d7f77 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1816,6 +1816,106 @@ static void handl

[Qemu-devel] [PATCH v6 18/21] gdbstub: Implement generic query (q pkt) with new infra

2019-04-25 Thread Jon Doron
Signed-off-by: Jon Doron --- gdbstub.c | 335 ++ 1 file changed, 335 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 7bc00d7f77..a2db1ec661 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1916,6 +1916,331 @@ static void handle_v_commands(GdbC

  1   2   3   >