On 4/25/19 7:34 AM, Igor Mammedov wrote:
> Instead of just asserting print the error that lead to assert first.
> While at it move assert into rebuild branch, which removes reduntant
"redundant"
> check done in case of !rebuild branch is taken (the later is taken
> care of by g_assert_no_error).
>
> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
> ---
> tests/bios-tables-test.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index f117461..5a5d036 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -199,11 +199,14 @@ static void dump_aml_files(test_data *data, bool
> rebuild)
> sdt->aml, ext);
> fd = g_open(aml_file, O_WRONLY|O_TRUNC|O_CREAT,
> S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);
> + if (fd < 0) {
> + perror(aml_file);
> + }
> + g_assert(fd >= 0);
> } else {
> fd = g_file_open_tmp("aml-XXXXXX", &sdt->aml_file, &error);
> g_assert_no_error(error);
> }
> - g_assert(fd >= 0);
>
> ret = qemu_write_full(fd, sdt->aml, sdt->aml_len);
> g_assert(ret == sdt->aml_len);
>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
