On 25/04/2019 07.57, Thomas Huth wrote: > On 24/04/2019 22.42, Wainer dos Santos Moschetta wrote: >> Hi Thomas, >> >> >> On 04/24/2019 07:37 AM, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do not run the >>> tests during our mandatory "make check" tests yet. Now that we've got >>> a new "ci" group of iotests that should be fine to run in every environ- >>> ment, it should be OK to enable the iotests during "make check" again. >>> Thus we now run the "ci" tests by default from the qemu-iotests-quick.sh >>> script, and only use the former "quick" group (that contains some tests >>> that are failing in some environments) when the user decided to run >>> "make check SPEED=thorough" or something similar. >>> >>> Signed-off-by: Thomas Huth <th...@redhat.com> >>> --- >>> tests/Makefile.include | 2 +- >>> tests/qemu-iotests-quick.sh | 17 ++++++++++++++++- >>> 2 files changed, 17 insertions(+), 2 deletions(-) >> >> One of Patchew's runners failed with this patch series: >> https://patchew.org/QEMU/20190424103747.10173-1-th...@redhat.com/ >> >> I encountered same failures with `make check` locally on Fedora 29 >> x86_64 (pulled latest qemu, and configured with defaults and >> x86_64-softmmu target): >> --- >> Not run: 233 >> Failures: 069 103 114 133 140 143 197 215 226 244 > > Ok, thanks for the info. Looks like many tests are failing because qemu-io > suddenly prints its program name in front of the error messages? E.g.: > > --- /tmp/qemu-test/src/tests/qemu-iotests/069.out 2019-04-24 > 16:52:31.000000000 +0000 > +++ /tmp/qemu-test/build/tests/qemu-iotests/069.out.bad 2019-04-24 > 16:59:13.310226424 +0000 > @@ -4,5 +4,5 @@ > > Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=131072 > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072 > backing_file=TEST_DIR/t.IMGFMT.base > -can't open device TEST_DIR/t.IMGFMT: Could not open backing file: Could not > open 'TEST_DIR/t.IMGFMT.base': No such file or directory > +qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing file: > Could not open 'TEST_DIR/t.IMGFMT.base': No such file or directory > > Does anybody from the block folks has a clue what might be going wrong here?
It's a regression in the current master branch, not caused by my series. The iotests also fail with vanilla master, e.g. reproducible with: cd tests/qemu-iotests ./check -qcow2 069 It's caused by Christophe's commit here: 99e98d7c9fc1a1639fad2c638733b02f4b43aebe qemu-io: Use error_[gs]et_progname() Christophe, could you please have a look? Thanks, Thomas
