On Wed, 17 Apr 2019 13:31:41 +0200 David Hildenbrand <da...@redhat.com> wrote:
> While the detection on s390x of the maximum ram pagesize works by pure luck, > we should try to do better. Especially, once "-mem-path" is replaced > by memory backends, the current approach will break. > > Configure the maximum page size after configuring initital memory. Provide > a function to detect the maximum ram pagesize > > I think this can be deferred to 4.1 as I don't think anything is actually > broken right now. > > v2 -> v3: > - Fix compile error > - Tested that hugepages correctly result in an error with > "modprobe kvm hpage=0", but not with "modprobe kvm hpage=1". > > v1 -> v2: > - Add a better comment describing that only initial memory is considered > - Add "exec: Introduce qemu_getmaxrampagesize() and rename > qemu_getrampagesize()" > > David Hildenbrand (2): > s390x/kvm: Configure page size after memory has actually been > initialized > exec: Introduce qemu_maxrampagesize() and rename qemu_getrampagesize() > > exec.c | 44 ++++++++++++++++++++++++++++++++++---- > hw/ppc/spapr_caps.c | 4 ++-- > hw/s390x/s390-virtio-ccw.c | 12 +++++++++++ > hw/vfio/spapr.c | 2 +- > include/exec/ram_addr.h | 3 ++- > target/ppc/kvm.c | 2 +- > target/s390x/cpu.c | 7 ++++++ > target/s390x/cpu.h | 1 + > target/s390x/kvm-stub.c | 4 ++++ > target/s390x/kvm.c | 35 ++++++++++++------------------ > target/s390x/kvm_s390x.h | 1 + > 11 files changed, 85 insertions(+), 30 deletions(-) > Thanks, applied.
