[Qemu-devel] [PATCH 08/13] kvm: x86: Inject pending MCE events on state writeback

2011-02-15 Thread Jan Kiszka
The current way of injecting MCE events without updating of and synchronizing with the CPUState is broken and causes spurious corruptions of the MCE-related parts of the CPUState. As a first step towards a fix, enhance the state writeback code with support for injecting events that are pending in

[Qemu-devel] [PATCH 06/13] Synchronize VCPU states before reset

2011-02-15 Thread Jan Kiszka
This is required to support keeping VCPU states across a system reset. If we do not read the current state before the reset, cpu_synchronize_all_post_reset may write back incorrect state information. The first user of this will be MCE MSR synchronization which currently works around the missing cp

[Qemu-devel] [PATCH 10/13] kvm: x86: Clean up kvm_setup_mce

2011-02-15 Thread Jan Kiszka
There is nothing to abstract here. Fold kvm_setup_mce into its caller and fix up the error reporting (return code of kvm_vcpu_ioctl holds the error value). Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/kvm.c | 11 --- 1 files changed, 4

[Qemu-devel] [PATCH 00/13] [uq/master] Patch queue, part IV (MCE edition)

2011-02-15 Thread Jan Kiszka
And the show goes on: This 4th round contains a rework of the MCE handling, mostly for KVM, but also few bits used in emulation mode are affected. Major contributions are: - fixed MCE injection race with other events - kick VCPU out of halt on asynchronous MCEs - unified TCG and KVM MCE injectio

[Qemu-devel] [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection code

2011-02-15 Thread Jan Kiszka
This switches KVM's MCE injection path to cpu_x86_inject_mce, both for SIGBUS and monitor initiated events. This means we prepare the MCA MSRs in the VCPUState also for KVM. We have to drop the MSRs writeback restrictions for this purpose which is now safe as every uncoordinated MSR injection is r

[Qemu-devel] [PATCH 05/13] x86: Optionally avoid injecting AO MCEs while others are pending

2011-02-15 Thread Jan Kiszka
Allow to tell cpu_x86_inject_mce that it should ignore Action Optional MCE events when the target VCPU is still processing another one. This will be used by KVM soon. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- monitor.c|7 +-- target-i

[Qemu-devel] [PATCH 12/13] Add qemu_ram_remap

2011-02-15 Thread Jan Kiszka
From: Huang Ying qemu_ram_remap() unmaps the specified RAM pages, then re-maps these pages again. This is used by KVM HWPoison support to clear HWPoisoned page tables across guest rebooting, so that a new page may be allocated later to recover the memory error. [ Jan: style fixlets ] Signed-of

[Qemu-devel] [PATCH 01/13] x86: Account for MCE in cpu_has_work

2011-02-15 Thread Jan Kiszka
MCEs can be injected asynchronously, so they can also terminate the halt state. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/exec.h | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/target-i386/exec.h b/targe

[Qemu-devel] [PATCHv2] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-15 Thread Tristan Gingold
Handle option '-icount X' on powerpc targets. Signed-off-by: Tristan Gingold --- target-ppc/translate_init.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 907535e.

[Qemu-devel] [PATCH 02/13] x86: Perform implicit mcg_status reset

2011-02-15 Thread Jan Kiszka
Reorder mcg_status in CPUState to achive automatic clearing on reset. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/cpu.h|3 ++- target-i386/helper.c |2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target-i386/cp

[Qemu-devel] [PATCH 13/13] KVM, MCE, unpoison memory address across reboot

2011-02-15 Thread Jan Kiszka
From: Huang Ying In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If the error physical memory p

[Qemu-devel] [PATCH 07/13] kvm: x86: Move MCE functions together

2011-02-15 Thread Jan Kiszka
Pure function suffling to avoid multiple #ifdef KVM_CAP_MCE sections, no functional changes. While at it, annotate some #ifdef sections. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/kvm.c | 346 ++

[Qemu-devel] [PATCH 03/13] x86: Small cleanups of MCE helpers

2011-02-15 Thread Jan Kiszka
Fix some code style issues, use proper headers, and align to cpu_x86 naming scheme. No functional changes. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- cpu-all.h|4 monitor.c|2 +- target-i386/cpu.h|5 + targ

[Qemu-devel] [PATCH 04/13] x86: Refine error reporting of MCE injection services

2011-02-15 Thread Jan Kiszka
As this service is used by the human monitor, make sure that errors get reported to the right channel, and also raise the verbosity. This requires to move Monitor typedef in qemu-common.h to resolve the include dependency. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Don

[Qemu-devel] [PATCH] ppc: init_excp_7x0: fix hreset entry point.

2011-02-15 Thread Tristan Gingold
From: gingold According to the PowePC 750 user's manual, the vector offset for system reset (both /HRESET and /SRESET) is 0x00100. Signed-off-by: Tristan Gingold --- target-ppc/translate_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/translate_init.

[Qemu-devel] [PATCH] gdbstub/ppc: handle read and write of fpscr

2011-02-15 Thread Tristan Gingold
From: Fabien Chouteau Although the support of this register may be uncomplete, there are no reason to prevent the debugger from reading or writing it. Signed-off-by: Tristan Gingold --- gdbstub.c |5 +++-- target-ppc/translate_init.c |5 ++--- 2 files changed, 5 inser

[Qemu-devel] [PATCH 11/13] kvm: x86: Fail kvm_arch_init_vcpu if MCE initialization fails

2011-02-15 Thread Jan Kiszka
There is no reason to continue if the kernel claims to support MCE but then fails to process our request. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/kvm.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-15 Thread Kevin Wolf
Am 14.02.2011 20:34, schrieb Anthony Liguori: > On 02/14/2011 12:34 PM, Luiz Capitulino wrote: >> On Mon, 14 Feb 2011 08:39:11 -0600 >> Anthony Liguori wrote: >> >> >>> On 02/14/2011 06:45 AM, Luiz Capitulino wrote: >>> So the question is: how does the schema based design support ex

Re: [Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 14.02.2011 19:12, Peter Maydell wrote: > On 11 February 2011 15:10, wrote: >> +uint32_t HELPER(neon_rshl_s32)(uint32_t valop, uint32_t shiftop) >> +{ >> +int32_t dest; >> +int32_t val = (int32_t)valop; >> +int8_t shift = (int8_t)shiftop; >> +if (shift >= 32) { >> +dest

Re: [Qemu-devel] [PATCH 06/10] vmmouse: convert to qdev

2011-02-15 Thread Markus Armbruster
Anthony Liguori writes: > On 02/12/2011 11:03 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >> >>> Convert to qdev, also add a proper reset function. [...] >> Pointer properties are for dirty hacks only. Is there really no better >> solution? Why does it have to be a property? >>

[Qemu-devel] [PATCH] tracetool: Add optional argument to specify dtrace probe names

2011-02-15 Thread Jes . Sorensen
From: Jes Sorensen Optional feature allowing a user to generate the probe list to match the name of the binary, in case they wish to install qemu under a different name than qemu-{system,user}, Signed-off-by: Jes Sorensen --- scripts/tracetool | 14 ++ 1 files changed, 10 inserti

Re: [Qemu-devel] [PATCH] gdbstub/ppc: handle read and write of fpscr

2011-02-15 Thread Peter Maydell
On 15 February 2011 08:59, Tristan Gingold wrote: > @@ -770,7 +770,8 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t > *mem_buf, int n) >             /* fpscr */ >             if (gdb_has_xml) >                 return 0; > -            return 4; > +            env->fpscr = ldtul_p(mem

Re: [Qemu-devel] [PATCH 05/10] vmport: convert to qdev

2011-02-15 Thread Markus Armbruster
Blue Swirl writes: > On Sat, Feb 12, 2011 at 6:57 PM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> Signed-off-by: Blue Swirl >>> --- >>>  hw/pc.h      |    1 - >>>  hw/pc_piix.c |    2 -- >>>  hw/vmport.c  |   24 +--- >>>  3 files changed, 21 insertions(+), 6 delet

Re: [Qemu-devel] [PATCH] gdbstub/ppc: handle read and write of fpscr

2011-02-15 Thread Tristan Gingold
On Feb 15, 2011, at 11:22 AM, Peter Maydell wrote: > On 15 February 2011 08:59, Tristan Gingold wrote: >> @@ -770,7 +770,8 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t >> *mem_buf, int n) >> /* fpscr */ >> if (gdb_has_xml) >> return 0; >> -

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Amit Shah
On (Mon) 14 Feb 2011 [16:18:10], Anthony Liguori wrote: > On 02/14/2011 11:56 AM, Chris Wright wrote: > >Please send in any agenda items you are interested in covering. > > -rc2 is tagged and waiting for announcement. Please take a look at > -rc2 and make sure there is nothing critical missing.

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Avi Kivity
On 02/15/2011 12:18 AM, Anthony Liguori wrote: On 02/14/2011 11:56 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. -rc2 is tagged and waiting for announcement. Please take a look at -rc2 and make sure there is nothing critical missing. Will tag 0.14.0

[Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
Make smpboot available not only for Linux but for all setups. Signed-off-by: Adam Lackorzynski --- hw/arm_boot.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/arm_boot.c b/hw/arm_boot.c index 620550b..a68b396 100644 --- a/hw/arm_boot.c +++ b/hw/arm_b

[Qemu-devel] [PATCH 2/3] target-arm: Fix soft interrupt in GIC distributor

2011-02-15 Thread Adam Lackorzynski
Fix selection of target list filter mode. Signed-off-by: Adam Lackorzynski --- hw/arm_gic.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index e6b1953..0e934ec 100644 --- a/hw/arm_gic.c +++ b/hw/arm_gic.c @@ -549,10 +549,10 @@ static voi

[Qemu-devel] [PATCH 3/3] target-arm: Implement cp15 VA->PA translation

2011-02-15 Thread Adam Lackorzynski
Implement VA->PA translations by cp15-c7 that went through unchanged previously. Signed-off-by: Adam Lackorzynski --- target-arm/cpu.h|1 + target-arm/helper.c | 51 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/tar

Re: [Qemu-devel] NBD block device backend - 'improvements'

2011-02-15 Thread Kevin Wolf
Am 14.02.2011 21:32, schrieb Stefan Hajnoczi: > On Mon, Feb 14, 2011 at 7:40 PM, Nicholas Thomas wrote: >> I've written a patch that changes the behaviour - instead of exiting at >> startup, we wait for the NBD connection to be established, and we hang >> on reads and writes until the connection i

[Qemu-devel] [FYI] memory leak in 0.14.0rc1 ?

2011-02-15 Thread Torsten Förtsch
Hi, perhaps this is the wrong list. If so then please accept my apology. I am trying out the opensuse kvm rpm from the Virtualization repository: http://download.opensuse.org/repositories/Virtualization/openSUSE_11.3/x86_64/kvm-0.14.0.rc1-67.1.x86_64.rpm I have installed winxp and run the ma

[Qemu-devel] Re: [PATCH] tracetool: Add optional argument to specify dtrace probe names

2011-02-15 Thread Stefan Hajnoczi
On Tue, Feb 15, 2011 at 11:10:22AM +0100, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Optional feature allowing a user to generate the probe list to match > the name of the binary, in case they wish to install qemu under a > different name than qemu-{system,user}, > > Signed-off-by:

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Markus Armbruster
Anthony Liguori writes: > On 02/14/2011 11:56 AM, Chris Wright wrote: >> Please send in any agenda items you are interested in covering. >> > > - QAPI and QMP events > - qdev future Do we need a qdev tree and a maintainer for it? > > I don't really have a coherent plan for the second on

[Qemu-devel] [PATCH v2] tracetool: Add optional argument to specify dtrace probe names

2011-02-15 Thread Jes . Sorensen
From: Jes Sorensen Optional feature allowing a user to generate the probe list to match the name of the binary, in case they wish to install qemu under a different name than qemu-{system,user}, Signed-off-by: Jes Sorensen --- scripts/tracetool | 21 ++--- 1 files changed, 14

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 10:48, Adam Lackorzynski wrote: > Make smpboot available not only for Linux but for all setups. I'm not convinced about this. I think if you're providing a raw image for an SMP system (rather than a Linux kernel) then it's your job to provide an image which handles the bootup

Re: [Qemu-devel] [PATCH v2] tracetool: Add optional argument to specify dtrace probe names

2011-02-15 Thread Stefan Hajnoczi
On Tue, Feb 15, 2011 at 12:34 PM, wrote: > From: Jes Sorensen > > Optional feature allowing a user to generate the probe list to match > the name of the binary, in case they wish to install qemu under a > different name than qemu-{system,user}, > > Signed-off-by: Jes Sorensen > --- >  scripts/t

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: > On 15 February 2011 10:48, Adam Lackorzynski > wrote: > > Make smpboot available not only for Linux but for all setups. > > I'm not convinced about this. I think if you're providing a raw > image for an SMP system (rather than a Linu

[Qemu-devel] [PATCH 1/2] pxa2xx_keypad: enhance emulation of KPAS, KPASMKP regs

2011-02-15 Thread Vasily Khoruzhick
Add emulation of KPAS register and proper emulation of KPASMKP regs, so now driver supports multipresses and properly works with Linux driver. Signed-off-by: Vasily Khoruzhick --- hw/pxa2xx_keypad.c | 114 1 files changed, 62 insertions(+), 5

[Qemu-devel] [PATCH 2/2] pxa2xx_keypad: Handle 0xe0xx keycodes

2011-02-15 Thread Vasily Khoruzhick
Add handling of 0xe0xx keycodes to pxa2xx_driver. Extended keycodes in keymap should be marked with most significant bit set (i.e. 0x80). Without this patch it's not possible to handle i.e. cursor keys. Signed-off-by: Vasily Khoruzhick --- hw/pxa2xx_keypad.c | 10 ++ 1 files changed, 1

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-15 Thread Luiz Capitulino
On Mon, 14 Feb 2011 14:15:27 -0600 Anthony Liguori wrote: > On 02/14/2011 01:58 PM, Luiz Capitulino wrote: > > No, of course not, our plan has always been to do this via an schema, > > the only reason we don't do this today is lack of time/help. > > > > > > Understood--I'm here to help now :

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 13:12, Adam Lackorzynski wrote: > > On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: >> On 15 February 2011 10:48, Adam Lackorzynski >> wrote: >> > Make smpboot available not only for Linux but for all setups. >> >> I'm not convinced about this. I think if you're p

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-15 Thread Luiz Capitulino
On Tue, 15 Feb 2011 10:20:01 +0100 Kevin Wolf wrote: > Am 14.02.2011 20:34, schrieb Anthony Liguori: > > On 02/14/2011 12:34 PM, Luiz Capitulino wrote: > >> On Mon, 14 Feb 2011 08:39:11 -0600 > >> Anthony Liguori wrote: > >> > >> > >>> On 02/14/2011 06:45 AM, Luiz Capitulino wrote: > >>>

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Gleb Natapov
On Mon, Feb 14, 2011 at 01:54:41PM -0600, Anthony Liguori wrote: > On 02/14/2011 11:56 AM, Chris Wright wrote: > >Please send in any agenda items you are interested in covering. > > - QAPI and QMP events > - qdev future > Making new Seabios stable release for qemu-0.14? --

[Qemu-devel] [PATCH 00/10] Fix Neon shift instructions

2011-02-15 Thread Peter Maydell
This patch series fixes bugs in the Neon shift instructions VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN, VRSHL, and VQRSHL. It is based on the v3 patchset Christophe sent recently, with some fixes for minor nits in those patches, plus some patches from me which fix problems with

[Qemu-devel] [PATCH 10/10] target-arm: Fix shift by immediate and narrow where src, dest overlap

2011-02-15 Thread Peter Maydell
For Neon shifts by immediate and narrow, correctly handle the case where the source registers and the destination registers overlap (the second pass should use the original register contents, not the results of the first pass). Signed-off-by: Peter Maydell --- target-arm/translate.c | 38 +

[Qemu-devel] [PATCH 03/10] target-arm: Fix unsigned VRSHL.s8 and .s16 right shifts by type width

2011-02-15 Thread Peter Maydell
From: Christophe Lyon Fix handling of unsigned VRSHL.s8 and .s16 right shifts by the type width. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-a

[Qemu-devel] [PATCH 05/10] target-arm: Fix saturated values for Neon right shifts

2011-02-15 Thread Peter Maydell
Fix value returned by signed 8 and 16 bit qrshl helpers when the result has saturated. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index a8885fa..7859f0b

[Qemu-devel] [PATCH 08/10] target-arm: Fix signed VQRSHL by large shift counts

2011-02-15 Thread Peter Maydell
Handle the case of signed VQRSHL by a shift count of the width of the data type or larger, which must be special cased in the qrshl_s* helper functions. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 34 +++--- 1 files changed, 31 insertions(+), 3 delet

[Qemu-devel] [PATCH 07/10] target-arm: fix decoding of Neon 64 bit shifts.

2011-02-15 Thread Peter Maydell
From: Christophe Lyon Fix decoding of 64 bits variants of VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN, taking into account whether inputs are unsigned or not. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell --- target-arm/translate.c | 45 ++--

[Qemu-devel] [PATCH 06/10] target-arm: fix Neon VQSHRN and VSHRN.

2011-02-15 Thread Peter Maydell
From: Christophe Lyon Call the normal shift helpers instead of the rounding ones. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c in

[Qemu-devel] [PATCH 04/10] target-arm: fix unsigned 64 bit right shifts.

2011-02-15 Thread Peter Maydell
From: Christophe Lyon Fix range of shift amounts which always give 0 as result. Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell --- target-arm/neon_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c

[Qemu-devel] [PATCH 01/10] target-arm: Fix rounding constant addition for Neon shifts

2011-02-15 Thread Peter Maydell
From: Christophe Lyon Handle cases where adding the rounding constant could overflow in Neon shift instructions: VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN. Signed-off-by: Christophe Lyon [peter.mayd...@linaro.org: fix handling of large shifts in rshl_s32, calculate signed saturated value as other

Re: [Qemu-devel] [PATCH 2/6] target-arm: fix Neon right shifts with shift amount == input width.

2011-02-15 Thread Christophe Lyon
>> -dest = src1 >> (tmp - 1); \ >> +dest = src1 >> (-tmp - 1); \ >> dest++; \ >> dest >>= 1; \ > > Again, these three lines have the same effect as dest = 0, > so we can fold into the previous if(). > >> } else if (tmp < 0) { \ >> @@ -594,7 +594,7 @@ uint64_t

[Qemu-devel] [PATCH 02/10] target-arm: Fix signed VRSHL by large shift counts

2011-02-15 Thread Peter Maydell
Correctly handle VRSHL of signed values by a shift count of the width of the data type or larger, which must be special-cased in the rshl_s* helper functions. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 17 +++-- 1 files changed, 3 insertions(+), 14 deletions(-) di

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Anthony Liguori
On 02/15/2011 06:11 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/14/2011 11:56 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - QAPI and QMP events - qdev future Do we need a qdev tree and a maintainer for

[Qemu-devel] [PATCH 09/10] target-arm: Fix unsigned VQRSHL by large shift counts

2011-02-15 Thread Peter Maydell
Correctly handle VQRSHL of unsigned values by a shift count of the width of the data type or larger, which must be special-cased in the qrshl_u* helper functions. Signed-off-by: Peter Maydell --- target-arm/neon_helper.c | 37 ++--- 1 files changed, 34 insertion

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 14.02.2011 19:18, Peter Maydell wrote: > On 11 February 2011 15:10, wrote: >> From: Christophe Lyon >> >> This patch series provides fixes such that ARM Neon instructions >> VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now >> pass all my tests. >> >> I have reworked all the

What's QAPI? (was: [Qemu-devel] [RFC] qapi: events in QMP)

2011-02-15 Thread Markus Armbruster
Anthony Liguori writes: > Hi, > > In my QAPI branch[1], I've now got almost every existing QMP command > converted with (hopefully) all of the hard problems solved. There is > only one remaining thing to attack before posting for inclusion and > that's events. Here's my current thinking about w

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Anthony Liguori
On 02/15/2011 04:44 AM, Avi Kivity wrote: On 02/15/2011 12:18 AM, Anthony Liguori wrote: On 02/14/2011 11:56 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. -rc2 is tagged and waiting for announcement. Please take a look at -rc2 and make sure there is

Re: [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.

2011-02-15 Thread Christophe Lyon
>> @@ -924,7 +924,11 @@ uint32_t HELPER(neon_qrshl_s32)(CPUState *env, uint32_t >> valop, uint32_t shiftop) >> dest = val << shift; >> if ((dest >> shift) != val) { >> SET_QC(); >> -dest = (uint32_t)(1 << (sizeof(val) * 8 - 1)) - (val > 0 ? 1 : >> 0); >> +

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Avi Kivity
On 02/15/2011 03:58 PM, Anthony Liguori wrote: On 02/15/2011 04:44 AM, Avi Kivity wrote: On 02/15/2011 12:18 AM, Anthony Liguori wrote: On 02/14/2011 11:56 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. -rc2 is tagged and waiting for announcement. Pl

[Qemu-devel] Re: What's QAPI?

2011-02-15 Thread Anthony Liguori
On 02/15/2011 08:07 AM, Markus Armbruster wrote: Anthony Liguori writes: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining thing to attack before posting for inclusion and that'

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Peter Maydell
On 15 February 2011 14:03, Christophe Lyon wrote: > It also seems that the neon_shl_s* helpers don't handle correctly large > negative shift amounts. They look OK to me (large -ve shift is a huge right shift, which for signed values should propagate the sign bit to all bit positions, so we shift

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-15 Thread Dushyant Bansal
Hrm. This means that your kernel headers in /usr/include/linux are too old. Can you try and find out which kernel version they are from please Yes, kernel headers version is 2.6.32. For the time being, I copied some of the header files from kvm/arch/powerpc/include/asm/ to kernel hea

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
On Tue Feb 15, 2011 at 13:37:44 +, Peter Maydell wrote: > On 15 February 2011 13:12, Adam Lackorzynski > wrote: > > > > On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: > >> On 15 February 2011 10:48, Adam Lackorzynski > >> wrote: > >> > Make smpboot available not only for Linux

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: ‘struct kvm_sregs’ has no member named ‘pvr’

2011-02-15 Thread Alexander Graf
On 15.02.2011, at 15:21, Dushyant Bansal wrote: > Hrm. This means that your kernel headers in /usr/include/linux are too old. Can you try and find out which kernel version they are from please >>> Yes, kernel headers version is 2.6.32. For the time being, I copied so

Re: [Qemu-devel] [FYI] memory leak in 0.14.0rc1 ?

2011-02-15 Thread Stefan Hajnoczi
2011/2/15 Torsten Förtsch : > I am trying out the opensuse kvm rpm from the Virtualization repository: > >  http://download.opensuse.org/repositories/Virtualization/openSUSE_11.3/x86_64/kvm-0.14.0.rc1-67.1.x86_64.rpm > > I have installed winxp and run the machine as "/usr/bin/qemu-kvm -name xp.home

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 15.02.2011 15:21, Peter Maydell wrote: > On 15 February 2011 14:03, Christophe Lyon wrote: >> It also seems that the neon_shl_s* helpers don't handle correctly large >> negative shift amounts. > > They look OK to me (large -ve shift is a huge right shift, > which for signed values should prop

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 14 Feb 2011 13:34:11 -0600 > Anthony Liguori wrote: > >> On 02/14/2011 12:34 PM, Luiz Capitulino wrote: >> > On Mon, 14 Feb 2011 08:39:11 -0600 >> > Anthony Liguori wrote: >> > >> > >> >> On 02/14/2011 06:45 AM, Luiz Capitulino wrote: >> >> >> >>> So

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Vincent Palatin
Hi Adam, >> Moving in the right direction, but it would be cleaner if the secondary >> CPU reset was handled inside arm_boot.c, I think (there is a TODO >> in that file to that effect). Then we could get rid of the cpu reset >> hook from realview.c. > > Like the following? This assumes that all t

[Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: 'struct kvm_sregs' has no member named 'pvr'

2011-02-15 Thread Dushyant Bansal
On Tuesday 15 February 2011 08:03 PM, Alexander Graf wrote: On 15.02.2011, at 15:21, Dushyant Bansal wrote: Hrm. This means that your kernel headers in /usr/include/linux are too old. Can you try and find out which kernel version they are from please Yes, kernel header

Re: [Qemu-devel] KVM call agenda for Feb 15

2011-02-15 Thread Stefan Hajnoczi
On Mon, Feb 14, 2011 at 10:18 PM, Anthony Liguori wrote: > On 02/14/2011 11:56 AM, Chris Wright wrote: >> >> Please send in any agenda items you are interested in covering. >> > > -rc2 is tagged and waiting for announcement.  Please take a look at -rc2 and > make sure there is nothing critical mis

Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add description fields for qdev properties

2011-02-15 Thread Anthony Liguori
On 02/04/2011 12:18 AM, Amit Shah wrote: Document the parameters for the virtserialport and virtioconsole devices. Example: $ ./x86_64-softmmu/qemu-system-x86_64 -device virtserialport,? virtserialport.nr=uint32, The 'number' for the port for \ predictable port numbers. Use this to spawn ports

Re: [Qemu-devel] [PATCH REBASE/RESEND 0/4] Auto-document qdev devices

2011-02-15 Thread Anthony Liguori
On 02/04/2011 12:18 AM, Amit Shah wrote: Hello, This is yet another rebase of the patchset I'd sent earlier. The usual notes apply: this is just the start, just getting the framework in place and a few examples so that people can then pick up and start documenting their devices and options. We

[Qemu-devel] Re: What's QAPI?

2011-02-15 Thread Anthony Liguori
On 02/15/2011 08:07 AM, Markus Armbruster wrote: Anthony Liguori writes: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining thing to attack before posting for inclusion and that'

[Qemu-devel] KVM call minutes for Feb 15

2011-02-15 Thread Chris Wright
QAPI and QMP - Anthony adding a new wiki page to describe all of this - specified in formal schema using JSON - includes documenation in javadoc-like syntax - can generate api (possibly protocol) docs - documenting each command and expected errors - creates marshalling functions and C interfa

[Qemu-devel] [PATCHv2 1/3] e1000: multi-buffer packet support

2011-02-15 Thread Michael S. Tsirkin
e1000 supports multi-buffer packets larger than rxbuf_size. This fixes the following (on linux): - in guest: ifconfig eth1 mtu 16110 - in host: ifconfig tap0 mtu 16110 ping -s 16082 Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi --- hw/e1000.c | 39 +++

[Qemu-devel] [PATCHv2 2/3] e1000: clear EOP for multi-buffer descriptors

2011-02-15 Thread Michael S. Tsirkin
The e1000 spec says: if software statically allocates buffers, and uses memory read to check for completed descriptors, it simply has to zero the status byte in the descriptor to make it ready for reuse by hardware. This is not a hardware requirement (moving the hardware tail pointer is), but is ne

[Qemu-devel] [PATCHv2 0/3] e1000: multi-buffer packet support

2011-02-15 Thread Michael S. Tsirkin
e1000 supports multi-buffer packets larger than rxbuf_size. This fixes the following (on linux): - in guest: ifconfig eth1 mtu 16110 - in host: ifconfig tap0 mtu 16110 ping -s 16082 Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205 Changes from v1: fix buff

[Qemu-devel] [PATCHv2 3/3] e1000: verify we have buffers, upfront

2011-02-15 Thread Michael S. Tsirkin
The spec says: Any descriptor with a non-zero status byte has been processed by the hardware, and is ready to be handled by the software. Thus, once we change a descriptor status to non-zero we should never move the head backwards and try to reuse this descriptor from hardware. This actually happ

[Qemu-devel] Re: [PATCH 00/10] Fix Neon shift instructions

2011-02-15 Thread Christophe Lyon
On 15.02.2011 14:44, Peter Maydell wrote: > This patch series fixes bugs in the Neon shift instructions > VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN, > VRSHL, and VQRSHL. It is based on the v3 patchset Christophe > sent recently, with some fixes for minor nits in those patches,

Re: [Qemu-devel] [PATCH REBASE/RESEND 1/4] qdev: Add a description field for qdev properties for documentation

2011-02-15 Thread Anthony Liguori
On 02/04/2011 12:18 AM, Amit Shah wrote: Add a 'description' along with each qdev property to document the input each qdev property takes. Signed-off-by: Amit Shah Acked-by: Markus Armbruster --- block_int.h | 14 hw/a9mpcore.c |2 +- hw/acpi_piix4.c

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-15 Thread Blue Swirl
On Mon, Feb 14, 2011 at 11:47 PM, Anthony Liguori wrote: > On 02/14/2011 03:25 PM, Blue Swirl wrote: >> >> I'd still like to have the inline wrapper over the factory interface, >> probably with similar signature to isa_serial_new. Then there would be >> two functions, one going through qdev and th

Re: [Qemu-devel] [FYI] memory leak in 0.14.0rc1 ?

2011-02-15 Thread Torsten Förtsch
On Tuesday, February 15, 2011 15:43:32 Stefan Hajnoczi wrote: > > I have installed winxp and run the machine as "/usr/bin/qemu-kvm -name > > xp.home -m 768 ...". > > Are you able to try QEMU 0.14.0-rc2 from source? > > $ git clone git://git.qemu.org/qemu.git > $ git checkout v0.14.0-rc2 > $ ./con

Re: [Qemu-devel] [PATCH 06/10] vmmouse: convert to qdev

2011-02-15 Thread Blue Swirl
On Tue, Feb 15, 2011 at 12:07 PM, Markus Armbruster wrote: > Anthony Liguori writes: > >> On 02/12/2011 11:03 AM, Markus Armbruster wrote: >>> Blue Swirl  writes: >>> >>> Convert to qdev, also add a proper reset function. > [...] >>> Pointer properties are for dirty hacks only.  Is there rea

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
Hi, On Tue Feb 15, 2011 at 10:02:05 -0500, Vincent Palatin wrote: > >> Moving in the right direction, but it would be cleaner if the secondary > >> CPU reset was handled inside arm_boot.c, I think (there is a TODO > >> in that file to that effect). Then we could get rid of the cpu reset > >> hook

Re: [Qemu-devel] [PATCH 05/10] vmport: convert to qdev

2011-02-15 Thread Blue Swirl
On Tue, Feb 15, 2011 at 12:22 PM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Sat, Feb 12, 2011 at 6:57 PM, Markus Armbruster wrote: >>> Blue Swirl writes: >>> Signed-off-by: Blue Swirl ---  hw/pc.h      |    1 -  hw/pc_piix.c |    2 --  hw/vmport.c  |   24 +

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 15:02, Vincent Palatin wrote: > This assumes that all the ARM SMP platforms are booting their > secondary CPU the same way as the emulated Realview. > For example, I'm currently writing a Tegra2 (dual A9) SoC emulation > and the second CPU is halted when the platform starts and

Re: [Qemu-devel] [PATCH 06/10] vmmouse: convert to qdev

2011-02-15 Thread Blue Swirl
On Tue, Feb 15, 2011 at 7:22 PM, Blue Swirl wrote: > On Tue, Feb 15, 2011 at 12:07 PM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On 02/12/2011 11:03 AM, Markus Armbruster wrote: Blue Swirl  writes: > Convert to qdev, also add a proper reset function. >> [...]

[Qemu-devel] [PATCH] linux-user: Support the epoll syscalls

2011-02-15 Thread Peter Maydell
Support the epoll family of syscalls: epoll_create(), epoll_create1(), epoll_ctl(), epoll_wait() and epoll_pwait(). Note that epoll_create1() and epoll_pwait() are later additions, so we have to test separately in configure for their presence. Signed-off-by: Peter Maydell --- configure

[Qemu-devel] [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD

2011-02-15 Thread Marcelo Tosatti
Note: to be applied to uq/master. In icount mode, halt emulation should take into account the nearest event when sleeping. Signed-off-by: Marcelo Tosatti Reported-and-tested-by: "Edgar E. Iglesias" diff --git a/cpus.c b/cpus.c index 468544c..21c3eba 100644 --- a/cpus.c +++ b/cpus.c @@ -770,7

[Qemu-devel] Re: [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD

2011-02-15 Thread Jan Kiszka
On 2011-02-15 18:54, Marcelo Tosatti wrote: > > Note: to be applied to uq/master. > > In icount mode, halt emulation should take into account the nearest event > when sleeping. > > Signed-off-by: Marcelo Tosatti > Reported-and-tested-by: "Edgar E. Iglesias" > > diff --git a/cpus.c b/cpus.c >

[Qemu-devel] Re: Comparing New Image Formats: FVD vs. QED

2011-02-15 Thread Chunqiang Tang
> Chunqiang Tang/Watson/IBM wrote on 01/28/2011 05:13:27 PM: > As you requested, I set up a wiki page for FVD at http://wiki.qemu.org/Features/FVD > . It includes a summary of FVD, a detailed specification of FVD, and a > comparison of the design and performance of FVD and QED. > See the figure

[Qemu-devel] Re: [PATCH] fix halt emulation with icount and CONFIG_IOTHREAD

2011-02-15 Thread Marcelo Tosatti
On Tue, Feb 15, 2011 at 07:58:53PM +0100, Jan Kiszka wrote: > On 2011-02-15 18:54, Marcelo Tosatti wrote: > > > > Note: to be applied to uq/master. > > > > In icount mode, halt emulation should take into account the nearest event > > when sleeping. > > > > Signed-off-by: Marcelo Tosatti > > Re

[Qemu-devel] Is this an invalid combination?

2011-02-15 Thread Bruce Rogers
Hi, We just noticed an issue flagged by a libvirt based test. This same command line didn't used to fail, and I wanted to be sure that this is behaving as intended. When the following command line is used on the current qemu version: x86_64-softmmu/qemu-system-x86_64 -kernel /boot/vmlinuz -d

[Qemu-devel] [PATCH 1/2] linux-user: add rmdir() strace

2011-02-15 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- linux-user/strace.c| 12 linux-user/strace.list |3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 183..05277c0 100644 --- a/linux-user/strace.c +++ b/linux-user/strac

[Qemu-devel] [PATCH 2/2] linux-user: in linux-user/strace.c, tswap() is useless

2011-02-15 Thread Laurent Vivier
Syscall parameters are already swapped by the caller. This patch removes useless tswap() from strace.c $ QEMU_STRACE=1 chroot /m68k mknod myramdisk b 1 1 with tswap() ... 29944 mknod("myramdisk",02663020) = 0 ... without tswap() ... 30042 mknod("myramdisk",S_IFBLK|0666,makedev(1,1)) = 0 ...

Re: [Qemu-devel] [FYI] memory leak in 0.14.0rc1 ?

2011-02-15 Thread Stefan Hajnoczi
2011/2/15 Torsten Förtsch : > On Tuesday, February 15, 2011 15:43:32 Stefan Hajnoczi wrote: >> > I have installed winxp and run the machine as "/usr/bin/qemu-kvm -name >> > xp.home -m 768 ...". >> >> Are you able to try QEMU 0.14.0-rc2 from source? >> >> $ git clone git://git.qemu.org/qemu.git >> $

Re: [Qemu-devel] Is this an invalid combination?

2011-02-15 Thread Anthony Liguori
On 02/15/2011 02:07 PM, Bruce Rogers wrote: Hi, We just noticed an issue flagged by a libvirt based test. This same command line didn't used to fail, and I wanted to be sure that this is behaving as intended. When the following command line is used on the current qemu version: x86_64-softmm

Re: [Qemu-devel] Is this an invalid combination?

2011-02-15 Thread Gleb Natapov
On Tue, Feb 15, 2011 at 02:21:41PM -0600, Anthony Liguori wrote: > On 02/15/2011 02:07 PM, Bruce Rogers wrote: > >Hi, > > > >We just noticed an issue flagged by a libvirt based test. This same command > >line didn't used to fail, and I wanted to be sure that this is behaving as > >intended. > >

  1   2   >