On Tue, 2017-07-25 at 14:18 +1000, David Gibson wrote:
> > Well, at this point I think nothing will set that flag It's there
> > for workaround around HW bugs on some chips. At least in full emu it
> > shouldn't happen unless we try to emulate those bugs. Hopefully direct
> > MMIO will just wor
On Tue, 2017-07-25 at 14:19 +1000, David Gibson wrote:
> > Nevertheless I have added support for the hcall in Linux and QEMU.
> > To use, I think we could create a specific source.
>
> So, IIUC, it's host constraints that would make this one way or the
> other. So what happens when a guest migrat
On Tue, Jul 25, 2017 at 12:38:52AM +, Alexandru Avadanii wrote:
> Hi, Andrew,
> I tried rebuilding virtinst (1.3.2), but that made no difference.
>
> However, changing "model=virtio-net-pci" to simply "model=virtio" (and
> letting the default kick in via libvirt)
> made a whole lot of differ
On Tue, Jul 25, 2017 at 3:13 AM, Lukáš Doktor wrote:
> Dne 25.7.2017 v 08:04 Philippe Mathieu-Daudé napsal(a):
>> Hi Lukáš,
>>
>> On 07/24/2017 09:36 AM, Lukáš Doktor wrote:
>>> Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a):
Hi Lukáš,
Since comment/indent fixes and code cha
Mao Zhongyi writes:
> On 07/25/2017 06:07 AM, John Snow wrote:
>> This was posted over a month ago with two R-Bs, did it get merged or dropped?
>>
>> --js
>
> Not yet, I hope that it will.
get_maintainers.pl blames Daniel, Gerd and Paolo :)
Colo_checkpoint_notify use semaphore to notify COLO thread to do checkpoint.
If x-checkpoint-delay is set to be a very small value,The semaphore will
be accumulated.Even we change x-checkpoint-delay to be a big one,the checkpoint
will continue work for a long time.So we use condtion variable instea
Dne 25.7.2017 v 08:04 Philippe Mathieu-Daudé napsal(a):
> Hi Lukáš,
>
> On 07/24/2017 09:36 AM, Lukáš Doktor wrote:
>> Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a):
>>> Hi Lukáš,
>>>
>>> Since comment/indent fixes and code changes are not related I'd rather see
>>> this split in at leas
Useful to build a whole set at once.
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 5f18243d05..da899522e4 100644
--- a/Makefile
+++ b/Makefile
@@ -814,6 +814,11 @@ endif
# Dependencies in Ma
Hi Lukáš,
On 07/24/2017 09:36 AM, Lukáš Doktor wrote:
Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a):
Hi Lukáš,
Since comment/indent fixes and code changes are not related I'd rather see this
split in at least 2 patches.
Hello Philippe, thank you for the review, I'm wondering what c
On 25.07.2017 00:40, Philippe Mathieu-Daudé wrote:
> Hi perl gurus :)
>
> after changing the ./configure I wanted to figure to whom email and got
> this:
>
> $ ./scripts/get_maintainer.pl -f configure
> Kamil Rytarowski (maintainer:NETBSD)
> qemu-devel@nongnu.org (open list:All patches CC here)
From: Bharata B Rao
Commit 0cffce56 (hw/ppc/spapr.c: adding pending_dimm_unplugs to
sPAPRMachineState) introduced a new way to track pending LMBs of DIMM
device that is marked for removal. Since this commit we can hit the
assert in spapr_pending_dimm_unplugs_add() in the following situation:
- D
From: Alexey Kardashevskiy
f1c2dc7c866a "spapr-pci: rework MSI/MSIX" (07/2013) changed MSIX encoding
but forgot to change the comment so this changes it.
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: David Gibson
---
hw/ppc/spapr_pci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletion
From: Laurent Vivier
Commit 3a38429 ("spapr: Add a "no HPT" encoding to HTAB migration stream")
allows to migrate an empty HPT, but doesn't mark correctly the
end of the migration stream.
The end condition (value returned by htab_save_iterate())
should be 1, whereas in 3a38429 it returns 0.
The
The following changes since commit b5a74cd81d76cb467552f38f2b39520d07c65ea2:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170724'
into staging (2017-07-24 18:15:45 +0100)
are available in the git repository at:
git://github.com/dgibson/qemu.git tags/pp
On Mon, Jul 24, 2017 at 09:07:19PM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2017-07-24 at 19:50 +1000, David Gibson wrote:
> > On Mon, Jul 24, 2017 at 05:00:57PM +1000, Benjamin Herrenschmidt wrote:
> > > On Mon, 2017-07-24 at 14:36 +1000, David Gibson wrote:
> > > > On Wed, Jul 05, 2017 at 0
On Mon, Jul 24, 2017 at 04:44:00PM +0200, Cédric Le Goater wrote:
> On 07/24/2017 08:35 AM, David Gibson wrote:
> > On Wed, Jul 05, 2017 at 07:13:27PM +0200, Cédric Le Goater wrote:
> >> The Thread Interrupt Management Area for the OS is mostly used to
> >> acknowledge interrupts and set the CPPR o
On Mon, Jul 24, 2017 at 01:47:28PM +0200, Cédric Le Goater wrote:
> On 07/24/2017 01:07 PM, Benjamin Herrenschmidt wrote:
> > On Mon, 2017-07-24 at 19:50 +1000, David Gibson wrote:
> >> On Mon, Jul 24, 2017 at 05:00:57PM +1000, Benjamin Herrenschmidt wrote:
> >>> On Mon, 2017-07-24 at 14:36 +1000,
On 07/24/2017 04:33 PM, Laurent Vivier wrote:
Le 24/07/2017 à 20:27, Philippe Mathieu-Daudé a écrit :
Clang's scan-build-5.0 reports:
linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value
if (*host_rt_dev_ptr != 0) {
^~~~
Reported-by: Clang Stat
Dne 24.7.2017 v 17:32 Eduardo Habkost napsal(a):
> On Mon, Jul 24, 2017 at 02:13:09PM +0200, Lukáš Doktor wrote:
>> Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a):
>>> On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote:
Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a):
> On Thu,
On 07/23/2017 04:58 PM, Peter Maydell wrote:
On 22 July 2017 at 05:47, Philippe Mathieu-Daudé wrote:
I'm seeing memleaks using the malta machine, they come from the
smbus_eeprom_init() in hw/i2c/smbus_eeprom.c which does:
uint8_t *eeprom_buf = g_malloc0(8 * 256); /* XXX: make this persist
On 24.07.2017 17:08, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> memsave and pmemsave only take 32bit size arguments in HMP at the
> moment; let them take 64bit values.
>
> Reported-by: Pierre Kim
> Signed-off-by: Dr. David Alan Gilbert
> ---
> hmp-commands.hx |
On 07/24/2017 06:13 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
i2c_recv() returns -1 on error, if the I2CCON_ACK_GEN bit was not set this code
was setting i2cds = -1.
i2c/exynos4210_i2c.c:117:20: warning: Loss of sign in implicit conversion
s->i2c
On 07/20/2017 10:47 AM, Alex Bennée wrote:
While adding the current user is a useful default behaviour for
creating new images it is not appropriate for Travis which already has
a default user.
Signed-off-by: Alex Bennée
---
tests/docker/Makefile.include | 1 +
1 file changed, 1 insertion(+)
Hello QEMU developers,
I'm trying to understand how QEMU software breakpoints work, but I get
stuck in one use-case.
Basically when you call kvm_insert_breakpoint for virtual_address1, it will
look if there is already breakpoint descriptor
in cpu->kvm_state->kvm_sw_breakpoints at virtual_address1.
I thought 2.9.0 is the latest and check to the wrong commit.
Now it supports encryption.
My cmd is:
> qemu-nbd --object secret,id=sec0,file=passwd.txt,format=raw \
> --image-opts
> driver=qcow2,file.filename=demo.qcow2,encrypt.format=luks,encrypt.key-secret=sec0
But it shows error m
>On 24/07/2017 20:35, Peng Hao wrote:
>> When a windows vm starts, periodic timer of rtc will stop several times.
>> windows kernel will check whether REG_A_UIP is changed. REG_C's interrupt
>> flags will not be cleared when periodic timer stops and the update timer
>> will switch to alarm tim
On 25/07/17 01:20, Cédric Le Goater wrote:
> On 07/24/2017 08:00 AM, Alexey Kardashevskiy wrote:
>> On 24/07/17 14:02, David Gibson wrote:
>>> On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote:
This is very similar to the current ICS_SIMPLE model in XICS. We try
to reuse th
On 06/07/17 03:13, Cédric Le Goater wrote:
> It will be used when the guest chooses the XIVE exploitation mode in
> CAS.
>
> Signed-off-by: Cédric Le Goater
> ---
> hw/intc/xive.c| 11 +++
> include/hw/ppc/xive.h | 2 ++
> 2 files changed, 13 insertions(+)
>
> diff --git a/hw/i
On 06/07/17 03:13, Cédric Le Goater wrote:
> The CAS negotiation process determines the interrupt controller model
> to use in the guest but currently, the sPAPR machine make uses of the
> controller very early in the initialization sequence. The interrupt
> source is used to allocate IRQ numbers a
Signed-off-by: Richard Henderson
---
target/s390x/mem_helper.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 026189aefd..1141f1362b 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.
Signed-off-by: Richard Henderson
---
target/s390x/misc_helper.c | 3 ++-
target/s390x/translate.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index 376dbd68c2..ab8551f605 100644
--- a/target/s390x/misc_helper.c
++
All of these uses also have an immediately visible
call to cpu_restore_state.
Signed-off-by: Richard Henderson
---
target/s390x/helper.c | 7 +++
target/s390x/mem_helper.c | 26 +-
target/s390x/misc_helper.c | 2 +-
3 files changed, 17 insertions(+), 18 deleti
Use ILEN_UNWIND to signal that we have in fact that
cpu_restore_state will have been called by the time
we arrive in do_program_interrupt.
Signed-off-by: Richard Henderson
---
target/s390x/cpu.h | 9 ++---
target/s390x/helper.c | 7 +--
target/s390x/misc_helper.c | 5 -
David Hildenbrand recently posted a series of patches correcting
various mistakes in the computation of ILEN for various instructions
in the respective helpers.
I think a better approach is to include ilen in the set of unwind
data for each insn. In this way we can fix these sorts of errors
autom
On Mon, Jul 24, 2017 at 03:25:29PM +0200, Cédric Le Goater wrote:
> On 07/24/2017 08:09 AM, Benjamin Herrenschmidt wrote:
> > On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote:
> >> On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote:
> >>> Each source adds its own ESB mempry regio
On Mon, Jul 24, 2017 at 02:52:29PM +0200, Cédric Le Goater wrote:
> On 07/19/2017 05:24 AM, David Gibson wrote:
> > On Wed, Jul 05, 2017 at 07:13:18PM +0200, Cédric Le Goater wrote:
> >> The XIVE interrupt controller of the POWER9 uses a set of tables to
> >> redirect exception from event sources t
On Mon, Jul 24, 2017 at 03:27:18PM +0200, Cédric Le Goater wrote:
> On 07/24/2017 08:39 AM, David Gibson wrote:
> > On Mon, Jul 24, 2017 at 04:09:31PM +1000, Benjamin Herrenschmidt wrote:
> >> On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote:
> >>> On Wed, Jul 05, 2017 at 07:13:22PM +0200, Céd
On Tue, Jul 25, 2017 at 11:26:13AM +1000, Alexey Kardashevskiy wrote:
> On 24/07/17 23:00, Cédric Le Goater wrote:
> >>> +#include "qemu/osdep.h"
> >>> +#include "qemu/log.h"
> >>> +#include "qapi/error.h"
> >>> +#include "target/ppc/cpu.h"
> >>> +#include "sysemu/cpus.h"
> >>> +#include "sysemu/dm
On 25/07/17 00:55, Cédric Le Goater wrote:
> On 07/24/2017 11:39 AM, Alexey Kardashevskiy wrote:
>> On 06/07/17 03:13, Cédric Le Goater wrote:
>>> A set of Hypervisor's call are used to configure the interrupt sources
>>> and the event/notification queues of the guest:
>>>
>>>H_INT_GET_SOURCE_I
Hi Eric,
On 07/24/2017 03:46 PM, Eric Blake wrote:
On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote:
If find_bitmap_by_name() fails we have bm=NULL and go to the 'fail' label, then
call bitmap_free(bm) which does g_free(bm->name) with bm=NULL...
Clang's scan-build-5.0 output:
block/qcow2-b
On 24/07/17 23:00, Cédric Le Goater wrote:
>>> +#include "qemu/osdep.h"
>>> +#include "qemu/log.h"
>>> +#include "qapi/error.h"
>>> +#include "target/ppc/cpu.h"
>>> +#include "sysemu/cpus.h"
>>> +#include "sysemu/dma.h"
>>> +#include "monitor/monitor.h"
>>> +#include "hw/ppc/xive.h"
>>> +
>>> +#inc
On 07/25/2017 06:07 AM, John Snow wrote:
This was posted over a month ago with two R-Bs, did it get merged or dropped?
--js
Not yet, I hope that it will.
Thanks,
Mao
On 06/16/2017 04:54 AM, Mao Zhongyi wrote:
From: Cao jin
The non-blocking connect mechanism is obsolete, and it doesn't
Reported-by: Sameeh Jubran
Signed-off-by: Philippe Mathieu-Daudé
---
original report from Sameeh Jubran:
http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html
Makefile | 2 +-
configure | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
i
>On 24/07/2017 12:38, wang.yong...@zte.com.cn wrote:
>> finally use g_main_loop_run to replace aio_poll in the
>> iothread_run function.
>
>That would make the performance of virtio-blk with iothreads worse,
>unfortunately. aio_poll is much more optimized than g_main_loop_run.
Hi Paolo,
An
* Halil Pasic [2017-07-24 16:34:52 +0200]:
> When initiating a program check interruption by calling program_interrupt
> the instruction length (ilen) of the current instruction is supplied as
> the third parameter.
>
> On s390x all the IO instructions are of instruction format S and their
> ile
Hi, Andrew,
I tried rebuilding virtinst (1.3.2), but that made no difference.
However, changing "model=virtio-net-pci" to simply "model=virtio" (and letting
the default kick in via libvirt)
made a whole lot of difference (see domain xml at the end).
The interfaces are now on separate buses, all
On 07/24/2017 07:33 AM, Peter Maydell wrote:
Correct off-by-one bug in the PSMAv7 MPU tracing where it would print
a write access as "reading", an insn fetch as "writing", and a read
access as "execute".
Since we have an MMUAccessType enum now, we can make the code clearer
in the process by usin
On Mon, Jul 24, 2017 at 11:11:34PM +0200, Paolo Bonzini wrote:
> On 18/07/2017 13:29, Igor Mammedov wrote:
> >> It may add a few additional CPU cycles, but I really doubt we can
> >> find a workload where CPUID speed has measurable impact. See,
> >> for example, how expensive the kernel KVM CPUID
Hi perl gurus :)
after changing the ./configure I wanted to figure to whom email and got
this:
$ ./scripts/get_maintainer.pl -f configure
Kamil Rytarowski (maintainer:NETBSD)
qemu-devel@nongnu.org (open list:All patches CC here)
$ fgrep -A5 NETBSD MAINTAINERS
NETBSD
L: qemu-devel@nongnu.org
This was posted over a month ago with two R-Bs, did it get merged or
dropped?
--js
On 06/16/2017 04:54 AM, Mao Zhongyi wrote:
From: Cao jin
The non-blocking connect mechanism is obsolete, and it doesn't
work well in inet connection, because it will call getaddrinfo
first and getaddrinfo will
On Fri, Jul 21, 2017 at 11:55:53AM +0200, Jens Freimann wrote:
> From: Jens Freimann
>
> Add a PXE testcase tunneling traffic through vhost-user-bridge process.
> Create a vhost-user-bridge process and connect it to qemu via a socket.
>
> Signed-off-by: Jens Freimann
> ---
> tests/Makefile.in
On 07/24/2017 02:23 PM, Emilio G. Cota wrote:
(Adding some Cc's)
On Mon, Jul 24, 2017 at 19:05:33 +, Andrew Baumann via Qemu-devel wrote:
Hi all,
I'm trying to track down what appears to be a translation bug in either
the aarch64 target or x86_64 TCG (in multithreaded mode). The symptoms
On 07/24/2017 11:39 AM, Eric Blake wrote:
We had a bug for multiple releases where dirty-bitmap count was
documented in bytes but reported in sectors; enhance the testsuite
to add coverage of DirtyBitmapInfo to ensure we do not regress again.
Signed-off-by: Eric Blake
---
tests/qemu-iotests
On Tue, Jul 25, 2017 at 12:41:12AM +0300, Alexander Bezzubikov wrote:
> 2017-07-24 23:46 GMT+03:00 Michael S. Tsirkin :
> > On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote:
> >> On 23/07/2017 15:22, Michael S. Tsirkin wrote:
> >> > On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksand
On 07/24/2017 04:52 PM, Eric Blake wrote:
> On 07/24/2017 04:48 PM, Philippe Mathieu-Daudé wrote:
>> On 07/24/2017 06:09 PM, Peter Maydell wrote:
>>> On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
Use error_report() + exit() instead of error_setg(&error_fatal).
hw/arm/sysbu
On 07/24/2017 06:22 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
configure | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 6b52e19ee3..48295aa1e6 100755
--- a/c
Signed-off-by: Emilio G. Cota
---
disas/arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/arm.c b/disas/arm.c
index 27396dd..a08bbbe 100644
--- a/disas/arm.c
+++ b/disas/arm.c
@@ -1651,7 +1651,7 @@ print_insn_coprocessor (bfd_vma pc, struct
disassemble_info *info, l
On 07/24/2017 04:48 PM, Philippe Mathieu-Daudé wrote:
> On 07/24/2017 06:09 PM, Peter Maydell wrote:
>> On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
>>> Use error_report() + exit() instead of error_setg(&error_fatal).
>>>
>>> hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variab
On 07/24/2017 06:01 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
Unlikely to happen.
hw/timer/pxa2xx_timer.c:145:19: warning: Out of bound memory access (accessed
memory precedes memory block)
counter = counters[n];
^~~
On 07/21/2017 11:51 AM, Stefan Hajnoczi wrote:
On Fri, Jul 21, 2017 at 07:16:34AM -0500, Eric Blake wrote:
On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote:
There is not much getting started documentation for qemu-iotests. This
patch explains how to create a new test and covers the overall test
On 07/24/2017 06:09 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
Use error_report() + exit() instead of error_setg(&error_fatal).
hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path')
results in a null pointer dereference
if (nod
On 07/24/2017 02:03 PM, Pranith Kumar wrote:
+#ifndef CPU_TLB_BITS_MAX
+# define CPU_TLB_BITS_MAX 8
You should simply require each backend to define this.
+++ b/tcg/i386/tcg-target.h
@@ -162,6 +162,8 @@ extern bool have_popcnt;
# define TCG_AREG0 TCG_REG_EBP
#endif
+#define CPU_TLB_BIT
On 07/24/2017 06:11 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
Reorder to only allocate if required.
hw/arm/vexpress.c:667:13: warning: Potential leak of memory pointed to by
'flashalias'
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu
2017-07-24 23:43 GMT+03:00 Michael S. Tsirkin :
> On Sun, Jul 23, 2017 at 01:15:43AM +0300, Aleksandr Bezzubikov wrote:
>> Signed-off-by: Aleksandr Bezzubikov
>> ---
>> hw/pci-bridge/pcie_root_port.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/pci-bridge/pcie_root_port.c b
2017-07-24 23:46 GMT+03:00 Michael S. Tsirkin :
> On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote:
>> On 23/07/2017 15:22, Michael S. Tsirkin wrote:
>> > On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote:
>> > > To enable hotplugging of a newly created pcie-pci-b
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series is the result of having fun with Clang's Static Analyzer during
> the week-end (see https://clang-analyzer.llvm.org/).
>
> No need to delay the first batch for -rc0.
I had a quick look through the mostly ARM related one
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Clang's scan-build-5.0 reports:
>
> linux-user/syscall.c:5581:9: warning: Dereference of undefined pointer value
> if (*host_rt_dev_ptr != 0) {
> ^~~~
>
> Reported-by: Clang Static Analyzer
> Suggested-by: Laurent Vi
On 24 July 2017 at 22:20, Philippe Mathieu-Daudé wrote:
> On 07/24/2017 06:09 PM, Peter Maydell wrote:
>>
>> On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
>
> ...
>
>>> diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c
>>> index d68e3dcdbd..ad0cc49b19 100644
>>> --- a/hw/arm/sysbus
(Adding some Cc's)
On Mon, Jul 24, 2017 at 19:05:33 +, Andrew Baumann via Qemu-devel wrote:
> Hi all,
>
> I'm trying to track down what appears to be a translation bug in either
> the aarch64 target or x86_64 TCG (in multithreaded mode). The symptoms
> are entirely consistent with a torn read/
On 24/07/2017 20:15, Brandon Carpenter wrote:
> Also set saved handle to zero when removing without adding a new watch.
>
> Signed-off-by: Brandon Carpenter
> ---
> ui/vnc-auth-vencrypt.c | 3 +++
> ui/vnc-ws.c| 6 ++
> ui/vnc.c | 4
> 3 files changed, 13 inser
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> configure | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 6b52e19ee3..48295aa1e6 100755
> --- a/configure
> +++ b/configure
> @@ -15
On 07/24/2017 06:09 PM, Peter Maydell wrote:
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
...
diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c
index d68e3dcdbd..ad0cc49b19 100644
--- a/hw/arm/sysbus-fdt.c
+++ b/hw/arm/sysbus-fdt.c
@@ -315,15 +315,14 @@ static int add_amd_xgbe_
On 24 July 2017 at 21:03, Hua Yanghao wrote:
> Sounds good PPM! currently I am working around this by
> objcopy a pure binary and it looks like qemu-system-arm is
> loading a binary at loader address + 0x1. From man page
> it claims it also supports multiboot image which I thought I could
> re
On 24/07/2017 23:03, Pranith Kumar wrote:
> This patch increases the number of entries we allow in the TLB. I went
> over a few architectures to see if increasing it is problematic. Only
> armv6 seems to have a limitation that only 8 bits can be used for
> indexing these entries. For other architec
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes
> se->field_offsets[i] = malloc(nb_fields * sizeof(int));
>^~~
>
> Reported-by: Clang Static Anal
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> i2c_recv() returns -1 on error, if the I2CCON_ACK_GEN bit was not set this
> code
> was setting i2cds = -1.
>
> i2c/exynos4210_i2c.c:117:20: warning: Loss of sign in implicit conversion
> s->i2cds = ret;
>^~~
>
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Reorder to only allocate if required.
>
> hw/arm/vexpress.c:667:13: warning: Potential leak of memory pointed to by
> 'flashalias'
>
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/vexpress.c |
On 18/07/2017 13:29, Igor Mammedov wrote:
>> It may add a few additional CPU cycles, but I really doubt we can
>> find a workload where CPUID speed has measurable impact. See,
>> for example, how expensive the kernel KVM CPUID code
>> (kvm_cpuid(), kvm_find_cpuid_entry()) is.
>
> I don't expect t
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Use error_report() + exit() instead of error_setg(&error_fatal).
>
> hw/arm/sysbus-fdt.c:322:9: warning: Array access (from variable 'node_path')
> results in a null pointer dereference
> if (node_path[1]) {
> ^~~~
I d
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> In a ARM multicore system, write_secondary_boot() only initializes fixups for
> FIXUP_GIC_CPU_IF and FIXUP_BOOTREG, while smpboot[] also uses FIXUP_DSB.
> This results in write_bootloader() using uninitialized fixupcontext[FIXUP_DSB]
> inst
This patch increases the number of entries we allow in the TLB. I went
over a few architectures to see if increasing it is problematic. Only
armv6 seems to have a limitation that only 8 bits can be used for
indexing these entries. For other architectures, I increased the
number of TLB entries to a
On 24 July 2017 at 19:27, Philippe Mathieu-Daudé wrote:
> Unlikely to happen.
>
> hw/timer/pxa2xx_timer.c:145:19: warning: Out of bound memory access (accessed
> memory precedes memory block)
> counter = counters[n];
> ^~~
>
> Reported-by: Clang Static Analyzer
>
On Mon, Jul 24, 2017 at 13:27:27 -0700, Richard Henderson wrote:
> We need not check for ARM vs Thumb state in order to dispatch
> disassembly of every instruction.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.c | 121
> -
> 1
On Mon, Jul 24, 2017 at 13:27:24 -0700, Richard Henderson wrote:
> From: Lluís Vilanova
>
> Signed-off-by: Lluís Vilanova
> Message-Id: <150002631325.22386.10348327185029496649.st...@frigg.lan>
> Signed-off-by: Richard Henderson
> ---
> target/arm/translate.h | 8 +---
> target/arm/trans
On Mon, Jul 24, 2017 at 11:38 AM, Eric Blake wrote:
> On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote:
>> since a negative value means it errored.
>>
>> hw/core/loader.c:149:9: warning: Loss of sign in implicit conversion
>> if (size > max_sz) {
>> ^~~~
>> hw/core/loader.c:171:9:
On 24/07/2017 21:03, Dr. David Alan Gilbert wrote:
>> I don't like having such a long-lived mutex (it seems like a recipe for
>> deadlocks with the BQL), plus memory_region_transaction_commit (the
>> expensive part of memory_global_dirty_log_stop) needs to be under the
>> BQL itself because it call
ARM is a fixed-length ISA and we can compute the page crossing
condition exactly once during init_disas_context.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 58 --
1 file changed, 33 insertions(+), 25
From: Lluís Vilanova
Signed-off-by: Lluís Vilanova
Message-Id: <150002631325.22386.10348327185029496649.st...@frigg.lan>
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 8 +---
target/arm/translate-a64.c | 107
target/arm/transla
On Mon, Jul 24, 2017 at 01:53:33PM +0200, Igor Mammedov wrote:
> On Mon, 24 Jul 2017 18:32:35 +0800 (CST)
> wrote:
>
> > > On Sun, 23 Jul 2017 20:46:11 +0800
> >
> >
> >
> >
> >
> > > Peng Hao wrote:
> >
> > > > When a guest that has several hotplugged dimms is migrated, on
> > > > des
From: Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation
loop.
Signed-off-by: Lluís Vilanova
Reviewed-by: Richard Henderson
Reviewed-by: Alex Benneé
Message-Id: <150002582711.22386.191527630537864599.st...@frigg.lan>
[rth: Move tb->size computation an
On Sun, Jul 23, 2017 at 01:15:43AM +0300, Aleksandr Bezzubikov wrote:
> Signed-off-by: Aleksandr Bezzubikov
> ---
> hw/pci-bridge/pcie_root_port.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/pci-bridge/pcie_root_port.c b/hw/pci-bridge/pcie_root_port.c
> index b0e49e1..ca92d8
From: Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation
loop.
Reviewed-by: Emilio G. Cota
Signed-off-by: Lluís Vilanova
Message-Id: <150002485863.22386.13949856269576226529.st...@frigg.lan>
[rth: Adjust for translate_insn interface change.]
Signed-off
On Mon, Jul 24, 2017 at 11:14:19AM +0200, Igor Mammedov wrote:
> On Sun, 23 Jul 2017 20:46:11 +0800
> Peng Hao wrote:
>
> > When a guest that has several hotplugged dimms is migrated, on
> > destination it will fail to resume. Because regions on source
> > are merged and on destination the order
From: Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation
loop.
Reviewed-by: Emilio G. Cota
Signed-off-by: Lluís Vilanova
Message-Id: <150002510079.22386.10164419868911710218.st...@frigg.lan>
[rth: Adjust for translate_insn interface change.]
Signed-off
We need not check for ARM vs Thumb state in order to dispatch
disassembly of every instruction.
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 121 -
1 file changed, 80 insertions(+), 41 deletions(-)
diff --git a/target/arm/translat
On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel Apfelbaum wrote:
> On 23/07/2017 15:22, Michael S. Tsirkin wrote:
> > On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote:
> > > To enable hotplugging of a newly created pcie-pci-bridge,
> > > we need to tell firmware (SeaBIOS in thi
From: Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation
loop.
Reviewed-by: Emilio G. Cota
Reviewed-by: Richard Henderson
Signed-off-by: Lluís Vilanova
Message-Id: <150002461630.22386.14827196109258040543.st...@frigg.lan>
[rth: Use DISAS_TOO_MANY for
Since AArch64 uses a fixed-width ISA, we can pre-compute the number of
insns remaining on the page. Also, we can check for single-step once.
Reviewed-by: Emilio G. Cota
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 17 +
1 file changed, 9 insertions(+), 8 de
Remembering the opcode is sufficient for handling fragmented frames from
the client, which may be introduced by an intermediary server/proxy.
Respond to pings and ignore pongs rather than close the connection as
many browsers use ping/pong to test an idle connection. Close
connections according to
From: Lluís Vilanova
Incrementally paves the way towards using the generic instruction translation
loop.
Signed-off-by: Lluís Vilanova
Reviewed-by: Richard Henderson
Reviewed-by: Alex Benneé
Message-Id: <150002364681.22386.1701754996184325808.st...@frigg.lan>
[rth: Adjust for tb_start interfa
1 - 100 of 435 matches
Mail list logo
