On 07/25/2017 06:07 AM, John Snow wrote:
This was posted over a month ago with two R-Bs, did it get merged or dropped? --js
Not yet, I hope that it will. Thanks, Mao
On 06/16/2017 04:54 AM, Mao Zhongyi wrote:From: Cao jin <caoj.f...@cn.fujitsu.com> The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking connect of migration goes through QIOChannel in a different manner(using a thread), and nobody use this old non-blocking connect anymore. Any newly written code which needs a non-blocking connect should use the QIOChannel code, so we can drop NonBlockingConnectHandler as a concept entirely. Suggested-by: Daniel P. Berrange <berra...@redhat.com> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> Signed-off-by: Mao Zhongyi <maozy.f...@cn.fujitsu.com> Reviewed-by: Juan Quintela <quint...@redhat.com> Reviewed-by: Daniel P. Berrange <berra...@redhat.com> --- v3: 1. fix the mistake that adds a unmodified file '--help' [Fam Zheng] v2: 1. block/ssh.c is not compiled in v1 which leads to no error reported when I run make & make check, although I make a mistake in block/ssh.c, because the package libssh2-devel missed in my system. Now fixed it. 2. Write the prototype in a single line. [Juan Quintela] Because it's a minor change, so still add the r-b. v1: This patch was reviewed by Daniel about a years ago, but it has never been merged just since socket_connect() called by net_socket_connect_init() where NonBlockingConnectHandler was passed to socket_connect(). it's broken. Now this problem was worked around by Daniel's patch(commit 6701e551 'Revert "Change net/socket.c to use socket_*() functions" again'). Therefore, resend it, of course, part of related code has changed over the years, so changed the patch accordingly. The reviewed patch listed on: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg06373.html block/sheepdog.c | 2 +- block/ssh.c | 2 +- include/qemu/sockets.h | 12 +-- io/channel-socket.c | 2 +- util/qemu-sockets.c | 205 ++++++------------------------------------------- 5 files changed, 28 insertions(+), 195 deletions(-)[snip]
