hi,
a few high level comments:
first:
is the iscsi.cfg really necessary? couldn't we just lookup on demand like we do
now?
*if* we want to cache that list, we should only do this on a per node level,
since
there is no guarantee that this is the same for all nodes.
(e.g. use /var/run//scs
ping (sorry i waited for such a long time ;) )
it probably does not apply anymore, but i'd like to get feedback
before starting the rebase
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-de
those parameters for file-restore
(keep 'tar' for the pve api for gui compatibility)
* use an '#[api]' enum for the format type
pve-common:
Dominik Csapak (1):
PBSClient: add 'tar' parameter to file_restore_extract
src/PVE/PBSClient.pm | 9 +++--
1 file cha
all endpoints now can handle the 'tar' parameter, so add it for all
Signed-off-by: Dominik Csapak
---
src/window/FileBrowser.js | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
index 4e4c639..e036d9f 100644
to be able to download 'tar.zst' archives
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Storage/FileRestore.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Storage/FileRestore.pm
b/src/PVE/API2/Storage/FileRestore.pm
index 764ebfb..6c9c
so that we can get a 'tar.zst' from proxmox-file-restore by giving
'--format tar --zstd' to the file-restore binary
Signed-off-by: Dominik Csapak
---
src/PVE/PBSClient.pm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/PVE/PBSClient.pm b/
such that one can tab through the editable tag fields.
We have to handle that manually, since ExtJs does not expect
contenteditable html tags for focus handling.
Signed-off-by: Dominik Csapak
---
www/manager6/form/Tag.js | 9 +
1 file changed, 9 insertions(+)
diff --git a/www/manager6
by setting 'contentEditable' to 'plaintext-only' instead of true.
Otherwise it was possible to paste html code into the field (an error
was thrown by the backend since it does not match the regex)
Signed-off-by: Dominik Csapak
---
www/manager6/form/Tag.js | 4 ++--
1 file c
aving the field
overflow or cut off.
To properly align the input with the '+' button, we have to add a custom
css class there. (In the hbox we could set the alignment, but this is
not possible in the 'column' layout)
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css
sry disregard this patch only, that property value is not supported in firefox
:(
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 10/20/23 09:08, Wolfgang Bumiller wrote:
On Thu, Oct 19, 2023 at 02:18:56PM +0200, Filip Schauer wrote:
Signed-off-by: Filip Schauer
---
Is it reasonable to add a "dev[n]" argument to the pct.conf, given that
device mount points only allow passing through block devices?
Why would they only
On 10/20/23 10:29, Thomas Lamprecht wrote:
Am 20/10/2023 um 09:51 schrieb Dominik Csapak:
On 10/20/23 09:08, Wolfgang Bumiller wrote:
Also, Dominik recently added resource mappings for qemu for USB & PCI.
PCI might be tricky, but for USB we may be able to use these mappings as
well.
That
hi,
nice elegant solution for not needing to change the config
or introducing a new file :)
there is one caveats with this solution, but that should not
matter for most situations:
in case the configured portal is not accessible, any new node
in the cluster (or one that did not activate the sto
one small comment inline
On 7/5/23 13:12, Christoph Heiss wrote:
As that info is not available through the store (which stores the
status), it must be fetched separately.
Signed-off-by: Christoph Heiss
---
www/manager6/panel/GuestStatusView.js | 32 +++
1 file change
one small comment inline
On 7/5/23 13:12, Christoph Heiss wrote:
It fits neatly there, is rather unintrusive and yet still visible at
first sight. It also solves the problem of having to create a bigger
row, so that the icon is still easily recognisable. At the default
font-size of 13pt, this re
the series looks mostly fine to me, i wrote two small
comments in the relevant patches, but both
are not super important to fix IMO
aside from that consider this series
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing
Hi,
sorry but I just noticed that it seems you did not create this patch
on top of our current master?
at least here it does not apply cleanly, since the files got moved to src/
(in may already)
so could you please rebase your patches on the current master branch
and send it again?
(i did not
On 10/24/23 11:53, Thomas Lamprecht wrote:
Am 19/10/2023 um 15:59 schrieb Dominik Csapak:
sry disregard this patch only, that property value is not supported in firefox
:(
We could set it only to "plaintext-only" for non-firefox then though?
sure not a problem, i just genera
On 10/24/23 12:07, Thomas Lamprecht wrote:
Am 24/10/2023 um 11:57 schrieb Dominik Csapak:
On 10/24/23 11:53, Thomas Lamprecht wrote:
Am 19/10/2023 um 15:59 schrieb Dominik Csapak:
sry disregard this patch only, that property value is not supported in firefox
:(
We could set it only to
for a software renderer and the
loading/detection throws an exception, falling back to the default
renderer.
0: https://github.com/xtermjs/xterm.js/issues/4574
Signed-off-by: Dominik Csapak
---
tested with and without webgl hardware support on firefox/chrome/chromium
xterm.js/src/main.js | 22
d.
To properly align the input with the '+' button, we have to add a custom
css class there. (In the hbox we could set the alignment, but this is
not possible in the 'column' layout)
Signed-off-by: Dominik Csapak
---
changes from v1:
* rebase on master
* drop unnecessary/appl
s has nothing directly to do with your patch, i just wanted to
mention it, since this change emphasizes the need for it IMO)
Otherwise consider this patch:
Reviewed-By: Dominik Csapak
Tested-By: Dominik Csapak
On 10/23/23 19:45, Yuri Konotopov wrote:
With this patch Proxmox now tries to login t
to be able to clear all of them at once
Signed-off-by: Dominik Csapak
---
sending this as a separate patch since i'm not sure if the button is
worth it. if deemed appropriate could also be squashed into the previous
patch
www/manager6/window/BulkAction.js | 26 ++
1
, so that e.g. in
the backup window we still have the filters in the grid header
(we could add a filter box there too, but that is already very crowded
and would take up too much space for now)
Signed-off-by: Dominik Csapak
---
www/manager6/form/VMSelector.js | 10 +-
www/manag
the header part of the gui did change, by moving the user name into a
button, which now contains more user specific actions. Update it to be
correct again.
Signed-off-by: Dominik Csapak
---
pve-gui.adoc | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/pve
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..c01bf89 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -80,6 +80,7 @@ my $observed
we'll need this since we want to record the profile used for creation,
which we get from outside
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 056
that
the consumer doesn't have to do it themselves
Signed-off-by: Dominik Csapak
---
src/Makefile | 2 ++
src/PVE/Profiles/Plugin.pm | 72 ++
2 files changed, 74 insertions(+)
create mode 100644 src/PVE/Profiles/Plugin.pm
diff --git a/sr
simply uses the json_config_properties for the vm config and maps them
to "vm_${opt}"
Signed-off-by: Dominik Csapak
---
PVE/Makefile | 1 +
PVE/Profiles/Makefile | 5 +
PVE/Profiles/VM.pm| 37 +
3 files changed, 43 insertions(
We could simply show the profiles
in the tree, and reuse the vm hw/options panels for that, but does
that seem overkill? We could also leave that API only for now, and
make the gui later? (Using it in the wizard would also not be trivial,
but there the constraints are rather straight forwar
simply uses the json_config_properties for the ct config and maps them
to "ct_${opt}"
Signed-off-by: Dominik Csapak
---
src/PVE/Makefile | 1 +
src/PVE/Profiles/CT.pm| 37 +
src/PVE/Profiles/Makefile | 4
3 files changed, 42
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index b17b4fe2..82240ba3 100755
--- a/PVE/CLI/qm.pm
basic CRUD for the profile section config
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 6 +
PVE/API2/Cluster/Makefile| 1 +
PVE/API2/Cluster/Profiles.pm | 230 +++
3 files changed, 237 insertions(+)
create mode 100644 PVE/API2/Cluster
we use the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from
the profile easily
Signed-off-by: Dominik Csapak
---
src/PVE/API2/LXC.pm | 24
1 file changed, 24 insertions(+)
diff --git
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
src/PVE/CLI/pct.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index a0b9bce..e579b7a 100755
--- a
we use the the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from the
profile easily
also we add the used profile to the meta info in the config, since
it might be interesting which one was used
Signed-off-b
thx for the answer! i'll see that i send a next version soon
some more comment from me inline
On 11/4/23 09:34, Thomas Lamprecht wrote:
On 03/11/2023 12:53, Dominik Csapak wrote:
This series aims to provide profile support when creating guests (ct/vm)
so that users can reuse options wi
small correction inline:
On 11/6/23 09:17, Dominik Csapak wrote:
[snip]
We could also go in a completely different direction and create a config
per profile? (like we handle vm configs). Downside of that is, that the
current guest config handling part is partly in pmxcfs, so we'd have to
On 11/6/23 10:22, Fiona Ebner wrote:
Am 03.11.23 um 12:53 schrieb Dominik Csapak:
+my $defaultData = {
+propertyList => {
+ type => { description => 'Profile type.' },
+ id => {
+ type => 'string',
+ description => "
On 11/6/23 09:53, Thomas Lamprecht wrote:
Am 06/11/2023 um 09:17 schrieb Dominik Csapak:
On 11/4/23 09:34, Thomas Lamprecht wrote:
On 03/11/2023 12:53, Dominik Csapak wrote:
Using a single section config for both VMs and CTs make handling the
properties a bit weird. For now i prefix the
On 11/6/23 11:12, Fiona Ebner wrote:
Am 06.11.23 um 10:34 schrieb Dominik Csapak:
On 11/6/23 10:22, Fiona Ebner wrote:
Am 03.11.23 um 12:53 schrieb Dominik Csapak:
+my $defaultData = {
+ propertyList => {
+ type => { description => 'Profile type.' },
+ id
On 11/6/23 19:32, Thomas Lamprecht wrote:
Am 18/10/2023 um 12:34 schrieb Hannes Laimer:
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index d59847f2..ad0bfc03 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -233,6 +233,10 @@
On 11/6/23 17:31, Thomas Lamprecht wrote:
Am 15/06/2023 um 10:08 schrieb Dominik Csapak:
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
was still broken in the german
did not properly review this, but what caught my attention was that you
don't define any permissions for this new property?
by default new options in pve-container only need 'VM.Config.Options' but
IMHO this should be root only for now? (unless we can use mappings
where we can use those permissio
On 11/6/23 17:01, Thomas Lamprecht wrote:
for the commit subject please: s/BulkActions/bulk actions/
Am 30/10/2023 um 13:58 schrieb Dominik Csapak:
This moves the filters out of the grid header for the BulkActions and
puts them into their own fieldset above the grid. With that, we can
easily
On 11/8/23 13:38, Thomas Lamprecht wrote:
Am 08/11/2023 um 13:14 schrieb Dominik Csapak:
On 11/6/23 17:01, Thomas Lamprecht wrote:
- the CT/VM ID filter is a bit odd, especially if tuned to match all,
not only parts of the VMID (which would not be *that* much better
either IMO), when I
to be able to clear all of them at once
Signed-off-by: Dominik Csapak
---
no changes
www/manager6/window/BulkAction.js | 26 ++
1 file changed, 26 insertions(+)
diff --git a/www/manager6/window/BulkAction.js
b/www/manager6/window/BulkAction.js
index cc561bd6..d3650f83
to use less vertical space
also remove the local-storage warning since this is not that helpful
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/window/BulkAction.js | 75 +--
1 file changed, 41 insertions(+), 34 deletions(-)
diff --git a/www/manager6
dd a filter box there too, but that is already very crowded
and would take up too much space for now)
Signed-off-by: Dominik Csapak
---
changes from v1:
* no changing of labelWidths, happens now in previous patch
* use circle tags instead of full
* correctly refresh the lxc warning in case the
style)
Signed-off-by: Dominik Csapak
---
honestly not sure if this has any performance impacts, since it somehow
has to attach an event handler to the global object which has to do work
now every time to check for the css classes...
www/manager6/Workspace.js | 20
1 f
and exclude the tags for that, since we want the tags to have their own
tooltips
Signed-off-by: Dominik Csapak
---
not really sure if we want to do this, since creating a custom tree
column type just for that seems overkill. also we have to touch private
properties of that here to change it
mhmm.. disregard these patches for now, instead of creating a custom
class we can use the delegate from the tooltip (like in the second patch)
and i want to check the performance of the second patch before it get's applied
(if it's too bad, we can apply the technique only for the scope we need)
to be able to clear all of them at once
Signed-off-by: Dominik Csapak
---
no changes
www/manager6/window/BulkAction.js | 26 ++
1 file changed, 26 insertions(+)
diff --git a/www/manager6/window/BulkAction.js
b/www/manager6/window/BulkAction.js
index 1ffc7538..5f76ef7a
to use less vertical space
also remove the local-storage warning since this is not that helpful
Signed-off-by: Dominik Csapak
---
no changes
www/manager6/window/BulkAction.js | 75 +--
1 file changed, 41 insertions(+), 34 deletions(-)
diff --git a/www/manager6
, so that e.g. in
the backup window we still have the filters in the grid header
(we could add a filter box there too, but that is already very crowded
and would take up too much space for now)
Signed-off-by: Dominik Csapak
---
changes since v2:
* removed accidentally commited clear button, was a
style)
Signed-off-by: Dominik Csapak
---
changes from v1:
* changed the style to show the tag in full form as tooltip, instead of
just the text
i did not found any harsh performance impact, the browser performance
info was very similar as without it (aside from natural jitter, etc. and the
c
and exclude the tags for that, since we want the tags to have their own
tooltips
we use the delegate function of the tooltips for that
Signed-off-by: Dominik Csapak
---
changes from v1:
* instead of using a custom tree column class, use the same delegate
mechanism as the next patch
www
one nit inline:
On 9/21/23 13:47, Markus Frank wrote:
add option to use the qemu vdagent implementation to enable the VNC
clipboard. When enabled with SPICE the spice-vdagent gets replaced with the QEMU
implementation.
This patch does not solve #1406, but does allow copy and paste with
a runnin
a few nits inline:
On 9/21/23 13:47, Markus Frank wrote:
Signed-off-by: Markus Frank
---
www/manager6/qemu/DisplayEdit.js | 8 +++
www/manager6/qemu/Options.js | 89
2 files changed, 97 insertions(+)
diff --git a/www/manager6/qemu/DisplayEdit.js b/www/
i tested with an ubuntu live iso (which conveniently has the
spice tools already installed and running after booting it)
found a few small nits, but those could be followed or fixed up,
not big blockers imho
aside from those, consider this series:
Reviewed-by: Dominik Csapak
Tested-by
since there is nowhere to migrate to and we hide the regular migrate
buttons/options too.
Signed-off-by: Dominik Csapak
---
www/manager6/node/CmdMenu.js | 5 +
www/manager6/node/Config.js | 2 ++
2 files changed, 7 insertions(+)
diff --git a/www/manager6/node/CmdMenu.js b/www/manager6
it shouldn't be called that often, and if we save it, it gets outdated,
e.g. when starting/stopping a guest
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 3 ---
1 file changed, 3 deletions(-)
diff --git a/www/manager6/tree/ResourceTree.js
b/www/manager6
it is a bit more verbose than the usage bar
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/www/manager6/tree/ResourceTree.js
b/www/manager6/tree/ResourceTree.js
index ed51ac32..acfa545a 100644
--- a/www/manager6
stop the tooltip show when the there is no text
this could happen for e.g. nodes that should not have a tooltip
Signed-off-by: Dominik Csapak
---
www/manager6/tree/ResourceTree.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js
b/www
since there is nowhere to migrate to and we hide the regular migrate
buttons/options too.
Signed-off-by: Dominik Csapak
---
changes from v1:
* use new 'isStandaloneNode()' from Utils
www/manager6/node/CmdMenu.js | 4
www/manager6/node/Config.js | 1 +
2 files changed, 5
into Utils and use it where we manually checked that
Signed-off-by: Dominik Csapak
---
I put it into utils since i did not find a better place. Could have put it
in the ResourceStore, but coupling those things seemed wrong to me.
www/manager6/Utils.js | 4
www/manager6
a few high level ui things
(i did not look too deeply in the code, but i'll send
probably some comments there too)
that probably was already there, but i find the all/any + invert combination
confusing (i had to think about it for a bit before getting a grasp on it)
i would propose we can write
in generaly my biggest issue with this patch is that
the various functions/formulas/handler are way to far
away from the place they live/get used/etc.
in generaly i'd try to use the 'controller+viewmodel' consistently
so have a controller (where the logic (methods+handlers) live, the
view where t
On 11/13/23 16:46, Thomas Lamprecht wrote:
Am 19/10/2023 um 11:13 schrieb Dominik Csapak:
diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
index 4e4c639..e036d9f 100644
--- a/src/window/FileBrowser.js
+++ b/src/window/FileBrowser.js
@@ -61,10 +61,6 @@ Ext.define
a schema can now have the 'oneOf' property which is an array of regular
schemas. In the default case any of that has to match. If the
'type-property'/'instance-types' are given, only the schema for the specific
type will be checked (and handles as 'additionalProperties' if there is
no matching type
this series implementes the oneOf schema for the api, see the individual
patches for more details
pve-common:
Dominik Csapak (4):
section config: add test for the schemas
json schema: implement 'oneOf' schema
section config: allow separated property lists for plugins
section c
by simply doing an 'is_deeply' on the generated schema with
the current generated schema
Signed-off-by: Dominik Csapak
---
test/section_config_test.pl | 133
1 file changed, 133 insertions(+)
diff --git a/test/section_config_test
: Dominik Csapak
---
src/api-viewer/APIViewer.js | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/src/api-viewer/APIViewer.js b/src/api-viewer/APIViewer.js
index d9753b2..26a1c08 100644
--- a/src/api-viewer/APIViewer.js
+++ b/src/api-viewer
more or less a copy from the normal section config test, but now with
properties defined multiple times as well as conflicting options
Signed-off-by: Dominik Csapak
---
test/Makefile | 1 +
test/section_config_separated_test.pl | 486 ++
2 files
s in the schema,
they have to be given in the 'global' options section now (the perl
package where the base plugin is defined)
for now, we then save the global options in the section '__global',
which is now a forbidden plugin type, but that should be fine as we
don
oneOf schema
* move the parsing with preparing into a helper into the Plugin class
* don't save the profile into the 'meta' option, but log it instead
0: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060073.html
pve-cluster:
Dominik Csapak (1):
add profiles.cfg to c
simply uses the json_config_properties for the ct config
Signed-off-by: Dominik Csapak
---
changes from v1:
* no prefixing with ct_ anymore
src/PVE/Makefile | 1 +
src/PVE/Profiles/CT.pm| 28
src/PVE/Profiles/Makefile | 4
3 files changed, 33
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..c01bf89 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -80,6 +80,7 @@ my $observed
simply uses the json_config_properties for the vm config
Signed-off-by: Dominik Csapak
---
changes from v1:
* no prefixing with vm anymore
PVE/Makefile | 1 +
PVE/Profiles/Makefile | 5 +
PVE/Profiles/VM.pm| 28
3 files changed, 34 insertions
we use the the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from the
profile easily
also we add the used profile to the log, since
it might be interesting which one was used
Signed-off-by: Dominik Csapak
---
ch
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
changes from v1:
* use init(1) for separated plugin schemas
PVE/CLI/qm.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE
one, else
we'd get a cyclic dependency, and without that we need to ignore
unknown sections
* we pack the type and id in the global options, so that when using
it with a seperated section config they get included in the
create/updateSchema
Signed-off-by: Dominik Csapak
--
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
changes from v1:
* use init(1) for separated plugins
src/PVE/CLI/pct.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/CLI/pct.pm b
we use the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from
the profile easily
we also log the used profile
Signed-off-by: Dominik Csapak
---
changes from v1:
* use helper from Plugin
* log profile when
basic CRUD for the profile section config
Signed-off-by: Dominik Csapak
---
changes from v1:
* use raise_param_exc when id or type is wrong
* extract the type from param
* use /mapping/guest-profile as acl path
* add missing index entry for profiles
PVE/API2/Cluster.pm | 7 ++
PVE
this series implementes the oneOf schema for the api, see the individual
patches for more details and changelog
pve-common:
Dominik Csapak (4):
section config: add test for the schemas
json schema: implement 'oneOf' schema
section config: allow separated property lists f
: Dominik Csapak
---
no changes
src/api-viewer/APIViewer.js | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/src/api-viewer/APIViewer.js b/src/api-viewer/APIViewer.js
index d9753b2..26a1c08 100644
--- a/src/api-viewer/APIViewer.js
+++ b/src/api
options hash:
it's not needed anymore to specify options that are specified in the
type specific propertyList, except if it's 'fixed => 1' (since that does
not exist in the schema)
Signed-off-by: Dominik Csapak
---
changes from v1:
* don't use the __global hack anymore, we
a schema can now have the 'oneOf' property which is an array of regular
schemas. In the default case any of that has to match. If the
'type-property'/'instance-types' are given, only the schema for the specific
type will be checked (and handles as 'additionalProperties' if there is
no matching type
by simply doing an 'is_deeply' on the generated schema with
the current generated schema
Signed-off-by: Dominik Csapak
---
no changes
test/section_config_test.pl | 133
1 file changed, 133 insertions(+)
diff --git a/test/section_config_test
more or less a copy from the normal section config test, but now with
properties defined multiple times as well as conflicting options
Signed-off-by: Dominik Csapak
---
changes from v1:
* changed generated api schema to reflect optimizations in SectionConfig
test/Makefile
'delete' is only possible for editing jobs, not creating them
Signed-off-by: Dominik Csapak
---
follow up to lukas patches
www/manager6/dc/Backup.js | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
inde
by removing the 'invert' checkbox and instead show the 4 modes possible,
we still assemble/parse the invert for the backend
Signed-off-by: Dominik Csapak
---
src/window/NotificationMatcherEdit.js | 54 +--
1 file changed, 18 insertions(+), 36 deletions(-)
di
(UX as well as code wise).
Dominik Csapak (2):
notification matcher: improve handling empty and invalid values
notification matcher: improve wording for mode
src/window/NotificationMatcherEdit.js | 138 ++
1 file changed, 99 insertions(+), 39 deletions(-)
--
2.30.2
Signed-off-by: Dominik Csapak
---
src/window/NotificationMatcherEdit.js | 84 ++-
1 file changed, 81 insertions(+), 3 deletions(-)
diff --git a/src/window/NotificationMatcherEdit.js
b/src/window/NotificationMatcherEdit.js
index c0dfa34..0f29203 100644
--- a/src/window
to compare nested hashes/lists and scalar values recursively.
Also includes some tests
Signed-off-by: Dominik Csapak
---
new in v3, split out from section config
changes to the is_deeply function:
* incorporate thomas suggestions
* fix sub call style
* add comment to make it clear `ref` never
by simply doing an 'is_deeply' on the generated schema with
the current generated schema
Signed-off-by: Dominik Csapak
---
test/section_config_test.pl | 133
1 file changed, 133 insertions(+)
diff --git a/test/section_config_test
: Dominik Csapak
---
src/api-viewer/APIViewer.js | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/src/api-viewer/APIViewer.js b/src/api-viewer/APIViewer.js
index d9753b2..26a1c08 100644
--- a/src/api-viewer/APIViewer.js
+++ b/src/api-viewer
this series implementes the oneOf schema for the api, see the individual
patches for more details and changelog
pve-common:
Dominik Csapak (5):
section config: add test for the schemas
tools: add is_deeply
json schema: implement 'oneOf' schema
section config: allow separate
a schema can now have the 'oneOf' property which is an array of regular
schemas. In the default case any of that has to match. If the
'type-property'/'instance-types' are given, only the schema for the specific
type will be checked (and handles as 'additionalProperties' if there is
no matching type
1 - 100 of 2437 matches
Mail list logo
