one small comment inline
On 7/5/23 13:12, Christoph Heiss wrote:
It fits neatly there, is rather unintrusive and yet still visible at
first sight. It also solves the problem of having to create a bigger
row, so that the icon is still easily recognisable. At the default
font-size of 13pt, this really wasn't the case.
Verified that each supported distro is present in the font and the name
matches up and tested through all supported distros (including
'unmanaged').
Signed-off-by: Christoph Heiss <c.he...@proxmox.com>
---
www/manager6/panel/GuestStatusView.js | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/www/manager6/panel/GuestStatusView.js
b/www/manager6/panel/GuestStatusView.js
index ca2f03453..c773f252d 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -29,6 +29,7 @@ Ext.define('PVE.panel.GuestStatusView', {
success: ({ result }) => {
view.down('#unprivileged').updateValue(
Proxmox.Utils.format_boolean(result.data.unprivileged));
+ view.ostype = result.data.ostype;
},
});
},
@@ -166,6 +167,22 @@ Ext.define('PVE.panel.GuestStatusView', {
+ ')';
}
- me.setTitle(me.getRecordValue('name') + text);
+ let title = `<div class="left-aligned">${me.getRecordValue('name') +
text}</div>`;
+
+ if (me.pveSelNode.data.type === 'lxc' && me.ostype && me.ostype !==
'unmanaged') {
+ // Manual mappings for distros with special casing
+ const namemap = {
+ 'archlinux': 'Arch Linux',
+ 'nixos': 'NixOS',
+ 'opensuse': 'openSUSE',
+ 'centos': 'CentOS',
+ };
+
+ const distro = namemap[me.ostype] ??
Ext.String.capitalize(me.ostype);
+ title += `<div class="right-aligned">
+ <i class="fl-${me.ostype} fl-fw"></i> ${distro}</div>`;
+ }
while in practice it won't make a difference,
we probably want to wrap the distro in an Ext.htmlEncode
we don't allow arbitrary values via the api, but if i edit
the config it simply returns the value, e.g. having
ostype: <b>test</b>
in the container config leads to bold text here
though i don't think this is a blocker for this series
+
+ me.setTitle(title);
},
});
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
