Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Gabriel Goller
On 07.04.2025 19:46, Thomas Lamprecht wrote: Am 08.01.25 um 15:38 schrieb Gabriel Goller: adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the returned data with the existing configuration. This will update the IPv4 and IPv6 address, as well as the interface name (in case the contai

Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 12:06 schrieb Gabriel Goller: > On 07.04.2025 19:46, Thomas Lamprecht wrote: >> Am 08.01.25 um 15:38 schrieb Gabriel Goller: >>> adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the >>> returned data with the existing configuration. This will update the >>> IPv4 and IPv6

[pve-devel] applied: [PATCH proxmox-i18n] Update italian translation

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 11:09:18 +0200, Gabriel Goller wrote: > Typos and errors introduced by previous commit. > > Applied, thanks! [1/1] Update italian translation commit: 78f696097f8e4c587a8b6e91afe2e0802b18e993 ___ pve-devel mailing list pve-d

Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

2025-04-08 Thread Fiona Ebner
Am 07.04.25 um 18:27 schrieb Aaron Lauterer: > @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({ > > $status->{ha} = > PVE::HA::Config::get_service_status("vm:$param->{vmid}"); > > + $status->{display}->{type} = 'std'; This is not the correct default in all cases (e.g. aarch64 V

Re: [pve-devel] [PATCH esxi-import-tools] listvms: exclude VMs without datastore_name from manifest.json.

2025-04-08 Thread Daniel Herzig
Wolfgang Bumiller writes: >> for vm in list_vms(connection): >> +# skip vms with empty datastore_name >> +datastore_name, relative_vmx_path = parse_file_path( >> +vm.config.files.vmPathName >> +) >> +if not datastore_name: >

Re: [pve-devel] [PATCH installer] auto: add some error context when loading the first-boot executable

2025-04-08 Thread Christoph Heiss
On Tue Apr 8, 2025 at 11:23 AM CEST, Thomas Lamprecht wrote: > Am 08.04.25 um 11:06 schrieb Christoph Heiss: > >> @@ -47,7 +47,9 @@ fn setup_first_boot_executable(first_boot: >> &FirstBootHookInfo) -> Result<()> { >> } >> } >> FirstBootHookSourceMode::FromIso => { >>

Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 09:01 schrieb Dominik Csapak: > On 4/8/25 00:13, Thomas Lamprecht wrote: >> Am 07.04.25 um 12:13 schrieb Dominik Csapak: >>> adds a checkbox 'import image' above the storage selector which: >>> * hides the original storage selector >>> * shows a 'source storage' selector >>> * shows

[pve-devel] [PATCH installer] country.pl: load iso 3166 country codes file as UTF8

2025-04-08 Thread Christoph Heiss
This file is UTF-8 encoded and contains Unicode characters for encoding country names, such as "Åland Islands" for example. Otherwise, the final locale-info.json that gets shipped with the ISO might contain wrongly-encoded country names, causing display errors in (at least) the GTK installer count

Re: [pve-devel] [PATCH installer] country.pl: load iso 3166 country codes file as UTF8

2025-04-08 Thread Maximiliano Sandoval
I ran ```sh make locale-info.json locales.json ``` then did a diff of the locales.json file before and after this patch. The resulting diff is: ```diff @@ -1001,7 +1001,7 @@ "ax": { "kmap": "", "mirror": "", - "name": "Åland Islands", + "name": "Åland Islands",

Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-08 Thread Dominik Csapak
On 4/8/25 10:40, Thomas Lamprecht wrote: Am 08.04.25 um 09:01 schrieb Dominik Csapak: On 4/8/25 00:13, Thomas Lamprecht wrote: Am 07.04.25 um 12:13 schrieb Dominik Csapak: adds a checkbox 'import image' above the storage selector which: * hides the original storage selector * shows a 'source s

Re: [pve-devel] [PATCH pve-http-server v2 1/1] fix unexpected EOF for client when closing TLS session

2025-04-08 Thread Fiona Ebner
Am 08.04.25 um 10:48 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 08.04.2025 09:27 CEST geschrieben: >> I feel like the questions regarding blocking/missing client ack from >> Fabian from v1 are not answered yet: >> >>> If I read the docs right, this could block (would that be an issue here?)

[pve-devel] [PATCH installer] auto: add some error context when loading the first-boot executable

2025-04-08 Thread Christoph Heiss
At least to one user in the forum already ran into this IIRC, and most recently Maximiliano too. This can happen when e.g. copying example answer files with the first-boot section, without then passing `--on-first-boot` to proxmox-auto-install-assistant. In that case, the user would just get a pr

Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
On 2025-04-08 09:49, Fiona Ebner wrote: Am 07.04.25 um 18:27 schrieb Aaron Lauterer: @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({ $status->{ha} = PVE::HA::Config::get_service_status("vm:$param->{vmid}"); + $status->{display}->{type} = 'std'; This is not the correct defau

Re: [pve-devel] [PATCH installer] gui: fall back to first found NIC if no default could be determined

2025-04-08 Thread Maximiliano Sandoval
Christoph Heiss writes: > If no DHCP server is configured on the network and/or no DHCP lease and > thus network configuration is retrieved, the installer will also be > unable to determine the default interface, aka. the one with the default > gateway set. > > Fix it by pre-selecting the first

[pve-devel] Applied: [PATCH installer] country.pl: load iso 3166 country codes file as UTF8

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 10:47:43 +0200, Christoph Heiss wrote: > This file is UTF-8 encoded and contains Unicode characters for encoding > country names, such as "Åland Islands" for example. > > Otherwise, the final locale-info.json that gets shipped with the ISO > might contain wrongly-encoded countr

Re: [pve-devel] [PATCH manager v5 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
On 2025-04-08 10:10, Dominik Csapak wrote: On 4/7/25 18:27, Aaron Lauterer wrote: If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finis

[pve-devel] [PATCH installer v2] auto: add some error context when loading first-boot executable

2025-04-08 Thread Christoph Heiss
At least to one user in the forum already ran into this IIRC, and most recently Maximiliano too. This can happen when e.g. copying example answer files with the first-boot section, without then passing `--on-first-boot` to proxmox-auto-install-assistant. In that case, the user would just get a pr

Re: [pve-devel] [PATCH manager v5 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Dominik Csapak
On 4/7/25 18:27, Aaron Lauterer wrote: If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron

[pve-devel] [PATCH guest-common 2/2] bump version to 5.2.2

2025-04-08 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- debian/changelog | 7 +++ 1 file changed, 7 insertions(+) diff --git a/debian/changelog b/debian/changelog index aa4b6c3..6750624 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libpve-guest-common-perl (5.2.2) bookworm; urgency=medium +

Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage

2025-04-08 Thread Dominik Csapak
On 4/8/25 00:13, Thomas Lamprecht wrote: Am 07.04.25 um 12:13 schrieb Dominik Csapak: adds a checkbox 'import image' above the storage selector which: * hides the original storage selector * shows a 'source storage' selector * shows a 'import file' selector * shows a 'target storage' selector S

[pve-devel] [PATCH manager v6 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron Lauterer --- changes since v5: * use new

[pve-devel] [PATCH qemu-server v6 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
This new property returns the configured or default display for a VM. Instead of a flat property, we use a nested 'type' object that contains the actual information. This way we can add other properties that belong to a VM's display in the future without much hassle, to have them all in one place.

Re: [pve-devel] [PATCH qemu-server, manager v5 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
sent a v6 https://lore.proxmox.com/pve-devel/20250408103715.1081055-1-a.laute...@proxmox.com/ On 2025-04-07 18:27, Aaron Lauterer wrote: This version 5 of the series uses a different approach as discussed [0] in the last interation. We add a new property in the VM status/current API result t

[pve-devel] [PATCH qemu-server v6 1/4] QemuServer: make get_vga_properties and extract_version public

2025-04-08 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- newly introduced with v6 PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ccdceed..b7ef69b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1159,7 +1159,7 @@ sub kvm_v

[pve-devel] [PATCH] add patch to disable elastic_shared_blob to prevent crashing OSDs

2025-04-08 Thread Stoiko Ivanov
reported in our community forum and upstream: https://forum.proxmox.com/threads/164735/ https://tracker.ceph.com/issues/70390 https://github.com/ceph/ceph/pull/62724 fix seems trivial, and the feature is quite new: https://ceph.io/assets/pdfs/events/2024/ceph-days-nyc/Diving%20Deep%20with%20Squid.

Re: [pve-devel] [PATCH proxmox-i18n] update Spanish translations

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 13:18:02 +0200, Maximiliano Sandoval wrote: > Applied, thanks! [1/1] update Spanish translations commit: ac9cf0fced2cee0ad7db0c0c94cad3ca11a139a5 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.c

[pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-08 Thread Dominik Csapak
By enabling the import button for qcow2/vmdk/raw files, and showing a window with a VMID selector and the disk edit panel. Change the edit panel so that when we give an explicit volume id directly, we don't let the user select one. Instead it show it in a displayfield. Signed-off-by: Dominik Csap

[pve-devel] applied: [PATCH proxmox] fix #6143: notify: allow overriding notification templates

2025-04-08 Thread Thomas Lamprecht
On Fri, 21 Mar 2025 14:33:41 +0100, Alexander Zeidler wrote: > Previously, notification templates could be modified by the user, but > these were overwritten again with installing newer package versions of > pve-manager and proxmox-backup. > > Now override templates can be created cluster-wide in

Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 13:27 schrieb Gabriel Goller: > I added the IP addresses and a "More" button to the Container Summary > and increased it's height, so as to make room for it. This make > everything look kinda weird (i.e., the GuestSummary panel is higher than > the CPU usage RRD graph.) But as I said

[pve-devel] [PATCH-SERIES manager/qemu-server/docs 0/3] drop writeback cache setting

2025-04-08 Thread Fiona Ebner
VirtIO-fs using writeback cache seems very broken at the moment. If a guest accesses a file (even just using 'touch'), that the host is currently writing, the guest can permanently end up with a truncated version of that file. Even subsequent operations like moving the file, will not result in the

[pve-devel] [PATCH docs 3/3] qm: virtiofs: drop writeback cache

2025-04-08 Thread Fiona Ebner
VirtIO-fs using writeback cache seems very broken at the moment. If a guest accesses a file (even just using 'touch'), that the host is currently writing, the guest can permanently end up with a truncated version of that file. Even subsequent operations like moving the file, will not result in the

[pve-devel] [PATCH manager 1/3] ui: virtiofs edit: drop writeback checkbox

2025-04-08 Thread Fiona Ebner
VirtIO-fs using writeback cache seems very broken at the moment. If a guest accesses a file (even just using 'touch'), that the host is currently writing, the guest can permanently end up with a truncated version of that file. Even subsequent operations like moving the file, will not result in the

[pve-devel] [PATCH http-server 3/3] anyevent: handle 'disconnected' flag in client_do_disconnect() itself

2025-04-08 Thread Fiona Ebner
Commit f737984 ("fix #4816: do not disconnect twice if client sends no data") introduced a 'disconnected' flag in the request state to avoid duplicate calls to client_do_disconnect() for a given client. The flag is only set and checked in the on_error callback of the handle however. Do this more ce

[pve-devel] [PATCH proxmox-i18n] update Spanish translations

2025-04-08 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- es.po | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/es.po b/es.po index afa25b1..2506f23 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox translations\

Re: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 15:25 schrieb Stefan Hanreich: > The hostname provided to the methods in the IPAM plugins is empty for > VMs that do not have a name set. We always included the dns_name key > in the request, even if it was undefined, which leads Netbox to return > a 400 Bad Request error. With this

[pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options

2025-04-08 Thread Stefan Hanreich
The hostname provided to the methods in the IPAM plugins is empty for VMs that do not have a name set. We always included the dns_name key in the request, even if it was undefined, which leads Netbox to return a 400 Bad Request error. With this patch we omit the dns_name parameter if it isn't set,

Re: [pve-devel] [PATCH qemu-server v7 2/4] api: status/current: add display property

2025-04-08 Thread Fiona Ebner
Am 08.04.25 um 14:27 schrieb Aaron Lauterer: > This new property returns the configured or default display for a VM. > > Instead of a flat property, we use a nested 'type' object that contains > the actual information. This way we can add other properties that belong > to a VM's display in the fut

Re: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options

2025-04-08 Thread Stefan Hanreich
On 4/8/25 15:29, Thomas Lamprecht wrote: > Am 08.04.25 um 15:25 schrieb Stefan Hanreich: >> The hostname provided to the methods in the IPAM plugins is empty for >> VMs that do not have a name set. We always included the dns_name key >> in the request, even if it was undefined, which leads Netbox

[pve-devel] [PATCH proxmox-firewall 1/1] guest: do not try to create map entries if there are no devices

2025-04-08 Thread Stefan Hanreich
When the firewall was enabled for a guest, but disabled for all interfaces of a guest, the firewall tried to add an empty list to the guest map, which is an invalid nftables statement. Signed-off-by: Stefan Hanreich --- proxmox-firewall/src/firewall.rs | 15 +-- 1 file changed, 9 ins

Re: [pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-08 Thread Stoiko Ivanov
On Tue, 8 Apr 2025 18:38:56 +0200 Friedrich Weber wrote: > Currently, as an unprivileged user with role PVEVMUser the GUI breaks > with an error after navigating to a VM's hardware tab. The reason is > that the frontend checks the GUI capabilites via `caps.mapping.hwrng`, > but `caps.mapping` do

[pve-devel] [PATCH http-server 1/3] anyevent: disconnect: check that handle is still defined before calling shutdown()

2025-04-08 Thread Fiona Ebner
Commit 07e56cc ("fix unexpected EOF for client when closing TLS session") added a call to stoptls() before the call to shutdown() for the handle's file descriptor. However, the documentation for AnyEvent[0] mentions for stoptls(): > This method may invoke callbacks (and therefore the handle might

Re: [pve-devel] [PATCH pve-http-server v2 1/1] fix unexpected EOF for client when closing TLS session

2025-04-08 Thread Fabian Grünbichler
> Fiona Ebner hat am 08.04.2025 09:27 CEST geschrieben: > > > Am 05.03.25 um 22:45 schrieb Rob Rozestraten via pve-devel: > > When pve-http-server initiates the closure of a TLS session, it does not > > send a TLS close notify, resulting in an unexpected EOF error on systems > > with recent c

[pve-devel] [PATCH manager] ui: qemu: unify enabled state of pci, usb and rng

2025-04-08 Thread Stoiko Ivanov
all 3 additions fail in the backend, if a user does not have VM.Config.HWType on the VM. unify their display to cause less confusion, to the most recently added version for the rng. drop the now unused noHWPerm (eslint reminded me about that). found while reviewing: https://lore.proxmox.com/all/

Re: [pve-devel] [PATCH installer] auto: add some error context when loading the first-boot executable

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 11:06 schrieb Christoph Heiss: > @@ -47,7 +47,9 @@ fn setup_first_boot_executable(first_boot: > &FirstBootHookInfo) -> Result<()> { > } > } > FirstBootHookSourceMode::FromIso => { > -Some(fs::read(format!("/cdrom/{FIRST_BOOT_EXEC_NAME}"))?

[pve-devel] applied: [PATCH guest-common 1/2] d/control: bump dependency for libpve-cluster-perl

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 10:12:31 +0200, Fiona Ebner wrote: > For example, otherwise build of qemu-server will fail with: > > unknown file 'mapping/directory.cfg' at /usr/share/perl5/PVE/Cluster.pm > if libpve-cluster-perl is not recent enough and there most likely are > runtime issues too. > Applied,

Re: [pve-devel] [PATCH qemu-server v6 1/4] QemuServer: make get_vga_properties and extract_version public

2025-04-08 Thread Fiona Ebner
Am 08.04.25 um 12:37 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > newly introduced with v6 > > PVE/QemuServer.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index ccdceed..b7ef69b 100644 > --- a/PVE/Qemu

[pve-devel] [PATCH manager v7 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-08 Thread Aaron Lauterer
Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than via novnc. While the console button in the top right allows to manually choose the console type, the Console in the main subme

[pve-devel] [PATCH qemu-server v7 1/4] QemuServer: add new public get_default_vga_type function

2025-04-08 Thread Aaron Lauterer
by moving that part out of get_vga_properties. We resolve missing parameters if necessary to make it easier to call from another module where we likely only have the VM config ready. Signed-off-by: Aaron Lauterer --- changes since v6: instead of making get_vga_properties and extract_version publ

[pve-devel] [PATCH qemu-server v7 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
This new property returns the configured or default display for a VM. Instead of a flat property, we use a nested 'type' object that contains the actual information. This way we can add other properties that belong to a VM's display in the future without much hassle, to have them all in one place.

[pve-devel] [PATCH manager v7 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron Lauterer --- changes since v6: none v5:

Re: [pve-devel] [PATCH qemu-server v7 1/4] QemuServer: add new public get_default_vga_type function

2025-04-08 Thread Fiona Ebner
Nit: please don't use "QemuServer" as a prefix in the commit subject. That contains no additional information (for humans, but also machines can already see the modified file). Am 08.04.25 um 14:27 schrieb Aaron Lauterer: > by moving that part out of get_vga_properties. > > We resolve missing par

[pve-devel] [PATCH esxi-import-tools v2] listvms: exclude VMs without datastore_name from manifest.json

2025-04-08 Thread Daniel Herzig
On newer ESXI-8x versions, the diskless vCLS machines in an ESXI-cluster are not stored on a datastore anymore. Instead, they are placed under `/var/run/crx` on the ESXI-hosts' filesystem. This can lead to issues with the ESXI-storage not being activated on the PVE-side [0]. This commit prevents

Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Gabriel Goller
If you want to take this in with this release, I can send a new version, but I'd like to wait a bit to be honest. The Summary looks currently a bit rough, even with the scrollbar. Also we can't differentiate between a dhcp ip-address or an address set manually on the container itself (and we alwa

[pve-devel] applied: [PATCH container v4 3/3] api: return all addresses of an interface

2025-04-08 Thread Thomas Lamprecht
Am 08.01.25 um 15:38 schrieb Gabriel Goller: > Return all ip-addresses of an interface, not only the first one. Change > return schema to resemble the 'agent/network-get-interfaces' qemu call > reponse. This helps us making the AgentIPView more generic and display > the ip on both containers and vm

[pve-devel] applied: [PATCH esxi-import-tools v2] listvms: exclude VMs without datastore_name from manifest.json

2025-04-08 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH-SERIES manager/qemu-server/docs 0/3] drop writeback cache setting

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 17:07 schrieb Fiona Ebner: > VirtIO-fs using writeback cache seems very broken at the moment. If a > guest accesses a file (even just using 'touch'), that the host is > currently writing, the guest can permanently end up with a truncated > version of that file. Even subsequent operat

Re: [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config

2025-04-08 Thread Stefan Hanreich
> On 08.04.2025 21:42 CEST Stoiko Ivanov wrote: > > > On Tue, 8 Apr 2025 20:43:17 +0200 > Thomas Lamprecht wrote: > > > On 08/04/2025 18:32, Stefan Hanreich wrote: > > > Since we now ship frr with Proxmox VE, the frr service is available on > > > the nodes but disabled on install. Prior to

[pve-devel] applied: [PATCH proxmox-firewall 1/1] guest: do not try to create map entries if there are no devices

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 15:41:35 +0200, Stefan Hanreich wrote: > When the firewall was enabled for a guest, but disabled for all > interfaces of a guest, the firewall tried to add an empty list to the > guest map, which is an invalid nftables statement. > > Applied, thanks! [1/1] guest: do not try

[pve-devel] applied: [PATCH proxmox-i18n] update Japanese translations

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 18:59:01 +0900, ribbon via pve-devel wrote: > --- ja.po.old 2025-04-08 17:49:19.253871143 +0900 > +++ ja.po 2025-04-08 18:48:58.615114632 +0900 > @@ -34,9 +34,8 @@ > msgstr "(ブートデバイスが未選択)" > > #: pve-manager/www/manager6/dc/AuthEditOpenId.js:98 > -#, fuzzy > msgid "(none

[pve-devel] applied: [PATCH installer v2] auto: add some error context when loading first-boot executable

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 11:54:43 +0200, Christoph Heiss wrote: > At least to one user in the forum already ran into this IIRC, and most > recently Maximiliano too. > > This can happen when e.g. copying example answer files with the > first-boot section, without then passing `--on-first-boot` to > prox

Re: [pve-devel] [PATCH esxi-import-tools] listvms: exclude VMs without datastore_name from manifest.json.

2025-04-08 Thread Wolfgang Bumiller
On Mon, Apr 07, 2025 at 05:04:22PM +0200, Daniel Herzig wrote: > On newer ESXI-8.x.y versions, the diskless vCLS machines in an > ESXI-cluster are not stored on a datastore anymore. > > Instead, they are placed under `/var/run/crx` on the ESXI-hosts' > filesystem. This can lead to issues with the

[pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config

2025-04-08 Thread Stefan Hanreich
Since we now ship frr with Proxmox VE, the frr service is available on the nodes but disabled on install. Prior to that users had to manually install frr, which automatically enabled the service. When applying a SDN configuration with an EVPN controller, we invoke systemctl restart frr, which leads

[pve-devel] [PATCH pve-docs 1/1] sdn: frr update documentation for installing frr package

2025-04-08 Thread Stefan Hanreich
The frr service now gets automatically enabled when applying an SDN configuration with an EVPN controller present. Reflect this change in the documentation. Also add a note for users upgrading from prior versions, that they still need to install frr before applying the SDN configuration. Signed-of

[pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed

2025-04-08 Thread Stefan Hanreich
Fixes the issue of the FRR service getting started, but not enabled when applying an SDN configuration and updates the docs to reflect the new behavior. pve-network: Stefan Hanreich (1): frr: enable frr service on reloading the controller config src/PVE/Network/SDN/Controllers/EvpnPlugin.pm |

[pve-devel] [PATCH pve-network v2 1/2] frr: remove erroneous outfunc from frr-reload command

2025-04-08 Thread Stefan Hanreich
Prior to the upgrade to frr-pythontools 10.2.1, frr-reload.py did not print any output to STDOUT, which masked the erroneous outfunc provided in run_command. With 10.2.1 frr-reload.py now prints to STDOUT, which triggers the codepath for invoking the outfunc, leading to an error when invoking frr-r

[pve-devel] [PATCH docs/network v2 0/3] improve behavior of frr service when pre-installed

2025-04-08 Thread Stefan Hanreich
Fixes the issue of the FRR service getting started, but not enabled when applying an SDN configuration and updates the docs to reflect the new behavior. Changes from v1 to v2: * additionally fix the outfunc in the reload command, which caused a regression with frr-pythontools 10.2.1 * move the e

[pve-devel] [PATCH pve-network v2 2/2] frr: enable and start frr on reloading the controller config

2025-04-08 Thread Stefan Hanreich
Since we now ship frr with Proxmox VE, the frr service is available on the nodes but disabled on install. Prior to that, users had to manually install frr, which automatically enabled the service. When first applying a SDN configuration with an EVPN controller, we always fell back to restarting the

[pve-devel] [PATCH pve-docs v2 1/1] sdn: frr update documentation for installing frr package

2025-04-08 Thread Stefan Hanreich
The frr service now gets automatically enabled when applying an SDN configuration with an EVPN controller present. Reflect this change in the documentation. Also add a note for users upgrading from prior versions, that they still need to install frr before applying the SDN configuration. Signed-of

[pve-devel] [PATCH docs] virtiofs: add a description of how to install virtiofsd

2025-04-08 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qm.adoc b/qm.adoc index 39cf492..44e2436 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1269,6 +1269,12 @@ Linux VMs with kernel >=5.4 support virtiofs by default (https://www.kernelconfig.io/CONFIG_VIRTIO_

[pve-devel] applied: [PATCH installer] btrfs: write /etc/kernel/cmdline unconditionally

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 21:18:06 +0200, Stoiko Ivanov wrote: > the recent change of handing the ESPs to proxmox-boot-tool broke > installation on btrfs booted with systemd-boot (currently efi-systems > without secureboot). our systemd-boot config-generation takes the > kernel commandline from /etc/kern

[pve-devel] [PATCH manager v6 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-08 Thread Aaron Lauterer
Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than via novnc. While the console button in the top right allows to manually choose the console type, the Console in the main subme

[pve-devel] [PATCH qemu-server, manager v6 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
We add a new property in the VM status/current API result that includes the display configurtion of the VM. This way we can check in the frontend what to do with it. I chose a nested return value, as that makes it easier to add/move additional display properties into it. Patch 1/4 makes two funct

Re: [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed

2025-04-08 Thread Stefan Hanreich
We should also consider adding frr-pythontools to the ISO, since otherwise applying doesn't work ootb. On 4/8/25 18:32, Stefan Hanreich wrote: > Fixes the issue of the FRR service getting started, but not enabled when > applying an SDN configuration and updates the docs to reflect the new > beha

Re: [pve-devel] [PATCH docs/network 0/2] improve behavior of frr service when pre-installed

2025-04-08 Thread Friedrich Weber
On 08/04/2025 18:32, Stefan Hanreich wrote: > Fixes the issue of the FRR service getting started, but not enabled when > applying an SDN configuration and updates the docs to reflect the new > behavior. - started with fresh ISO with sha256sum: 695c1c9b247e62d851d29d39c3e9399d3a15dd7c1bdca68b357b6

Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 14:13 schrieb Dominik Csapak: > By enabling the import button for qcow2/vmdk/raw files, and showing a > window with a VMID selector and the disk edit panel. > functionality wise I'd have applied that as it would be new and have thus almost no regression potential, might be also bett

Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI

2025-04-08 Thread Michael Köppl
On 4/8/25 14:13, Dominik Csapak wrote: this is a continuation of my previous series [0] It enables importing disks on the UI in the HardwareView of a vm, in the create wizard, and in the storage content view. I split the patches so that the wizard and storage content view one are separate, so t

[pve-devel] [PATCH proxmox-i18n] update Spanish translations

2025-04-08 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- es.po | 190 +++--- 1 file changed, 88 insertions(+), 102 deletions(-) diff --git a/es.po b/es.po index 1f2556a..a6d7288 100644 --- a/es.po +++ b/es.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: prox

[pve-devel] [PATCH proxmox-i18n] Update italian translation

2025-04-08 Thread Gabriel Goller
Typos and errors introduced by previous commit. Fixes: 99c75561ae98 ("update Italian translations") Signed-off-by: Gabriel Goller --- it.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/it.po b/it.po index e3128c5ba04b..95997e333272 100644 --- a/it.po +++ b/it.po @@ -

Re: [pve-devel] [PATCH qemu-server, manager v6 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
sent a v7 https://lore.proxmox.com/pve-devel/20250408122710.1164112-2-a.laute...@proxmox.com/T/#m54aae8f7595a1478748c2b61180c46d0cf52e38b On 2025-04-08 12:37, Aaron Lauterer wrote: We add a new property in the VM status/current API result that includes the display configurtion of the VM. This

Re: [pve-devel] [PATCH qemu-server, manager v7 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Hannes Duerr
Created a VM, started it and opened the console -> noVNC was selected added a serial device and selected Serial output as Display -> xtermjs was selected selected SPICE as Display -> noVNC was selected the patches behaved as i would have expected, please consider them Tested-by: Hannes Duerr

[pve-devel] [PATCH-SERIES http-server 0/3] fix disconnecting clients

2025-04-08 Thread Fiona Ebner
Commit 07e56cc ("fix unexpected EOF for client when closing TLS session") added a call to stoptls() before the call to shutdown() for the handle's file descriptor. However, the documentation for AnyEvent[0] mentions for stoptls(): > This method may invoke callbacks (and therefore the handle might

[pve-devel] [PATCH http-server 2/3] anyevent: always avoid re-entering client_do_disconnect() in on_error callback

2025-04-08 Thread Fiona Ebner
Commit f737984 ("fix #4816: do not disconnect twice if client sends no data") introduced a 'disconnected' flag in the request state to avoid duplicate calls to client_do_disconnect() for a given client. This works, except in the case where client_do_disconnect() enters the on_error callback itself.

[pve-devel] [PATCH docs] virtual machines: document importing disks from import storage

2025-04-08 Thread Dominik Csapak
Explain which formats can be imported and what the requirements for the storage are (content type). Give an example on how to import into an existing and new guest. Also note that images are copied, not moved and that they can't reference external files. Signed-off-by: Dominik Csapak --- qm.ado

[pve-devel] [PATCH i18n] update German translations

2025-04-08 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 226 +- 1 file changed, 98 insertions(+), 128 deletions(-) diff --git a/de.po b/de.po index 1c1965d..c291c2f 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox tra

[pve-devel] applied: [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 18:38:56 +0200, Friedrich Weber wrote: > Currently, as an unprivileged user with role PVEVMUser the GUI breaks > with an error after navigating to a VM's hardware tab. The reason is > that the frontend checks the GUI capabilites via `caps.mapping.hwrng`, > but `caps.mapping` doe

Re: [pve-devel] [PATCH i18n] update German translations

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 16:33 schrieb Shannon Sterz: > Signed-off-by: Shannon Sterz > --- > de.po | 226 +- > 1 file changed, 98 insertions(+), 128 deletions(-) Hmm, when trying to apply this (with b4) I got an warning: > @@ -5967,6 +5948,7 @@ msg

[pve-devel] [PATCH i18n v2] update German translations

2025-04-08 Thread Shannon Sterz
Signed-off-by: Shannon Sterz --- de.po | 226 +- 1 file changed, 98 insertions(+), 128 deletions(-) diff --git a/de.po b/de.po index 1c1965d..7339f83 100644 --- a/de.po +++ b/de.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: proxmox tra

Re: [pve-devel] [PATCH i18n] update German translations

2025-04-08 Thread Shannon Sterz
On Tue Apr 8, 2025 at 4:39 PM CEST, Thomas Lamprecht wrote: > Am 08.04.25 um 16:33 schrieb Shannon Sterz: >> Signed-off-by: Shannon Sterz >> --- >> de.po | 226 +- >> 1 file changed, 98 insertions(+), 128 deletions(-) > > > Hmm, when trying

Re: [pve-devel] [PATCH-SERIES http-server 0/3] fix disconnecting clients

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 16:20:11 +0200, Fiona Ebner wrote: > Commit 07e56cc ("fix unexpected EOF for client when closing TLS > session") added a call to stoptls() before the call to shutdown() for > the handle's file descriptor. However, the documentation for > AnyEvent[0] mentions for stoptls(): > >

[pve-devel] applied: [PATCH i18n v2] update German translations

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 16:51:46 +0200, Shannon Sterz wrote: > Applied, thanks! [1/1] update German translations commit: 5d3ea37c3c30c2fb26e1a065ecd7b5848a3e112c ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-b

Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Gabriel Goller
On 08.04.2025 12:18, Thomas Lamprecht wrote: Am 08.04.25 um 12:06 schrieb Gabriel Goller: On 07.04.2025 19:46, Thomas Lamprecht wrote: Am 08.01.25 um 15:38 schrieb Gabriel Goller: adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the returned data with the existing configuration. T

Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in network tab

2025-04-08 Thread Thomas Lamprecht
Am 08.04.25 um 14:15 schrieb Gabriel Goller: > If you want to take this in with this release, I can send a new version, > but I'd like to wait a bit to be honest. > > The Summary looks currently a bit rough, even with the scrollbar. Also > we can't differentiate between a dhcp ip-address or an add

[pve-devel] [PATCH manager v7 2/3] ui: vm create wizard: allow importing disks

2025-04-08 Thread Dominik Csapak
by adding a new 'import' button in the disk tab, which adds the same input panel as the one we have when doing an 'Import Hard Disk' for an existing VM. partially fixes #2424 Signed-off-by: Dominik Csapak --- www/manager6/panel/MultiDiskEdit.js | 36 + www/manager6/q

Re: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 15:25:17 +0200, Stefan Hanreich wrote: > The hostname provided to the methods in the IPAM plugins is empty for > VMs that do not have a name set. We always included the dns_name key > in the request, even if it was undefined, which leads Netbox to return > a 400 Bad Request erro

[pve-devel] applied: [PATCH] add patch to disable elastic_shared_blob to prevent crashing OSDs

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 12:39:04 +0200, Stoiko Ivanov wrote: > reported in our community forum and upstream: > https://forum.proxmox.com/threads/164735/ > https://tracker.ceph.com/issues/70390 > https://github.com/ceph/ceph/pull/62724 > > fix seems trivial, and the feature is quite new: > https://ceph

[pve-devel] applied: [PATCH access-control] openid: fix groups-claim regex

2025-04-08 Thread Thomas Lamprecht
On Tue, 08 Apr 2025 13:33:49 +0200, Mira Limbeck wrote: > The previous regex matched exactly that combination of characters, > rather than any combination of the specified ones. > > Applied, thanks! [1/1] openid: fix groups-claim regex commit: 55ab21ecfcd090ef7d364be39bdbb740391138a4 __

[pve-devel] [PATCH qemu-server 2/3] virtiofs: drop writeback option

2025-04-08 Thread Fiona Ebner
VirtIO-fs using writeback cache seems very broken at the moment. If a guest accesses a file (even just using 'touch'), that the host is currently writing, the guest can permanently end up with a truncated version of that file. Even subsequent operations like moving the file, will not result in the

Re: [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config

2025-04-08 Thread Thomas Lamprecht
On 08/04/2025 18:32, Stefan Hanreich wrote: > Since we now ship frr with Proxmox VE, the frr service is available on > the nodes but disabled on install. Prior to that users had to manually > install frr, which automatically enabled the service. When applying a > SDN configuration with an EVPN cont

[pve-devel] [PATCH installer] btrfs: write /etc/kernel/cmdline unconditionally

2025-04-08 Thread Stoiko Ivanov
the recent change of handing the ESPs to proxmox-boot-tool broke installation on btrfs booted with systemd-boot (currently efi-systems without secureboot). our systemd-boot config-generation takes the kernel commandline from /etc/kernel/cmdline - without this there is no root= parameter, and we end

Re: [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config

2025-04-08 Thread Stefan Hanreich
> On 08.04.2025 20:43 CEST Thomas Lamprecht wrote: > > > On 08/04/2025 18:32, Stefan Hanreich wrote: > > Since we now ship frr with Proxmox VE, the frr service is available on > > the nodes but disabled on install. Prior to that users had to manually > > install frr, which automatically enabl

  1   2   >