all 3 additions fail in the backend, if a user does not have VM.Config.HWType on the VM.
unify their display to cause less confusion, to the most recently added version for the rng. drop the now unused noHWPerm (eslint reminded me about that). found while reviewing: https://lore.proxmox.com/all/20250408195959.0b1f3...@rosa.proxmox.com/T/#t Signed-off-by: Stoiko Ivanov <s.iva...@proxmox.com> --- www/manager6/qemu/HardwareView.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index b949264f..480bbb3d 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -599,7 +599,6 @@ Ext.define('PVE.qemu.HardwareView', { }); // heuristic only for disabling some stuff, the backend has the final word. - const noHWPerm = !caps.nodes['Sys.Console'] && !caps.mapping['Mapping.Use']; const noVMConfigHWTypePerm = !caps.vms['VM.Config.HWType']; const noVMConfigNetPerm = !caps.vms['VM.Config.Network']; const noVMConfigDiskPerm = !caps.vms['VM.Config.Disk']; @@ -607,8 +606,8 @@ Ext.define('PVE.qemu.HardwareView', { const noVMConfigCloudinitPerm = !caps.vms['VM.Config.Cloudinit']; const noVMConfigOptionsPerm = !caps.vms['VM.Config.Options']; - me.down('#addUsb').setDisabled(noHWPerm || isAtUsbLimit()); - me.down('#addPci').setDisabled(noHWPerm || isAtLimit('hostpci')); + me.down('#addUsb').setDisabled(noVMConfigHWTypePerm || isAtUsbLimit()); + me.down('#addPci').setDisabled(noVMConfigHWTypePerm || isAtLimit('hostpci')); me.down('#addAudio').setDisabled(noVMConfigHWTypePerm || isAtLimit('audio')); me.down('#addSerial').setDisabled(noVMConfigHWTypePerm || isAtLimit('serial')); me.down('#addNet').setDisabled(noVMConfigNetPerm || isAtLimit('net')); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
