Am 08.04.25 um 12:37 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer <a.laute...@proxmox.com> > --- > newly introduced with v6 > > PVE/QemuServer.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index ccdceed..b7ef69b 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -1159,7 +1159,7 @@ sub kvm_version { > return $kvm_api_version; > } > > -my sub extract_version { > +sub extract_version {
This is named too generally to make public. And there is no need to make it public if you use PVE::QemuServer::Machine::extract_version() for the new caller in the next patch. We could think about merging this helper with PVE::QemuServer::Machine::extract_version(), but totally orthogonal to this series. > my ($machine_type, $version) = @_; > $version = kvm_user_version() if !defined($version); > return PVE::QemuServer::Machine::extract_version($machine_type, $version) > @@ -3414,7 +3414,7 @@ my sub print_ovmf_drive_commandlines { > return ("if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code", > $var_drive_str); > } > > -my sub get_vga_properties { > +sub get_vga_properties { > my ($conf, $arch, $machine_version, $winversion) = @_; > > my $vga = parse_vga($conf->{vga}); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel