[pve-devel] [PATCH proxmox-backup-restore-image 4/5] update ubuntu-kernel to Ubuntu-6.14.0-22.22

2025-06-02 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/submodules/ubuntu-kernel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/submodules/ubuntu-kernel b/src/submodules/ubuntu-kernel index 9f8b45f..2591c2a 16 --- a/src/submodules/ubuntu-kernel +++ b/src/submodules/ubuntu-kernel @@ -1

[pve-devel] [PATCH proxmox-backup-restore-image 2/5] update ZFS to 2.3.2

2025-06-02 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/submodules/zfsonlinux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/submodules/zfsonlinux b/src/submodules/zfsonlinux index 55dd24c..92f430b 16 --- a/src/submodules/zfsonlinux +++ b/src/submodules/zfsonlinux @@ -1 +1

[pve-devel] [PATCH proxmox-backup-restore-image 3/5] build initramfs: remove additional ZFS scripts

2025-06-02 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/build_initramfs.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/src/build_initramfs.sh b/src/build_initramfs.sh index 52a50c3..0cccb90 100755 --- a/src/build_initramfs.sh +++ b/src/build_initramfs.sh @@ -104,6 +104,7 @@ if [ -z "$DOWNLOAD_ONLY&quo

[pve-devel] [PATCH proxmox-backup-restore-image 5/5] kernel: enable more filesystem options

2025-06-02 Thread Stoiko Ivanov
options selected with looking through make menuconfig based on current config-base in kernel 6.14. Signed-off-by: Stoiko Ivanov --- src/config-base | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/config-base b/src/config-base index edd95c1..fcebf07 100644 --- a

[pve-devel] [PATCH proxmox-backup/proxmox-backup-restore-image] update and adapt to ZFS 2.3 and kernel 6.14

2025-06-02 Thread Stoiko Ivanov
config options for newly added filesystems to add. Tested minimally with a backup of a VM containing a zpool. proxmox-backup-restore-image: Stoiko Ivanov (5): build initramfs: usr-merge initramfs update ZFS to 2.3.2 build initramfs: remove additional ZFS scripts update ubuntu-kernel to Ubuntu

[pve-devel] [PATCH proxmox-backup-restore-image 1/5] build initramfs: usr-merge initramfs

2025-06-02 Thread Stoiko Ivanov
dpkg does to unpack archives, as `dpkg-deb -x` removed the symlinks to create a directory. [0] https://wiki.debian.org/UsrMerge [1] https://salsa.debian.org/dpkg-team/dpkg/-/blob/main/src/main/unpack.c?ref_type=heads#L1544 Signed-off-by: Stoiko Ivanov --- src/build_initramfs.sh | 9 +++-- 1

[pve-devel] [PATCH proxmox-backup 1/1] restore-daemon: adapt to zpool output changes in 2.3

2025-06-02 Thread Stoiko Ivanov
mands provide JSON. the change was probably introduced in zfs upstream commit: 5137c132a ("zpool import output is not formated properly.") [0] https://github.com/openzfs/zfs/issues/17084 Signed-off-by: Stoiko Ivanov --- proxmox-restore-daemon/src/proxmox_restore_daemon/disk.rs | 2 +- 1

[pve-devel] [PATCH zfsonlinux 4/5] d/control: record conflict with nordugrid-arc-client

2025-05-27 Thread Stoiko Ivanov
779b5232db366c4e48b159a76cb0d18be4452273 Signed-off-by: Stoiko Ivanov --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index f2688dfac..8be70d999 100644 --- a/debian/control +++ b/debian/control @@ -213,7 +213,7 @@ Architecture

[pve-devel] [PATCH zfsonlinux 5/5] d/lintian-overrides: adapt to renamed tags

2025-05-27 Thread Stoiko Ivanov
based on upstream https://salsa.debian.org/zfsonlinux-team/zfs/ commit f575e949292670934e1b6ced6e7c41e2072c Signed-off-by: Stoiko Ivanov --- debian/zfs-test.lintian-overrides | 4 ++-- debian/zfsutils-linux.lintian-overrides | 11 ++- 2 files changed, 8 insertions(+), 7

[pve-devel] [PATCH zfsonlinux 2/5] d/: move some tools out of /usr/sbin and add links for compatibility

2025-05-27 Thread Stoiko Ivanov
/proc/spl/kstat. See: #1064835, #1063457 Originally-by: Shengqi Chen Signed-off-by: Stoiko Ivanov --- debian/rules | 8 debian/zfsutils-linux.install | 6 +++--- debian/zfsutils-linux.links | 3 +++ 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/debian

[pve-devel] [PATCH zfsonlinux 1/5] cherry-pick usr-merge fix for libzfs6linux

2025-05-27 Thread Stoiko Ivanov
598 for the details. based on commit 0431247714965007bc156fd57852689b395b2bae https://salsa.debian.org/zfsonlinux-team/zfs/ Originally-by: Shengqi Chen Signed-off-by: Stoiko Ivanov --- debian/libzfs6linux.postrm | 15 +++ debian/libzfs6linux.preinst | 16 2 fi

[pve-devel] [PATCH zfsonlinux 0/5] port some changes from salsa.d.o

2025-05-27 Thread Stoiko Ivanov
the linked bugs.d.o report), but afaict the deletion is racy and does not happen often. Tested by comparing the resulting deb-packages with the ones without the patches via diffoscope, and running the package on 2 VMs with replication and ztest. Stoiko Ivanov (5): cherry-pick usr-merge fix for

[pve-devel] [PATCH zfsonlinux 3/5] usr-merge: synchronize debian/ with upstream

2025-05-27 Thread Stoiko Ivanov
minor changes found by `diff -ru` on debian/ with the one in debian-upstream based on https://salsa.debian.org/zfsonlinux-team/zfs/ commits: 3b029ca123417535a53efa23f54975649924c66c 3b029ca123417535a53efa23f54975649924c66c Signed-off-by: Stoiko Ivanov --- debian/libzfslinux-dev.install.in

[pve-devel] [PATCH pve-kernel] cherry-pick additional fix for AMD Epyc genua systems

2025-04-14 Thread Stoiko Ivanov
stems") Signed-off-by: Stoiko Ivanov --- ...ine-ae4dma-Remove-deprecated-PCI-IDs.patch | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 patches/kernel/0016-dmaengine-ae4dma-Remove-deprecated-PCI-IDs.patch diff --git a/patches/kernel/0016-dmaengine-ae4dma-Remove-

[pve-devel] [PATCH pve-kernel] cherry-pick fixes for AMD Epyc genua systems

2025-04-10 Thread Stoiko Ivanov
-basavaraj.nati...@amd.com/ [0] before proxmox-boot-cleanup.service (so pinning with --next-boot did not help) Signed-off-by: Stoiko Ivanov --- ...-Use-the-MSI-count-and-its-correspon.patch | 31 +++ ...Utilize-the-AE4DMA-engine-s-multi-qu.patch | 201 ++ 2 files changed, 232

Re: [pve-devel] [PATCH pve-network 1/1] frr: enable frr service on reloading the controller config

2025-04-08 Thread Stoiko Ivanov
On Tue, 8 Apr 2025 20:43:17 +0200 Thomas Lamprecht wrote: > On 08/04/2025 18:32, Stefan Hanreich wrote: > > Since we now ship frr with Proxmox VE, the frr service is available on > > the nodes but disabled on install. Prior to that users had to manually > > install frr, which automatically enable

[pve-devel] [PATCH installer] btrfs: write /etc/kernel/cmdline unconditionally

2025-04-08 Thread Stoiko Ivanov
future, at the expense of 3 change-sites which are quite far apart. Fixes: dc5b8d7 ("btrfs: use proxmox-boot-tool to sync ESPs for RAID installs") Signed-off-by: Stoiko Ivanov --- tested minimally with a vm with a single disk booted with a efi-disk without enrolled keys - as this is what

[pve-devel] [PATCH manager] ui: qemu: unify enabled state of pci, usb and rng

2025-04-08 Thread Stoiko Ivanov
/20250408195959.0b1f3...@rosa.proxmox.com/T/#t Signed-off-by: Stoiko Ivanov --- www/manager6/qemu/HardwareView.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index b949264f..480bbb3d 100644 --- a

Re: [pve-devel] [PATCH manager] ui: qemu: hardware view: fix hwrng cap check for unprivileged users

2025-04-08 Thread Stoiko Ivanov
never > evaluated. > > Fixes: a47a8afb ("ui: let non-root users configure VirtIO RNG devices") > Signed-off-by: Friedrich Weber Thanks for tackling this so quick! Managed to reproduce the original issue - your patch fixes it for me as well! it improves the current situation s

[pve-devel] [PATCH] add patch to disable elastic_shared_blob to prevent crashing OSDs

2025-04-08 Thread Stoiko Ivanov
%20Squid.pdf Signed-off-by: Stoiko Ivanov --- the commit message was re-used for both the patch-file and the commit itself hope that's ok? did not build this - as it'd take quite long. only verified that this setting is set to true (for all OSDs irrespective when they were created) with o

[pve-devel] [PATCH zfsonlinux 5/8] d/control: remove transitional dummy package spl

2025-04-05 Thread Stoiko Ivanov
debian upstream did this in 2021, but I overlooked that back then[0]. [0] https://salsa.debian.org/zfsonlinux-team/zfs/-/commit/50841f137b225746a549d3dac98cc6b05a39e4dd Signed-off-by: Stoiko Ivanov --- Makefile | 1 - debian/control | 19 --- 2 files changed, 20

[pve-devel] [PATCH pve-firmware] iwlwifi-extra: update list of forced inclusions

2025-04-05 Thread Stoiko Ivanov
. Follows commit bebdf38 ("iwl 5.19 extra: force some ibt (intel bluetooth) fw inclusion") [0] https://packages.debian.org/sid/all/firmware-iwlwifi/filelist Reported-by: Moayad Almalat Signed-off-by: Stoiko Ivanov -- hope I'm not overlooking a more sophisticated process for compili

[pve-devel] [PATCH zfsonlinux 3/8] d/copyright: remove files deleted by upstream

2025-04-05 Thread Stoiko Ivanov
Signed-off-by: Shengqi Chen (cherry picked from commit d9b0863953ff843f103bb45e33c410d4e0db5c24) Signed-off-by: Stoiko Ivanov --- debian/copyright | 7 --- 1 file changed, 7 deletions(-) diff --git a/debian/copyright b/debian/copyright index 4ac98c266..6beb70757 100644 --- a/debian

[pve-devel] [PATCH zfsonlinux 6/8] d/control: libzfslinux-dev Depends: libtirpc-dev, zlib1g-dev (Closes: #1095855)

2025-04-05 Thread Stoiko Ivanov
follows debian-upstream commit e6dc49f60a43045ef87cf683305e03c864274aac Originally-by: наб Signed-off-by: Stoiko Ivanov --- debian/control | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 6ee22da9e..5a3ac6867 100644 --- a/debian

Re: [pve-devel] [PATCH manager/docs 0/4] fix #2413: make target for ballooning configurable

2025-04-04 Thread Stoiko Ivanov
ing for a VM of mine and running `pvestatd start --debug 1`, watching it inflate the balloon and the setting the target to 99%, watching it deflate it again). For me this can be applied as-is: Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov > > [1] https://bugzilla.proxmox.com/show

Re: [pve-devel] [PATCH docs v3 1/1] qm: pve machine version: add section to explain +pveX versions

2025-04-04 Thread Stoiko Ivanov
some suggestions for rephrasings inline: On Fri, 4 Apr 2025 14:53:45 +0200 Dominik Csapak wrote: > and clarify what windows guests will be pinned to. > > Signed-off-by: Dominik Csapak > --- > changes from v2: > * mention that windows gets pinned during guest creation > > qm.adoc | 15 +++

Re: [pve-devel] [PATCH qemu-server/docs v3] disable S3/S4 power states by default

2025-04-04 Thread Stoiko Ivanov
followed-up, if they are sensible imho) I'll send as reply to the patch. with and without those addressed for the series: Reviewed-by: Stoiko Ivanov Tested-By: Stoiko Ivanov [0] https://www.kernel.org/doc/Documentation/power/states.txt [1] https://learn.microsoft.com/en-us/windows-hardware/dr

[pve-devel] [PATCH zfsonlinux 4/8] d/control: Bump library SONAMEs: libzfs4 -> libzfs6, libzpool5 -> libzpool6

2025-04-01 Thread Stoiko Ivanov
follows debian-upstream commit 9b1a98603ee3231aaa13782688c5888bc9c939de Signed-off-by: Stoiko Ivanov --- Makefile | 4 ++-- debian/control | 18 +- .../{libzfs4linux.docs => libzfs6linux.docs} |

[pve-devel] [PATCH zfsonlinux 0/8] update to ZFS 2.3.1

2025-03-31 Thread Stoiko Ivanov
a59116fa4e7 looked up after skimming through: https://github.com/openzfs/zfs/issues/17052 [0] https://salsa.debian.org/zfsonlinux-team/zfs/ [1] https://github.com/openzfs/zfs/pull/17137 Stoiko Ivanov (8): update zfs submodule to 2.3.1 and refresh patches Install new manpages for zpool-{ddtprune,pr

[pve-devel] [PATCH zfsonlinux 8/8] cherry-pick fix for ABI break from zfs 2.3.2-staging

2025-03-31 Thread Stoiko Ivanov
without this patch many common operations break when running with a kernel module < 2.3.1. Noticed while testing replication with our current 2.2.7 module and userspace from 2.3.1 Signed-off-by: Stoiko Ivanov --- ...ount-matches-and-injections-for-each.patch | 500 ++ deb

[pve-devel] [PATCH zfsonlinux 7/8] d/control: add Multi-Arch attributes for binary packages

2025-03-31 Thread Stoiko Ivanov
follows debian-upstream commit e83f1857d5dbf4efd0c3f1351644c8ce88bc2654 Signed-off-by: Stoiko Ivanov --- debian/control | 9 + 1 file changed, 9 insertions(+) diff --git a/debian/control b/debian/control index 5a3ac6867..50196019f 100644 --- a/debian/control +++ b/debian/control

[pve-devel] [PATCH zfsonlinux 1/8] update zfs submodule to 2.3.1 and refresh patches

2025-03-31 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...META-and-DCH-consistency-in-autoconf.patch | 2 +- .../0002-always-load-ZFS-module-on-boot.patch | 2 +- ...o-the-zed-binary-on-the-systemd-unit.patch | 2 +- ...ith-d-dev-disk-by-id-in-scan-service.patch | 2 +- debian/patches/0005-Enable-zed

[pve-devel] [PATCH zfsonlinux 2/8] Install new manpages for zpool-{ddtprune, prefetch}

2025-03-31 Thread Stoiko Ivanov
Signed-off-by: Shengqi Chen (cherry picked from commit 4d3133d3e1d6073969972cefd9bd7254d342ab8f) Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index 2fd7aefe7

[pve-devel] [RFC pve-kernel] add disable_write_zeroes quirk for Crucial T700 and T705

2025-03-19 Thread Stoiko Ivanov
/write_zeroes_max_bytes). however as the T705 drives in our pool are all in use the test there was limited to a rather small LV of 350M (still the change was from 5 seconds to 0.5 seconds). Signed-off-by: Stoiko Ivanov --- sending as RFC, as I'm not certain if that approach makes sense in general, or if

Re: [pve-devel] [PATCH zfsonlinux] patches: fix for zvol sync/flush regression

2025-03-11 Thread Stoiko Ivanov
Thanks for analysis and preparing the patch! LGTM - gave it a spin on a VM (with nested guest for testing) on kernel 6.8 - works as expected. Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Tue, 11 Mar 2025 09:44:03 +0100 Fabian Grünbichler wrote: > this broke with 2.2.7, and

[pve-devel] [PATCH dab-pve-appliances] pmg: use non-virtual package for dbus

2025-03-04 Thread Stoiko Ivanov
missed updating the patch before sending. Fixes: 524c142 ("fix #5700: pmg: add dbus to installed packages") Signed-off-by: Stoiko Ivanov --- sorry for the noise - noticed while checking out Thomas' improvment to patch 1 - thx for that! debian-12-bookworm-pmg-8-64/Makefile | 2 +-

[pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries

2025-03-04 Thread Stoiko Ivanov
no semantic change intended. adding new packages causes a bit of churn in the diff otherwise Signed-off-by: Stoiko Ivanov --- debian-12-bookworm-pmg-8-64/Makefile | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/debian-12-bookworm-pmg-8-64/Makefile b

[pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template

2025-03-04 Thread Stoiko Ivanov
the request seems sensible, and dbus is usually present on current debian systems. the regular debian-template is not affected, because it installs all packages with priority standard (dbus has priority standard) minimally tested the result locally. Stoiko Ivanov (2): pmg: reformat dab

[pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages

2025-03-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian-12-bookworm-pmg-8-64/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/debian-12-bookworm-pmg-8-64/Makefile b/debian-12-bookworm-pmg-8-64/Makefile index 55e6424..0f4a70a 100644 --- a/debian-12-bookworm-pmg-8-64/Makefile +++ b/debian-12-bookworm

[pve-devel] [PATCH pve-kernel v2] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-22 Thread Stoiko Ivanov
CDN nodes Signed-off-by: Stoiko Ivanov --- v1->v2: * drop mistakenly added KREL increment - thx @Thomas for noticing. replaces: https://lore.proxmox.com/pve-devel/20250120192712.1642091-1-s.iva...@proxmox.com/ Makefile | 17 + README | 5 + 2 files changed, 14 insertions(+)

Re: [pve-devel] [PATCH pve-kernel] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-22 Thread Stoiko Ivanov
On Wed, 22 Jan 2025 15:49:06 +0100 Thomas Lamprecht wrote: > Am 20.01.25 um 20:27 schrieb Stoiko Ivanov: > > Can be used to generate a package for testing a particular bugfix, or > > new version, which can be shared with a small audience, without > > reusing the curren

[pve-devel] [PATCH pve-kernel] buildsys: add explicit DEB_VERSION variable in Makefile

2025-01-20 Thread Stoiko Ivanov
CDN nodes Signed-off-by: Stoiko Ivanov --- Makefile | 19 ++- README | 5 + 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index d069d5ac3183..cbd47ccce02a 100644 --- a/Makefile +++ b/Makefile @@ -6,11 +6,12 @@ KERNEL_MIN=11 KERNEL_PAT

Re: [pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.2.7 and refresh patches

2025-01-15 Thread Stoiko Ivanov
On Thu, 12 Dec 2024 18:01:45 +0100 Stoiko Ivanov wrote: > drop the cherry-picked kernel 6.11 compatibility patches. > > this upstream release [0] is a bit larger than usual, and might have a bit > of potential for regressions. While catching up on upstream's changes (in con

[pve-devel] maintenance downtime of lore.proxmox.com (list-archive)

2024-12-18 Thread Stoiko Ivanov
Hi, We will run maintenance on parts of our infrastructure, which hosts https://lore.proxmox.com - our public-inbox instance used for archiving our mailing-lists. The service will be unavailable for a short period. Best Regards, Stoiko Ivanov

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.2.7 and refresh patches

2024-12-12 Thread Stoiko Ivanov
tainers and storage replication, additionally I installed that version on a VM with / on ZFS - mostly for checking 308d04ac3 in our environment. [0] https://github.com/openzfs/zfs/releases/tag/zfs-2.2.7 Signed-off-by: Stoiko Ivanov --- >From a quick skim at upstream's channels I think th

[pve-devel] [PATCH installer] unconfigured.sh: set kernel.printk to level warn

2024-11-26 Thread Stoiko Ivanov
imply set the sysctl to log only messages of level warn and above to the console. Tested in a VM, where I manually ran the command before starting the TUI installer (and selecting XFS as filesystem there). without it the messages got displayed, with the command they did not. Signed-off-by: Stoiko I

[pve-devel] [PATCH pve-kernel/master 0/2] fix two small issues with IOMMU in certain setups

2024-11-26 Thread Stoiko Ivanov
-upstream, as this broke iGPU passthrough for old Intel-CPUs (without the patch users affected by the issue reported to Ubuntu had the options of disabling iommu via kernel-cmdline anyways). I'd suggest pulling patch 2/2 also for our kernel 6.8. Stoiko Ivanov (2): fix #5926: cherry-pick ACS-

[pve-devel] [PATCH pve-kernel/master 1/2] fix #5926: cherry-pick ACS-quirk fix from linux-stable/6.11.7

2024-11-26 Thread Stoiko Ivanov
the latest linux-stable pull I found in ubuntu-oracular was for 6.11.5 - this fix here seems targeted enough. see also the discussion upstream: https://lore.kernel.org/all/20241029163317.ga216...@nvidia.com/ Signed-off-by: Stoiko Ivanov --- ...nable_acs-support-for-the-ACS-quirks.patch | 68

[pve-devel] [PATCH pve-kernel/master 2/2] revert Ubuntu patch disabling IOMMU functionality for Skylake iGPU

2024-11-26 Thread Stoiko Ivanov
appen after we get some feedback that it indeed fixes the issue of the reporters in the forum) Signed-off-by: Stoiko Ivanov --- ...UCE-iommu-intel-disable-DMAR-for-SKL.patch | 53 +++ 1 file changed, 53 insertions(+) create mode 100644 patches/kernel/0017-Revert-UBUNTU-SAUCE-iommu-

[pve-devel] [pve-network] d/postinst: do not break, if ipam-file moves fail

2024-11-20 Thread Stoiko Ivanov
/ipam cache/state files") Signed-off-by: Stoiko Ivanov --- noticed while looking at another small issue, and was reminded about the recent change for ifupdown2: https://lore.proxmox.com/pve-devel/20241113190113.678807-1-s.iva...@proxmox.com/ debian/libpve-network-perl.postinst | 4 ++-- 1 fi

Re: [pve-devel] [PATCH pve-docs v2 4/4] sdn: add documentation for isolated ports option

2024-11-19 Thread Stoiko Ivanov
On Tue, 19 Nov 2024 11:06:12 +0100 Hannes Dürr wrote: > I like your changes, but I would adapt the description more to the > bridge manpage [0]. > > [0] https://www.man7.org/linux/man-pages/man8/bridge.8.html > > On 11/18/24 19:52, Stoiko Ivanov wrote: > > On Tue, 12

[pve-devel] [PATCH cluster 1/1] cfs: add 'sdn/mac-cache.json' to observed files

2024-11-18 Thread Stoiko Ivanov
follows commit: d8ef05c (cfs: add 'sdn/pve-ipam-state.json' to observed files) with the same motivation - the data in the macs.db file is a cache, to prevent unneccessary lookups to external IPAM modules - is not private in the sense of secrets for external resources. Signed-off-by: Sto

[pve-devel] [pve-cluster/pve-network] move macs.db from priv/ to sdn/

2024-11-18 Thread Stoiko Ivanov
should probably also be moved to a non-root-exclusive directory. >From a quick glance the remaining files in `priv/` do belong there. minimally tested this on my machine. pve-cluster: Stoiko Ivanov (1): cfs: add 'sdn/mac-cache.json' to observed files src/PVE/Cluster.pm | 3 ++

[pve-devel] [pve-network 1/1] ipam: move mac-cache.db to unprivileged sdn/ subdirectory

2024-11-18 Thread Stoiko Ivanov
be used to hijack (external systems) - the mac-cache can be kept next to the remaining sdn-config. minimally tested on my machine. depends on the pve-cluster commit sent with this. Signed-off-by: Stoiko Ivanov --- src/PVE/Network/SDN/Ipams.pm | 29 +++-- 1 file changed, 27

Re: [pve-devel] [PATCH pve-docs v2 4/4] sdn: add documentation for isolated ports option

2024-11-18 Thread Stoiko Ivanov
On Tue, 12 Nov 2024 16:54:25 +0100 Stefan Hanreich wrote: > Signed-off-by: Stefan Hanreich > --- > pvesdn.adoc | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/pvesdn.adoc b/pvesdn.adoc > index 39de80f..b1f2578 100644 > --- a/pvesdn.adoc > +++ b/pvesdn.adoc > @@ -383,6 +383,11 @@

Re: [pve-devel] [PATCH pve-common v2 1/4] tap_plug: add support for bridge port isolation

2024-11-18 Thread Stoiko Ivanov
e doc-suggestions: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Tue, 12 Nov 2024 16:54:22 +0100 Stefan Hanreich wrote: > From: Alexandre Derumier via pve-devel > > This is allow to block traffic/isolation traffic between all ports > on the bridge with isolation (so between th

Re: [pve-devel] [PATCH storage] dirplugin: fix #3986: check for trailing slashes

2024-11-13 Thread Stoiko Ivanov
Thanks for tackling this long-open issue! On Wed, Nov 13, 2024 at 05:32:49PM +0100, Daniel Herzig wrote: > This patch removes trailing slashes from manually entered > paths by adding an additional if clause in the sub > check_config. For me the context of the change, and why something in the commi

[pve-devel] [RFC ifupdown2] d/maintscripts: use postinst arguments to determine first install

2024-11-13 Thread Stoiko Ivanov
on should be limited. Originally introduced in: 849ae55de6454ea4631de0899182c148c954e46a Fixes: 8d5303c35044b612afc68eec1dc5bc265a5dd328 Signed-off-by: Stoiko Ivanov --- sending as RFC, as I'm not sure that the small cosmetic fix is worth the potetial regressions at all, but after spending a bit to

[pve-devel] [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install

2024-11-13 Thread Stoiko Ivanov
on first-install, as this got shifted around a bit and it took me too long to see that we did not want to error out here on purpose Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d Signed-off-by: Stoiko Ivanov --- debian/ifupdown2.postinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [pve-devel] [PATCH common/qemu-server v2] improve sysfs write behaviour

2024-11-08 Thread Stoiko Ivanov
gave this another spin on my reproducer for the failing device-reset - still works fine! 2 cosmetic nits for the patches aside - which from my pov can also be left as is (or maybe fixed up when applying): Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Fri, 8 Nov 2024 10:32:57 +0100

Re: [pve-devel] [PATCH common v2 2/2] sysfstools: fix regression on binding to vfio-pci

2024-11-08 Thread Stoiko Ivanov
On Fri, 8 Nov 2024 10:32:59 +0100 Dominik Csapak wrote: > when starting a vm with passthrough, we have to bind all normal pci > devices to vfio-pci. This happens by > > * unbinding from current driver > * telling vfio-pci the 'vendorid modelid' combo to it know this device s/to it know/so it kn

Re: [pve-devel] [PATCH common v2 1/2] sysfstools: file_write: extend with logging and ignore list

2024-11-08 Thread Stoiko Ivanov
2 cosmetic nits inline: On Fri, 8 Nov 2024 10:32:58 +0100 Dominik Csapak wrote: > the actual error and path is useful to know when trying to debug or > figure out what did not work, so warn here if there was an error. > > Also takes now an optional error list that can be ignored. If > encounter

Re: [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough

2024-11-05 Thread Stoiko Ivanov
On Tue, 5 Nov 2024 10:24:21 +0100 Dominik Csapak wrote: > Since pve-common commit: > > eff5957 (sysfstools: file_write: properly catch errors) > > this check here fails now when the reset does not work. It turns out > that resetting the device is not always necessary, and we previously > igno

Re: [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour

2024-11-05 Thread Stoiko Ivanov
; to '/sys/bus/pci/devices/:01:00.0/reset': Inappropriate ioctl for device can't reset PCI device ':01:00.0' ``` (similarly this is the output when starting on the commandline with `qm start `) with or without the nit/idea for the qemu-server 1/1 patch conside

[pve-devel] [PATCH installer] installer-common: do not drop nomodeset from target kernel cmdline

2024-10-30 Thread Stoiko Ivanov
: a02a78a865fc37f7bdea077a4421319b84c635c9 Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- minimally tested by redoing the change in the second debug shell and installing in a VM w/ secure boot disabled (nomodeset breaks the debugshells if secureboot is enabled) one remaining question is if we want to also preserve the

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.2.6

2024-09-05 Thread Stoiko Ivanov
patches did not need adaptation Signed-off-by: Stoiko Ivanov --- upstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upstream b/upstream index 25665920..baa50314 16 --- a/upstream +++ b/upstream @@ -1 +1 @@ -Subproject commit 2566592045780e7be7afc899c2496b1ae3af4f4d

[pve-devel] [PATCH zfsonlinux 2/2] debian: remove libzfsbootenv1linux.install

2024-09-05 Thread Stoiko Ivanov
Fixes: fd0cc4becda91c46991e723ae6f0b08dcdf661e6 Signed-off-by: Stoiko Ivanov --- debian/libzfsbootenv1linux.install | 1 - 1 file changed, 1 deletion(-) delete mode 100644 debian/libzfsbootenv1linux.install diff --git a/debian/libzfsbootenv1linux.install b/debian/libzfsbootenv1linux.install deleted file mode 100644 index 01d

[pve-devel] [PATCH zfsonlinux 0/2] update ZFS to 2.2.6

2024-09-05 Thread Stoiko Ivanov
github.com/openzfs/zfs/pull/16359/commits/6f27c4cadd29eb9b850c1c66bf71ef9ba119b955 https://github.com/openzfs/zfs/pull/16359/commits/ef08cb26dae6b3c2e930e66852f13329babb7c2e [0] https://github.com/openzfs/zfs/pull/16359 Stoiko Ivanov (2): update zfs submodule to 2.2.6 debi

Re: [pve-devel] [PATCH storage v2] api: disks: zfs: enable monthly scrub when creating a pool

2024-08-28 Thread Stoiko Ivanov
On Tue, 27 Aug 2024 16:24:33 +0200 Maximiliano Sandoval wrote: > And disable it when destroying the pool. > can be fine in general - but why? our packages ship: /etc/cron.d/zfsutils-linux (and /usr/lib/zfs-linux/scrub) which does (afair) run a monthly scrub (and trim) under certain conditions (i

[pve-devel] [PATCH zfsonlinux 4/5] d/zfsutils-linux.install: move most exectuables from sbin to bin

2024-08-20 Thread Stoiko Ivanov
/proc/spl/kstat. differences: we never shipped zvol_wait and zilstat in /sbin, so no need for the compatibility symlink. [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/rules | 6 -- debian/zfsutils-linux.install | 6 +++--- debian/zfs

[pve-devel] [PATCH zfsonlinux 0/5] update to ZFS 2.2.5 and opt-in to usrmerge

2024-08-20 Thread Stoiko Ivanov
few containers with replication configured. additionally installed a VM with ZFS on / and checked that the usrmerge did not prevent it from booting. [0] https://github.com/openzfs/zfs/pull/16359 [1] https://salsa.debian.org/zfsonlinux-team/zfs Stoiko Ivanov (5): update zfs submodule to 2.

[pve-devel] [PATCH zfsonlinux 2/5] debian: remove libzfsbootenv1linux.install

2024-08-20 Thread Stoiko Ivanov
Fixes: fd0cc4becda91c46991e723ae6f0b08dcdf661e6 Signed-off-by: Stoiko Ivanov --- debian/libzfsbootenv1linux.install | 1 - 1 file changed, 1 deletion(-) delete mode 100644 debian/libzfsbootenv1linux.install diff --git a/debian/libzfsbootenv1linux.install b/debian/libzfsbootenv1linux.install deleted file mode 100644 index 01d

[pve-devel] [PATCH zfsonlinux 3/5] debian: install files to /usr

2024-08-20 Thread Stoiko Ivanov
follows commit 902967808693510631a198414dc57dc4ca564afe in debian upstream [0], which was done to support usrmerge [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/libnvpair3linux.install.in | 2 +- debian/libpam-zfs.install

[pve-devel] [PATCH zfsonlinux 1/5] update zfs submodule to 2.2.5

2024-08-20 Thread Stoiko Ivanov
patches did not need adaptation Signed-off-by: Stoiko Ivanov --- upstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upstream b/upstream index 25665920..33174af1 16 --- a/upstream +++ b/upstream @@ -1 +1 @@ -Subproject commit 2566592045780e7be7afc899c2496b1ae3af4f4d

[pve-devel] [PATCH zfsonlinux 5/5] d/NEWS: add news for usr-merge

2024-08-20 Thread Stoiko Ivanov
to raise awareness for the changed paths (NEWS entries get displayed when installing updates). follows commit 20e286d2f5c8752ac1372cd084729147cf276f3f in debian upstream [0]. [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/NEWS | 13 + 1

Re: [pve-devel] [PATCH storage] storage: add bzip2 support

2024-08-02 Thread Stoiko Ivanov
oper_Documentation#Commits_and_Commit_Messages Your colleagues preparing the release-notes will be grateful. > > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5267 > > Suggested-by: Stoiko Ivanov > Signed-off-by: Maximiliano Sandoval > --- > > For the sake of not having a c

[pve-devel] [PATCH manager] pve7to8: fix typo in log message

2024-07-10 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- noticed while pulling the changes over to pmg7to8 PVE/CLI/pve7to8.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 940fb5c6..416ec79b 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/pve7to8.pm

Re: [pve-devel] [PATCH proxmox-offline-mirror 0/2] remove snapshot directories vanished on source also on medium

2024-07-09 Thread Stoiko Ivanov
superseded-by: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064545.html On Mon, 24 Jun 2024 21:57:10 +0200 Stoiko Ivanov wrote: > This patchset fixes a small glitch that we noticed in a pom-setup, creating > regular snapshots, without cleaning them up regularly. > >

[pve-devel] [PATCH proxmox-offline-mirror v2 1/5] bump proxmox-apt to 0.11 and adapt to changes.

2024-07-09 Thread Stoiko Ivanov
The recent changes to proxmox-apt along with the introduction of the proxmox_apt_apit_types crate led to the following changes. Signed-off-by: Stoiko Ivanov --- Cargo.toml | 3 ++- debian/control | 3 ++- src/lib.rs | 5 +++-- src/mirror.rs | 11 +-- 4 files changed, 12

[pve-devel] [PATCH proxmox-offline-mirror v2 4/5] pool: gc: remove empty directories under link_dir

2024-07-09 Thread Stoiko Ivanov
/walkdir/latest/walkdir/struct.WalkDir.html#method.contents_first Signed-off-by: Stoiko Ivanov --- src/pool.rs | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/pool.rs b/src/pool.rs index b4f2a6a..56dcbb4 100644 --- a/src/pool.rs +++ b/src/pool.rs @@ -451,6 +451,7

[pve-devel] [PATCH proxmox-offline-mirror v2 3/5] pool: unlink_file: fix check for empty directory

2024-07-09 Thread Stoiko Ivanov
-time. [0] https://docs.rs/nix/latest/nix/trait.NixPath.html#tymethod.is_empty Signed-off-by: Stoiko Ivanov --- src/pool.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pool.rs b/src/pool.rs index 611dcc9..b4f2a6a 100644 --- a/src/pool.rs +++ b/src/pool.rs

[pve-devel] [PATCH proxmox-offline-mirror v2 5/5] pool: remove unused imports

2024-07-09 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/pool.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pool.rs b/src/pool.rs index 56dcbb4..7db976e 100644 --- a/src/pool.rs +++ b/src/pool.rs @@ -1,14 +1,14 @@ use std::{ cmp::max, collections::{hash_map::Entry

[pve-devel] [PATCH proxmox-offline-mirror v2 0/5] remove snapshot directories vanished on source also on medium

2024-07-09 Thread Stoiko Ivanov
-time for the sync still took quite long. strace showed that the process still walked through the directories for each snapshot on the medium - they were not cleaned up after all the files inside were removed. tested the patch locally (which is the reason for patch 1/2). Stoiko Ivanov (5): b

[pve-devel] [PATCH proxmox-offline-mirror v2 2/5] pool: drop superfluous check for impossible path combination

2024-07-09 Thread Stoiko Ivanov
confusion in the future. Signed-off-by: Stoiko Ivanov --- src/pool.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/pool.rs b/src/pool.rs index f20f5ea..611dcc9 100644 --- a/src/pool.rs +++ b/src/pool.rs @@ -265,9 +265,6 @@ impl PoolLockGuard<'_> { for link_entry

[pve-devel] [PATCH proxmox-offline-mirror 2/2] medium: remove snapshot link directories not present in source mirror

2024-06-24 Thread Stoiko Ivanov
medium, still caused the medium sync to be quite slow. Signed-off-by: Stoiko Ivanov --- src/medium.rs | 18 +- src/types.rs | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/medium.rs b/src/medium.rs index 53df50d..2c2d24e 100644 --- a/src/medium.rs

[pve-devel] [PATCH proxmox-offline-mirror 0/2] remove snapshot directories vanished on source also on medium

2024-06-24 Thread Stoiko Ivanov
the sync still took quite long. strace showed that the process still walked through the directories for each snapshot on the medium - they were not cleaned up after all the files inside were removed. tested the patch locally (which is the reason for patch 1/2). Stoiko Ivanov (2): bump proxmox

[pve-devel] [PATCH proxmox-offline-mirror 1/2] bump proxmox-time to 2.0

2024-06-24 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Cargo.toml | 2 +- debian/control | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index bf7d754..edcdb87 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -35,4 +35,4 @@ proxmox-section-config = "2" pro

[pve-devel] [PATCH zfsonlinux v2 1/2] update zfs submodule to 2.2.4 and refresh patches

2024-05-07 Thread Stoiko Ivanov
mostly - drop all patches we had queued up to get kernel 6.8 supported. Signed-off-by: Stoiko Ivanov --- ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 12 +- ...hten-bounds-for

[pve-devel] [PATCH zfsonlinux v2 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
-off-by: Stoiko Ivanov --- ...-guard-access-to-freshly-introduced-.patch | 438 ++ ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 113 - debian/patches/series | 2 +- 3 files changed, 439 insertions(+), 114 deletions(-) create mode 100644 debian

[pve-devel] [PATCH zfsonlinux v2 0/2] Update to ZFS 2.2.4

2024-05-07 Thread Stoiko Ivanov
tps://github.com/openzfs/zfs/pull/16022 Stoiko Ivanov (2): update zfs submodule to 2.2.4 and refresh patches update arc_summary arcstat patch with new introduced values ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-

Re: [pve-devel] [PATCH zfsonlinux 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
having that throw exceptions will probably cause some discomfort to our users...) On Tue, 7 May 2024 15:38:36 +0200 Stoiko Ivanov wrote: > ZFS 2.2.4 added new kstats for speculative prefetch in: > 026fe796465e3da7b27d06ef5338634ee6dd30d8 > > Adapt our patch introduced with ZFS 2.1 (

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.2.4 and refresh patches

2024-05-07 Thread Stoiko Ivanov
mostly - drop all patches we had queued up to get kernel 6.8 supported. Signed-off-by: Stoiko Ivanov --- ...md-unit-for-importing-specific-pools.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 2 +- ...-guard-access-to-l2arc-MFU-MRU-stats.patch | 12 +- ...hten-bounds-for

[pve-devel] [PATCH zfsonlinux 2/2] update arc_summary arcstat patch with new introduced values

2024-05-07 Thread Stoiko Ivanov
-off-by: Stoiko Ivanov --- ...guard-access-to-freshly-introduced-.patch} | 79 --- debian/patches/series | 2 +- 2 files changed, 69 insertions(+), 12 deletions(-) rename debian/patches/{0009-arc-stat-summary-guard-access-to-l2arc-MFU-MRU-stats.patch

[pve-devel] [PATCH zfsonlinux 0/2] Update to ZFS 2.2.4

2024-05-07 Thread Stoiko Ivanov
://github.com/openzfs/zfs/releases/tag/zfs-2.2.4 [1] https://github.com/openzfs/zfs/pull/15992 [2] https://github.com/openzfs/zfs/pull/15588 [3] https://github.com/openzfs/zfs/pull/16022 Stoiko Ivanov (2): update zfs submodule to 2.2.4 and refresh patches update arc_summary arcstat patch with new

[pve-devel] [PATCH installer 0/2] fix 2 cosmetic glitches with the tests.

2024-04-30 Thread Stoiko Ivanov
self). Stoiko Ivanov (2): d/control: add geoip-bin to Build-Depends tests: prevent uninitialized value warning with undef as fqdn debian/control | 1 + test/parse-fqdn.pl | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.39.2 __

[pve-devel] [PATCH installer 2/2] tests: prevent uninitialized value warning with undef as fqdn

2024-04-30 Thread Stoiko Ivanov
cosmetic issue - but was distracting enough to make me look if there's an error. Signed-off-by: Stoiko Ivanov --- test/parse-fqdn.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl index 6638fbe..47e0e21 100755 --- a/test/

[pve-devel] [PATCH installer 1/2] d/control: add geoip-bin to Build-Depends

2024-04-30 Thread Stoiko Ivanov
else the tests running: `./proxmox-low-level-installer -t test.img dump-env` print quite a few warnings about the use of uninitialized values (though they still continue happily). This was a slight distraction for me. Signed-off-by: Stoiko Ivanov --- debian/control | 1 + 1 file changed, 1

Re: [pve-devel] [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-04-30 Thread Stoiko Ivanov
for completeness sake - gave the v3 a quick spin as well - so also from my side the: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov still applies :) On Tue, 30 Apr 2024 12:46:07 +0200 Aaron Lauterer wrote: > booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash >

Re: [pve-devel] [PATCH 1/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-04-30 Thread Stoiko Ivanov
patches: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Tue, 30 Apr 2024 10:54:33 +0200 Aaron Lauterer wrote: > By mapping files into the ISO, the UUID for the partitions change as > they depend on the timestamp. The result is, that grub cannot find its > partition anymore and

Re: [pve-devel] [PATCH pve-installer] answer: perform basic input validation for keyboard

2024-04-24 Thread Stoiko Ivanov
On Wed, 24 Apr 2024 10:48:50 +0200 Christian Ebner wrote: > Currently it is possible to validate and create an iso with an > invalid keyboad layout, only failing later during installation. > > Add a basic check for correct keyboard layout by defining an enum > with allowed variants. > > Signed-

  1   2   3   4   5   6   7   >