dropping the `nomodeset` here makes little sense: * currently users need to explicitly add it when booting the kernel, which is probably only done when the system needs it to show any output when booting * it was originally removed, because the installer had a grub-entry that explicitly disabled it - and the reasoning was to remove everything installer-specific - but I assume that it should cause less problems to keep it in place in all cases.
This was also partially pointed to in: https://bugzilla.proxmox.com/show_bug.cgi?id=4230#c38 Fixes: a02a78a865fc37f7bdea077a4421319b84c635c9 Suggested-by: Thomas Lamprecht <t.lampre...@proxmox.com> Signed-off-by: Stoiko Ivanov <s.iva...@proxmox.com> --- minimally tested by redoing the change in the second debug shell and installing in a VM w/ secure boot disabled (nomodeset breaks the debugshells if secureboot is enabled) one remaining question is if we want to also preserve the vga=\S+ parameter: * we set it for the TUI-installer options (to vga=788) - so this might warrant removal * while I assume that most cases where the TUI installer is used are either due to UX-preference, or to workaround issues with x.org - there might be cases where keeping it present ensures that the target system has a sensible/readabl console at all * if someone explicitly set it, it will get removed, so keeping all options apart from vga=788 might be a sensible improvment in any case will gladly send a follow-up for this Proxmox/Install/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm index ae70093..49c247b 100644 --- a/Proxmox/Install/Config.pm +++ b/Proxmox/Install/Config.pm @@ -44,7 +44,7 @@ my sub parse_kernel_cmdline { } $cmdline =~ s/(?:BOOT_IMAGE|root|ramdisk_size|splash|vga)=\S+\s?//gi; - $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui|nomodeset//gi; + $cmdline =~ s/ro|rw|quiet|proxdebug|proxtui//gi; $cfg->{target_cmdline}= $cmdline; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
