On Tue, 27 Aug 2024 16:24:33 +0200 Maximiliano Sandoval <m.sando...@proxmox.com> wrote:
> And disable it when destroying the pool. > can be fine in general - but why? our packages ship: /etc/cron.d/zfsutils-linux (and /usr/lib/zfs-linux/scrub) which does (afair) run a monthly scrub (and trim) under certain conditions (including by default on healthy pools) what do we gain by explicitly enabling a unit for scrubbing (which at least from experiences with the per-pool import unit, will cause odd warnings in the journal, resulting in support requests)? > Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com> > --- > > Differences from v1: > - Add --now flag to commands so they are `started` on top of `enabled`. a short explanation on why this is/was necessary would help (maybe even with a link to the relevant documentation e.g.: https://documentation.suse.com/smart/systems-management/html/systemd-working-with-timers/index.html#systemd-timer-manage > > > src/PVE/API2/Disks/ZFS.pm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/PVE/API2/Disks/ZFS.pm b/src/PVE/API2/Disks/ZFS.pm > index 6fb6bd6b..6d9ace5b 100644 > --- a/src/PVE/API2/Disks/ZFS.pm > +++ b/src/PVE/API2/Disks/ZFS.pm > @@ -490,6 +490,13 @@ __PACKAGE__->register_method ({ > run_command($cmd); > } > > + if (-e '/lib/systemd/system/zfs-scrub-monthly@.timer') { > + my $scrubtimer = 'zfs-scrub-monthly@'. > PVE::Systemd::escape_unit($name, undef) . '.timer'; > + $cmd = ['systemctl', 'enable', $scrubtimer, '--now']; > + print "# ", join(' ', @$cmd), "\n"; > + run_command($cmd); > + } > + > PVE::Diskmanage::udevadm_trigger($devs->@*); > > if ($param->{add_storage}) { > @@ -583,6 +590,11 @@ __PACKAGE__->register_method ({ > run_command(['systemctl', 'disable', $importunit]); > } > > + if (-e '/lib/systemd/system/zfs-scrub-monthly@.timer') { > + my $scrubtimer = 'zfs-scrub-monthly@' . > PVE::Systemd::escape_unit($name) . '.timer'; > + run_command(['systemctl', 'disable', $scrubtimer, '--now']); > + } > + > run_command(['zpool', 'destroy', $name]); > > my $config_err; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
