gave this another spin on my reproducer for the failing device-reset - still works fine!
2 cosmetic nits for the patches aside - which from my pov can also be left as is (or maybe fixed up when applying): Tested-by: Stoiko Ivanov <s.iva...@proxmox.com> Reviewed-by: Stoiko Ivanov <s.iva...@proxmox.com> On Fri, 8 Nov 2024 10:32:57 +0100 Dominik Csapak <d.csa...@proxmox.com> wrote: > and fix passthrough regressions > > As i feared previously in [0], making it a hard error when encountering > errors during sysfs writes uncovered some situations where our code was > too strict to keep some setups working. > > One such case is resetting devices, which is seemingly not necessary > at all times, so this series > > * donwgrades that error to warning > * adds some more logging to `file_write` to be able to better debug > > Another case that broke was passing through similar devices with the > same vendor/modelid since the write to vfio-pci's 'new_id' works only > once for the same vendor/modelid. > > To fix that make some errors ignorable for file_write > > changes from v1: > * also include error ignore list > * ignore EEXIST for writing to new_id > > 0: > https://lore.proxmox.com/pve-devel/20240723082925.934603-1-d.csa...@proxmox.com/ > > pve-common: > > Dominik Csapak (2): > sysfstools: file_write: extend with logging and ignore list > sysfstools: fix regression on binding to vfio-pci > > src/PVE/SysFSTools.pm | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > qemu-server: > > Dominik Csapak (1): > pci: don't hard require resetting devices for passthrough > > PVE/QemuServer/PCI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
