Re: hydrogen packaging

2016-11-29 Thread Jaromír Mikeš
2016-11-29 23:33 GMT+01:00 James Cowgill : > Hi, > > On 27/11/16 16:34, Jaromír Mikeš wrote: >> 2016-11-27 12:32 GMT+01:00 James Cowgill : >>> Other than that I think it's OK to upload assuming I don't find anything >>> else :) >> >> As package has been split I think it must go to "NEW" and uploade

Re: hydrogen packaging

2016-11-29 Thread James Cowgill
Hi, On 27/11/16 16:34, Jaromír Mikeš wrote: > 2016-11-27 12:32 GMT+01:00 James Cowgill : >> Other than that I think it's OK to upload assuming I don't find anything >> else :) > > As package has been split I think it must go to "NEW" and uploaded by DD. > Am I right? Yes, and uploaded! (with a m

Re: hydrogen packaging

2016-11-27 Thread Jaromír Mikeš
2016-11-27 12:32 GMT+01:00 James Cowgill : > Ok just going over a few other things I spotted. > > CXXFLAGS is clobbered in CMakeLists.txt:109 Fixed! > These files exist in debian/tmp but are not installed anywhere. The > appdata one must go in the hydrogen package for the same reason as the > ic

Re: hydrogen packaging

2016-11-27 Thread James Cowgill
On 27/11/16 01:00, Jaromír Mikeš wrote: > 2016-11-27 1:33 GMT+01:00 James Cowgill : >> On 26/11/16 13:39, Jaromír Mikeš wrote: >>> 2016-11-26 13:44 GMT+01:00 James Cowgill : On 26/11/16 02:02, Jaromír Mikeš wrote: > 2016-11-26 0:15 GMT+01:00 James Cowgill : >> On 25/11/16 17:15, Jaromí

Re: hydrogen packaging

2016-11-26 Thread Jaromír Mikeš
2016-11-27 1:33 GMT+01:00 James Cowgill : > On 26/11/16 13:39, Jaromír Mikeš wrote: >> 2016-11-26 13:44 GMT+01:00 James Cowgill : >>> On 26/11/16 02:02, Jaromír Mikeš wrote: 2016-11-26 0:15 GMT+01:00 James Cowgill : > On 25/11/16 17:15, Jaromír Mikeš wrote: >> 2016-11-25 17:13 GMT+01:0

Re: hydrogen packaging

2016-11-26 Thread James Cowgill
On 26/11/16 13:39, Jaromír Mikeš wrote: > 2016-11-26 13:44 GMT+01:00 James Cowgill : >> On 26/11/16 02:02, Jaromír Mikeš wrote: >>> 2016-11-26 0:15 GMT+01:00 James Cowgill : On 25/11/16 17:15, Jaromír Mikeš wrote: > 2016-11-25 17:13 GMT+01:00 James Cowgill : >> -- d/hydrogen.install >>

Re: hydrogen packaging

2016-11-26 Thread Jaromír Mikeš
2016-11-26 13:44 GMT+01:00 James Cowgill : > Hi, > > On 26/11/16 02:02, Jaromír Mikeš wrote: >> 2016-11-26 0:15 GMT+01:00 James Cowgill : >>> On 25/11/16 17:15, Jaromír Mikeš wrote: 2016-11-25 17:13 GMT+01:00 James Cowgill : > -- d/hydrogen.install >> usr/share/hydrogen/data/img >

Re: hydrogen packaging

2016-11-26 Thread James Cowgill
Hi, On 26/11/16 02:02, Jaromír Mikeš wrote: > 2016-11-26 0:15 GMT+01:00 James Cowgill : >> On 25/11/16 17:15, Jaromír Mikeš wrote: >>> 2016-11-25 17:13 GMT+01:00 James Cowgill : -- d/hydrogen.install > usr/share/hydrogen/data/img It seems that the only reason for putting this in hydr

Re: hydrogen packaging

2016-11-25 Thread Jaromír Mikeš
Hi, 2016-11-26 0:15 GMT+01:00 James Cowgill : > On 25/11/16 17:15, Jaromír Mikeš wrote: >> 2016-11-25 17:13 GMT+01:00 James Cowgill : >> If this is ok solution than done. >> http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2016-August/053680.html > > I didn't know about the fil

Re: hydrogen packaging

2016-11-25 Thread James Cowgill
Hi, On 25/11/16 17:15, Jaromír Mikeš wrote: > 2016-11-25 17:13 GMT+01:00 James Cowgill : >> On 25/11/16 00:59, Jaromír Mikeš wrote: >>> 2016-11-24 23:38 GMT+01:00 James Cowgill : -- d/changelog > + * Exclude .gitignore file from upstream tarball. Can this be removed now? >>> >>> You

Re: hydrogen packaging

2016-11-25 Thread Jaromír Mikeš
2016-11-25 17:13 GMT+01:00 James Cowgill : > On 25/11/16 00:59, Jaromír Mikeš wrote: >> 2016-11-24 23:38 GMT+01:00 James Cowgill : >>> On 13/11/16 20:23, Jaromír Mikeš wrote: 2016-11-13 19:20 GMT+01:00 Jaromír Mikeš : >> >> Hi James, >> >> thank you for your time to review this ... more issues

Re: hydrogen packaging

2016-11-25 Thread James Cowgill
On 25/11/16 00:59, Jaromír Mikeš wrote: > 2016-11-24 23:38 GMT+01:00 James Cowgill : >> On 13/11/16 20:23, Jaromír Mikeš wrote: >>> 2016-11-13 19:20 GMT+01:00 Jaromír Mikeš : > > Hi James, > > thank you for your time to review this ... more issues than I thought ;) > >> Here's a review: >> >> --

Re: hydrogen packaging

2016-11-24 Thread Jaromír Mikeš
2016-11-25 1:59 GMT+01:00 Jaromír Mikeš : > 2016-11-24 23:38 GMT+01:00 James Cowgill : >> -- d/changelog >>> + * Exclude .gitignore file from upstream tarball. >> Can this be removed now? > > You mean from changelog or removing .gitignore file? So only this issue I don't understand. > >> -- d/c

Re: hydrogen packaging

2016-11-24 Thread trebmuh
-- d/patches/1010-spelling.patch +- ERRORLOG( "Could't locate two Jack input port" ); ++ ERRORLOG( "Couldn't locate two Jack input port" ); Should be "...input ports" (plural ports) ++[...]more information about you can find here:[...] Maybe "you can find more information here:"? Spelling

Re: hydrogen packaging

2016-11-24 Thread Jaromír Mikeš
2016-11-24 23:38 GMT+01:00 James Cowgill : > On 13/11/16 20:23, Jaromír Mikeš wrote: >> 2016-11-13 19:20 GMT+01:00 Jaromír Mikeš : Hi James, thank you for your time to review this ... more issues than I thought ;) > Here's a review: > > -- d/changelog >> + * Exclude .gitignore file from upstrea

Re: hydrogen packaging

2016-11-24 Thread James Cowgill
On 24/11/16 22:30, Jaromír Mikeš wrote: > 2016-11-13 21:23 GMT+01:00 Jaromír Mikeš : > >> I think hydrogen package is ready for upload. >> As package has been split I think there is a need upload from DD. >> Can someone review and upload please? > > ping? ;) Didn't see this before replying - I n

Re: hydrogen packaging

2016-11-24 Thread James Cowgill
Hi Jaromír, On 13/11/16 20:23, Jaromír Mikeš wrote: > 2016-11-13 19:20 GMT+01:00 Jaromír Mikeš : >> Ok almost happy with hydrogen package. >> I would like to close also this bug: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591301 >> by adding libportmidi-dev [linux-any], to B-D ... How to

Re: hydrogen packaging

2016-11-24 Thread Jaromír Mikeš
2016-11-13 21:23 GMT+01:00 Jaromír Mikeš : > I think hydrogen package is ready for upload. > As package has been split I think there is a need upload from DD. > Can someone review and upload please? ping? ;) best regards mira ___ pkg-multimedia-maint

Re: hydrogen packaging

2016-11-13 Thread Jaromír Mikeš
2016-11-13 19:20 GMT+01:00 Jaromír Mikeš : > Ok almost happy with hydrogen package. > I would like to close also this bug: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591301 > by adding libportmidi-dev [linux-any], to B-D ... How to do it right > way in CDBS? > There are B-D in d/rules file

Re: hydrogen packaging

2016-11-13 Thread Jaromír Mikeš
Ok almost happy with hydrogen package. I would like to close also this bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591301 by adding libportmidi-dev [linux-any], to B-D ... How to do it right way in CDBS? There are B-D in d/rules file and d/control I guess I should add it to one file and

Bug#629107: hydrogen: No text in User Manual (Was: hydrogen packaging)

2016-11-13 Thread Jaromír Mikeš
2016-11-13 11:55 GMT+01:00 James Cowgill : > Control: tags -1 patch > > Hi, > > On 12/11/16 11:41, Jaromír Mikeš wrote: >> 2016-11-12 11:58 GMT+01:00 : >> >>> while you're working around the Hydrogen packaging, can I humbly >>> ask you to hav

Processed: Bug#629107: hydrogen: No text in User Manual (Was: hydrogen packaging)

2016-11-13 Thread Debian Bug Tracking System
Processing control commands: > tags -1 patch Bug #629107 [hydrogen] hydrogen: No text in User Manual Added tag(s) patch. -- 629107: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=629107 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems

Bug#629107: hydrogen: No text in User Manual (Was: hydrogen packaging)

2016-11-13 Thread James Cowgill
Control: tags -1 patch Hi, On 12/11/16 11:41, Jaromír Mikeš wrote: > 2016-11-12 11:58 GMT+01:00 : > >> while you're working around the Hydrogen packaging, can I humbly >> ask you to have a look at this bug : >> https://bugs.debian.org/629107 ? >> >>

Re: hydrogen packaging

2016-11-12 Thread Jaromír Mikeš
2016-11-12 11:58 GMT+01:00 : > while you're working around the Hydrogen packaging, can I humbly > ask you to have a look at this bug : > https://bugs.debian.org/629107 ? > > There is willingness upstream (which I'm part of regarding the > manual) to update and impro

Re: hydrogen packaging

2016-11-12 Thread trebmuh
Hi Jaromír and all, while you're working around the Hydrogen packaging, can I humbly ask you to have a look at this bug : https://bugs.debian.org/629107 ? There is willingness upstream (which I'm part of regarding the manual) to update and improve the bundled update manual and not

Re: hydrogen packaging

2016-11-12 Thread Jaromír Mikeš
2016-11-11 22:22 GMT+01:00 Jaromír Mikeš : > Hi Team, > > I am currently working on updating hydrogen package. > Current lintian output > > $ lintian -IE --pedantic --no-tag-display-limit hydrogen_0.9.7-1_amd64.changes > I: hydrogen source: quilt-patch-missing-description 1000_portaudio_v2.patch >

hydrogen packaging

2016-11-11 Thread Jaromír Mikeš
Hi Team, I am currently working on updating hydrogen package. Current lintian output $ lintian -IE --pedantic --no-tag-display-limit hydrogen_0.9.7-1_amd64.changes I: hydrogen source: quilt-patch-missing-description 1000_portaudio_v2.patch P: hydrogen source: debian-watch-may-check-gpg-signature