2016-11-27 12:32 GMT+01:00 James Cowgill <jcowg...@debian.org>:

> Ok just going over a few other things I spotted.
>
> CXXFLAGS is clobbered in CMakeLists.txt:109

Fixed!

> These files exist in debian/tmp but are not installed anywhere. The
> appdata one must go in the hydrogen package for the same reason as the
> icon has to.
>
> /usr/share/appdata/hydrogen.appdata.xml
> /usr/share/man/man1/hydrogen.1

Fixed!

> Your new debian/copyright file seems to contain some C++ code which
> should not be there.

Fixed!

> Other than that I think it's OK to upload assuming I don't find anything
> else :)

As package has been split I think it must go to "NEW" and uploaded by DD.
Am I right?

Thank you !

mira

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to