On 25/11/16 00:59, Jaromír Mikeš wrote: > 2016-11-24 23:38 GMT+01:00 James Cowgill <jcowg...@debian.org>: >> On 13/11/16 20:23, Jaromír Mikeš wrote: >>> 2016-11-13 19:20 GMT+01:00 Jaromír Mikeš <mira.mi...@gmail.com>: > > Hi James, > > thank you for your time to review this ... more issues than I thought ;) > >> Here's a review: >> >> -- d/changelog >>> + * Exclude .gitignore file from upstream tarball. >> Can this be removed now? > > You mean from changelog or removing .gitignore file?
Oh I thought you reverted this stuff but I see that you haven't (just removed the ~repack suffix). If you haven't worked out yet, I am of the opinion that repacking an orig tarball for the purposes of making git-buildpackage easier to use is unacceptable. See devref 6.7.8. >> -- d/rules >>> + cp data/doc/manual_en.html data/doc/manual_en.html.bak >>> + touch data/doc/manual.docbook data/doc/tutorial.docbook >>> $(MAKE) -C data/doc >>> touch $@ >>> + mv data/doc/manual_en.html.bak data/doc/manual_en.html >> >> Doesn't restoring manual_en.html defeat the purpose of rebuilding the >> documentation? > > Exactly ... I was suggesting that you remove the cp and mv. Thanks, James
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
