Commitfest 2024-01 second week update

Hi, Here's a quick status report after the second week: Status summary: status | w1 | w2 -+---+- Needs review:| 238 | 213 Waiting on Author: |44 | 46 Ready for Committer: |27 | 27 Committed:

Re: Rework LogicalOutputPluginWriterUpdateProgress

On Mon, 13 Mar 2023 at 08:17, wangw.f...@fujitsu.com wrote: > > On Fri, Mar 10, 2023 20:17 PM Osumi, Takamichi/大墨 昂道 > wrote: > > Hi, > > > > > > On Friday, March 10, 2023 6:32 PM Wang, Wei/王 威 > > wrote: > > > Attach the new patch set. > > Thanks for updating the patch ! One review comment on

Re: Implement missing join selectivity estimation for range types

On Fri, 5 Jan 2024 at 23:09, Schoemans Maxime wrote: > > On 05/01/2024 11:37, vignesh C wrote: > > One of the tests was aborted at [1], kindly post an updated patch for > the same: > > Thank you for notifying us. > I believe I fixed the issue but it is hard to be certai

Re: CI and test improvements

On Wed, 12 Jul 2023 at 11:38, Michael Paquier wrote: > > On Wed, Jul 12, 2023 at 12:56:17AM -0500, Justin Pryzby wrote: > > And, since 681d9e462: > > > > security is missing from contrib/seg/meson.build > > Ugh. Good catch! Are we planning to do anything more in this thread, the thread has been

Re: Catalog domain not-null constraints

On Wed, 29 Nov 2023 at 01:14, Peter Eisentraut wrote: > > On 23.11.23 14:13, Aleksander Alekseev wrote: > > =# create domain connotnull1 integer; > > =# create domain connotnull2 integer; > > =# alter domain connotnull1 add not null value; > > =# alter domain connotnull2 set not null; > > =# \dD >

Re: pgsql: Clean up role created in new subscription test.

On Fri, 1 Dec 2023 at 18:23, Daniel Gustafsson wrote: > > > On 1 Dec 2023, at 13:19, Alvaro Herrera wrote: > > > > Isn't it simpler to use DROP OWNED BY in 0001? > > I suppose it is, I kind of like the explicit drops but we do use OWNED BY > quite > a lot in the regression tests so changed to th

Re: Where can I find the doxyfile?

On Tue, 7 Nov 2023 at 12:23, John Morris wrote: > > Another update, this time with an abbreviated Doxyfile. Rather than including > the full Doxyfile, this updated version only includes modified settings. It > is more compact and more likely to survive across future doxygen versions. Meson buil

Re: Commitfest manager January 2024

On Fri, 19 Jan 2024 at 09:19, Peter Smith wrote: > > Hi Vignesh, > > If you would like any assistance processing the 100s of CF entries I > am happy to help in some way. Thanks Peter, that will be great. Regards, Vignesh

Re: Documentation for building with meson

On Wed, 29 Mar 2023 at 00:57, samay sharma wrote: > > Hi, > > On Wed, Mar 15, 2023 at 4:28 AM Peter Eisentraut > wrote: >> >> > [PATCH v8 1/5] Make minor additions and corrections to meson docs >> >> The last hunk revealed that there is some mixing up between meson setup >> and meson configure.

Re: Lockless queue of waiters in LWLock

On Sat, 26 Nov 2022 at 00:24, Pavel Borisov wrote: > > Hi, hackers! > In the measurements above in the thread, I've been using LIFO wake > queue in a primary lockless patch (and it was attached as the previous > versions of a patch) and an "inverted wake queue" (in faсt FIFO) as > the alternative

Re: Collation version tracking for macOS

On Sat, 21 Jan 2023 at 02:24, Jeff Davis wrote: > > On Thu, 2023-01-19 at 00:11 -0800, Jeff Davis wrote: > > Attached are a new set of patches, including a major enhancement: the > > icu_multilib contrib module. > > Attached rebased v8. > > [ It looks like my email client truncated the last email

Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s).

On Fri, 22 Sept 2023 at 18:45, Amul Sul wrote: > > > > On Wed, Sep 20, 2023 at 8:29 PM Alvaro Herrera > wrote: >> >> On 2023-Sep-20, Amul Sul wrote: >> >> > On the latest master head, I can see a $subject bug that seems to be >> > related >> > commit #b0e96f311985: >> > >> > Here is the table d

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Wed, 10 May 2023 at 06:07, Justin Pryzby wrote: > > On Wed, Mar 29, 2023 at 11:03:59PM -0500, Justin Pryzby wrote: > > On Wed, Jul 13, 2022 at 04:49:00PM -0700, Andres Freund wrote: > > > On 2022-07-14 08:46:02 +0900, Michael Paquier wrote: > > > > On Wed, Jul 13, 2022 at 12:30:00PM -0500, Just

Re: Make documentation builds reproducible

On Fri, 25 Aug 2023 at 01:23, Tristan Partin wrote: > > On Thu Aug 24, 2023 at 2:30 PM CDT, Tom Lane wrote: > > "Tristan Partin" writes: > > > On Wed Aug 23, 2023 at 2:24 PM CDT, Peter Eisentraut wrote: > > >> Somewhere at PGCon, I forgot exactly where, maybe in the same meeting > > >> where we t

Re: Inconsistency in reporting checkpointer stats

On Sun, 19 Feb 2023 at 15:28, Nitin Jadhav wrote: > > > This doesn't pass the tests, because the regression tests weren't adjusted: > > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs > > Thanks for sharing this. I have fixed this

Re: Amcheck verification of GiST and GIN

On Mon, 27 Mar 2023 at 03:47, Andrey Borodin wrote: > > On Sun, Mar 19, 2023 at 4:00 PM Andrey Borodin wrote: > > > > Also, there are INCLUDEd attributes. Right now we just put them as-is > > to the bloom filter. Does this constitute a TOAST bug as in B-tree? > > If so, I think we should use a ve

Re: MultiXact\SLRU buffers configuration

On Mon, 9 Jan 2023 at 09:49, Andrey Borodin wrote: > > On Tue, Jan 3, 2023 at 5:02 AM vignesh C wrote: > > does not apply on top of HEAD as in [1], please post a rebased patch: > > > Thanks! Here's the rebase. I'm seeing that there has been no activity in this

Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?

On Mon, 20 Feb 2023 at 16:06, David Geier wrote: > > Hi! > > On 2/14/23 13:48, David Geier wrote: > > > > It still fails. > > > > I'll get Cirrus-CI working on my own Github fork so I can make sure it > > really compiles on all platforms before I submit a new version. > > It took some time until C

Re: Prefetch the next tuple's memory during seqscans

On Mon, 10 Jul 2023 at 15:04, Daniel Gustafsson wrote: > > > On 10 Jul 2023, at 11:32, Daniel Gustafsson wrote: > > > >> On 4 Apr 2023, at 06:50, David Rowley wrote: > > > >> Updated patches attached. > > > > This patch is marked Waiting on Author, but from the thread it seems Needs > > Review i

Re: PATCH: Using BRIN indexes for sorted output

On Wed, 2 Aug 2023 at 21:34, Tomas Vondra wrote: > > > > On 8/2/23 17:25, Sergey Dudoladov wrote: > > Hello, > > > >> Parallel version is not supported, but I think it should be possible. > > > > @Tomas are you working on this ? If not, I would like to give it a try. > > > > Feel free to try. Just

Re: Cross-database SERIALIZABLE safe snapshots

On Mon, 10 Jul 2023 at 14:48, Heikki Linnakangas wrote: > > On 09/03/2023 07:34, Thomas Munro wrote: > > Here is a feature idea that emerged from a pgsql-bugs thread[1] that I > > am kicking into the next commitfest. Example: > > > > s1: \c db1 > > s1: CREATE TABLE t (i int); > > s1: BEGIN TRANSA

Re: XLog size reductions: smaller XLRec block header for PG17

On Tue, 26 Sept 2023 at 02:09, Matthias van de Meent wrote: > > On Tue, 19 Sept 2023 at 01:03, Andres Freund wrote: > > > > Hi, > > > > On 2023-05-18 19:22:26 +0300, Heikki Linnakangas wrote: > > > On 18/05/2023 17:59, Matthias van de Meent wrote: > > > > It changes the block IDs used to fit in 6

Re: ReadRecentBuffer() doesn't scale well

On Fri, 30 Jun 2023 at 07:43, Thomas Munro wrote: > > On Fri, Jun 30, 2023 at 3:39 AM Andres Freund wrote: > > I am wondering if we don't want something more generic than stashing this in > > rd_amcache. Don't want to end up duplicating relevant code across the uses > > of > > rd_amcache in ever

Re: Allow parallel plan for referential integrity checks?

On Fri, 18 Aug 2023 at 16:29, Juan José Santamaría Flecha wrote: > > > On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel > wrote: >> >> On 8/17/23 14:00, Frédéric Yhuel wrote: >> > On 8/17/23 09:32, Frédéric Yhuel wrote: >> >> On 8/10/23 17:06, Juan José Santamaría Flecha wrote: >> >>> Recently I r

Re: Using AF_UNIX sockets always for tests on Windows

On Wed, 22 Mar 2023 at 09:59, Thomas Munro wrote: > > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that > it's a better "OS harmonisation" outcome if we can choose both ways on > both OSes. I will leave the 0003 patch aside for now due to lack of > time, but here's a rebase o

Re: some namespace.c refactoring

On Thu, 23 Feb 2023 at 16:38, Peter Eisentraut wrote: > > On 20.02.23 15:03, Peter Eisentraut wrote: > > On 15.02.23 19:04, Alvaro Herrera wrote: > >> That said, I think most of this code is invoked for DDL, where > >> performance is not so critical; probably just fixing > >> get_object_property_d

Re: Trivial revise for the check of parameterized partial paths

On Thu, 29 Jun 2023 at 08:53, Richard Guo wrote: > > While working on the invalid parameterized join path issue [1], I > noticed that we can simplify the codes for checking parameterized > partial paths in try_partial_hashjoin/mergejoin_path, with the help of > macro PATH_REQ_OUTER. > > - if

Re: Retiring is_pushed_down

On Thu, 27 Jul 2023 at 08:25, Richard Guo wrote: > > > On Tue, Jul 25, 2023 at 3:39 PM Richard Guo wrote: >> >> * This patch calculates the outer join relids that are being formed >> generally in this way: >> >> bms_difference(joinrelids, bms_union(outerrelids, innerrelids)) >> >> Of course t

Re: XLog size reductions: smaller XLRec block header for PG17

On Mon, 22 Jan 2024 at 16:08, Aleksander Alekseev wrote: > > Hi, > > > I'm seeing that there has been no activity in this thread for nearly 4 > > months, I'm planning to close this in the current commitfest unless > > someone is planning to take it forward. > > I don't think that closing CF entrie

Commitfest 2024-01 third week update

Hi, Here's a quick status report after the third week: Status summary: status| w1 | w2 | w3 ---+---++-- Needs review: |238 | 213| 181 Waiting on Author:

Re: Support "Right Semi Join" plan shapes

On Mon, 22 Jan 2024 at 11:27, wenhui qiu wrote: > > Hi vignesh CI saw this path has been passed > (https://cirrus-ci.com/build/6109321080078336),can we push it? If you have found no comments from your review and testing, let's mark it as "ready for committer". Regards, Vignesh

Re: Documentation to upgrade logical replication cluster

hat were created in node2 between when > the subscriptions where disabled in node2 and now, e.g.: > > IMO this link should be like "Step N", not some words -- maybe it is > another opportunity for using xreflabel? Modified to xref > > 18b > Also has typos "whe

Re: Documentation to upgrade logical replication cluster

On Mon, 15 Jan 2024 at 14:39, Hayato Kuroda (Fujitsu) wrote: > > Dear Vignesh, > > Thanks for updating the patch! > > > > 7. > > > ``` > > > + > > > +dba@node1:/opt/PostgreSQL/postgres/&majorversion;/bin$ pg_ctl -D > > /opt/PostgreSQL/pub_data stop -l logfile > > > + > > > ``` > > > > > > Hmm. I t

Re: Documentation to upgrade logical replication cluster

odified The attached v4 version patch has the changes for the same. Regards, Vignesh From 4abe4ed86d68a5ecb60c3bf29249bb883605fb76 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Wed, 13 Dec 2023 14:11:58 +0530 Subject: [PATCH v4] Documentation for upgrading logical replication cluster. Documentation

Re: Documentation to upgrade logical replication cluster

On Thu, 25 Jan 2024 at 05:45, Peter Smith wrote: > > Here are some review comments for patch v3. > > == > doc/src/sgml/ref/pgupgrade.sgml > > 1. > + > + > + This page does not cover steps to upgrade logical replication > clusters, refer > +for details on upgrading > + logical replica

Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

On Wed, 20 Dec 2023 at 19:17, Jelte Fennema-Nio wrote: > > On Thu, 14 Dec 2023 at 13:57, Jelte Fennema-Nio wrote: > > I changed all the places that were not adhering to those spellings. > > It seems I forgot a /g on my sed command to do this so it turned out I > missed one that caused the test to

Re: Printing backtrace of postgres processes

xtern PGPROC *BackendPidGetProcWithLock(int pid); extern int BackendXidGetPid(TransactionId xid); extern bool IsBackendPid(int pid); +extern bool SendProcSignalBackendOrAuxproc(int pid, ProcSignalReason reason); extern VirtualTransactionId *GetCurrentVirtualXIDs(TransactionId limitXmin, boo

Re: Evaluate arguments of correlated SubPlans in the referencing ExprState

On Tue, 24 Oct 2023 at 01:47, Alena Rybakina wrote: > > Hi! > > I looked through your patch and noticed that it was not applied to the > current version of the master. I rebased it and attached a version. I didn't > see any problems and, honestly, no big changes were needed, all regression > te

Re: Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE

On Mon, 27 Nov 2023 at 21:58, vignesh C wrote: > > On Fri, 24 Nov 2023 at 18:37, Shubham Khanna > wrote: > > > > n Fri, Nov 24, 2023 at 6:33 PM vignesh C wrote: > > > > > > Hi, > > > > > > Improved tab completion for "ALTER DEFAUL

Re: gai_strerror() is not thread-safe on Windows

On Tue, 5 Dec 2023 at 00:57, Thomas Munro wrote: > > On second thoughts, I guess it would make more sense to use the exact > messages Windows' own implementation would return instead of whatever > we had in the past (probably cribbed from some other OS or just made > up?). I asked CI to spit thos

Re: A new strategy for pull-up correlated ANY_SUBLINK

On Fri, 13 Oct 2023 at 14:09, Alena Rybakina wrote: > > On 13.10.2023 10:04, Andy Fan wrote: >> >> It seems to me that the expressions "=" and "IN" are equivalent here due to >> the fact that the aggregated subquery returns only one value, and the result >> with the "IN" operation can be conside

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

On Mon, 4 Dec 2023 at 13:22, Dmitry Koval wrote: > > Hello! > > Added commit v21-0004-SPLIT-PARTITION-optimization.patch. CFBot shows that the patch does not apply anymore as in [1]: === Applying patches on top of PostgreSQL commit ID 8ba6fdf905d0f5aef70ced4504c6ad297bfe08ea === === applying patc

Re: Exposing the lock manager's WaitForLockers() to SQL

On Thu, 11 Jan 2024 at 15:22, Will Mortensen wrote: > > Here is a new series adding a single pg_wait_for_lockers() function > that takes a boolean argument to control the interpretation of the > lock mode. It omits LOCK's handling of descendant tables so it > requires permissions directly on desce

Re: Add recovery to pg_control and remove backup_label

On Mon, 20 Nov 2023 at 06:46, Michael Paquier wrote: > > (I am not exactly sure how, but we've lost pgsql-hackers on the way > when you sent v5. Now added back in CC with the two latest patches > you've proposed attached.) > > Here is a short summary of what has been missed by the lists: > - I've

Re: [PATCH] Add sortsupport for range types and btree_gist

On Wed, 10 Jan 2024 at 19:49, jian he wrote: > > On Wed, Jan 10, 2024 at 8:00 AM jian he wrote: > > > > ` > > from the doc, add sortsupport function will only influence index build time? > > > > +/* > > + * GiST sortsupport comparator for ranges. > > + * > > + * Operates solely on the lower bound

Re: [PATCH] Add support function for containment operators

On Sun, 21 Jan 2024 at 00:31, Tom Lane wrote: > > jian he writes: > > Now I see your point. If the transformed plan is right, the whole > > added code should be fine. > > but keeping the textrange_supp related test should be a good idea. > > since we don't have SUBTYPE_OPCLASS related sql tests.

Re: fix stats_fetch_consistency value in postgresql.conf.sample

On Sat, 20 Jan 2024 at 08:39, Michael Paquier wrote: > > On Sat, Jan 20, 2024 at 07:59:22AM +0530, vignesh C wrote: > > I'm seeing that there has been no activity in this thread for more > > than 8 months, I'm planning to close this in the current commitfest > >

Re: [PATCH] Compression dictionaries for JSONB

On Wed, 17 Jan 2024 at 19:52, Aleksander Alekseev wrote: > > Hi Shubham, > > > > > 8272749e added a few more arguments to CastCreate(). Here is the > > > > rebased patch. > > > > > > After merging afbfc029 [1] the patch needed a rebase. PFA v10. > > > > > > The patch is still in a PoC state and t

Re: Confine vacuum skip logic to lazy_scan_skip

On Fri, 12 Jan 2024 at 05:12, Melanie Plageman wrote: > > v3 attached > > On Thu, Jan 4, 2024 at 3:23 PM Andres Freund wrote: > > > > Hi, > > > > On 2024-01-02 12:36:18 -0500, Melanie Plageman wrote: > > > Subject: [PATCH v2 1/6] lazy_scan_skip remove unnecessary local var > > > rel_pages > > >

Re: POC: GROUP BY optimization

On Thu, 25 Jan 2024 at 01:15, Alexander Korotkov wrote: > > On Wed, Jan 24, 2024 at 7:38 PM Nathan Bossart > wrote: > > A recent buildfarm failure [0] seems to indicate a name collision with the > > "abc" index in the aggregates.sql test and the "abc" table in > > namespace.sql. > > > > [0] > >

Re: pg_upgrade failing for 200+ million Large Objects

On Tue, 2 Jan 2024 at 23:03, Kumar, Sachin wrote: > > > On 11/12/2023, 01:43, "Tom Lane" > > wrote: > > > I had initially supposed that in a parallel restore we could > > have child workers also commit after every N TOC items, but was > > soon disabused of that idea. Af

Re: PoC: prefetching index leaf pages (for inserts)

On Mon, 6 Nov 2023 at 22:36, Tomas Vondra wrote: > > Seems cfbot was not entirely happy about the patch, for two reasons: > > 1) enable_insert_prefetching definition was inconsistent (different > boot/default values, missing in .conf and so on) > > 2) stupid bug in execReplication, inserting index

Re: Lockless queue of waiters in LWLock

On Sat, 20 Jan 2024 at 07:28, vignesh C wrote: > > On Sat, 26 Nov 2022 at 00:24, Pavel Borisov wrote: > > > > Hi, hackers! > > In the measurements above in the thread, I've been using LIFO wake > > queue in a primary lockless patch (and it was attached as t

Re: MERGE ... WHEN NOT MATCHED BY SOURCE

On Sat, 1 Jul 2023 at 18:04, Dean Rasheed wrote: > > On Tue, 21 Mar 2023 at 12:26, Alvaro Herrera wrote: > > > > On 2023-Mar-21, Dean Rasheed wrote: > > > > > Looking at it with fresh eyes though, I realise that I could have just > > > written > > > > > > action->qual = make_and_qual((Node *

Re: Supporting MERGE on updatable views

On Mon, 30 Oct 2023 at 15:04, Dean Rasheed wrote: > > On Sun, 29 Oct 2023 at 17:17, Dean Rasheed wrote: > > > > On Sat, 28 Oct 2023 at 09:35, jian he wrote: > > > > > > Do we need to add > > > > We don't want to include MERGE in that sentence, because MERGE i

Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning

On Wed, 4 Oct 2023 at 04:02, Ashutosh Bapat wrote: > > On Fri, Sep 29, 2023 at 8:36 AM Amit Langote wrote: > > IOW, something > > like the following would have sufficed: > > > > @@ -1735,6 +1735,10 @@ build_child_join_sjinfo(PlannerInfo *root, > > SpecialJoinInfo *parent_sjinfo, > > /* > > * f

Re: [PoC/RFC] Multiple passwords, interval expirations

On Tue, 10 Oct 2023 at 16:37, Gurjeet Singh wrote: > > > On Mon, Oct 9, 2023 at 2:31 AM Gurjeet Singh wrote: > > > > > > Next steps: > > > - Break the patch into a series of smaller patches. > > > - Add TAP tests (test the ability to actually login with these passwords) > > > - Add/update documen

Re: [CAUTION!! freemail] Re: Partial aggregates pushdown

On Thu, 7 Dec 2023 at 05:41, fujii.y...@df.mitsubishielectric.co.jp wrote: > > Hi Mr.Haas. > > > -Original Message- > > From: Robert Haas > > Sent: Wednesday, December 6, 2023 10:25 PM > > On Wed, Dec 6, 2023 at 3:41 AM fujii.y...@df.mitsubishielectric.co.jp > > wrote: > > > Are you conc

Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500

On Mon, 8 Jan 2024 at 22:21, Tom Lane wrote: > > Richard Guo writes: > > On Sun, Jan 7, 2024 at 6:41 AM Tom Lane wrote: > >> Thanks for the report! I guess we need something like the attached. > > > +1. > > Pushed, thanks for looking at it. I have changed the status of the commitfest entry to

Re: Request for comment on setting binary format output per session

On Mon, 31 Jul 2023 at 21:58, Dave Cramer wrote: > > > Dave Cramer > > > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson wrote: >> >> > On 25 Apr 2023, at 16:47, Dave Cramer wrote: >> >> > Patch attached with comments removed >> >> This patch no longer applies, please submit a rebased version on

Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning

On Tue, 31 Oct 2023 at 10:48, Ashutosh Bapat wrote: > > On Thu, Sep 14, 2023 at 4:39 PM Ashutosh Bapat > wrote: > > > > The patch set is thus > > 0001 - patch used to measure memory used during planning > > > > 0002 - Patch to free intermediate Relids computed by > > adjust_child_relids_multileve

Re: POC, WIP: OR-clause support for indexes

On Tue, 5 Dec 2023 at 16:25, Andrei Lepikhov wrote: > > Here is fresh version with the pg_dump.pl regex fixed. Now it must pass > buildfarm. > > Under development: > 1. Explanation of the general idea in comments (Robert's note) > 2. Issue with hiding some optimizations (Alexander's note and examp

Re: Separate memory contexts for relcache and catcache

On Wed, 3 Jan 2024 at 16:56, Melih Mutlu wrote: > > Hi, > > torikoshia , 4 Ara 2023 Pzt, 07:59 tarihinde şunu > yazdı: >> >> Hi, >> >> I also think this change would be helpful. >> >> I imagine you're working on the Andres's comments and you already notice >> this, but v1 patch cannot be applied

Re: Some revises in adding sorting path

On Mon, 17 Jul 2023 at 14:25, Richard Guo wrote: > > > On Wed, Mar 29, 2023 at 4:00 AM David Rowley wrote: >> >> If you write some tests for this code, it will be useful to prove that >> it actually does something, and also that it does not break again in >> the future. I don't really want to jus

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

On Fri, 19 Jan 2024 at 10:50, Michael Paquier wrote: > > On Thu, Jan 18, 2024 at 09:25:16AM +0100, Anthonin Bonnefoy wrote: > > From what I can tell, there's no change in the behaviour. All paths > > would eventually go through HandleSlashCmds's cleaning logic. This is > > also mentioned in ignore

Re: Support run-time partition pruning for hash join

On Tue, 7 Nov 2023 at 13:25, Richard Guo wrote: > > > On Mon, Nov 6, 2023 at 11:00 PM Alexander Lakhin wrote: >> >> Please look at a warning and an assertion failure triggered by the >> following script: >> set parallel_setup_cost = 0; >> set parallel_tuple_cost = 0; >> set min_parallel_table_sca

Re: psql's FETCH_COUNT (cursor) is not being respected for CTEs

On Tue, 2 Jan 2024 at 20:28, Daniel Verite wrote: > > Hi, > > PFA a rebased version. CFBot shows that the patch does not apply anymore as in [1]: === Applying patches on top of PostgreSQL commit ID a3a836fb5e51183eae624d43225279306c2285b8 === === applying patch ./v5-0001-Implement-retrieval-of-

Re: Improving btree performance through specializing by key shape, take 2

On Mon, 30 Oct 2023 at 21:50, Matthias van de Meent wrote: > > On Thu, 26 Oct 2023 at 00:36, Peter Geoghegan wrote: > > Most of the work with something like > > this is the analysis of the trade-offs, not writing code. There are > > all kinds of trade-offs that you could make with something like

Re: Reducing connection overhead in pg_upgrade compat check phase

On Fri, 27 Oct 2023 at 18:50, Daniel Gustafsson wrote: > > Attached is a v10 rebase of this patch which had undergone significant bitrot > due to recent changes in the pg_upgrade check phase. This brings in the > changes into the proposed structure without changes to queries, with no > additional

Re: User functions for building SCRAM secrets

On Sat, 2 Dec 2023 at 12:22, John Naylor wrote: > > On Wed, Mar 22, 2023 at 9:06 PM Jonathan S. Katz wrote: > > > > Maybe I'm not conveying the problem this is solving -- I'm happy to go > > one more round trying to make it clearer -- but if this is not clear, > > it'd be good to at develop an al

Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

On Wed, 22 Nov 2023 at 21:54, Daniel Verite wrote: > > Shlok Kyal wrote: > > > > The error was corrected and a new diff file was created. > > > The diff file was created based on 16 RC1. > > > We confirmed that 5 places where errors occurred when performing > > > make check were changed to

Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

On Fri, 26 Jan 2024 at 22:22, Jelte Fennema-Nio wrote: > > On Fri, 26 Jan 2024 at 13:11, Alvaro Herrera wrote: > > I wonder, would it make sense to put all these new functions in a > > separate file fe-cancel.c? > > > Okay I tried doing that. I think the end result is indeed quite nice, > having

Re: Tab completion for ATTACH PARTITION

On Wed, 13 Sept 2023 at 06:57, bt23nguyent wrote: > > Hi, > > Currently, the psql's tab completion feature does not support properly > for ATTACH PARTITION. When key is typed after "ALTER TABLE > ATTACH PARTITION ", all possible table names should be > displayed, however, foreign table names are

Re: Wrong rows estimations with joins of CTEs slows queries by more than factor 500

On Mon, 29 Jan 2024 at 08:01, Richard Guo wrote: > > > On Sat, Jan 27, 2024 at 10:08 AM vignesh C wrote: >> >> On Mon, 8 Jan 2024 at 22:21, Tom Lane wrote: >> > >> > Richard Guo writes: >> > > On Sun, Jan 7, 2024 at 6:41 AM Tom Lane wro

Commitfest 2024-01 fourth week update

Hi, Here's a quick status report after the fourth week: Status summary: status| w1 | w2 | w3| w4 ---+---+++-- Needs review: |238 | 213| 181| 147 W

Re: Documentation to upgrade logical replication cluster

Thanks for the comments, the attached v5 version patch has the changes for the same. Regards, Vignesh From 08d42bc4b8601c9af9302e9778523640a238f8d5 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Wed, 13 Dec 2023 14:11:58 +0530 Subject: [PATCH v5] Documentation for upgrading logical replication c

Re: Race condition in FetchTableStates() breaks synchronization of subscription tables

On Fri, 26 Jan 2024 at 11:30, Alexander Lakhin wrote: > > Hello hackers, > > After determining a possible cause for intermittent failures of the test > subscription/031_column_list [1], I was wondering what makes another > subscription test (014_binary) fail on the buildfarm: > https://buildfarm.p

Re: Race condition in FetchTableStates() breaks synchronization of subscription tables

On Tue, 30 Jan 2024 at 07:24, Zhijie Hou (Fujitsu) wrote: > > On Monday, January 29, 2024 9:22 PM vignesh C wrote: > > > > On Fri, 26 Jan 2024 at 11:30, Alexander Lakhin wrote: > > > > > > Hello hackers, > > > > > > After determining a poss

Re: Documentation to upgrade logical replication cluster

On Mon, 29 Jan 2024 at 16:01, Bharath Rupireddy wrote: > > On Mon, Jan 29, 2024 at 10:10 AM vignesh C wrote: > > > > Thanks for the comments, the attached v5 version patch has the changes > > for the same. > > Thanks for working on this. Here are some c

Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix

On Wed, 31 Jan 2024 at 10:27, Peter Smith wrote: > > Hi, > > PSA a small fix for a misleading comment found in the pg_upgrade test code. Is the double # intentional here, as I did not see this style of commenting used elsewhere: +# # Upgraded regress_sub1 should still have enabled and failover as

Re: Improve eviction algorithm in ReorderBuffer

On Tue, 30 Jan 2024 at 13:37, Masahiko Sawada wrote: > > On Fri, Jan 26, 2024 at 5:36 PM Masahiko Sawada wrote: > > > > On Wed, Dec 20, 2023 at 12:11 PM Amit Kapila > > wrote: > > > > > > On Wed, Dec 20, 2023 at 6:49 AM Masahiko Sawada > > > wrote: > > > > > > > > On Tue, Dec 19, 2023 at 8:02

Re: CI and test improvements

On Thu, 18 Jan 2024 at 06:46, Michael Paquier wrote: > > On Wed, Jan 17, 2024 at 05:34:00PM +0530, vignesh C wrote: > > Are we planning to do anything more in this thread, the thread has > > been idle for more than 7 months. If nothing more is planned for this, > > I&

Re: Emitting JSON to file using COPY TO

On Sat, 27 Jan 2024 at 11:25, Junwang Zhao wrote: > > Hi hackers, > > Kou-san(CCed) has been working on *Make COPY format extendable[1]*, so > I think making *copy to json* based on that work might be the right direction. > > I write an extension for that purpose, and here is the patch set togethe

Re: Race condition in FetchTableStates() breaks synchronization of subscription tables

On Tue, 30 Jan 2024 at 17:22, Zhijie Hou (Fujitsu) wrote: > > On Tuesday, January 30, 2024 11:21 AM vignesh C wrote: > > > > On Tue, 30 Jan 2024 at 07:24, Zhijie Hou (Fujitsu) > > wrote: > > > > > > On Monday, January 29, 2024 9:22 PM vignesh C > &g

Re: Documentation to upgrade logical replication cluster

cal slots on the primary are copied > to the > new standby. > ``` I felt that this change is not related to this patch. I'm removing these changes from the patch. Let's handle rephrasing of the base code change in a separate thread. Thanks for the comments, the attached v7 version pat

Re: Why is src/test/modules/committs/t/002_standby.pl flaky?

On Mon, 22 Jan 2024 at 09:56, Peter Smith wrote: > > 2024-01 Commitfest. > > Hi, This patch has a CF status of "Needs Review" [1], but it seems > like there were CFbot test failures last time it was run [1]. Please > have a look and post an updated version if necessary. The patch which you submit

Re: [PoC] Implementation of distinct in Window Aggregates: take two

On Wed, 8 Nov 2023 at 11:46, Shlok Kyal wrote: > > Hi, > > I went through the Cfbot, and some of the test cases are failing for > this patch. It seems like some tests are crashing: > https://api.cirrus-ci.com/v1/artifact/task/6291153444667392/crashlog/crashlog-postgres.exe_03b0_2023-11-07_10-41-39

Re: [PATCH] Support % wildcard in extension upgrade filenames

On Sun, 7 Jan 2024 at 12:36, vignesh C wrote: > > On Mon, 7 Aug 2023 at 19:25, Sandro Santilli wrote: > > > > On Tue, Aug 01, 2023 at 08:24:15PM +0200, Daniel Gustafsson wrote: > > > > On 28 Jun 2023, at 10:29, Daniel Gustafsson wrote: > > > > > >

Re: [PoC/RFC] Multiple passwords, interval expirations

On Sat, 27 Jan 2024 at 07:18, vignesh C wrote: > > On Tue, 10 Oct 2023 at 16:37, Gurjeet Singh wrote: > > > > > On Mon, Oct 9, 2023 at 2:31 AM Gurjeet Singh wrote: > > > > > > > > Next steps: > > > > - Break the patch into a series of s

Re: [PATCH] ltree hash functions

On Wed, 6 Dec 2023 at 04:08, Tommy Pavlicek wrote: > > Thanks. > > I've attached the latest version that updates the naming in line with > the convention. > > On Mon, Dec 4, 2023 at 12:46 AM jian he wrote: > > > > On Fri, Dec 1, 2023 at 8:44 AM Tommy Pavlicek wrote: > > > > > > > > > Patch updat

Re: Moving forward with TDE [PATCH v3]

On Mon, 22 Jan 2024 at 11:47, Peter Smith wrote: > > 2024-01 Commitfest. > > Hi, This patch has a CF status of "Needs Review" [1], but it seems > there were CFbot test failures last time it was run [2]. Please have a > look and post an updated version if necessary. The patch which you submitted h

Re: Collation version tracking for macOS

On Mon, 22 Jan 2024 at 00:28, Jeff Davis wrote: > > On Sat, 2024-01-20 at 07:40 +0530, vignesh C wrote: > > This thread has been idle for a year now, It has stalled after a lot > > of discussion. > > @Jeff Davis: Do you want to try to restart the discussion by posting &g

Re: Request for comment on setting binary format output per session

On Sat, 27 Jan 2024 at 07:45, vignesh C wrote: > > On Mon, 31 Jul 2023 at 21:58, Dave Cramer wrote: > > > > > > Dave Cramer > > > > > > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson wrote: > >> > >> > On 25 Apr 2023, at 16:4

Re: Volatile write caches on macOS and Windows, redux

On Mon, 22 Jan 2024 at 07:46, Peter Smith wrote: > > 2024-01 Commitfest. > > Hi, this patch was marked in CF as "Needs Review" [1], but there has > been no activity on this thread for 6+ months. > > Is anything else planned, or can you post something to elicit more > interest in the patch? Otherwi

Re: Skip collecting decoded changes of already-aborted transactions

On Tue, 3 Oct 2023 at 15:54, vignesh C wrote: > > On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote: > > > > On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote: > > > > > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada > > > wrote: > >

Re: Forbid the use of invalidated physical slots in streaming replication.

On Mon, 8 Jan 2024 at 10:25, vignesh C wrote: > > On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat > wrote: > > > > > > > pg_replication_slot could be set back to null. > > > > > > > > In this case, since the basebackup was taken after the slot

Re: Move bki file pre-processing from initdb to bootstrap

On Sat, 11 Nov 2023 at 00:03, Krishnakumar R wrote: > > Thank you for review, Peter. > > Makes sense on the split part. Was starting to think in same lines, at the > end of last iteration. Will come back shortly. > > On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut > wrote: >> >> On 17.10.23 0

Re: Unified File API

On Sat, 6 Jan 2024 at 22:58, vignesh C wrote: > > On Thu, 29 Jun 2023 at 13:20, John Morris wrote: > > > > Background > > > > == > > > > PostgreSQL has an amazing variety of routines for accessing files. Consider > > just t

Re: Using AF_UNIX sockets always for tests on Windows

On Sun, 21 Jan 2024 at 18:01, vignesh C wrote: > > On Wed, 22 Mar 2023 at 09:59, Thomas Munro wrote: > > > > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that > > it's a better "OS harmonisation" outcome if we can choose both ways o

Re: GenBKI emits useless open;close for catalogs without rows

On Wed, 8 Nov 2023 at 12:50, Peter Eisentraut wrote: > > On 08.11.23 08:16, Peter Eisentraut wrote: > > On 19.09.23 20:05, Heikki Linnakangas wrote: > >> One thing caught my eye though: We currently have an "open" command > >> after every "create". Except for bootstrap relations; creating a > >> b

<    1   2   3   4   5   6   7   8   9   10   >