On Wed, 22 Nov 2023 at 21:54, Daniel Verite <dan...@manitou-mail.org> wrote: > > Shlok Kyal wrote: > > > > The error was corrected and a new diff file was created. > > > The diff file was created based on 16 RC1. > > > We confirmed that 5 places where errors occurred when performing > > > make check were changed to ok. > > Reviewing the patch, I see these two problems in the current version > (File: psql-slashDplus-partition-indentation.diff, Date: 2023-09-19 00:19:34) > > * There are changes in the regression tests that do not concern this > feature and should not be there. > > For instance this hunk: > > --- a/src/test/regress/expected/foreign_data.out > +++ b/src/test/regress/expected/foreign_data.out > @@ -742,8 +742,6 @@ COMMENT ON COLUMN ft1.c1 IS 'ft1.c1'; > Check constraints: > "ft1_c2_check" CHECK (c2 <> ''::text) > "ft1_c3_check" CHECK (c3 >= '01-01-1994'::date AND c3 <= > '01-31-1994'::date) > -Not-null constraints: > - "ft1_c1_not_null" NOT NULL "c1" > Server: s0 > FDW options: (delimiter ',', quote '"', "be quoted" 'value') > > It seems to undo a test for a recent feature adding "Not-null > constraints" to \d, which suggests that you've been running tests > against and older version than the source tree you're diffing > against. These should be the same version, and also the latest > one (git HEAD) or as close as possible to the latest when the > patch is submitted. > > * The new query with \d on partitioned tables does not work with > Postgres servers 12 or 13: > > > postgres=# CREATE TABLE measurement ( > city_id int not null, > logdate date not null, > peaktemp int, > unitsales int > ) PARTITION BY RANGE (logdate); > > postgres=# \d measurement > ERROR: syntax error at or near "." > LINE 2: ... 0 AS level, c.relkind, false AS i.inhdetach... > > > Setting the CommitFest status to WoA.
I have changed the status of the CommitFest entry to "Returned with Feedback" as Shlok's and Daniel's suggestions are not handled. Feel free to address them and add a new commitfest entry for the same. Regards, Vignesh
