On Mon, 30 Oct 2023 at 15:04, Dean Rasheed <dean.a.rash...@gmail.com> wrote: > > On Sun, 29 Oct 2023 at 17:17, Dean Rasheed <dean.a.rash...@gmail.com> wrote: > > > > On Sat, 28 Oct 2023 at 09:35, jian he <jian.universal...@gmail.com> wrote: > > > > > > Do we need to add <<command>MERGE</command> for the following sentence? > > > > > We don't want to include MERGE in that sentence, because MERGE isn't > > supported on views or tables with rules, but I guess we could add > > another sentence after that one, to make that clear. > > > > Here's an updated patch doing that, plus another couple of minor > updates to that page. > > I also noticed that the code to detect rules ought to ignore disabled > rules, so I've updated it to do so, and added a new regression test to > cover that case. > > Arguably that's a pre-existing bug, so the fix could be extracted and > applied separately, but I'm not sure that it's worth the effort.
CFBot shows that the patch does not apply anymore as in [1]: === Applying patches on top of PostgreSQL commit ID 55627ba2d334ce98e1f5916354c46472d414bda6 === === applying patch ./support-merge-into-view-v10.patch .... patching file src/backend/executor/nodeModifyTable.c ... Hunk #7 FAILED at 2914. ... 1 out of 15 hunks FAILED -- saving rejects to file src/backend/executor/nodeModifyTable.c.rej Please post an updated version for the same. [1] - http://cfbot.cputube.org/patch_46_4076.log Regards, Vignesh
