Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-07 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: > Thanks for picking this up. > > On Thu, Sep 07, 2023 at 03:33:57PM -0400, Bruce Momjian wrote: > > The default value is > class="systemname">localhost, > > wh

Re: Correct the documentation for work_mem

2023-09-07 Thread Bruce Momjian
it or some > (nonexistent) overall limit. How about > > - memory available for hash tables is computed by multiplying > + memory limit for a hash table is computed by multiplying Adjusted patch attached. -- Bruce Momjian https://momjian.us EDB

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-08 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote: > >> IMO the phrase "open a port" is kind of nonstandard. I think we sho

Re: Correct the documentation for work_mem

2023-09-11 Thread Bruce Momjian
have 12 sorts and 4 hashes then that's not "several sort or hash > operations", it's "several sort and hash operations". Of course, it > could just be sorts or just hashes, so "and/or" works fine for that. Yes, I see your point and went with "and&qu

Re: pg_upgrade --check fails to warn about abstime

2023-09-21 Thread Bruce Momjian
ver added code to pg_upgrade to check for that, and no one complained either. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Partial aggregates pushdown

2023-09-25 Thread Bruce Momjian
ix to the patch. > > Tuesday, August 8, 2023 at 3:31 Bruce Momjian > > > I have modified the program except for the point "if the version of the > > > remote server is less than PG17". > > > Instead, we have addressed the following. > > > "

Re: Partial aggregates pushdown

2023-09-26 Thread Bruce Momjian
please suggest a correction? I like your new wording, thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Obsolete reference to pg_relation in comment

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 10:44:25AM +0200, Daniel Gustafsson wrote: > > On 6 Sep 2023, at 21:13, Bruce Momjian wrote: > > On Wed, Jul 26, 2023 at 05:14:08PM -0400, Tom Lane wrote: > > >> I think we should reword this to just generically claim that holding > >> th

Re: [PATCH] pgrowlocks: Make mode names consistent with docs

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 12:58:29PM -0400, Bruce Momjian wrote: > You are right something is wrong. However, I looked at your patch and I > am thinking we need to go the other way and add "For" in the upper > block, rather than removing it in the lower one. I have two reasons

Re: pg_upgrade instructions involving "rsync --size-only" might lead to standby corruption?

2023-09-26 Thread Bruce Momjian
On Thu, Sep 7, 2023 at 01:52:45PM -0400, Bruce Momjian wrote: > On Mon, Jul 10, 2023 at 02:37:24PM -0700, Nikolay Samokhvalov wrote: > > Maybe. It will require changes in other parts of this doc. > > Thinking (here:  > > https://gitlab.com/postgres/postgres/-/me

Re: Document that server will start even if it's unable to open some TCP/IP ports

2023-09-26 Thread Bruce Momjian
On Tue, Sep 12, 2023 at 05:25:44PM -0700, Gurjeet Singh wrote: > On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian wrote: > > > > On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote: > > > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote: > > >

Re: Correct the documentation for work_mem

2023-09-26 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 02:05:44AM +1300, David Rowley wrote: > On Tue, 12 Sept 2023 at 03:03, Bruce Momjian wrote: > > > > On Mon, Sep 11, 2023 at 10:02:55PM +1200, David Rowley wrote: > > > It's certainly not a show-stopper. I do believe the patch makes some > &

Re: Set enable_seqscan doesn't take effect?

2023-09-28 Thread Bruce Momjian
t; Greetings, > > > > Andres Freund > I’m so sorry for that. I think I’m not very familiar with pg, so I ask many > naive questions. And I apologize for my behavior. I think you might find our IRC channel a more natural fit for getting your questions a

Re: Fix incorrect comment reference

2023-09-29 Thread Bruce Momjian
t still points to the > > > > proper callsite (so that people don't go looking for that confused)? > > > > > > I don't really have a strong view on what the best thing to do is. I > > > was just pointing out that the comment might not be quite so obviously > > > wrong as you were supposing. > > > > "Wrong" is certainly too strong; my apologies. > > > > I'm really just hoping to improve it for future readers to save them > > some confusion I had initially reading it. > > Updated patch attached. Patch applied. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: SHARED locks barging behaviour

2023-09-29 Thread Bruce Momjian
fomask) || HEAP_XMAX_IS_EXCL_LOCKED(tuple->t_data->t_infomask)) goto l3; require_sleep = false; } } and this is basically saying that if the row is locked (HEAP_XMAX_IS_LOCKED_ONLY), but not exclusively locked (!HEAP_XMAX_IS_EXCL_LOCKED)

Re: document the need to analyze partitioned tables

2023-09-29 Thread Bruce Momjian
tached is the next version of my patch. I adjusted your patch to be shorter and clearer, patch attached. I am planning to apply this back to PG 11. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is

Re: document the need to analyze partitioned tables

2023-09-29 Thread Bruce Momjian
On Sat, Sep 30, 2023 at 12:39:43AM +0200, Laurenz Albe wrote: > On Fri, 2023-09-29 at 18:08 -0400, Bruce Momjian wrote: > > On Wed, Sep  6, 2023 at 05:53:56AM +0200, Laurenz Albe wrote: > > > > We may have different mental models here. This relates to the part > > > &

Re: document the need to analyze partitioned tables

2023-10-06 Thread Bruce Momjian
On Mon, Oct 2, 2023 at 04:48:20AM +0200, Laurenz Albe wrote: > On Fri, 2023-09-29 at 22:34 -0400, Bruce Momjian wrote: > > Very good point! Updated patch attached. > > Thanks! Some small corrections: > > > diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/ma

Re: Good News Everyone! + feature proposal

2023-10-06 Thread Bruce Momjian
h the IRC handles. As a human I feel that necessity. There is: https://wiki.postgresql.org/wiki/IRC2RWNames -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: [PoC/RFC] Multiple passwords, interval expirations

2023-10-06 Thread Bruce Momjian
il_old EXISTS rolpassword EXISTS rolvaliduntil I did blog about the password rotation problem and suggested certificates: https://momjian.us/main/blogs/pgblog/2020.html#July_17_2020 -- Bruce Momjian https://momjian.us

Re: Problem, partition pruning for prepared statement with IS NULL clause.

2023-10-06 Thread Bruce Momjian
On Fri, Oct 6, 2023 at 06:09:45PM +0400, Sergei Glukhov wrote: > Test case: > -- > set plan_cache_mode to force_generic_plan; > prepare stmt AS select * from hp where a is null and b = $1; > explain execute stmt('xxx'); > -- I can confirm the crash in git

Re: Problem, partition pruning for prepared statement with IS NULL clause.

2023-10-06 Thread Bruce Momjian
On Fri, Oct 6, 2023 at 05:00:54PM -0400, Bruce Momjian wrote: > On Fri, Oct 6, 2023 at 06:09:45PM +0400, Sergei Glukhov wrote: > > Test case: > > -- > > set plan_cache_mode to force_generic_plan; > > prepare stmt AS select * from hp where a is null and b = $1; &g

Re: Where can I find the doxyfile?

2023-10-06 Thread Bruce Momjian
It would be nice if this doxygen file would be placed somewhere > on the current site. > > P.S. I've tried to run doxygen on postgres sources without config, > and it didn't find any source file, this archived thread helped. > > Perhaps doxygen file can be just placed into pos

Re: [PoC/RFC] Multiple passwords, interval expirations

2023-10-08 Thread Bruce Momjian
On Sun, Oct 8, 2023 at 10:24:42AM -0700, Gurjeet Singh wrote: > On Fri, Oct 6, 2023 at 1:46 PM Bruce Momjian wrote: > > > > On Fri, Oct 6, 2023 at 01:20:03PM -0700, Jeff Davis wrote: > > > The basic problem, as I see it, is: how do we keep users from > > >

Re: [PoC/RFC] Multiple passwords, interval expirations

2023-10-08 Thread Bruce Momjian
On Sun, Oct 8, 2023 at 10:50:15AM -0700, Gurjeet Singh wrote: > On Sun, Oct 8, 2023 at 10:29 AM Bruce Momjian wrote: > > > > I was speaking of autoremoving in cases where we are creating a new one, > > and taking the previous new one and making it the old one, if that was &g

Re: Lowering the default wal_blocksize to 4K

2023-10-09 Thread Bruce Momjian
s in 8KB WAL > pages, it seems we should just go for 4KB? How do we handle shorter maximum row lengths and shorter maximum index entry lengths? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.

Re: Lowering the default wal_blocksize to 4K

2023-10-09 Thread Bruce Momjian
On Mon, Oct 9, 2023 at 04:36:20PM -0700, Andres Freund wrote: > Hi, > > On 2023-10-09 19:26:54 -0400, Bruce Momjian wrote: > > On Mon, Oct 9, 2023 at 04:08:05PM -0700, Andres Freund wrote: > > > There's an alternative approach we could take, which is to write i

Re: document the need to analyze partitioned tables

2023-10-10 Thread Bruce Momjian
On Fri, Oct 6, 2023 at 06:49:05PM +0200, Laurenz Albe wrote: > On Fri, 2023-10-06 at 12:20 -0400, Bruce Momjian wrote: > > Good points, updated patch attached. > > That patch is good to go, as far as I am concerned. Patch applied back to PG 11, thanks. -- Bruce Momjian

Re: Internal key management system

2020-03-12 Thread Bruce Momjian
256-bit key for the master key, but give users an option of 128-bit vs 256-bit keys for block-level encryption. 256-bit keys are considered necessary for security against future quantum computing attacks. This looks like a bug in the patch: -This parameter can only be set in the postg

Re: PATCH: add support for IN and @> in functional-dependency statistics use

2020-03-13 Thread Bruce Momjian
functional > dependencies. Wow, that is a very good example --- the arrays do not tie elements in one array to elements in another array; good point. I get it now! -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: RETURNING does not explain evaluation context for subqueries

2020-03-13 Thread Bruce Momjian
ses the snapshot from before the update. My guess is that we just didn't consider the rules for what the 'y' references, and I bet if I dig into the code I can find out why this happening. RETURNING for INSERT/UPDATE/DELETE isn't part of the SQL standard, so we don't hav

Re: Fix comment for max_cached_tuplebufs definition

2020-03-14 Thread Bruce Momjian
* 2 times > MaxHeapTupleSize amount of memory which is approximately 64MB. I've > attached a patch to modify the comment. > > But, I'm not sure whether the intention was to keep 8MB cache only. In > that case, I can come up with another patch. Yes, I see you are correct, si

Re: control max length of parameter values logged

2020-03-14 Thread Bruce Momjian
am sorry --- I am confused. Why are we truncating or allowing control of truncation of BIND parameter values, but have no such facility for queries. Do we assume queries are shorter than BIND parameters, or is it just that it is easier to trim BIND parameters than values embedded in non-EXECUTE que

Re: Internal key management system

2020-03-16 Thread Bruce Momjian
On Mon, Mar 16, 2020 at 04:13:21PM +0900, Masahiko Sawada wrote: > On Thu, 12 Mar 2020 at 08:13, Bruce Momjian > wrote: > > > > On Fri, Mar 6, 2020 at 03:31:00PM +0900, Masahiko Sawada wrote: > > > On Fri, 6 Mar 2020 at 15:25, Moon, Insung > > > wr

Re: Just for fun: Postgres 20?

2020-03-16 Thread Bruce Momjian
ONB was discovered to be sub-optimal in August/September. While a relesae team might have gotten the release out before January, that isn't certain. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Add PostgreSQL home page to --help output

2020-03-16 Thread Bruce Momjian
tgresql.org/> I actually have never seen URLs in <>, only email addresses. I think using <> for URLs and emails is confusing because they usually have different actions, unless we want to add mailto: Report bugs <mailto:pgsql-b...@lists.postgresql.org>

Re: Add PostgreSQL home page to --help output

2020-03-16 Thread Bruce Momjian
On Mon, Mar 16, 2020 at 05:55:26PM -0400, Bruce Momjian wrote: > Report bugs mailto:pgsql-b...@lists.postgresql.org > PostgreSQL home page https://www.postgresql.org/ > > I kind of prefer the last one since the can both be pasted directly into > a browser. Act

Re: Error on failed COMMIT

2020-03-17 Thread Bruce Momjian
ed before the commit. Applications that track statement errors and issue rollbacks will be fine. So, we are left with applications that issue COMMIT and expect success after a transaction block has failed. Do we know how other database systems handle this? -- Bruce Momjian https://m

Re: Error on failed COMMIT

2020-03-17 Thread Bruce Momjian
On Tue, Mar 17, 2020 at 07:15:05PM -0400, Dave Cramer wrote: > On Tue, 17 Mar 2020 at 16:47, Bruce Momjian wrote: > Third, the idea that individual interfaces, e.g. JDBC, should throw an > error in this case while the server just changes the COMMIT return tag > to

Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING

2020-03-17 Thread Bruce Momjian
item as being exactly the same as > it is in SELECT. > > (Compare the handling of with_query, which has pretty much the > same problem of being way too complex to document three times.) I have implemented the ideas above in the attached patch. I have synchronized the syntax t

Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING

2020-03-18 Thread Bruce Momjian
On Tue, Mar 17, 2020 at 10:58:54PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have implemented the ideas above in the attached patch. I have > > synchronized the syntax to match SELECT, and synchronized the paragraphs > > describing the item. > > I thi

Re: Define variables in the approprieate scope

2020-03-18 Thread Bruce Momjian
r each loop iteration. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Internal key management system

2020-03-19 Thread Bruce Momjian
fferent encryption key for block > encryption. Therefore we will end up with having two encryption keys > inside database. Maybe we can discuss this after the key manager has > been introduced. I know Sehrope liked derived keys so let's get his feedback on this. We might want to have two

Re: Internal key management system

2020-03-19 Thread Bruce Momjian
On Thu, Mar 19, 2020 at 11:42:36PM +0900, Masahiko Sawada wrote: > On Thu, 19 Mar 2020 at 22:00, Bruce Momjian wrote: > > > > On Thu, Mar 19, 2020 at 06:32:57PM +0900, Masahiko Sawada wrote: > > > On Thu, 19 Mar 2020 at 15:59, Masahiko Sawada > > > > I und

Re: Internal key management system

2020-03-19 Thread Bruce Momjian
On Fri, Mar 20, 2020 at 12:50:27AM +0900, Masahiko Sawada wrote: > On Fri, Mar 20, 2020 at 0:35 Bruce Momjian wrote: > Well, the issue is if the user can control the user key, there is might be > a way to make the user key do nothing. > > Well I meant ‘USER_KEY:’ is a fixe

Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file

2020-03-19 Thread Bruce Momjian
sage, and improved quoting. This patch backpatches the "could not open" cause to PG 12, where it was first widely used, and backpatches the quoting fix in that patch to all supported releases. Because some of the branches are different, I

Re: Add PostgreSQL home page to --help output

2020-03-19 Thread Bruce Momjian
bOn Mon, Mar 16, 2020 at 09:10:25PM -0300, Alvaro Herrera wrote: > On 2020-Mar-16, Bruce Momjian wrote: > > > On Mon, Mar 16, 2020 at 05:55:26PM -0400, Bruce Momjian wrote: > > > Report bugs mailto:pgsql-b...@lists.postgresql.org > > > PostgreSQL home p

Re: color by default

2020-03-19 Thread Bruce Momjian
t; export PG_COLORS='error=01;34:locus=01;33' > > Having to dig into the code to find out that stuff is not a good user > experience. And I found out about that only because I worked on a > patch touching this area yesterday. I can confirm there is still no mention of PG_COL

Re: Internal key management system

2020-03-20 Thread Bruce Momjian
s. The wrapped password is visible, but to use it you must be able to connect to a running server (to unwrap it), or have a shut down server and know the paasphrase. Read access to the file system is not sufficient since there is no access to the pass phrase. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: color by default

2020-03-20 Thread Bruce Momjian
On Thu, Mar 19, 2020 at 10:15:57PM -0400, Bruce Momjian wrote: > On Tue, Mar 3, 2020 at 02:31:01PM +0900, Michael Paquier wrote: > > On Mon, Mar 02, 2020 at 01:00:44PM +0100, Juan José Santamaría Flecha wrote: > > > - The new entry in the documentation, specially as the P

Re: color by default

2020-03-20 Thread Bruce Momjian
On Fri, Mar 20, 2020 at 11:15:07PM -0400, Tom Lane wrote: > Bruce Momjian writes: > >> I can confirm there is still no mention of PG_COLORS in our > >> documentation. > > > My mistake, PG_COLOR (not PG_COLORS) is documented properly. > > Yeah, but the poi

Re: Internal key management system

2020-03-21 Thread Bruce Momjian
On Sat, Mar 21, 2020 at 02:12:46PM +0900, Masahiko Sawada wrote: > On Sat, 21 Mar 2020 at 05:30, Bruce Momjian wrote: > > We should create an SQL-level master key that is different from the > > block-level master key. By using separate keys, and not deriving them > > from a

Re: Internal key management system

2020-03-21 Thread Bruce Momjian
On Sat, Mar 21, 2020 at 10:01:02AM -0400, Bruce Momjian wrote: > On Sat, Mar 21, 2020 at 02:12:46PM +0900, Masahiko Sawada wrote: > > On Sat, 21 Mar 2020 at 05:30, Bruce Momjian wrote: > > > We should create an SQL-level master key that is different from the > > >

Re: Ecpg dependency

2020-03-21 Thread Bruce Momjian
and this is a new bug in PG 12. The attached patch fixes PG 12 and master. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscripti

Re: Ecpg dependency

2020-03-21 Thread Bruce Momjian
On Sat, Mar 21, 2020 at 02:14:44PM -0400, Bruce Momjian wrote: > On Tue, Mar 10, 2020 at 01:47:14PM +0100, Filip Janus wrote: > > Hello, > > After upgrade from 11.2 to 12.2 I found, that build of ecpg component > > depends > > on pgcommon_shlib and pgport_shlib.  But bu

Re: [HACKERS] WAL logging problem in 9.4.3?

2020-03-21 Thread Bruce Momjian
ostgresNode.pm > > > and RecursiveCopy.pm along with 018_wal_optimize.pl. > > > (0004-Add-TAP-test-for-WAL-skipping-feature.patch) > > > > That is a good idea. Rather than make it specific to this test, I would > > like > > to back-

Re: Ecpg dependency

2020-03-21 Thread Bruce Momjian
On Sat, Mar 21, 2020 at 07:30:48PM +, Dagfinn Ilmari Mannsåker wrote: > Bruce Momjian writes: > > > On Sat, Mar 21, 2020 at 02:14:44PM -0400, Bruce Momjian wrote: > >> On Tue, Mar 10, 2020 at 01:47:14PM +0100, Filip Janus wrote: > >> > Hello, > >>

Re: Internal key management system

2020-03-23 Thread Bruce Momjian
On Mon, Mar 23, 2020 at 03:55:34PM +0900, Masahiko Sawada wrote: > On Sat, 21 Mar 2020 at 23:50, Bruce Momjian wrote: > > Actually, I think we need three files: > > > > * TDE WAL key file > > * TDE block key file > > * SQL-level file > > > > Primar

Re: backend type in log_line_prefix?

2020-03-23 Thread Bruce Momjian
> + application_name text, > + backend_type text > ) SERVER pglog > OPTIONS ( filename '/home/josh/data/log/pglog.csv', format 'csv' ); > Patch applied to master, thanks. -- Bruce Momjian https://momjian.us EnterpriseDB

Re: Define variables in the approprieate scope

2020-03-23 Thread Bruce Momjian
On Mon, Mar 23, 2020 at 01:00:24PM -0300, Alvaro Herrera wrote: > On 2020-Mar-18, Bruce Momjian wrote: > > > On Tue, Feb 25, 2020 at 09:35:52AM +0100, Antonin Houska wrote: > > > I've noticed that two variables in RelationCopyStorage() are defined in a > > >

Re: Internal key management system

2020-03-24 Thread Bruce Momjian
x27;ll update the patch and post. Yes, that makes sense to me. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: Internal key management system

2020-03-27 Thread Bruce Momjian
On Wed, Mar 25, 2020 at 05:51:08PM +0900, Masahiko Sawada wrote: > On Tue, 24 Mar 2020 at 23:15, Bruce Momjian wrote: > > > > On Tue, Mar 24, 2020 at 02:29:57PM +0900, Masahiko Sawada wrote: > > > That seems to work fine. > > > > > > So we will have p

Re: backup manifests

2020-03-27 Thread Bruce Momjian
s feels like it has generated a lot of bickering emails, and people don't want to spend their time dealing with that. -- Bruce Momjian https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +

Re: backup manifests

2020-03-27 Thread Bruce Momjian
On Fri, Mar 27, 2020 at 06:38:33PM -0400, Stephen Frost wrote: > Greetings, > > On Fri, Mar 27, 2020 at 18:36 Bruce Momjian wrote: > > On Thu, Mar 26, 2020 at 12:34:52PM -0400, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > > >

Re: Improving connection scalability: GetSnapshotData()

2020-03-28 Thread Bruce Momjian
; I have heard quite a few complaints about the scalability of snapshot > acquisition in Postgres. Generally from very large users that are not > well represented on the mailing lists, for a variety of reasons. The > GetSnapshotData() bottleneck is a *huge* problem for us. (As problems &g

Re: Ecpg dependency

2020-03-31 Thread Bruce Momjian
On Sat, Mar 21, 2020 at 06:13:03PM -0400, Bruce Momjian wrote: > On Sat, Mar 21, 2020 at 07:30:48PM +, Dagfinn Ilmari Mannsåker wrote: > > Bruce Momjian writes: > > > On Sat, Mar 21, 2020 at 02:14:44PM -0400, Bruce Momjian wrote: > > > Oh, I forgot to mention I g

Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING

2020-03-31 Thread Bruce Momjian
On Wed, Mar 18, 2020 at 12:24:45PM -0400, Bruce Momjian wrote: > On Tue, Mar 17, 2020 at 10:58:54PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I have implemented the ideas above in the attached patch. I have > > > synchronized the syntax to match S

Re: backend type in log_line_prefix?

2020-03-31 Thread Bruce Momjian
On Fri, Mar 27, 2020 at 04:30:07PM +0900, Kyotaro Horiguchi wrote: > Hello. > > At Mon, 23 Mar 2020 18:38:53 -0400, Bruce Momjian wrote in > > Patch applied to master, thanks. > > The patch (8e8a0becb3) named archiver process as just "archiver". On > th

Re: Issues with building cpp extensions on PostgreSQL 10+

2020-03-31 Thread Bruce Momjian
Makefile.shlib > +++ b/src/Makefile.shlib > @@ -101,6 +101,7 @@ endif > # Try to keep the sections in some kind of order, folks... > > override CFLAGS += $(CFLAGS_SL) > +override CXXFLAGS += $(CFLAGS_SL) > ifdef SO_MAJOR_VERSION > # libraries ought to use this to refer to

Re: Tab completion for \gx

2020-03-31 Thread Bruce Momjian
else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\i|\\include|" > + else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\gx|\\i|\\include|" > > "\\ir|\\include_relative|\\o|\\out|" >

Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)

2022-01-24 Thread Bruce Momjian
; > do it honestly, and put them into the range intended for that purpose. > > Trying to take short-cuts is just going to cause trouble down the road. > > Understood. I will rework the patch accordingly. Thanks Thanks. To get the rsync update reduction we need to preserve database o

Re: pg_upgrade should truncate/remove its logs before running

2022-01-24 Thread Bruce Momjian
_output.d in > + the directory of the new cluster. > Uh, how are we instructing people to delete that pg_upgrade output directory? If pg_upgrade completes cleanly, would it be removed automatically? -- Bruce Momjian https://momjian.us EDB

Re: pg_upgrade should truncate/remove its logs before running

2022-01-24 Thread Bruce Momjian
On Mon, Jan 24, 2022 at 11:41:17AM -0600, Justin Pryzby wrote: > On Mon, Jan 24, 2022 at 12:39:30PM -0500, Bruce Momjian wrote: > > On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote: > > > On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote: > > &g

Re: XTS cipher mode for cluster file encryption

2022-01-24 Thread Bruce Momjian
ure wiki page is: https://wiki.postgresql.org/wiki/Transparent_Data_Encryption Do people want to advance this feature forward? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: XTS cipher mode for cluster file encryption

2022-02-01 Thread Bruce Momjian
onfirm that we (Cybertec) do and that we're ready to spend more time on the > community implementation. Well, I sent an email a week ago asking if people want to advance this feature forward, and so far you are the only person to reply, which I think means the

Re: XTS cipher mode for cluster file encryption

2022-02-01 Thread Bruce Momjian
any do), I’d > encourage Antonin to start a new thread with the patch to do the temporary > file > access consolidation which then provides a buffered access and reduces the > number of syscalls and work towards getting that committed, ideally as part of > this release.

Re: Support for NSS as a libpq TLS backend

2022-02-02 Thread Bruce Momjian
eparately for PL/v8, but has gotten much harder to do in the past few years. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: Replace pg_controldata output fields with macros for better code manageability

2022-02-02 Thread Bruce Momjian
POINT_OLDESTXID "Latest checkpoint's oldestXID:" > #define PG_CONTROL_FIELD_CHECKPOINT_OLDESTXID_DB "Latest checkpoint's > oldestXID's DB:" > and so on. That seems like a very good idea. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Unclear problem reports

2022-02-02 Thread Bruce Momjian
ho do not already have access to such experts. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: Support for NSS as a libpq TLS backend

2022-02-04 Thread Bruce Momjian
On Thu, Feb 3, 2022 at 01:42:53PM -0500, Stephen Frost wrote: > Greetings, > > * Bruce Momjian (br...@momjian.us) wrote: > > On Tue, Feb 1, 2022 at 01:52:09PM -0800, Andres Freund wrote: > > > There's https://hg.mozilla.org/projects/nspr/file/tip/pr/src - which

Re: Support for NSS as a libpq TLS backend

2022-02-04 Thread Bruce Momjian
the mediocre OpenSSL public documentation? For the record, I do like the idea of adding NSS, but I am concerned about its long-term maintenance, we you explained. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical wo

Re: Unclear problem reports

2022-02-04 Thread Bruce Momjian
On Wed, Feb 2, 2022 at 07:21:19PM -0700, David G. Johnston wrote: > On Wed, Feb 2, 2022 at 5:35 PM Bruce Momjian wrote: > > I consider these as problems that need digging to find the cause, and > users are usually unable to do sufficient digging, and we don't have &

Re: Unclear problem reports

2022-02-04 Thread Bruce Momjian
On Thu, Feb 3, 2022 at 12:28:05PM +0800, Julien Rouhaud wrote: > Hi, > > On Wed, Feb 02, 2022 at 07:35:36PM -0500, Bruce Momjian wrote: > > The Postgres community is great at diagnosing problems and giving users > > feedback. In most cases, we can either diagnose a probl

Re: Support for NSS as a libpq TLS backend

2022-02-04 Thread Bruce Momjian
ively turn that into a good one. Oh, yeah, the OpenSSL documentation is verifiably mediocre. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: support for CREATE MODULE

2022-02-04 Thread Bruce Momjian
Implement. Asking about Desirability first can avoid a lot of effort. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-09 Thread Bruce Momjian
n't see why it is needed --- TDE can easily decrypt/encrypt the pages while they are copied. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-09 Thread Bruce Momjian
ht now is a hack, and I *know* it can Yes, it is a hack, but it seems to be a clever one that we might have chosen if it had not been part of the original system. > cause massive performance drops on busy systems. See above. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: support for CREATE MODULE

2022-02-10 Thread Bruce Momjian
path name resolution for functions would remain the  > same, nothing would need to change there because of modules. > > Would that be an acceptable direction to go? Well, that would allow us to have CREATE EXTENSION syntax, but what would it do that C

Re: Synchronizing slots from primary to standby

2022-02-10 Thread Bruce Momjian
> > this patch. > > > > OK. Understood, thanks Andres. I would love to see this feature in PG 15. Can someone explain its current status? Thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-11 Thread Bruce Momjian
t; to find out what it really means, but at least it seems like it points > you more in the right direction. To me, anyway. I think CLONE would be confusing since we don't use that term often, maybe LOG_DB_COPY or LOG_FILE_COPY? -- Bruce Momjian

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-11 Thread Bruce Momjian
On Fri, Feb 11, 2022 at 01:18:58PM -0500, Robert Haas wrote: > On Fri, Feb 11, 2022 at 12:50 PM Bruce Momjian wrote: > > On Fri, Feb 11, 2022 at 12:35:50PM -0500, Robert Haas wrote: > > > How about something like LOG_AS_CLONE? That makes it clear, I hope, > > > that w

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-14 Thread Bruce Momjian
se fs-based cloning, that would also need to issue a checkpoint, > which makes me think that CHECKPOINT is not the best name. I think if we want LOG, it has tob e WAL_LOG instead of just LOG. Was there discussion that the user _has_ to specify and option instead of using a default? That d

Re: support for CREATE MODULE

2022-02-14 Thread Bruce Momjian
ge pattern that requires modules since it already works with schemas and just uses schema permissions to designate public/private schema interfaces. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: support for CREATE MODULE

2022-02-14 Thread Bruce Momjian
On Mon, Feb 14, 2022 at 07:42:21PM -0500, Bruce Momjian wrote: > On Mon, Feb 14, 2022 at 03:23:07PM -0800, Swaha Miller wrote: > > A prominent use case for grouping functions into modules would > > be access control on the group as a whole, with one command > > for an entire m

Re: Mark all GUC variable as PGDLLIMPORT

2022-02-15 Thread Bruce Momjian
g goal here is to make Windows have the same GUC variable visibility as Unix --- when we change things in a way that breaks extensions, we hear about Unix breakage quickly and adjust for it. It is Windows being different and only getting the problem reports later that is the real problem. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.

Re: support for CREATE MODULE

2022-02-17 Thread Bruce Momjian
On Tue, Feb 15, 2022 at 12:29:54PM -0800, Swaha Miller wrote: > On Mon, Feb 14, 2022 at 4:58 PM Bruce Momjian wrote: > > I was working on a talk about microservices today and decided to create > > two schemas --- a public one that has USAGE permission for other > ser

Re: New docs chapter on Transaction Management and related changes

2022-11-06 Thread Bruce Momjian
On Fri, Nov 4, 2022 at 04:17:28PM +0100, Laurenz Albe wrote: > On Sat, 2022-10-15 at 21:08 -0400, Bruce Momjian wrote: > > I therefore merged all three paragraphs into > > one and tried to make the text saner;  release_savepoint.sgml diff > > attached, URL content updated. &g

Re: New docs chapter on Transaction Management and related changes

2022-11-07 Thread Bruce Momjian
he first attachment shows my changes to your patch, and the second attachment is my full patch. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson diff --git a/doc/

Re: New docs chapter on Transaction Management and related changes

2022-11-07 Thread Bruce Momjian
ect some more > from a chapter titled "Internals" / "Transaction Management". > > In reality, the new chapter is about transaction IDs. So perhaps the > name should reflect that, so that it does not mislead the reader. I renamed it to "Transaction Process

Re: New docs chapter on Transaction Management and related changes

2022-11-18 Thread Bruce Momjian
e other types wait on transactionid. > > +Row-level read and write locks are recorded directly in locked > > +rows and can be inspected using the > > +extension. Row-level read locks might also require the assignment > > +of multixact IDs (mxid).

<    7   8   9   10   11   12   13   14   15   16   >