On Mon, Mar 23, 2020 at 01:00:24PM -0300, Alvaro Herrera wrote: > On 2020-Mar-18, Bruce Momjian wrote: > > > On Tue, Feb 25, 2020 at 09:35:52AM +0100, Antonin Houska wrote: > > > I've noticed that two variables in RelationCopyStorage() are defined in a > > > scope higher than necessary. Please see the patch. > > > > It seems cleaner to me to allocate the variables once before the loop > > starts, rather than for each loop iteration. > > If we're talking about personal preference, my own is what Antonin > shows. However, since disagreement has been expressed, I think we > should only change it if the generated code turns out better.
I am fine with either usage, frankly. I was just pointing out what might be the benefit of the current coding. -- Bruce Momjian <br...@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
