On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> Thanks for picking this up.
>
> On Thu, Sep 07, 2023 at 03:33:57PM -0400, Bruce Momjian wrote:
> > The default value is <systemitem
> > class="systemname">localhost</systemitem>,
> > which allows only local TCP/IP <quote>loopback</quote>
> > connections to be
> > - made. While client authentication (<xref
> > + made. If <varname>listen_addresses</varname> is not empty,
> > + the server will start if it can open a <varname>port</varname>
> > + on at least one TCP/IP address. A warning will be emitted for
> > + any TCP/IP address which cannot be opened.
>
> I think we should move this sentence to before the Ń•entence about the
> default value. That way, "If the list is empty, ..." is immediately
> followed by "If the list is not empty, ..."
>
> IMO the phrase "open a port" is kind of nonstandard. I think we should say
> something along the lines of
>
> If listen_addresses is not empty, the server will start only if it can
> listen on at least one of the specified addresses. A warning will be
> emitted for any addresses that the server cannot listen on.
Good idea, updated patch attached.
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 6bc1b215db..eaf2a42261 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -656,10 +656,16 @@ include_dir 'conf.d'
<literal>::</literal> allows listening for all IPv6 addresses.
If the list is empty, the server does not listen on any IP interface
at all, in which case only Unix-domain sockets can be used to connect
- to it.
+ to it. If the list is not empty, the server will start if it can
+ open a <varname>port</varname> on at least one TCP/IP address.
+ A warning will be emitted for any TCP/IP address which cannot
+ be opened.
The default value is <systemitem class="systemname">localhost</systemitem>,
which allows only local TCP/IP <quote>loopback</quote> connections to be
- made. While client authentication (<xref
+ made.
+ </para>
+ <para>
+ While client authentication (<xref
linkend="client-authentication"/>) allows fine-grained control
over who can access the server, <varname>listen_addresses</varname>
controls which interfaces accept connection attempts, which
