library.
>
> r15596 changed some of these "exempt" files. This exemption should
be
> codified in the PDD and into the test files.
Exempt C-language files now protected from the coding standards hammer,
as of r16496.
Is it ok to close this ticket now?
Paul
On Mon Jan 08 10:07:38 2007, particle wrote:
> On 1/8/07, Paul Cochrane via RT <[EMAIL PROTECTED]>
wrote:
> > On Thu Nov 16 05:00:35 2006, coke wrote:
> > > Any files that are copied from somewhere else should be immune
from
> > > our coding standards.
&
ated by flex/yacc. I just tried it
> > with r16702 and the tests pass even when languages/cola/lexer.c has
> > trailing spaces. Perhaps an 'svn up' makes the tests pass?
>
> r16664. Updating to r16760 makes the test pass. --James
>
Thanks for confirming! Ticket now resolved.
Regards,
Paul
Resolved as of r16981
This ticket was resolved by chromatic++ in r17069.
Problem fixed by chromatic++ in r17426; thanks!
Resolved as of r17538. The fix included as a side effect the MANIFEST
now including Added and Deleted (but not committed) files.
Resolved as of r17556.
Resolved.
On Sat Mar 17 23:51:04 2007, [EMAIL PROTECTED] wrote:
> On Wed Jan 03 07:51:56 2007, coke wrote:
>
> > It would be nice if configure.pl gracefully handled the error
> condition > of "no compiler found".
>
> Here's a patch for that!
Patch applied in r17614. Thanks!
nd".
> >
> > Here's a patch for that!
>
> Patch applied in r17614. Thanks!
Even though I've applied this patch and it works, I've only been able
to test it on linux x86. Could someone on windows make sure that
Configure.pl still does the right thing?
Ta heaps
Paul
I've now got access to a FreeBSD (6.1 PRERELEASE #4) box, and have
checked out and compiled Parrot. Attached is the output of 'make
test', and myconfig.
Regards,
Paul
myconfig
Description: Binary data
make_test.out
Description: Binary data
On Fri Feb 23 13:32:02 2007, kjs wrote:
> parrotbug seems to be broken on win32.
What output are you getting (if at all)?
On Thu Mar 15 19:47:07 2007, [EMAIL PROTECTED] wrote:
> I have a patch for doing this, at least a build, compile, and test
type
> patch. Instead of doing one massive patch to send, here's a script
to
> move the files(diffs include the entire file twice) and apply the
> patch. It moves all th
On Tue Feb 20 15:31:02 2007, [EMAIL PROTECTED] wrote:
> On Saturday 17 February 2007 08:27, jerry gay wrote:
>
> > as noted in my svn log at time of checkin, this is a failing test
> > which exposes a bug in Parrot::Distribution. '*.t' files are only
perl
> > files if the shebang says they are, b
via [EMAIL PROTECTED] I.e. is it ok for me to
remove the send-capability of parrotbug and therefore try to fix the
b0rkenness?
Comments most definitely welcome!
Paul
Applied in r17628. Thanks!
On Sun Mar 18 23:49:11 2007, codermattie wrote:
> this is the third patch in the series of src/library.c re-factors.
>
> This patch is compile and test-suite tested on linux-i686. it does
> include a minor change
> on win32 that I was not able to test.
>
> I have created a few new path utility fu
On Mon Mar 19 01:07:54 2007, codermattie wrote:
> here is the re-based patch. please see the tickets for the third and
> fourth for comments on the changes.
>
> this patch was compile tested.
(added message to incorrect ticket, this was the right one)
Applied in r17630. Thanks! I'll close this t
Ticket is superseded by #41905
Ticket is superseded by #41905
On Mon Mar 19 03:39:21 2007, codermattie wrote:
> Hello,
>
> This patch begins the feature enhancement phase of the
> Parrot_locate_runtime_str.
>
> based on: rev 17631
>
> two new static functions are introduced.
>
> * try_load_path:
>
> this helper combines the path_finalization with the sta
Fixed by chromatic in r17426.
7) only
contains a test of the MANIFEST (the script also doesn't currently
work). I believe all tests which used to be part of this file are now
in t/codingstd and therefore this script can be renamed to something
more appropriate to what it does, or deleted. This ticket can then be
close.
What is the opinion as to what should be done with the script?
Paul
ey are still needed?
>
> Thanks!
> Swaroop
Jerry,
Hasn't t/codingstd/c_indent.t superseded this patch? I think it also
closes this ticket, do you agree?
Paul
mation (gleaned from gcov). Is a makefile target the
best option here, or should the script be used? It would be good to
combine the output from the C-related parts of Parrot with that of the
Perl-related parts, as pointed out by Paul Jackson.
particle++ confirmed that this patch works successfully on windows.
Closing the ticket.
particle++ confirms that this works on Win32. Ticket resolved.
On Tue Mar 20 12:13:15 2007, coke wrote:
> per chromatic, this should probably be backed out. At least for the
> 0.4.10 release.
Backed out until we find another solution to the problem.
Paul
Actually bothering to attach the patch this time...
parrot_distro.patch
Description: Binary data
Thanks! Applied in r17859.
Note: I had to update include/parrot/debug.h to make sure that src/
debug.c
Thanks! Applied in r17863.
otes.
> Consider /* this is a 'comment */. perl was actually segfaulting
until I
> realized what was going on and restored it.
That did the trick! Thanks heaps :-) Applied in r17878.
Paul
> ++---
> languages/lua/pmc/luastring.pmc|2 -
> languages/pugs/pmc/pugscapture.pmc |2 -
> languages/tcl/src/pmc/tcllist.pmc |2 -
> src/inter_call.c | 6 ++---
> 12 files changed, 72 insertions(+), 72 deletions(-)
>
> Shawn M Moore
Thanks! It's great to have someone help out :-) Eventually all
applied in r17893.
Paul
il on Linux with GCC. Anyway,
applied as
> r17794.
This ticket can be closed now, can't it?
Regards,
Paul
w to encourage good formatting habits, without assuming that
everyone
> uses emacs or vim, and with minimal clutter in our source code.
A CAGE ticket has been generated in RT for this.
Is it ok to close the current ticket now?
Paul
mped
>
> (gdb) p pc - interpreter->code->base.data
> $43 = 1022
>
> 1022 in this case is the Relative-PC in the src/ASTGrammar.pbc file.
>
> (gdb) p interpreter->code->base.name
> $48 = 0x82c23c8 "BYTECODE_src/ASTGrammar_gen.pir"
>
> Given BYTECODE_src/ASTGrammar_gen.pir:
> run disassemble on src/ASTGrammar.pbc
>
> make disassemble
> ./disassemble languages/cardinal/src/ASTGrammar.pbc |less
>
> And puff, smoke, magic:
>
> I found out I was core dumping on line #459 of src/ASTGrammar_gen.pir
Thanks! Applied as r17922. Note that 'interpreter' had to be changed
to 'interp' to get this to compile. This name change hadn't occurred
when you submitted the patch (so was not a problem with the patch), but
I thought it best to note it in the ticket.
Paul
n if it's GMT/UTC. In fact, perhaps it should
> explicitly always be that.
Generated files are checked for timestamps which use GMT/UTC in t/
codingstd/gmt_utc.t. config/init/defaults.pm was updated in r17923 to
generate a GMT timestamp and now the gmt_utc.t test passes. Closing
the ticket.
Paul
Perl::Critic::Bangs module into t/codingstd/
perlcritic.t and if it is installed, the Bangs::ProhibitFlagComments
policy is added to the list of policies. This change was made in
r17925. All FIXME|TODO|XXX comments which have been added to RT should
be replaced with RT#.
Paul
rrot to Coverity which recently
arrived.
On Mon, Mar 19, 2007 at 05:37:39PM +0100, Paul Cochrane wrote:
> Hello,
>
> As one of the people helping to tidy up the source of the Parrot
> project: (http://www.parrotcode.org/) I'm interested in getting Parrot
> added to Coverity'
nd haven't had time over the past couple of months to attack the
ticket. If you have the tuits, go for it! other than that, I'll have
a go at it hopefully sometime soon (famous last words...)
Paul
> I'd like to get this ticket (#41908) resolved. The patch was applied,
> so
On Mon May 07 04:40:24 2007, codermattie wrote:
> Hello,
>
> My version of Emacs appears to be leaking tabs into files despite
> having this in my emacs config:
>
> (setq indent-tabs-mode nil)
>
> To help track down the problem in emacs/cperl and get it fixed I need
> better diagnostics. I have
On Mon May 07 06:49:42 2007, codermattie wrote:
> Hello,
>
> I noticed while debugging my patches to the loader that the message
>for a failure in .load_bytecode was really
> horrible. It was something like this:
>
> immc: Couldn't find file %s
>
> At the time I didn't know what immc was, an
On Mon Apr 30 12:22:21 2007, mdiep wrote:
> On Wed Mar 21 03:44:10 2007, codermattie wrote:
> > Hello,
> >
> > now that 0.4.10 has released I would like to merge rt# 41908 which
> > introduces extension guessing.
> > The current implementation does not affect the behavior of existing
> > code. No n
ive critisms; you've done great work and your help is greatly
appreciated.
Thanks again,
Paul
it looks pretty
good to me, so I've applied it as r18482, thanks!
I haven't noticed the failure from t/perl/Parrot_Docs.t. This might be
a problem with your setup as you mentioned in a previous email.
Paul
ntical header guard test until we have a decent way to check for
copied header files. Some C languages files are exempted from the
coding standards tests and you might want to do a similar thing here
with the C headers. Have a look at is_c_exemption() in lib/Parrot/
Distribution.pm (and the file in general).
One nit: the changes to the test should really have been a separate
patch. Thanks for your hard work!
Paul
On Mon May 14 05:08:56 2007, codermattie wrote:
> On Thu, 10 May 2007 12:18:00 -0700
> "chromatic via RT" at parrotcode.org>
wrote:
>
> > On Thursday 10 May 2007 02:37:15 Mike Mattie wrote:
> >
> > > quick patch to use the mem_sys_free wrapper instead of using the
> > > platform's free() direct
cygwin is building as of r18821. Is this ticket required anymore?
Paul
cygwin is currently building (as of r18821). Is this ticket required
anymore?
Paul
meber with the expection of
> Parrot::Configure::Step. Any help that can be offered would be
> appreciated there. ;)
kid51,
you've been working hard on this area, are you able to comment on the
current status of the Configure tests? We might be able to close this
ticket :-)
Paul
On Thu Jun 07 05:21:33 2007, jkeen at verizon.net wrote:
> Paul Cochrane wrote:
> >> 'rpath' sounds pretty general to me (if not particularly
> >> self-documenting). Is there really a significant bang for the
buck to
> >> changing it? (Or, differe
After much help from Ron Blaschke to get this working nicely on Win32,
I've applied the latest patch as r19059 and am now closing the ticket.
Paul
ause we might be able to make a small change to the makefile
rather than the extra work of a new configure step.
Comments most definitely welcome.
Paul
lso isn't String a standard C++ class?
>
> I've applied your patch. Thanks.
Does this close this ticket, or are there still outstanding instances?
Paul
oblems with this,
I'll commit the patch, and add t/codingstd/perlcritic.t to the coding
standards section of the test harness.
Paul
perlcritic.patch
Description: Binary data
Implemented as of r19319.
have svn 1.4.0 yet (why not?) C
As of r19331 there are 190 files affected. The complete list I'm
attaching to this ticket. As I get time, I'm going to attack this
ticket directory by directory.
Paul
internal_exceptions.out
Description: Binary data
I've a question about the tags target: it searches c, perl and pmc
files. Shouldn't it also search/process the .ops files (as c-language
files)?
Paul
On Tue Jun 26 13:35:51 2007, ptc wrote:
> On Tue Jun 26 06:36:50 2007, particle wrote:
> > On 6/26/07, Paul Cochrane via RT at
> parrotcode.org> wrote:
> > > On Thu Sep 21 14:38:40 2006, particle wrote:
> > > > parrot's source is littered with
nt-ctags, which on my system points to 'exuberant-ctags'.
Should the program called by the makefile tags target actually be
'exuberant-ctags'? Or should we check the user's system at config time
to check if ctags points to emacs ctags, or to exuberant-ctags?
Ideas?
Paul
Many thanks! Applied as r19683.
seems that 'find_method' isn't working in this test anymore. The
only other japh tests using 'find_method' are TODO'ed and so I don't
know if I should either remove this test or TODO it, or if there is
something wrong with what I've done. Can anyone shed any light on this
problem?
Many thanks in advance,
Paul
Many thanks! Applied as r19702.
Thanks again! Applied in r19703.
Resolved in r19716
Just updating this ticket to the current state of play:
> The lint target needs to be renamed to splint.
Actually, this has been changed to sunlint and bsdlint. The splint
target has existed for a while (in two forms; now combined as of r19721
into the one target).
> Then create a new lint ta
On Tue Jun 26 02:36:59 2007, ptc wrote:
> On Thu Sep 21 14:38:40 2006, particle wrote:
> > parrot's source is littered with internal_exception() calls, the
bulk
> > (all?) of which should be converted to real_exception() calls.
> > internal exceptions are uncatchable, and might as well be called
>
Thanks! Applied as r19899.
How does this file look? Does it explain everything which needs to be
explained? If everything's ok (or noone makes any noise over the next
few days) I'll add this file to docs/project.
Comments most definitely welcome.
Paul
commiter_guide.pod
Description: Binary data
Parrot is now running under Coverity Prevent. The address for access
to its output is: http://scan2.coverity.com:9035/. If you wish to get
an account to be able to then access the scan page, you will need to
send an email to [EMAIL PROTECTED] I'm going to put this info
up on the Parrot wiki
On Mon Nov 13 14:24:04 2006, chip wrote:
> The C standard says that the isxxx() and toxxx() functions are only
defined
> if their input falls in the domain of unsigned char, or the special
case of
> -1 ("EOF"). Therefore, all input values to these functions should be
cast
> (directly or indirec
Since we now have tests covering this issue, and the instances in the
code have been cleaned up, I'm now closing this ticket.
Thanks! Applied in r20535.
lines has been added as
t/codingstd/check_copyright.t in r20898.
Paul
't return, like exit().
>
> I've done a ton of this for perl5, and can bring it on over.
Andy,
You've done a lot of work on this in parrot already and I haven't seen
anything new as far as attributes go for a while. Have you finished
adding gcc attributes? If so, we can close this ticket.
Paul
just the pmc's? C also found instances
in:
src/ops/io.ops
src/hash.c
src/pmc_freeze.c
src/stm/backend.c
I.e. should these be updated/changed as well?
Paul
On Sat Sep 08 14:11:57 2007, [EMAIL PROTECTED] wrote:
> On Saturday 08 September 2007 14:00:39 Paul Cochrane via RT wrote:
>
> > Is this restricted to just the pmc's? C also found
instances
> > in:
> >
> > src/ops/io.ops
> > src/hash.c
> > src
not a sensible forward-looking portable strategy.
>
> I realize this patch precludes cross-compilation at the moment, but
does it
> work better for you, Andy?
Applied the patch with some modifications so that it runs correctly on
Windows in r21212. Tested on Linux x86, Windows and Cygwin.
Paul
by using the configure line:
perl Configure.pl --cc=moo
then for some reason the configuration with solaris continues, even
though it should barf. The problem exists around line 39 in
config/init/hints/solaris.pm. If one tries C if the
C call doesn't work, then configure just happily continues
configuring. How does one get configure to stop completely at this
point??? Using plain C on Linux, Windows and Cygwin worked fine.
Paul
kid51,
This should be fixed as of r21207.
ptc
lier commit (getting Configure.pl to die more gracefully when
the compiler doesn't work) explicit C statements are used so
that exiting is forced and exit codes from C<_run_command> are observed.
Does that help answer your objections?
Paul
Applied in r21262.
d's
> > 'mv', maybe? iunno) that dependency can be replaced.
> >
> > ~jerry
> >
>
> Hmmm s~sed 's/\.o/\.c/g'~perl -pe 's/\.o/\.c/g'~
>
> That should do it...
>
That seemed to do the job! Thanks! Committed in 21274.
particle: could you confirm that this works as expected for you? Then
you can close the ticket.
Paul
On Sat Mar 10 19:15:20 2007, coke wrote:
> From docs/BROKEN.pod.
>
>
> Is this something that needs fixing?
>
> (it's in compilers/imcc/main.c)
There is also a src/main.c which says it is the entry point for to
Parrot programs. Should src/parrot.c be removed?
it was that difficult eh?
Paul
On Mon Oct 01 14:36:55 2007, ptc wrote:
> In src/exceptions.c there is mention about "exception being still in
TODO".
> This means that something about exceptions is not yet finished, and
needs
> to be implemented so that the code mentioned here (near
> rethrow_c_exception()) can be completed. S
On Mon Oct 08 12:14:07 2007, leo wrote:
> Am Montag, 8. Oktober 2007 19:05 schrieb Paul Cochrane:
> > So, the patch is right (however, for my wrong reasoning)? Is
> everyone
> > happy if I apply it then?
>
> $ svn ann src/pmc/pair.pmc
> 8374leo A Pair PMC
arser.c
> astparser.c
>
>
> Is that sufficient to close this issue, or should I provide a patch to
> disable the C4102 warning?
Is this ticket still relevant? Are we still seeing these warnings with
msvc?
Paul
by default and to rip the old stuff out. Can I? Huh? Huh?
Please?
Paul
o the 8.3 format. My feeling is that
these should be guidelines but are not strict enough for a test. What
are people's feelings? Allison: do you wish to make a decision about
this particular coding standard item?
Anyway, can this file (check_source_standards.pl) be removed and this
ticket closed?
Paul
James,
Thanks for pointing out what you meant. I think I must have been
having a bit of a brain-fade moment or something...
On Sun Jul 08 18:06:03 2007, [EMAIL PROTECTED] wrote:
> Paul Cochrane wrote:
>Perl 5 is able to work out
> > automatically the warnings flags of gcc
> http://rt.perl.org/rt3/Ticket/Display.html?id=39824
Since the above ticket has now been resolved, does this mean that this
ticket can also be resolved?
Paul
if we can close this ticket.
Paul
[1] If one does ack -l internal_exception then one finds several more
files, however these are the files in which internal_exception() could/
should be converted to real_exception().
mips_jit_emit.patch
Description: Binary data
hppa_jit_emit.patch
Desc
as different names on different systems) and now 'make tags'
should work out of the box for all the variations that I'm aware of
(namely ctags, exuberant-ctags and ctags-exuberant). This is the
situation as of r22321. If noone reports any other variants in the
next three days then I'll close this ticket.
Paul
Patch applied in r22363. Thanks!
is
required atm to close this ticket is proper integration with
Devel::Cover so that the Perl-related components could be tested for
coverage as well as the C-related components all from within the same
make target.
Paul
rules for splint now exists in the Parrot Makefile. Some
are commented out and marked as being worthy of adding back in,
dependent upon other things being finished. Does the set we have
constitute a "reasonable" set? I.e. can we lay this ticket to rest?
Paul
On Sun Oct 21 13:25:50 2007, ptc wrote:
> On Thu Mar 15 19:12:48 2007, ptc wrote:
> > splint spews many many errors by default. Take a look at the
> > Makefile that perl5 has for the start of some rules that Andy worked
> > on for the perl5 code.
>
> Andy Lester has done a very large amount of wo
ages/urm/README:137
> languages/urm/t/syn.t:13
> languages/urm/urmc:11
This language is all GPLd, so maybe a good canditate for being moved to
google-code. Or perhaps we could ask the author if we can license it
under Artistic 2.0? Opinions?
If you got this far through this message, thanks! :-)
Paul
901 - 1000 of 1010 matches
Mail list logo