On Mon May 07 12:55:56 2007, mark <!-- x --> at glines.org wrote: > Hi, > > The attached patch adds a bullet to PDD07 about headerfile guards, and > adds a test to c/codingstd/ to check for existence, uniqueness, and > lack of conflicting names. Then it fixes up all headers returned by > Parrot::Distribution->c_header_files(), to pass the tests. > > (Are there any headers hiding here and there that Parrot::Distribution > doesn't know about?) > > As a special case, the test ignores bison-generated headers, which do > not include guards. It might be useful to try to convince bison to emit > some, or postprocess bison's output with perl, to add a guard header and > footer. > > Mark
Thanks! Applied in r18461, r18462, r18465, r18466, r18467, r18468, and r18469. A comment: this patch was in essence three patches (the pod, a test and a patch of the headers), next time could you separate them into three patches? The test was itself actually a new file, so it could have just been attached rather than a patch made of it. Also, when you add a new file, could you also update MANIFEST as well? These are meant as positive critisms; you've done great work and your help is greatly appreciated. Thanks again, Paul
