On Sat Sep 08 12:37:00 2007, [EMAIL PROTECTED] wrote:
> Several PMCs use vtable methods directly, rather than going through 
the 
> accessor macros.  These are particularly evident in bytecode freezing 
and 
> thawing.
> 
> The existing code looks like:
> 
>         io->vtable->push_integer(INTERP, io, sub->comp_flags);
>         io->vtable->push_integer(INTERP, io, sub->vtable_index);
> 
> and it should be:
> 
>        VTABLE_push_integer(INTERP, io, sub->comp_flags);
>         VTABLE_push_integer(INTERP, io, sub->vtable_index);
> 
> This task requires minimal C skills.  The relevant PMCs are:
> 
> src/pmc/array.pmc
> src/pmc/eval.pmc
> src/pmc/fixedbooleanarray.pmc
> src/pmc/fixedintegerarray.pmc
> src/pmc/fixedpmcarray.pmc
> src/pmc/fixedstringarray.pmc
> src/pmc/float.pmc
> src/pmc/hash.pmc
> src/pmc/integer.pmc
> src/pmc/key.pmc
> src/pmc/lexinfo.pmc
> src/pmc/orderedhash.pmc
> src/pmc/pair.pmc
> src/pmc/parrotclass.pmc
> src/pmc/parrotobject.pmc
> src/pmc/resizablebooleanarray.pmc
> src/pmc/string.pmc
> src/pmc/sub.pmc
> 

Is this restricted to just the pmc's?  C<ack -l> also found instances 
in:

src/ops/io.ops
src/hash.c
src/pmc_freeze.c
src/stm/backend.c

I.e. should these be updated/changed as well?

Paul

Reply via email to