Re: [OpenWrt-Devel] [PATCH procd v2 05/17] ujail: use "#pragma once" in .h where needed

Hi, our code uses the ifdef pattern in all projects and we would like to keep it that way. JOhn On 25/11/2015 18:54, Etienne CHAMPETIER wrote: > Signed-off-by: Etienne CHAMPETIER > --- > jail/capabilities.h | 1 + > jail/elf.h | 4 +--- > jail/log.h | 1 + > jail/secc

Re: [OpenWrt-Devel] [PATCH procd v2 00/17] ujail fs jail rework/fixes/improvements

Hi, On 25/11/2015 18:54, Etienne CHAMPETIER wrote: > As requested, i've split up in smaller patches my work > I also follow the unwritten code style requirement :) > > "rework fs jail part" commit is still a bit big > but if i split it further i will edit the same line > in each commit (tell me i

Re: [OpenWrt-Devel] [PATCH] ramips: add support for MQmaker WiTi board

Hi, you need to add info to the patch what has changed between versions and which version this is. John On 25/11/2015 21:20, Sebastian Careba wrote: > The board is based on mt7621AT cpu, and has 16mb nor flash, 256mb of ram, 2 > sata ports, microsd card slot, 1 USB 3.0 port and at least

Re: [OpenWrt-Devel] [PATCH 2/8] lantiq: add dsl-vr9-firmware-xdsl

On 25/11/2015 23:39, Hauke Mehrtens wrote: > On 11/25/2015 11:29 AM, John Crispin wrote: >> >> >> On 25/11/2015 10:53, Andre Heider wrote: >>> Hi, >>> >>> On Tue, Nov 24, 2015 at 9:24 PM, Hauke Mehrtens wrote: >>>> +define Package/d

Re: [OpenWrt-Devel] [PATCH 2/8] lantiq: add dsl-vr9-firmware-xdsl

phy firmwares for xrx300 > 2015-11-25 23:39 GMT+01:00 Hauke Mehrtens : >> On 11/25/2015 11:29 AM, John Crispin wrote: >>> >>> >>> On 25/11/2015 10:53, Andre Heider wrote: >>>> Hi, >>>> >>>> On Tue, Nov 24, 2015 at 9:24 PM, Hauke

Re: [OpenWrt-Devel] [PATCH] ramips: add support for MQmaker WiTi board

Hi, as said before, please add version info to your patches. it is explained here -> https://dev.openwrt.org/wiki/SubmittingPatches -> 13. The canonical patch format ¶ John On 26/11/2015 07:41, Sebastian Careba wrote: > The board is based on mt7621AT cpu, and has 16mb nor flash, 256mb o

Re: [OpenWrt-Devel] [PATCH v2] ralink: renable nand support

rom: John Crispin > > CONFIG_MTK_MTD_NAND was incorrectly disabled by r47619. > > Signed-off-by: John Crispin > > git-svn-id: svn://svn.openwrt.org/openwrt/trunk@47640 > 3c298f89-4303-0410-b956-a3cf2f4a3e73 > --- > target/linux/ramips/mt7621/config-3.18 | 1 +

Re: [OpenWrt-Devel] fstools: factory reset on power failure during startup

On 26/11/2015 09:24, Florian Eckert wrote: > Hi, > > I am using openwrt CC and an ubifs filesystem on top of ubi. > If I plug off the power during startup, some times my configuration > get lost and i am back to factory reset. > > In the package fstools there is the bin "mount_root" it is calle

Re: [OpenWrt-Devel] [PATCH] Add support for Huawei WS880

Hi, please read https://dev.openwrt.org/wiki/SubmittingPatches specifically section 10 and 13 John On 26/11/2015 17:33, Prototik wrote: > --- > target/linux/bcm53xx/image/Makefile| 14 +++ > .../910-ARM-BCM5301X-Add-DT-for-Huawei-WS880.patch | 115 > ++

Re: [OpenWrt-Devel] [PATCH] procd: hotplug.json: allow passing hotplug events from all subsystems

Hi Yousong, On 28/11/2015 05:22, Yousong Zhou wrote: > There are time that programs need to be notified of events from > subsystems that are not enumerated in the .json definition, e.g. QEMU > guest agent by default requires /dev/virtio-ports/org.qemu.guest_agent.0 > which is a symlink to /dev/vpo

Re: [OpenWrt-Devel] [PATCH] uboot-at91: Add package for uboot on the at91 platform

Hi, see comments inline On 28/11/2015 19:35, Ben Whitten wrote: > This patch adds a uboot package for at91 and honours COPTS. > If the SPL binary is generated for the specified board it moves that too. > > Signed-off-by: Ben Whitten > --- > package/boot/uboot-at91/Makefile | 117 > +++

Re: [OpenWrt-Devel] [PATCH] procd: hotplug.json: allow passing hotplug events from all subsystems

On 29/11/2015 05:10, Luiz Angelo Daros de Luca wrote: > John, > > How about generate the subsystem list from /etc/hotplug.d dirs. The list > could be loaded at startup and refreshed the same way hotplug.json is ( > which might be "never" as procd does not have an "init q"). > > Regards, > > Lui

Re: [OpenWrt-Devel] [PATCH] ar71xx: build image for TL-WR710N v2.1

On 29/11/2015 20:30, Norbert Wegener wrote: > # This patch just extends target/linux/ar71xx/image/Makefile to build > # images also for version 2.1 of TL-WR710N > # patch against the latest git > > # Signed off by: Norbert Wegener the "#" are not needed. please remove them John > ---

Re: [OpenWrt-Devel] New Ubiquiti AC products locked against 3rd party firmware?

On 30/11/2015 09:38, Petr Štetiar wrote: > Ben West [2015-11-27 10:00:51]: > > Hi, > >> This person is reporting a new Ubiquiti AC AP where there the bootloader >> does an RSA signature check on the firmware image. > > let's hope, that it would be possible to replace/patch that unfriendly U-B

Re: [OpenWrt-Devel] [PATCH] procd: hotplug.json: allow passing hotplug events from all subsystems

On 30/11/2015 10:33, Jo-Philipp Wich wrote: > Hi all, > > as an intermediate solution we could simply allow qemu specific events. > > I'm with John here that passing on uevents unfiltered is probably no > good idea. > > ~ Jow yep, hence my idea about includes we could ship a "include /etc/ho

Re: [OpenWrt-Devel] [PATCH 2/4] lantiq: base-files: drop the dsl tone settings

On 03/12/2015 09:07, Andre Heider wrote: > Hi, > > On Wed, Dec 2, 2015 at 10:07 PM, Daniel Schwierzeck > wrote: >> I think the removal of the tone setup in r46920 should be reverted. It >> is still the only way to exactly control which pilot tones are sent by >> the DSL firmware. I would not tr

Re: [OpenWrt-Devel] [PATCH 2/4] lantiq: base-files: drop the dsl tone settings

On 03/12/2015 12:07, Andre Heider wrote: > Hi, > > On Thu, Dec 3, 2015 at 10:46 AM, Daniel Golle wrote: >> Usually by differentiating firmware by target markets. >> Ie. depending on where you buy the device, you end up with different >> xDSL settings, similar to how allowed wifi channels are ha

Re: [OpenWrt-Devel] [PATCH v4] ramips: add support for MQmaker WiTi board

offtopic ... my 2 samples of this board just arrived :) i know what i will be testing later on today On 03/12/2015 12:13, Felix Fietkau wrote: > On 2015-12-03 07:20, Sebastian Careba wrote: >> The board is based on mt7621AT cpu, and has 16mb nor flash, 256mb of ram, 2 >> sata ports, microsd card

Re: [OpenWrt-Devel] lantiq: vrx200 nmi handling

On 04/12/2015 15:58, Florian Eckert wrote: > Hallo mailinglist, > > I have seen in the linux sources of the lantiq falcon soc, that there > is some working done for nmi handling. > > I have an lantiq xrx200 board and want to use nmi handling to react on > an power failure which is signaled over

Re: [OpenWrt-Devel] A Popular European Cable Modem Is Now Open-Source.

opensource means the source is open. this release is based on closed source from brcm. the tree is full of pre compile brcm blobs --> https://github.com/tch-opensrc/TC72XX_LxG1.0.10mp5_OpenSrc/tree/master/bcmdrivers/broadcom/net/fpm/impl4 to me it smells like technicolor marketing it trying to se

Re: [OpenWrt-Devel] [enhancement] ar71xx: Moving UART related GPIO initialization into the serial drivers.

dont send patches as attachements. please inline them On 10/12/2015 01:46, Piotr Madalinski wrote: >> Here are my patches for ar71xx enabling UART to be turned on and off >> at runtime to free up the GPIO pins, > And I forgot to attach the patches. Sorry. Here they are. > > > > __

Re: [OpenWrt-Devel] [PATCH v5] Add support for Ubiquiti EdgeRouter X (UBNT-ERX)

it is the correct list, just been real busy this week with other stuff. i'll be merging stuff again as of the weekend, sorry for the delay. On 09/12/2015 16:34, Nikolay Martynov wrote: > Hi. > > I know you guys a probably very busy, but could you please confirm > that this is the right list to

Re: [OpenWrt-Devel] [PATCH] ncurses: Fix build of libncursew

On 09/12/2015 19:45, Ted Hess wrote: > Packages using libncursesw can fail to build if both libncurses and > libncursesw > are not installed. Currently the ncurses.h file is installed in > "usr/include/ncursesw" > directory and includes other .h files in the "usr/include" directory > incorrect

Re: [OpenWrt-Devel] [PATCH 0/9] Add CPS support to mt7621 and add ubnt-erx support to work with it

oh nice, i'll fold these today. i was about to send mt7621 support upstream but decided to wait until you sent your CPS patches. On 11/12/2015 05:01, Nikolay Martynov wrote: > That patch series adds support for Ubiquiti ERX router. > This router is based on mt7621 and it looks like there are some

Re: [OpenWrt-Devel] [PATCH 2/9] ramips: mt7621: use symbolic names of gic interrupt settings

On 11/12/2015 05:01, Nikolay Martynov wrote: > This also adds dts nodes for cpc and mc for documentation purposes > > Signed-off-by: Nikolay Martynov > --- > target/linux/ramips/dts/DIR-860L-B1.dts | 2 +- > target/linux/ramips/dts/FIREWRT.dts | 2 +- > target/linux/ramips/dts/MT7621.dts

Re: [OpenWrt-Devel] [PATCH 6/9] ramips: Fix CM_GCR_CPC_BASE_CPCBASE_{MSK, SHF} values

Hi, On 11/12/2015 05:01, Nikolay Martynov wrote: > Update CM_GCR_CPC_BASE_CPCBASE_{MSK,SHF} to match datasheet > do you mean the GIC or the mt7621 datasheet ? is this a mt7621 specific change or is this an upstream bug that we need to submit a patch for ? John > Signed-off-by: Nikolay

Re: [OpenWrt-Devel] [PATCH 9/9] ramips: use gic timer as clocksource for mt7621

52,8 @@ choice > + select SYS_SUPPORTS_SMP > + select SYS_SUPPORTS_MIPS_CPS > + select MIPS_GIC > ++select COMMON_CLK > ++select CLKSRC_MIPS_GIC > + select HW_HAS_PCI > + endchoice > + > +--- a/arch/mips

Re: [OpenWrt-Devel] [PATCH 7/9] ramips: enable CPS for mt7621

hes-4.3/0001-arch-mips-ralink-add-mt7621-support.patch > > b/target/linux/ramips/patches-4.3/0001-arch-mips-ralink-add-mt7621-support.patch > index 67d816c..153dd9e 100644 > --- > a/target/linux/ramips/patches-4.3/0001-arch-mips-ralink-add-mt7621-support.patch > +++

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: Fix whitespace in the switch driver.

On 05/12/2015 12:03, Vittorio G (VittGam) wrote: > Also avoid using two variables where one can be used. > Hi, several issues 1) the subject and description dont match. 2) why would we want to intermingle the portmap and register init variables. they are 2 different things. imho that is not c

Re: [OpenWrt-Devel] [PATCH v2] lantiq: fall back to a more appropriate default dsl firmware

On 07/12/2015 19:59, Andre Heider wrote: > --- > > v2: use annex b firmware for annex j too > > package/network/config/ltq-vdsl-app/files/dsl_control | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > mode change 100644 => 100755 > package/network/config/ltq-vdsl-app/files/dsl_co

Re: [OpenWrt-Devel] [PATCH v2] lantiq: base-files: use vdsl per default

Hi, On 07/12/2015 19:59, Andre Heider wrote: > Since r43114 adsl will be used if annex is specified, so don't. if r43114 changed the default behaviour then we need to fix r43114 rather than hide the regression by deleting code. John > --- > > v2: rebased > > target/linux/lantiq/base-

Re: [OpenWrt-Devel] [PATCH] [package] OpenSSL: Added source/old to PKG_SOURCE_URL

Hi, technically correct but you make 2 changes int he patch. 1) add a new url 2) split the variable into 2 variables for no apparent reason. i would sugegst you drop 2) and we just merge 1) John On 07/12/2015 21:10, Kevin Kirsch wrote: > OpenSSL moves old versions of the library from >

Re: [OpenWrt-Devel] [PATCH] [package] OpenSSL: Added source/old to PKG_SOURCE_URL

On 11/12/2015 10:59, Kevin Kirsch wrote: > Hi, > > Am 11.12.2015 um 10:53 schrieb John Crispin: >> technically correct but you make 2 changes int he patch. >> >> 1) add a new url >> 2) split the variable into 2 variables for no apparent reason. > >

Re: [OpenWrt-Devel] [PATCH v6 0/6] add Cisco MR18 support

Hi, i merges 1-4 of this series. 4/6 seems to have a lot of comments that were never addressed. please resend 5/6 and 6/6 with the comments fixed John On 05/12/2015 23:48, Christian Lamparter wrote: > This series adds support for Cisco Meraki's MR18 router [0]. > It features: > CPU: Athe

Re: [OpenWrt-Devel] [PATCH] [package] OpenSSL: Added source/old to PKG_SOURCE_URL

On 11/12/2015 11:07, Kevin Kirsch wrote: > Hi, > > Am 11.12.2015 um 11:01 schrieb John Crispin: >> On 11/12/2015 10:59, Kevin Kirsch wrote: >>> Am 11.12.2015 um 10:53 schrieb John Crispin: >>>> technically correct but you make 2 changes int he patch. >>

Re: [OpenWrt-Devel] [PATCH] [package] OpenSSL: Added source/old to PKG_SOURCE_URL

On 11/12/2015 11:11, Alexander Dahl wrote: > Hei hei, > > Am 2015-12-11 10:53, schrieb John Crispin: >> 2) split the variable into 2 variables for no apparent reason. > > There is a reason, see: > >>> + http://www.openssl.org/source/old/$(PKG_BASE)/ \ >

Re: [OpenWrt-Devel] [PATCH] [tools] firmware-utils: Add Archer C2600 support to tplink-safeloader

Hi, the patch is whitespace broken. please fix an resend John On 05/12/2015 02:18, Josh Bendavid wrote: > From: Josh Bendavid mailto:joshbenda...@gmail.com>> > > Add support for Archer C2600 to tplink-safeloader by adding needed > partition table, and vendor information plus support lis

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: get rid of ltq-vdsl-fw

Hi, On 29/11/2015 20:46, Andre Heider wrote: > John mentioned an existing mechanism to ship B per default with an > optional patch on to top to morph it into A, iiuc [0]. That might > work, I haven't looked into it. had a chat with hauke. the bdiff between the A and B FW is around 64K. the idea w

Re: [OpenWrt-Devel] ar71xx: add support for EnGenius ECB1750

Hi, the patches you sent are all whitespace broken and have several other formal errors. please read section 11 and 13 of the "how to submit patches" guidelines. specifically the bit about patch versioning. the next issues is that your mail client removed all tabs and added spaces another issue

Re: [OpenWrt-Devel] [PATCH 1/2] ath10k-firmware: Update QCA988X firmware to 10.2.4.70.13-2

On 03/12/2015 15:00, Felix Fietkau wrote: > On 2015-11-29 00:51, Martin Blumenstingl wrote: >> Signed-off-by: Martin Blumenstingl >> --- >> Working fine for me after a short test on a QCA9880-BR4A. >> > Maybe it's worth testing the latest from here (seems to be newer): > https://www.codeaurora.o

Re: [OpenWrt-Devel] [PATCH procd 4/9] instance, ujail: wire capabilities (-C) support

Hi, nice to see cpas being added. please expalin a bit about the file that needs to be created for it to work John On 01/12/2015 00:09, Etienne CHAMPETIER wrote: > Signed-off-by: Etienne CHAMPETIER > --- > service/instance.c | 22 ++ > service/instance.h | 1 + > 2

Re: [OpenWrt-Devel] [PATCH 3/3] ramips: Disable all ethernet ports except port 4 on HT-TM02.

On 05/12/2015 12:04, Vittorio G (VittGam) wrote: > Port 4 is the only ethernet port on this router, so disable all other PHYs > in order to save power. > > Signed-off-by: Vittorio Gambaletta > > --- > > --- a/target/linux/ramips/dts/HT-TM02.dts > +++ b/target/linux/ramips/dts/HT-TM02.dts > @@

Re: [OpenWrt-Devel] [PATCH] ramips: Fix failsafe for HT-TM02.

On 05/12/2015 12:04, Vittorio G (VittGam) wrote: > The failsafe VLAN workaround is not needed on HT-TM02 (RT5350); it actually > breaks > failsafe since this router has only one port and it is 4 and not 0. > > Anyway, it seems that the workaround is still needed for other routers (see > https:/

Re: [OpenWrt-Devel] [PATCH][RFC] kernel: swconfig: add API for setting port link speed

On 11/12/2015 14:48, Rafał Miłecki wrote: > @@ -251,6 +279,7 @@ static struct switch_attr default_port[] = { > .description = "Get port link information", > .set = NULL, you forgot to delete this line ___ openwrt-devel maili

Re: [OpenWrt-Devel] [PATCH 2/9] ramips: mt7621: use symbolic names of gic interrupt settings

On 11/12/2015 14:56, Nikolay Martynov wrote: > 2015-12-11 1:45 GMT-05:00 John Crispin : >> >> >> On 11/12/2015 05:01, Nikolay Martynov wrote: >>> This also adds dts nodes for cpc and mc for documentation purposes >>> >>> Signed-off-by: Nikolay Ma

Re: [OpenWrt-Devel] [PATCH] ramips: Fix failsafe for HT-TM02.

On 11/12/2015 14:48, Vittorio G (VittGam) wrote: > Hi, > > On 11/12/2015 14:32:45 CET, John Crispin wrote: >> hardcoding the board id here is not a good idea. we should rather use >> the board.json data to probe if a switch is registered. if not we dont >> apply the

Re: [OpenWrt-Devel] [PATCH 1/3] ramips: Fix whitespace in the switch driver.

On 11/12/2015 15:03, Vittorio G (VittGam) wrote: > > Because there are two __be32's used to fetch data from the device > tree; one is used only once for the portmap, while the other is > used three times, for the two registers and for the led_polarity. > Maybe the name should be tmp instead, but

Re: [OpenWrt-Devel] [PATCH 9/9] ramips: use gic timer as clocksource for mt7621

On 11/12/2015 17:25, Felix Fietkau wrote: > On 2015-12-11 05:01, Nikolay Martynov wrote: >> * Switches clocksource to gic timer. >> * Moves frequency definitions to dtsi since frequency was hardcoded anyway >> Will work on proper frequency detection later. >> >> Signed-off-by: Nikolay Martynov

Re: [OpenWrt-Devel] [PATCH 9/9] ramips: use gic timer as clocksource for mt7621

On 11/12/2015 17:31, Nikolay Martynov wrote: > 2015-12-11 11:29 GMT-05:00 John Crispin : >> >> >> On 11/12/2015 17:25, Felix Fietkau wrote: >>> On 2015-12-11 05:01, Nikolay Martynov wrote: >>>> * Switches clocksource to gic timer. >>>> * M

Re: [OpenWrt-Devel] [PATCH 9/9] ramips: use gic timer as clocksource for mt7621

On 11/12/2015 19:36, Nikolay Martynov wrote: > 2015-12-11 13:33 GMT-05:00 John Crispin : >> >> >> On 11/12/2015 17:31, Nikolay Martynov wrote: >>> 2015-12-11 11:29 GMT-05:00 John Crispin : >>>> >>>> >>>> On 11/12/2015 17:25, Feli

Re: [OpenWrt-Devel] [PATCH v2 3/3] [CC] ramips: Disable all ethernet ports except port 4 on HT-TM02.

patch 1/3 and 3/3 seem to be missing for this eries On 12/12/2015 02:10, Vittorio G (VittGam) wrote: > Port 4 is the only ethernet port on this router, so disable all other PHYs > in order to save power. > > Signed-off-by: Vittorio Gambaletta > > --- > > --- a/target/linux/ramips/dts/HT-TM02.

Re: [OpenWrt-Devel] [PATCH v2 2/3] ramips: Get ethernet ports to be disabled from the device tree.

Hi, comments inline On 12/12/2015 02:10, Vittorio G (VittGam) wrote: > Line 461 is actually enabling all switch ports, so line 508 is always getting > zero ports to be disabled (except for port 5 in SoCs where this is not > implemented, > as it will be sticky disabled in register POC0). > > Als

Re: [OpenWrt-Devel] [PATCH v2 2/3] ramips: Get ethernet ports to be disabled from the device tree.

On 12/12/2015 07:19, John Crispin wrote: > why a semicolon ? i believe a "," needs to be added instead please also > remove the superfluous "," while you are at it to make the comment > orthographically correct. it seems to be have been copied from SDK code.

Re: [OpenWrt-Devel] [PATCH v2] ramips: use gic timer as clocksource for mt7621

es-4.3/0902-mt7621-use-gic-timer.patch > @@ -0,0 +1,85 @@ > +--- a/arch/mips/ralink/Kconfig > b/arch/mips/ralink/Kconfig > +@@ -52,6 +52,8 @@ choice > + select SYS_SUPPORTS_SMP > + select SYS_SUPPORTS_MIPS_CPS > + select MIPS_GIC >

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for Cisco's MR18

On 12/12/2015 01:15, Christian Lamparter wrote: > From: Chris R Blake > > This patch adds support for Cisco's MR18. > Detailed instructions for the flashing the device can > be found in the OpenWrt forum thread: > > > Signed-off-by: Chris R Bl

Re: [OpenWrt-Devel] [PATCH v5] Add support for Ubiquiti EdgeRouter X (UBNT-ERX)

On 12/12/2015 07:33, Nikolay Martynov wrote: > Hi > >>> >>> Doesn't work: >>> * No GPIO leds. All leds are controlled by switch, >>> but stock firmware was able to control them. >> >> Try enabling SWCONFIG_LEDS and configure the trigger with >> ucidef_set_led_switch like other platforms have

Re: [OpenWrt-Devel] [PATCH v2] uboot-at91: Add package for uboot on the at91 platform

Hi, please read the "how to submit patches" guidelines and try again. things to lock out for 1) white space breakage tab vs spaces 2) dont attach nor forward patches 3) dont use html mail inlined tags (mailto:) John On 04/12/2015 15:00, Ben Whitten wrote: > In-line; > > On 3 December 2

Re: [OpenWrt-Devel] [PATCH][RFC] kernel: swconfig: add API for setting port link speed

Hi Rafał, in addition to the comment i made last night, i found another possible issue. see below. On 11/12/2015 14:48, Rafał Miłecki wrote: > Some switches can force link speed for a port. Let's add API that will > allow driver to export this feature. > > Signed-off-by: Rafał Miłecki > --- >

Re: [OpenWrt-Devel] [PATCH v5] Add support for Ubiquiti EdgeRouter X (UBNT-ERX)

On 12/12/2015 07:50, Nikolay Martynov wrote: > Hi, John. > >> >> as for the led support, you need to add an extra hook function so that >> swconfig can read the per port traffic counters. it can then make gpio >> leds flash based on those values. > > Just to make sure we are on the same page:

Re: [OpenWrt-Devel] [PATCH v2 2/3] ramips: Get ethernet ports to be disabled from the device tree.

On 12/12/2015 08:07, Vittorio G (VittGam) wrote: > Hi, > > On 12/12/2015 07:20:43 CET, John Crispin wrote: >> On 12/12/2015 07:19, John Crispin wrote: >>> why a semicolon ? i believe a "," needs to be added instead please also >>> remove the supe

Re: [OpenWrt-Devel] [PATCH 2/2] ramips: add support for Ubiquiti EdgeRouter X (UBNT-ERX)

looks good, i split the nand id patch out into its own commit and did a test build. wont be near mt7621 HW till later today but i am assuming its all fine now thanks ! On 12/12/2015 07:45, Nikolay Martynov wrote: > This router is based on MT7621 SoC, no wifi, no usb, nand. > > Works: > * Boots

Re: [OpenWrt-Devel] [PATCH][RFC] kernel: swconfig: add API for setting port link speed

On 12/12/2015 09:04, Rafał Miłecki wrote: > On 12 December 2015 at 07:54, John Crispin wrote: >> Hi Rafał, >> >> in addition to the comment i made last night, i found another possible >> issue. see below. >> >> On 11/12/2015 14:48, Rafał Miłecki wrote: >

Re: [OpenWrt-Devel] [PATCH] ar71xx: add support for Cisco's MR18

On 12/12/2015 12:32, Christian Lamparter wrote: > On Saturday, December 12, 2015 07:28:35 AM John Crispin wrote: >> >> On 12/12/2015 01:15, Christian Lamparter wrote: >>> From: Chris R Blake >>> >>> This patch adds support for Cisco's MR18. >&g

Re: [OpenWrt-Devel] [PATCH 1/2] ath10k-firmware: Update QCA988X firmware to 10.2.4.70.13-2

On 12/12/2015 13:27, Martin Blumenstingl wrote: > On Thu, Dec 3, 2015 at 3:00 PM, Felix Fietkau wrote: >> Maybe it's worth testing the latest from here (seems to be newer): >> https://www.codeaurora.org/cgit/quic/qsdk/oss/firmware/ath10k-firmware/tree/10.2.4 > I have just updated one of my devic

Re: [OpenWrt-Devel] [PATCH v5] Add support for Ubiquiti EdgeRouter X (UBNT-ERX)

On 12/12/2015 17:03, Nikolay Martynov wrote: > Hi > > 2015-12-12 2:01 GMT-05:00 John Crispin : >> >> >> On 12/12/2015 07:50, Nikolay Martynov wrote: >>> Hi, John. >>> >>>> >>>> as for the led support, you need to add an ex

Re: [OpenWrt-Devel] [PATCH 6/6] ramips: mt7621: disable ISDN in kernel config

On 14/12/2015 04:04, Nikolay Martynov wrote: > It's unlikely that devices on this SoC would need any ISDN support. > This should make kernel a bit smaller. > > Signed-off-by: Nikolay Martynov > --- > target/linux/ramips/mt7621/config-4.3 | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [OpenWrt-Devel] [PATCH 2/3] lantiq: unify dsl led names

Hi, we had a discussion yesterday with a few people and agreed to cleanup the led names on for the lantiq target to match the format expected by the kernel. i like this patch however we need to do the led renaming first i guess. John On 17/12/2015 00:26, Mathias Kresin wrote: > Signed-of

Re: [OpenWrt-Devel] [PATCH v2] lantiq, xrx200-net: add devicetree aliases support for port->mac mapping

On 14/12/2015 10:18, Martin Schiller wrote: > This patch adds devicetree aliases support, which makes it possible to > renumber the physical mac ports. > > This change has only cosmetical reasons (e.g. appearance in swconfig, > kernel messages on link change). > > Signed-off-by: Martin Schiller

Re: [OpenWrt-Devel] [PATCH] [ipq806x] initial support for TP-Link Archer C2600

Hi, the patch touches too many parts at once. please split it up 1 patch for the ath9k changes another for the kernel part and once for the patches to base-files John On 13/12/2015 18:18, Josh Bendavid wrote: > From: Josh Bendavid > > Add initial support for Archer C2600 to Makefiles

Re: [OpenWrt-Devel] [PATCH] omap: add kernel 4.4

Hi Dirk, i just added these to my local queue and will push then when i am done merging. i wont even compile test this patch so please make sure to test it once it is in trunk John On 12/12/2015 21:54, Dirk Neukirchen wrote: > - tested on Beagleboard C4 > > Signed-off-by: Dirk Neukirche

Re: [OpenWrt-Devel] [PATCH] package/kernel: Build it87 hardware monitor module

you know how to write proper descriptions for patches. i have seen you do it many times over many years. i wont even explain to you what is wrong with this one. please fix and resend. John On 16/12/2015 23:10, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > Fixed typo i

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

On 17/12/2015 10:51, Tathagata Das wrote: > I am not sure if this patch is under verification or not. Please let me know > if any modification is required in this patch. > > Regards, > Tathagata > Hi, still pending, i'll try to do more merging later today John > > -Original Mes

Re: [OpenWrt-Devel] [PATCH v2] lantiq, xrx200-net: add devicetree aliases support for port->mac mapping

On 17/12/2015 12:03, Martin Schiller wrote: > On 12/17/2015 at 9:20 AM, John Crispin wrote: >> >> >> On 14/12/2015 10:18, Martin Schiller wrote: >>> This patch adds devicetree aliases support, which makes it possible >> to >>> renumber the phy

Re: [OpenWrt-Devel] [PATCH 2/3] lantiq: unify dsl led names

On 17/12/2015 13:58, Mathias Kresin wrote: > 2015-12-17 7:52 GMT+01:00 John Crispin : >> Hi, >> >> we had a discussion yesterday with a few people and agreed to cleanup >> the led names on for the lantiq target to match the format expected by >> the kernel. i l

Re: [OpenWrt-Devel] ramips: MT7621 all ethernet interrupts to CPU0?

On 18/12/2015 15:19, Cristian Morales Vega wrote: > I am far from an expert here. Somebody knows if this is to be expected? yes > > root@OpenWrt:/tmp# cat /proc/irq/11/smp_affinity_list > 0-3 > root@OpenWrt:/tmp# cat /proc/interrupts >CPU0 CPU1 CPU2 CPU3 > 7:

Re: [OpenWrt-Devel] ramips: MT7621 all ethernet interrupts to CPU0?

On 18/12/2015 15:19, Cristian Morales Vega wrote: > I am far from an expert here. Somebody knows if this is to be expected? with the kernel now running the GIC we actually should have a fully functional irq affinity setup. might make sense to put the pic irqs on a secondary core > > root@OpenW

Re: [OpenWrt-Devel] [PATCH 2/2] lantiq: get rid of ltq-vdsl-fw

On 19/12/2015 09:14, Andre Heider wrote: > Hi again, > > On Fri, Dec 11, 2015 at 11:50 AM, John Crispin wrote: >> had a chat with hauke. the bdiff between the A and B FW is around 64K. >> the idea would be to patch dsl_control to have a mechanism similar to >

Re: [OpenWrt-Devel] ramips: mtk_soc_eth vs old ralink ethernet driver for the M2M

i'll try to test during the day. i had tested most socs but apparently 5350 still has an issue. On 19/12/2015 23:57, Christian Lamparter wrote: > Hello, > > I'm looking into a issue with M2M [0] (It's a RT5350 device). > Currently, the sole ethernet - port on this device is not > working. Instead

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/2015 13:05, Imre Kaloz wrote: > Hi Daniel, > > On Wed, 23 Dec 2015 07:58:59 +0100, Daniel Dickinson > wrote: > >> I am reworking this (requiring console login) as couple of packages >> for the packages feed, although it may require an image.mk or packages >> Makefile hook in order to

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/2015 13:32, Daniel Dickinson wrote: > I'm inclined to make the opt-out an image generation time decision > rather than configurable on the overlayfs for what I think are obvious > reasons. yep, that would be the best choice. > > Regards, > > Daniel >

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

Hi, you sent the patch as an attachment. because of this patchwork did not pick it up. could you please resend with the patch inline rather than attached. John On 14/12/2015 10:37, Tathagata Das wrote: > Add support for the Netgear D7800 and build appropariate sysupgrade and > factory im

Re: [OpenWrt-Devel] [PATCH 2/3] initial support for TP-Link Archer C2600

Hi, could you please resend the patches with the following changes * prefix each one with "ipq806x: " * dont copy paste the same subject for all 3 patches but describe what is in the patch please. John On 17/12/2015 13:35, Josh Bendavid wrote: > The device tree file is similar to the c

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

net@3740 { > ++status = "ok"; > ++phy-mode = "sgmii"; > ++qcom,id = <2>; > ++ > ++mtd-mac-address = <&art 0>; > ++ > ++fixed-link { > ++

Re: [OpenWrt-Devel] [PATCH v2] lantiq: fall back to a more appropriate default dsl firmware

Hi, does not apply any more. please rebase ! John On 19/12/2015 08:50, Andre Heider wrote: > Hi, > > On Fri, Dec 11, 2015 at 10:36 AM, John Crispin wrote: >>> @@ -69,11 +72,12 @@ start_service() { >>> eval "xtse_adsl=\"\${xtse_adsl_$

Re: [OpenWrt-Devel] [PATCH] base-files utils/busybox: Make requiring login in console default for easily accessed devices

On 23/12/2015 17:32, Bastian Bittorf wrote: > * Daniel Curran-Dickinson [23.12.2015 17:27]: >> I'm implementing without mount_root - that means passwordless >> failsafe unless user has preconfigured passwords in their image. >> OTOH if they have configured passwords in their image then they will

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R

Hi, the patch is badly formatted. please read the SubmittingPatches howto. things to look out for are * subject prefix * description that reflects hte actual patch content * your signed-off line is at the end of the patch. please put it above the tear line instead. you should consider using "git

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

Hi, your mail client replaced all tabs with spaces. please consider using git to send patches. it will save you a lot of time. John On 24/12/2015 11:21, Tathagata Das wrote: > Add support for the Netgear D7800 and build appropriate sysupgrade and > factory images. > > Known issues: > .

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

On 24/12/2015 10:16, Piotr Dymacz wrote: > Hello, > > Small comment inline, below. > > Plus: > 1. This patch is not for trunk, so you should add "CC" prefix in the subject. small addition. for us to merge board support into CC it needs to first be merged into trunk. i cannot accept a patch for

Re: [OpenWrt-Devel] [PATCH v2 12/12] lantiq: use devicename:colour:function led naming scheme

On 24/12/2015 13:28, Mathias Kresin wrote: > The leds of the following boards are not renamed due to lack of > manuals/informations: > > - ARV7519PW > - ARV7510PW22 > - ARV4510PW i have these here so i'll take care of those boards > > The leds of the ARV4518PWR01* boards are unchanged, since

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

> > I have tried with git -send-email option. But it says command not > supported. Could you send me the command? > > On 24-12-2015 18:48, John Crispin wrote: > >> Hi, >> >> your mail client replaced all tabs with spaces. >> >> please consider

Re: [OpenWrt-Devel] [Patch] ipq806x: add support for Netgear D7800

On 24/12/2015 17:55, Tathagata Das wrote: > > > > > Thank you for help John. > > I have followed those step and send the patch again. Please check. > well, we never received that mail i am afraid. John > On 24-12-2015 21:24, John Crispin wrote: >

Re: [OpenWrt-Devel] [PATCH 3/3] ath10k: bypass otp check at initialization (needed for TP-Link Archer C2600)

Hi comments inline On 25/12/2015 05:59, Josh Bendavid wrote: > There is a patch added here to ath10k to bypass some checks on startup. I > believe this is related to the calibration data being provided in external > files (dumped from the ART mtd partition at init time) rather than directly >

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2P, fix led support for WRTnode platform

Hi, the patch subject is missing the "ralink: " prefix John On 24/12/2015 17:13, xzmu wrote: > Signed-off-by: xzmu > --- > .../linux/ramips/base-files/etc/board.d/02_network | 2 + > target/linux/ramips/base-files/etc/diag.sh | 5 ++ > target/linux/ramips/base-files/lib/ramip

Re: [OpenWrt-Devel] [PATCH] lantiq: P2812HNUFX - move usb leds to P2812HNU-F1

On 25/12/2015 10:43, Mathias Kresin wrote: > The P2812HNU-F3 doesn't have usb leds. Only the P2812HNU-F1 has those > leds. > > Reported-by: Sylwester Petela > Signed-off-by: Mathias Kresin > --- > > Hi John, > > I received the report yesterday and till now, I didn't had the time to > send a

Re: [OpenWrt-Devel] New "Security" wiki page. Improvements/corrections appreciated

Hi, On 29/12/2015 05:49, Brian Smith wrote: > Hi, > > I was curious about OpenWrt security so I did some reading. I noticed > that a lot of the information on the web about OpenWrt security was out > of date and/or spread across many places, so I made an attempt to > coalesce what I found into a

Re: [OpenWrt-Devel] MT7628, IRQ GPIO

On 30/12/2015 15:04, Baptiste Clenet wrote: > 2015-12-30 11:52 GMT+01:00 Baptiste Clenet : >> Hi, >> >> I'm working on the MT7628 board and I try to register GPIO's irq. (I >> haven't updated to kernel 4.3, I'm still on the previous version 3.18) >> I've got two interrupts on GPIO 15 and GPIO 46.

Re: [OpenWrt-Devel] Kernel 4.3, MT7688 does not boot

On 30/12/2015 17:37, Baptiste Clenet wrote: > Hi, > > I'm using a custom board including a MT7688 chip, I made the image > with the latest openwrt build (I've just downloaded it), I got an > image of 2,9Mo. > > I flashed it and here is the debug: > > ## Booting image at bc05 ... >Image

Re: [OpenWrt-Devel] [PATCH 4/4] lantiq: lantiq-deu: Make the DEU driver compatible with 4.2 and newer

Hi On 31/12/2015 01:10, Martin Blumenstingl wrote: > + > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) > +#include > +#else > #include > +#endif please just drop the old code. there is no need to be compatible to old kernels. John ___ ope

Re: [OpenWrt-Devel] [PATCH 1/4] lantiq: Add the xbar to vr9.dts

On 31/12/2015 01:10, Martin Blumenstingl wrote: > linux 4.4 (since commit 08b3c894e56580b8ed3e601212a25bda974c3cc2 > "MIPS: lantiq: Disable xbar fpi burst mode") requires that the xbar is > defined in the .dts of vrx200 (VR9) SoCs. > --- > I am not sure if the xbar size is really 0x1000 or if it'

Re: [OpenWrt-Devel] [PATCH v2 4/5] ltq-vdsl-app: enable G.993.5 XTSE bit by default

On 30/12/2015 21:59, Mathias Kresin wrote: > According to ITU-T G.997.1 Amendment 2 (04/2013) section 2.1, bit 3 of > XTSE octet 8 either allow or denies the initialization of G.993.5. > > Even if the current redistributable xDSL firmware doesn't include > G.993.5 vectoring support, enable this

<    2   3   4   5   6   7   8   9   10   11   >