On 11/12/2015 10:59, Kevin Kirsch wrote:
> Hi,
>
> Am 11.12.2015 um 10:53 schrieb John Crispin:
>> technically correct but you make 2 changes int he patch.
>>
>> 1) add a new url
>> 2) split the variable into 2 variables for no apparent reason.
>
> I do the split to avoid hardcoding the PKG_BASE in the URI. Should I
> split the patch in 2 patches (first split, than add new url)?
>
>> i would sugegst you drop 2) and we just merge 1)
>
> That would be equivalent to the first version of the patch but needs
> paying closer attention when increasing the PKG_BASE.
>
> Kevin
>
Hi,
i dont understand what issue splitting the variables fixes. if it fixes
an issue then fine. otherwise it is imho just over engineering.
John
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
