Hi, see comments inline
On 28/11/2015 19:35, Ben Whitten wrote: > This patch adds a uboot package for at91 and honours COPTS. > If the SPL binary is generated for the specified board it moves that too. > > Signed-off-by: Ben Whitten <benwhit...@gmail.com> > --- > package/boot/uboot-at91/Makefile | 117 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 117 insertions(+) > create mode 100644 package/boot/uboot-at91/Makefile > > diff --git a/package/boot/uboot-at91/Makefile > b/package/boot/uboot-at91/Makefile > new file mode 100644 > index 0000000..7eb2828 > --- /dev/null > +++ b/package/boot/uboot-at91/Makefile > @@ -0,0 +1,117 @@ > +# > +# Copyright (C) 2013-2015 OpenWrt.org > +# > +# This is free software, licensed under the GNU General Public License v2. > +# See /LICENSE for more information. > +# > + > +include $(TOPDIR)/rules.mk > + > +PKG_NAME:=u-boot > +PKG_VERSION:=2015.10 > +PKG_RELEASE:=1 > + > +PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(BUILD_VARIANT)/$(PKG_NAME)-$(PKG_VERSION) > +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2 > +PKG_SOURCE_URL:= \ > + http://mirror2.openwrt.org/sources \ > + ftp://ftp.denx.de/pub/u-boot > +PKG_MD5SUM:=7c203b0fc3390a122d8e8b75f147eac5 > + > +PKG_BUILD_PARALLEL:=1 > + > +include $(INCLUDE_DIR)/package.mk > + > +define uboot/Default > + TITLE:= > + CONFIG:= > + IMAGE:= > +endef > + are you sure that the section above is required ? it seems superflous to me. John > +define uboot/at91sam9263ek_nandflash > + TITLE:=U-Boot for the AT91SAM9263-EK board (NandFlash) > +endef > + > +define uboot/at91sam9g20ek_nandflash > + TITLE:=U-Boot for the AT91SAM9G20-EK board (NandFlash) > +endef > + > +define uboot/at91sam9g20ek_2mmc_nandflash > + TITLE:=U-Boot for the AT91SAM9G20-EK 2MMC board (NandFlash) > +endef > + > +define uboot/at91sam9xeek_nandflash > + TITLE:=U-Boot for the AT91SAM9XE-EK board (NandFlash) > +endef > + > +define uboot/at91sam9x5ek_nandflash > + TITLE:=U-Boot for the AT91SAM9X5-EK board (NandFlash) > +endef > + > +UBOOTS := \ > + at91sam9263ek_nandflash \ > + at91sam9g20ek_nandflash \ > + at91sam9g20ek_2mmc_nandflash \ > + at91sam9xeek_nandflash \ > + at91sam9x5ek_nandflash > + > +define Package/uboot/template > +define Package/uboot-at91-$(1) > + SECTION:=boot > + CATEGORY:=Boot Loaders > + DEPENDS:=@TARGET_at91 > + TITLE:=$(2) > + URL:=http://www.denx.de/wiki/U-Boot > + VARIANT:=$(1) > +endef > +endef > + > +define BuildUBootPackage > + $(eval $(uboot/Default)) > + $(eval $(uboot/$(1))) > + $(call Package/uboot/template,$(1),$(TITLE)) > +endef > + > +ifdef BUILD_VARIANT > +$(eval $(call uboot/$(BUILD_VARIANT))) > +UBOOT_CONFIG:=$(if $(CONFIG),$(CONFIG),$(BUILD_VARIANT)) > +UBOOT_IMAGE:=$(if > $(IMAGE),$(IMAGE),openwrt-$(BOARD)-$(BUILD_VARIANT)-u-boot.bin) > +endif > + > +define Build/Configure > + +$(MAKE) $(PKG_JOBS) -C $(PKG_BUILD_DIR) \ > + $(UBOOT_CONFIG)_config > +endef > + > +define Build/Compile > + +$(MAKE) $(PKG_JOBS) -C $(PKG_BUILD_DIR) \ > + CROSS_COMPILE=$(TARGET_CROSS) \ > + KCFLAGS="$(filter-out -fstack-protector, $(TARGET_CFLAGS))" > +endef > + > +define Package/uboot/install/default > + $(INSTALL_DIR) $(BIN_DIR)/uboot-$(BOARD)-$(1) > + $(CP) \ > + $(PKG_BUILD_DIR)/u-boot.bin \ > + $(BIN_DIR)/uboot-$(BOARD)-$(1)/openwrt-$(BOARD)-$(1)-u-boot.bin > + if [ -e $(PKG_BUILD_DIR)/boot.bin ]; then \ > + $(CP) \ > + $(PKG_BUILD_DIR)/boot.bin \ > + > $(BIN_DIR)/uboot-$(BOARD)-$(1)/openwrt-$(BOARD)-$(1)-boot.bin; \ > + fi > +endef > + > +define Package/uboot/install/template > +define Package/uboot-at91-$(1)/install > + $(call Package/uboot/install/default,$(2)) > +endef > +endef > + > +$(foreach u,$(UBOOTS), \ > + $(eval $(call Package/uboot/install/template,$(u),$(u))) \ > +) > + > +$(foreach u,$(UBOOTS), \ > + $(eval $(call BuildUBootPackage,$(u))) \ > + $(eval $(call BuildPackage,uboot-at91-$(u))) \ > +) > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
