On 11/12/2015 11:07, Kevin Kirsch wrote:
> Hi,
>
> Am 11.12.2015 um 11:01 schrieb John Crispin:
>> On 11/12/2015 10:59, Kevin Kirsch wrote:
>>> Am 11.12.2015 um 10:53 schrieb John Crispin:
>>>> technically correct but you make 2 changes int he patch.
>>>>
>>>> 1) add a new url
>>>> 2) split the variable into 2 variables for no apparent reason.
>
>> i dont understand what issue splitting the variables fixes. if it fixes
>> an issue then fine. otherwise it is imho just over engineering.
>
> The URL I added is http://www.openssl.org/source/old/1.0.2/. The 1.0.2
> has to be changed whenever the PKG_BASE is increased. If this is an
> issue it should be fixed. If this is not an issue the first version of
> the patch is sufficient.
>
> Kevin
>
my bad i missed the PKG_BASE usage further down in the patch. i just
merged this into my local tree
John
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
