cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/326?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Remove last uses of inet_ntoa
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/326?usp=email )
Change subject: Remove last uses of inet_ntoa
..
Remove last uses of inet_ntoa
inet_ntoa is officially deprecated and in some places
its u
I wouldn't claim to understand what management_post_tunnel_open() or
init_route() *does* here (why is it converting a numeric address back
to ascii, just to feed it to getaddrinfo() afterwards?), but the actual
code changes look reasonable.
Same for the "buffer" to "char *" changes, especially in
Attention is currently required from: flichtenheld, plaisthos.
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 3:
(1
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/375?usp=email
to review the following change.
Change subject: Add undefined and abort on error to clang sanaitize builds
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/376?usp=email
to review the following change.
Change subject: Add --enable-werror to all platforms in Github Actions
...
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/374?usp=email
to review the following change.
Change subject: Remove CMake custom compiler flags for RELEASE and DEBUG build
...
Attention is currently required from: MaxF, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 3:
(1
Attention is currently required from: flichtenheld.
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 2:
(11 comments)
MaxF has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/371?usp=email )
Change subject: Add compatibility functions for mbedtls 2.X.Y
..
Abandoned
Changes were added to the patch that implements mbedtls 3 suppo
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/371?usp=email )
Change subject: Add compatibility functions for mbedtls 2.X.Y
..
Patch Set 2:
(1 comment)
Patchset:
PS2:
Abandoning this, becau
Attention is currently required from: flichtenheld.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by
Attention is currently required from: MaxF, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/372?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/373?usp=email )
Change subject: Remove openssl engine method for loading the key
..
Remove openssl engine method for loading the key
This is a contributio
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/373?usp=email )
Change subject: Remove openssl engine method for loading the key
..
Remove openssl e
Turns out it compiles just fine across all platforms, and I must have
gotten confused by a parallel build (by gerrit...) triggering errors
that looked related to "SSL things", assuming it must have been
this patch...
Manually tested it on OpenBSD 6.8 with LibreSSL, and via GH/buildbot
on all the
Attention is currently required from: flichtenheld, unauthorized.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/401?usp=email )
Change subject: Test change
..
Patch Set 1: Code-Review-1
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/373?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/373?usp=email )
Change subject: Remove openssl engine method for loading the key
..
Patc
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/268?usp=email )
Change subject: Change type of frame.mss_fix to uint16_t
..
Change type of frame.mss_fix to uint16_t
Since in the end this always ends up
Thanks for bearing with me :-) - I'm not happy with all the changes, but
we do want to avoid needless casts, and eventually build with -Wall -Werror,
so I understand there's no other way...
Lightly tested by running an instance with --mssfix 200 and looking
with tcpdump at the resulting SYNs (mss
cron2 has uploaded a new patch set (#5) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/268?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Change type of frame.mss_fix to uint16_t
..
As agreed in the weekly community meeting we will be sending weekly
meeting summaries to the OpenVPN developer's mailing list from now on.
Meeting summary for 18 October 2023:
* *Closed: Community Hackathon 2023 meeting*
/This was held in Orihuela Costa 6-8 October./
/For a summary seeHa
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/373?usp=email )
Change subject: Remove openssl engine method for loading the key
..
Patc
Attention is currently required from: flichtenheld.
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 1:
(1 comment)
F
Attention is currently required from: flichtenheld.
MaxF has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 1:
(2 comments)
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/373?usp=email
to review the following change.
Change subject: Remove openssl engine method for loading the key
.
Attention is currently required from: MaxF.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/371?usp=email )
Change subject: Add compatibility functions for mbedtls 2.X.Y
..
Patch Set 2:
Attention is currently required from: MaxF, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/372?usp=email )
Change subject: Update README.mbedtls
..
Patch Set 2: Code-Review+
Attention is currently required from: MaxF, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/371?usp=email )
Change subject: Add compatibility functions for mbedtls 2.X.Y
..
P
Attention is currently required from: MaxF.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 1:
(1 comment)
Patc
Attention is currently required from: MaxF, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y
..
Patch Set 1: Code
Attention is currently required from: MaxF, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/371?usp=email )
Change subject: Add compatibility functions for mbedtls 2.X.Y
..
P
Lightly tested on the regular server testbed - "normal" connections
work just fine, connections from a client without --client fail (as
expected), and the server logs
2023-10-18 11:56:42 Note: peer reports running in P2P mode (no
--pull/--clientoption). It will not negotiate ciphers with this s
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server
..
Add warning if a p2p NCP client connects to a p2mp server
Cha
cron2 has uploaded a new patch set (#4) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: Add warning if a p2p NCP client connects to a p2mp
36 matches
Mail list logo
