Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/375?usp=email
to review the following change.
Change subject: Add undefined and abort on error to clang sanaitize builds
......................................................................
Add undefined and abort on error to clang sanaitize builds
The -fno-sanitize-recover=all flag ensures that for all errors we actually
abort the tests in the automated testing and not just print some errors in red
that nobody sess. Also add the undefined tests to catch more bugs.
For libreSSL we do not add the udefined behaviour as we have (even with the
latest LibreSSL version) an undefined behaviour in LibreSSL itself.
Change-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/375/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 58fbc29..2a25582 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -186,7 +186,7 @@
- name: autoconf
run: autoreconf -fvi
- name: configure
- run: CFLAGS="-fsanitize=address -fno-omit-frame-pointer -O2" CC=clang
./configure --with-crypto-library=${{matrix.ssllib}}
+ run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all
-fno-omit-frame-pointer -O2" CC=clang ./configure
--with-crypto-library=${{matrix.ssllib}}
- name: make all
run: make -j3
- name: make check
@@ -201,8 +201,8 @@
os: [macos-11, macos-12, macos-13]
include:
- build: asan
- cflags: "-fsanitize=address -fno-optimize-sibling-calls
-fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=address
+ cflags: "-fsanitize=address,undefined -fno-sanitize-recover=all
-fno-optimize-sibling-calls -fsanitize-address-use-after-scope
-fno-omit-frame-pointer -g -O1"
+ ldflags: -fsanitize=address,undefined -fno-sanitize-recover=all
# Our build system ignores LDFLAGS for plugins
configureflags: --disable-plugin-auth-pam
--disable-plugin-down-root
- build: normal
@@ -300,8 +300,8 @@
configureflags: ["--with-openssl-engine=no"]
include:
- build: asan
- cflags: "-fsanitize=address -fno-optimize-sibling-calls
-fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=address
+ cflags: "-fsanitize=address -fno-sanitize-recover=all
-fno-optimize-sibling-calls -fsanitize-address-use-after-scope
-fno-omit-frame-pointer -g -O1"
+ ldflags: -fsanitize=address -fno-sanitize-recover=all
cc: clang
- build: normal
cflags: "-O2 -g"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/375?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17
Gerrit-Change-Number: 375
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
