Attention is currently required from: flichtenheld. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email )
Change subject: Add support for mbedtls 3.X.Y ...................................................................... Patch Set 1: (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/370/comment/dd9f6001_8850e081 : PS1, Line 28: This commit breaks compatibility for mbed TLS version 2.x.y. A > That makes me unhappy. […] Would you prefer to put the two commits together into one? I don't think reordering them makes sense, you'd just end up with a file full of unused functions. File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/370/comment/c741b867_3336d64e : PS1, Line 174: if (info && name > why is the cipher_kt_insecure check missing here? By accident. Thanks for catching this! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/370?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I445a93e84dc54b865b757038d22318ac427fce96 Gerrit-Change-Number: 370 Gerrit-PatchSet: 1 Gerrit-Owner: MaxF <m...@max-fillinger.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 18 Oct 2023 12:14:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
