I wouldn't claim to understand what management_post_tunnel_open() or init_route() *does* here (why is it converting a numeric address back to ascii, just to feed it to getaddrinfo() afterwards?), but the actual code changes look reasonable.
Same for the "buffer" to "char *" changes, especially in print_in6_addr(). As this is "refactoring to appease compilers", and neither a bugfix nor "real" compat stuff, it only goes to master. Your patch has been applied to the master branch. commit 7c637b35038e4cc7d2f16e07f413cfa2b0f1f97a Author: Frank Lichtenheld Date: Sun Oct 8 12:34:15 2023 +0200 Remove last uses of inet_ntoa Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com> Acked-by: Arne Schwabe <arne-open...@rfc2549.org> Message-Id: <20231008103415.19625-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/search?l=mid&q=20231008103415.19625-1-fr...@lichtenheld.com Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel